[GitHub] [arrow-rs] HaoYang670 commented on issue #2564: Why do we check for null in TypedDictionaryArray value function

2022-08-23 Thread GitBox
HaoYang670 commented on issue #2564: URL: https://github.com/apache/arrow-rs/issues/2564#issuecomment-1225274876 > Dictionaries are a special case, as the value of a null index is undefined, we can't then use it as an index in the values array. Hmm🤔, Why is `Dictionary` a special case

[GitHub] [arrow] pitrou commented on a diff in pull request #13804: ARROW-17318: [C++][Dataset] Support async streaming interface for getting fragments in Dataset

2022-08-23 Thread GitBox
pitrou commented on code in PR #13804: URL: https://github.com/apache/arrow/pull/13804#discussion_r953408867 ## cpp/src/arrow/dataset/dataset.h: ## @@ -174,9 +186,24 @@ class ARROW_DS_EXPORT Dataset : public std::enable_shared_from_this { Dataset(std::shared_ptr schema, comp

[GitHub] [arrow-rs] viirya commented on a diff in pull request #2570: Support SQL-compliant behavior on eq_dyn, neq_dyn, lt_dyn, lt_eq_dyn, gt_dyn, gt_eq_dyn

2022-08-23 Thread GitBox
viirya commented on code in PR #2570: URL: https://github.com/apache/arrow-rs/pull/2570#discussion_r953371116 ## arrow/src/compute/kernels/comparison.rs: ## @@ -2386,7 +2408,30 @@ pub fn eq_dyn(left: &dyn Array, right: &dyn Array) -> Result { _ if matches!(right.data_t

[GitHub] [arrow-rs] tustvold commented on issue #2564: Why do we check for null in TypedDictionaryArray value function

2022-08-23 Thread GitBox
tustvold commented on issue #2564: URL: https://github.com/apache/arrow-rs/issues/2564#issuecomment-1225268353 Dictionaries are a special case, as the value of a null index is undefined, we can't then use it as an index in the values array -- This is an automated message from the Apache G

[GitHub] [arrow] pitrou merged pull request #13932: MINOR: [C++] Fix StringFormatter type error in localfs_benchmark

2022-08-23 Thread GitBox
pitrou merged PR #13932: URL: https://github.com/apache/arrow/pull/13932 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache

[GitHub] [arrow] pitrou commented on pull request #13932: MINOR: [C++] Fix StringFormatter type error in localfs_benchmark

2022-08-23 Thread GitBox
pitrou commented on PR #13932: URL: https://github.com/apache/arrow/pull/13932#issuecomment-1225267600 AppVeyor failure is unrelated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [arrow] pitrou merged pull request #13781: ARROW-17322: [Docs] Documenting issue lifecycle for bugs and feature requests

2022-08-23 Thread GitBox
pitrou merged PR #13781: URL: https://github.com/apache/arrow/pull/13781 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache

[GitHub] [arrow-datafusion] yjshen commented on a diff in pull request #3238: MINOR: Add bounds check to Column physical expression

2022-08-23 Thread GitBox
yjshen commented on code in PR #3238: URL: https://github.com/apache/arrow-datafusion/pull/3238#discussion_r953404218 ## datafusion/physical-expr/src/expressions/column.rs: ## @@ -74,21 +74,84 @@ impl PhysicalExpr for Column { /// Get the data type of this expression, giv

[GitHub] [arrow] pitrou commented on a diff in pull request #13781: ARROW-17322: [Docs] Documenting issue lifecycle for bugs and feature requests

2022-08-23 Thread GitBox
pitrou commented on code in PR #13781: URL: https://github.com/apache/arrow/pull/13781#discussion_r953402451 ## docs/source/developers/bug_reports.rst: ## @@ -186,10 +176,109 @@ Good reproducible examples or minimal bug reports can be found in next tabs: #> 1 rows x 1

[GitHub] [arrow] github-actions[bot] commented on pull request #13959: ARROW-14742: [C++] Allow ParquetWriter to take a RecordBatchReader as input

2022-08-23 Thread GitBox
github-actions[bot] commented on PR #13959: URL: https://github.com/apache/arrow/pull/13959#issuecomment-1225261879 https://issues.apache.org/jira/browse/ARROW-14742 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [arrow] github-actions[bot] commented on pull request #13959: ARROW-14742: [C++] Allow ParquetWriter to take a RecordBatchReader as input

2022-08-23 Thread GitBox
github-actions[bot] commented on PR #13959: URL: https://github.com/apache/arrow/pull/13959#issuecomment-1225261915 :warning: Ticket **has not been started in JIRA**, please click 'Start Progress'. -- This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [arrow] AlvinJ15 opened a new pull request, #13959: ARROW-14742: [C++] Allow ParquetWriter to take a RecordBatchReader as input

2022-08-23 Thread GitBox
AlvinJ15 opened a new pull request, #13959: URL: https://github.com/apache/arrow/pull/13959 Add defaults to FileSystemDatasetWriteOptions file_write_options, filesystem, partitioning, basename_template -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [arrow] github-actions[bot] commented on pull request #13311: ARROW-16340: [Python] Move all Python related code into PyArrow

2022-08-23 Thread GitBox
github-actions[bot] commented on PR #13311: URL: https://github.com/apache/arrow/pull/13311#issuecomment-1225260926 Revision: b2780355cfbe34677815fcd954c0c2b206915319 Submitted crossbow builds: [ursacomputing/crossbow @ actions-e15d161feb](https://github.com/ursacomputing/crossbow/bra

[GitHub] [arrow] AlenkaF commented on pull request #13311: ARROW-16340: [Python] Move all Python related code into PyArrow

2022-08-23 Thread GitBox
AlenkaF commented on PR #13311: URL: https://github.com/apache/arrow/pull/13311#issuecomment-1225259744 @github-actions crossbow submit *almalinux* *centos* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [arrow-ballista] Ted-Jiang opened a new pull request, #154: [minor]Use info instead print

2022-08-23 Thread GitBox
Ted-Jiang opened a new pull request, #154: URL: https://github.com/apache/arrow-ballista/pull/154 # Which issue does this PR close? Closes #. # Rationale for this change # What changes are included in this PR? # Are there any user-facing changes?

[GitHub] [arrow-ballista] yahoNanJing commented on pull request #153: Introduce CuratorTaskManager for make an active job be curated by only one scheduler

2022-08-23 Thread GitBox
yahoNanJing commented on PR #153: URL: https://github.com/apache/arrow-ballista/pull/153#issuecomment-1225245903 Hi @thinkharderdev, @avantgardnerio and @andygrove, could you help review this PR? A few other PRs will be proposed after this PR finishes. -- This is an automated messa

[GitHub] [arrow] cyb70289 commented on a diff in pull request #13946: ARROW-17500: [Go] Kernel and KernelContext interfaces

2022-08-23 Thread GitBox
cyb70289 commented on code in PR #13946: URL: https://github.com/apache/arrow/pull/13946#discussion_r953326376 ## go/arrow/compute/internal/kernel.go: ## @@ -0,0 +1,521 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements.

[GitHub] [arrow-rs] viirya commented on pull request #2566: Add sum_dyn to calculate sum for dictionary array

2022-08-23 Thread GitBox
viirya commented on PR #2566: URL: https://github.com/apache/arrow-rs/pull/2566#issuecomment-1225229364 cc @sunchao -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

[GitHub] [arrow] github-actions[bot] commented on pull request #13311: ARROW-16340: [Python] Move all Python related code into PyArrow

2022-08-23 Thread GitBox
github-actions[bot] commented on PR #13311: URL: https://github.com/apache/arrow/pull/13311#issuecomment-1225224335 ``` Invalid group(s) {'centos', 'almalinux'}. Must be one of {'python', 'test', 'example', 'r', 'verify-rc', 'linux-amd64', 'verify-rc-jars', 'nightly', 'conda', 'nightly-r

[GitHub] [arrow-rs] viirya commented on a diff in pull request #2570: Support SQL-compliant behavior on eq_dyn, neq_dyn, lt_dyn, lt_eq_dyn, gt_dyn, gt_eq_dyn

2022-08-23 Thread GitBox
viirya commented on code in PR #2570: URL: https://github.com/apache/arrow-rs/pull/2570#discussion_r953371116 ## arrow/src/compute/kernels/comparison.rs: ## @@ -2386,7 +2408,30 @@ pub fn eq_dyn(left: &dyn Array, right: &dyn Array) -> Result { _ if matches!(right.data_t

[GitHub] [arrow-rs] viirya commented on pull request #2570: Support SQL-compliant behavior on eq_dyn, neq_dyn, lt_dyn, lt_eq_dyn, gt_dyn, gt_eq_dyn

2022-08-23 Thread GitBox
viirya commented on PR #2570: URL: https://github.com/apache/arrow-rs/pull/2570#issuecomment-1225222920 cc @sunchao -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

[GitHub] [arrow-rs] viirya opened a new pull request, #2570: Support SQL-compliant behavior on eq_dyn, neq_dyn, lt_dyn, lt_eq_dyn, gt_dyn, gt_eq_dyn

2022-08-23 Thread GitBox
viirya opened a new pull request, #2570: URL: https://github.com/apache/arrow-rs/pull/2570 # Which issue does this PR close? Closes #2569. # Rationale for this change # What changes are included in this PR? # Are there any user-facing chang

[GitHub] [arrow-rs] viirya opened a new issue, #2569: Support SQL-compliant behavior on eq_dyn, neq_dyn, lt_dyn, lt_eq_dyn, gt_dyn, gt_eq_dyn

2022-08-23 Thread GitBox
viirya opened a new issue, #2569: URL: https://github.com/apache/arrow-rs/issues/2569 **Is your feature request related to a problem or challenge? Please describe what you are trying to do.** Part of #2568. **Describe the solution you'd like** **Describe alternat

[GitHub] [arrow-rs] viirya opened a new issue, #2568: Add sql-compliant feature for enabling sql-compliant kernel behavior

2022-08-23 Thread GitBox
viirya opened a new issue, #2568: URL: https://github.com/apache/arrow-rs/issues/2568 **Is your feature request related to a problem or challenge? Please describe what you are trying to do.** Some kernels behaves different with SQL semantics. For example, NaN is equal to NaN with

[GitHub] [arrow] github-actions[bot] commented on pull request #13892: ARROW-12175: [C++] Fix CMake packages

2022-08-23 Thread GitBox
github-actions[bot] commented on PR #13892: URL: https://github.com/apache/arrow/pull/13892#issuecomment-1225217709 Revision: 119c8e142f8f0a18bb359eea23c3f731c8c84d11 Submitted crossbow builds: [ursacomputing/crossbow @ actions-1eec7bcaa0](https://github.com/ursacomputing/crossbow/bra

[GitHub] [arrow-rs] liukun4515 commented on issue #2387: Decimal Precision Validation

2022-08-23 Thread GitBox
liukun4515 commented on issue #2387: URL: https://github.com/apache/arrow-rs/issues/2387#issuecomment-1225208053 > > That is what I am doing!! > > I know, my point is we aren't doing strict validation currently so the optimisation is ill-formed until such a time as we are doing strict

[GitHub] [arrow] AlenkaF commented on pull request #13311: ARROW-16340: [Python] Move all Python related code into PyArrow

2022-08-23 Thread GitBox
AlenkaF commented on PR #13311: URL: https://github.com/apache/arrow/pull/13311#issuecomment-1225206974 @github-actions crossbow submit -g almalinux -g centos -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[GitHub] [arrow] kou commented on pull request #13892: ARROW-12175: [C++] Fix CMake packages

2022-08-23 Thread GitBox
kou commented on PR #13892: URL: https://github.com/apache/arrow/pull/13892#issuecomment-1225205251 @github-actions crossbow submit -g nightly-tests -g nightly-packaging -g nightly-release -- This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [arrow] kou commented on pull request #13903: ARROW-17433: [CI][C++] Use Visual Studio 2019 on AppVeyor

2022-08-23 Thread GitBox
kou commented on PR #13903: URL: https://github.com/apache/arrow/pull/13903#issuecomment-1225191072 @pitrou Could you fix the following build error? (You can push to this branch.) https://ci.appveyor.com/project/ApacheSoftwareFoundation/arrow/builds/44560863 ```text FAILED:

[GitHub] [arrow] AlenkaF commented on a diff in pull request #13951: ARROW-16949: [Doc] Add Glossary to the New Contributor's Guide

2022-08-23 Thread GitBox
AlenkaF commented on code in PR #13951: URL: https://github.com/apache/arrow/pull/13951#discussion_r953346208 ## docs/source/developers/guide/resources.rst: ## @@ -31,9 +31,10 @@ Additional information and resources On this page we have listed resources that may be relevant or

[GitHub] [arrow-datafusion] codecov-commenter commented on pull request #3243: chore: update cranelifts to 0.87.0

2022-08-23 Thread GitBox
codecov-commenter commented on PR #3243: URL: https://github.com/apache/arrow-datafusion/pull/3243#issuecomment-1225187076 # [Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/3243?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_

[GitHub] [arrow] github-actions[bot] commented on pull request #13958: ARROW-17511: [C++] Add support for xsimd 9.0.0

2022-08-23 Thread GitBox
github-actions[bot] commented on PR #13958: URL: https://github.com/apache/arrow/pull/13958#issuecomment-1225178843 :warning: Ticket **has not been started in JIRA**, please click 'Start Progress'. -- This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [arrow] github-actions[bot] commented on pull request #13958: ARROW-17511: [C++] Add support for xsimd 9.0.0

2022-08-23 Thread GitBox
github-actions[bot] commented on PR #13958: URL: https://github.com/apache/arrow/pull/13958#issuecomment-1225178824 https://issues.apache.org/jira/browse/ARROW-17511 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [arrow] ursabot commented on pull request #12824: ARROW-16141: [R] Update rhub/fedora-clang-devel for upstreamed changes

2022-08-23 Thread GitBox
ursabot commented on PR #12824: URL: https://github.com/apache/arrow/pull/12824#issuecomment-1225178101 Benchmark runs are scheduled for baseline = 3c13dc4e54b0c539349610ffd791e5d5cabb40e2 and contender = c90d07f74a2af924bf156391a67914d03a6119c6. c90d07f74a2af924bf156391a67914d03a6119c6 is

[GitHub] [arrow] kou commented on pull request #13956: MINOR: [CI] [C++] Pin xsimd version to 8.1.0 in CPP conda env file

2022-08-23 Thread GitBox
kou commented on PR #13956: URL: https://github.com/apache/arrow/pull/13956#issuecomment-1225176548 I've extracted it to #13958. BTW, what CI jobs were failed? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [arrow] vibhatha commented on pull request #13687: ARROW-17181: [Docs][Python] Scalar UDF Experimental Documentation

2022-08-23 Thread GitBox
vibhatha commented on PR #13687: URL: https://github.com/apache/arrow/pull/13687#issuecomment-1225176371 > I think part of the challenge with this documentation is that implementing `affine` in pure-python is not a very compelling use case. I think the more interesting case for UDFs is when

[GitHub] [arrow] vibhatha commented on a diff in pull request #13401: ARROW-16855: [C++] Adding Read Relation ToProto

2022-08-23 Thread GitBox
vibhatha commented on code in PR #13401: URL: https://github.com/apache/arrow/pull/13401#discussion_r953325526 ## cpp/src/arrow/engine/substrait/registry.h: ## @@ -0,0 +1,86 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreeme

[GitHub] [arrow-datafusion] yjshen opened a new pull request, #3243: chore: update cranelifts to 0.87.0

2022-08-23 Thread GitBox
yjshen opened a new pull request, #3243: URL: https://github.com/apache/arrow-datafusion/pull/3243 # Which issue does this PR close? Closes #. # Rationale for this change # What changes are included in this PR? # Are there any user-facing changes?

[GitHub] [arrow-rs] liukun4515 commented on issue #2387: Decimal Precision Validation

2022-08-23 Thread GitBox
liukun4515 commented on issue #2387: URL: https://github.com/apache/arrow-rs/issues/2387#issuecomment-1225169192 I find other thing about the `casting`. I writ the test code for `cast int32 to int8` like below ``` let a = Int32Array::from(vec![1, 17890]); l

[GitHub] [arrow-ballista] yahoNanJing opened a new pull request, #153: Introduce CuratorTaskManager for make an active job be curated by only one scheduler

2022-08-23 Thread GitBox
yahoNanJing opened a new pull request, #153: URL: https://github.com/apache/arrow-ballista/pull/153 # Which issue does this PR close? Closes #130. # Rationale for this change # What changes are included in this PR? # Are there any user-facing chang

[GitHub] [arrow-rs] liukun4515 commented on issue #2445: `SchemaResult` in IPC deviates from other implementations

2022-08-23 Thread GitBox
liukun4515 commented on issue #2445: URL: https://github.com/apache/arrow-rs/issues/2445#issuecomment-1225144026 > @liukun4515 That seems out of date, the current definition in `Flight.proto` for Schema Result shows: > > ```proto > /* > * Wrap the result of a getSchema call

[GitHub] [arrow-rs] liukun4515 commented on issue #2445: `SchemaResult` in IPC deviates from other implementations

2022-08-23 Thread GitBox
liukun4515 commented on issue #2445: URL: https://github.com/apache/arrow-rs/issues/2445#issuecomment-1225142558 > @liukun4515 That seems out of date, the current definition in `Flight.proto` for Schema Result shows: > > ```proto > /* > * Wrap the result of a getSchema call

[GitHub] [arrow-rs] HaoYang670 commented on issue #2564: Why do we check for null in TypedDictionaryArray value function

2022-08-23 Thread GitBox
HaoYang670 commented on issue #2564: URL: https://github.com/apache/arrow-rs/issues/2564#issuecomment-1225136120 I guess you are right @psvri. We always don't check the validation in the `value()` method, so the checking could be removed here. cc @tustvold -- This is an automated mess

[GitHub] [arrow-rs] zeroshade commented on issue #2445: `SchemaResult` in IPC deviates from other implementations

2022-08-23 Thread GitBox
zeroshade commented on issue #2445: URL: https://github.com/apache/arrow-rs/issues/2445#issuecomment-1225135381 @liukun4515 That seems out of date, the current definition in `Flight.proto` for Schema Result shows: ```protobuf /* * Wrap the result of a getSchema call */ m

[GitHub] [arrow-rs] Jimexist opened a new pull request, #2567: use rust 1.63

2022-08-23 Thread GitBox
Jimexist opened a new pull request, #2567: URL: https://github.com/apache/arrow-rs/pull/2567 # Which issue does this PR close? Closes #. # Rationale for this change use rust 1.63 # What changes are included in this PR? # Are there any user-facing ch

[GitHub] [arrow-datafusion] liukun4515 commented on issue #3221: Add TypeCoercion optimizer rule

2022-08-23 Thread GitBox
liukun4515 commented on issue #3221: URL: https://github.com/apache/arrow-datafusion/issues/3221#issuecomment-1225131136 @andygrove I go through the spark code about the type coercion and find https://github.com/apache/spark/blob/55c3347c48f93a9c5c5c2fb00b30f838eb081b7f/sql/catalyst/sr

[GitHub] [arrow-rs] liukun4515 commented on issue #2445: `SchemaResult` in IPC deviates from other implementations

2022-08-23 Thread GitBox
liukun4515 commented on issue #2445: URL: https://github.com/apache/arrow-rs/issues/2445#issuecomment-1225123380 You can change your server code to ``` async fn get_schema( &self, _request: Request, ) -> Result, Status> { let tid = Field::new("tid", DataType::Int

[GitHub] [arrow-rs] liukun4515 commented on issue #2445: `SchemaResult` in IPC deviates from other implementations

2022-08-23 Thread GitBox
liukun4515 commented on issue #2445: URL: https://github.com/apache/arrow-rs/issues/2445#issuecomment-1225116252 The define of `GetSchema` is `rpc GetSchema(FlightDescriptor) returns (SchemaResult) {} ` and the `SchemaResult` is ``` /* * Wrap the result of a getSchema call

[GitHub] [arrow] ursabot commented on pull request #13952: MINOR: [R] Remove trailing whitespace in flight tests

2022-08-23 Thread GitBox
ursabot commented on PR #13952: URL: https://github.com/apache/arrow/pull/13952#issuecomment-1225096207 ['Python', 'R'] benchmarks have high level of regressions. [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/b831fee5c94f441595a37ccc2440b588...6be0409f557644fd9917873a0b2b8658/)

[GitHub] [arrow] ursabot commented on pull request #13952: MINOR: [R] Remove trailing whitespace in flight tests

2022-08-23 Thread GitBox
ursabot commented on PR #13952: URL: https://github.com/apache/arrow/pull/13952#issuecomment-1225096092 Benchmark runs are scheduled for baseline = 9b23a7078bc7b6176f5d918f504956609bfe61a9 and contender = 3c13dc4e54b0c539349610ffd791e5d5cabb40e2. 3c13dc4e54b0c539349610ffd791e5d5cabb40e2 is

[GitHub] [arrow-rs] liukun4515 commented on issue #2445: `SchemaResult` in IPC deviates from other implementations

2022-08-23 Thread GitBox
liukun4515 commented on issue #2445: URL: https://github.com/apache/arrow-rs/issues/2445#issuecomment-1225095059 @skejserjensen , you can implement `GetSchema` by wrapping the schema to the ipc message format in the server side. You can follow bellow code which is in the arrow-rs.

[GitHub] [arrow] kiszk commented on pull request #13942: ARROW-17498: [CI] Fix build failure when tests are not specified on Spark integration tests

2022-08-23 Thread GitBox
kiszk commented on PR #13942: URL: https://github.com/apache/arrow/pull/13942#issuecomment-1225090154 @raulcd Thank you very much for tracking the latest changes in Spark. Which URL is the latest successful log? It would be good to note here for future reference. Then, we could close

[GitHub] [arrow] westonpace commented on pull request #13912: ARROW-17350: [C++] Create a scheduler for asynchronous work

2022-08-23 Thread GitBox
westonpace commented on PR #13912: URL: https://github.com/apache/arrow/pull/13912#issuecomment-1225087434 The ASAN error seems legitimate but I believe I've addressed review comments and fixed most of the bugs. This is probably ready for another review while I work through this issue. -

[GitHub] [arrow-nanoarrow] lidavidm closed issue #33: Ensure headers are in a subdirectory?

2022-08-23 Thread GitBox
lidavidm closed issue #33: Ensure headers are in a subdirectory? URL: https://github.com/apache/arrow-nanoarrow/issues/33 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [arrow-nanoarrow] lidavidm commented on issue #33: Ensure headers are in a subdirectory?

2022-08-23 Thread GitBox
lidavidm commented on issue #33: URL: https://github.com/apache/arrow-nanoarrow/issues/33#issuecomment-1225086510 Ah ok, clearly I wasn't paying attention - I'll give that a try then. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [arrow-nanoarrow] paleolimbot commented on issue #33: Ensure headers are in a subdirectory?

2022-08-23 Thread GitBox
paleolimbot commented on issue #33: URL: https://github.com/apache/arrow-nanoarrow/issues/33#issuecomment-1225084495 I think I did that (at least added the option to generate a single header and single source file) in #31! https://github.com/apache/arrow-nanoarrow/pull/31/files#diff-1e7de1a

[GitHub] [arrow] kou commented on a diff in pull request #13839: ARROW-17293: [Java][CI] Prune java nightly builds

2022-08-23 Thread GitBox
kou commented on code in PR #13839: URL: https://github.com/apache/arrow/pull/13839#discussion_r953252712 ## .github/workflows/java_nightly.yml: ## @@ -64,6 +68,31 @@ jobs: fi echo $PREFIX archery crossbow download-artifacts -f java-jars -t binar

[GitHub] [arrow-nanoarrow] lidavidm commented on issue #33: Ensure headers are in a subdirectory?

2022-08-23 Thread GitBox
lidavidm commented on issue #33: URL: https://github.com/apache/arrow-nanoarrow/issues/33#issuecomment-1225080469 Hmm, I hadn't realized quotes also (typically, but not guaranteed) searches the current directory first. That probably works well enough then. SQLite etc. do pre-generate

[GitHub] [arrow] liukun4515 commented on issue #13853: [Go][Rust] Deserializing a Byte array to a schema

2022-08-23 Thread GitBox
liukun4515 commented on issue #13853: URL: https://github.com/apache/arrow/issues/13853#issuecomment-1225076005 > @liukun4515 Slight correction: The C++/Go does not convert it to a full flight message, it just returns the full IPC Schema message bytes which can then be slotted into the flig

[GitHub] [arrow-nanoarrow] paleolimbot commented on issue #33: Ensure headers are in a subdirectory?

2022-08-23 Thread GitBox
paleolimbot commented on issue #33: URL: https://github.com/apache/arrow-nanoarrow/issues/33#issuecomment-1225072272 I'm very new to all of this and I'm happy to defer to best practice! I thought that I had used quote-includes rather than bracket includes (i.e., `#include "typedefs_inline.h

[GitHub] [arrow] g302ge closed issue #13424: Update Plasma Buffer failed

2022-08-23 Thread GitBox
g302ge closed issue #13424: Update Plasma Buffer failed URL: https://github.com/apache/arrow/issues/13424 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail

[GitHub] [arrow] davisusanibar commented on a diff in pull request #13839: ARROW-17293: [Java][CI] Prune java nightly builds

2022-08-23 Thread GitBox
davisusanibar commented on code in PR #13839: URL: https://github.com/apache/arrow/pull/13839#discussion_r953239299 ## .github/workflows/java_nightly.yml: ## @@ -64,6 +68,27 @@ jobs: fi echo $PREFIX archery crossbow download-artifacts -f java-jar

[GitHub] [arrow] github-actions[bot] commented on pull request #13957: ARROW-17510: [CI][C++][Windows][MSVC] Use ccache

2022-08-23 Thread GitBox
github-actions[bot] commented on PR #13957: URL: https://github.com/apache/arrow/pull/13957#issuecomment-1225060969 https://issues.apache.org/jira/browse/ARROW-17510 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [arrow] github-actions[bot] commented on pull request #13957: ARROW-17510: [CI][C++][Windows][MSVC] Use ccache

2022-08-23 Thread GitBox
github-actions[bot] commented on PR #13957: URL: https://github.com/apache/arrow/pull/13957#issuecomment-1225060977 :warning: Ticket **has not been started in JIRA**, please click 'Start Progress'. -- This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [arrow] kou opened a new pull request, #13957: ARROW-17510: [CI][C++][Windows][MSVC] Use ccache

2022-08-23 Thread GitBox
kou opened a new pull request, #13957: URL: https://github.com/apache/arrow/pull/13957 ccache supports MSVC since 4.6.0: https://ccache.dev/releasenotes.html#_ccache_4_6 > Added support for caching calls to Microsoft Visual C++ (MSVC) and > clang-cl (MSVC compatibility for Cl

[GitHub] [arrow-datafusion] jklamer commented on pull request #3201: Use .get() to avoid panic

2022-08-23 Thread GitBox
jklamer commented on PR #3201: URL: https://github.com/apache/arrow-datafusion/pull/3201#issuecomment-1225045323 @alamb ran `cargo fmt` this time -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [arrow] kou commented on pull request #13956: MINOR: [CI] [C++] Pin xsimd version to 8.1.0 in CPP conda env file

2022-08-23 Thread GitBox
kou commented on PR #13956: URL: https://github.com/apache/arrow/pull/13956#issuecomment-1225041768 FYI: I"m working on xsimd 8.1.0 and 9.0.0 support in https://github.com/apache/arrow/pull/13903 -- This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [arrow] amoeba opened a new pull request, #13956: MINOR: [CI] [C++] Pin xsimd version to 8.1.0 in CPP conda env file

2022-08-23 Thread GitBox
amoeba opened a new pull request, #13956: URL: https://github.com/apache/arrow/pull/13956 This fixes local and CI builds that use conda now that xsimd 9.0.0 has been published to [conda-forge](https://anaconda.org/conda-forge/xsimd). `cpp/cmake_modules/ThirdpartyToolchain.cmake` has a stric

[GitHub] [arrow] paleolimbot merged pull request #12824: ARROW-16141: [R] Update rhub/fedora-clang-devel for upstreamed changes

2022-08-23 Thread GitBox
paleolimbot merged PR #12824: URL: https://github.com/apache/arrow/pull/12824 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.a

[GitHub] [arrow] kou merged pull request #13952: MINOR: [R] Remove trailing whitespace in flight tests

2022-08-23 Thread GitBox
kou merged PR #13952: URL: https://github.com/apache/arrow/pull/13952 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.or

[GitHub] [arrow] westonpace commented on a diff in pull request #13912: ARROW-17350: [C++] Create a scheduler for asynchronous work

2022-08-23 Thread GitBox
westonpace commented on code in PR #13912: URL: https://github.com/apache/arrow/pull/13912#discussion_r953206180 ## cpp/src/arrow/util/async_util.h: ## @@ -17,128 +17,188 @@ #pragma once -#include - #include "arrow/result.h" #include "arrow/status.h" +#include "arrow/uti

[GitHub] [arrow] github-actions[bot] commented on pull request #13892: ARROW-12175: [C++] Fix CMake packages

2022-08-23 Thread GitBox
github-actions[bot] commented on PR #13892: URL: https://github.com/apache/arrow/pull/13892#issuecomment-1225011810 Revision: 4ef2eeb551762648d54528aa3a539e3e7d63c8ae Submitted crossbow builds: [ursacomputing/crossbow @ actions-99f1df6034](https://github.com/ursacomputing/crossbow/bra

[GitHub] [arrow] westonpace commented on a diff in pull request #13912: ARROW-17350: [C++] Create a scheduler for asynchronous work

2022-08-23 Thread GitBox
westonpace commented on code in PR #13912: URL: https://github.com/apache/arrow/pull/13912#discussion_r953203592 ## cpp/src/arrow/dataset/file_base.cc: ## @@ -488,13 +504,15 @@ class TeeNode : public compute::MapNode { const char* kind_name() const override { return "TeeNode"

[GitHub] [arrow] kou commented on pull request #13892: ARROW-12175: [C++] Fix CMake packages

2022-08-23 Thread GitBox
kou commented on PR #13892: URL: https://github.com/apache/arrow/pull/13892#issuecomment-1225010780 @github-actions crossbow submit verify-rc-source-python-linux-conda-latest-amd64 wheel-windows-cp310-amd64 -- This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] [arrow-datafusion] ursabot commented on pull request #3241: Moved nullif out of unary functions

2022-08-23 Thread GitBox
ursabot commented on PR #3241: URL: https://github.com/apache/arrow-datafusion/pull/3241#issuecomment-1225006933 Benchmark runs are scheduled for baseline = e1d4069de9d2aaf85655edd72744f176431c03d3 and contender = c574269a0f713638958b1efcc41d399212533176. c574269a0f713638958b1efcc41d39921

[GitHub] [arrow-datafusion] andygrove closed issue #3069: Some functions are incorrectly declared as unary

2022-08-23 Thread GitBox
andygrove closed issue #3069: Some functions are incorrectly declared as unary URL: https://github.com/apache/arrow-datafusion/issues/3069 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [arrow-datafusion] andygrove merged pull request #3241: Moved nullif out of unary functions

2022-08-23 Thread GitBox
andygrove merged PR #3241: URL: https://github.com/apache/arrow-datafusion/pull/3241 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@

[GitHub] [arrow-datafusion] andygrove commented on pull request #3242: Add assertion for invariant in `create_physical_expression` and fix ViewTable projection

2022-08-23 Thread GitBox
andygrove commented on PR #3242: URL: https://github.com/apache/arrow-datafusion/pull/3242#issuecomment-1225004505 > Given the above sql, it results in this plan. Isn't this 1 too many projections? > > ``` > create view v as select 1 as a, 2 as b, 3 as c; > explain analyze sele

[GitHub] [arrow] toddfarmer commented on a diff in pull request #13781: ARROW-17322: [Docs] Documenting issue lifecycle for bugs and feature requests

2022-08-23 Thread GitBox
toddfarmer commented on code in PR #13781: URL: https://github.com/apache/arrow/pull/13781#discussion_r953195902 ## docs/source/developers/bug_reports.rst: ## @@ -186,10 +176,109 @@ Good reproducible examples or minimal bug reports can be found in next tabs: #> 1 rows

[GitHub] [arrow] toddfarmer commented on a diff in pull request #13781: ARROW-17322: [Docs] Documenting issue lifecycle for bugs and feature requests

2022-08-23 Thread GitBox
toddfarmer commented on code in PR #13781: URL: https://github.com/apache/arrow/pull/13781#discussion_r953195623 ## docs/source/developers/bug_reports.rst: ## @@ -186,10 +176,109 @@ Good reproducible examples or minimal bug reports can be found in next tabs: #> 1 rows

[GitHub] [arrow] westonpace commented on a diff in pull request #13912: ARROW-17350: [C++] Create a scheduler for asynchronous work

2022-08-23 Thread GitBox
westonpace commented on code in PR #13912: URL: https://github.com/apache/arrow/pull/13912#discussion_r953189589 ## cpp/src/arrow/util/async_util.cc: ## @@ -19,186 +19,334 @@ #include "arrow/util/future.h" #include "arrow/util/logging.h" +#include "arrow/util/make_unique.h"

[GitHub] [arrow] ursabot commented on pull request #13939: ARROW-17494: [C++] Fix substrait tests linkage on static builds

2022-08-23 Thread GitBox
ursabot commented on PR #13939: URL: https://github.com/apache/arrow/pull/13939#issuecomment-1224986351 ['Python', 'R'] benchmarks have high level of regressions. [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/4ad4bb8cef72487c98d8873dfa6db10f...b831fee5c94f441595a37ccc2440b588/)

[GitHub] [arrow] ursabot commented on pull request #13939: ARROW-17494: [C++] Fix substrait tests linkage on static builds

2022-08-23 Thread GitBox
ursabot commented on PR #13939: URL: https://github.com/apache/arrow/pull/13939#issuecomment-1224986203 Benchmark runs are scheduled for baseline = 78d586a45852b69c40b88a43d86a1c90efdf1e0d and contender = 9b23a7078bc7b6176f5d918f504956609bfe61a9. 9b23a7078bc7b6176f5d918f504956609bfe61a9 is

[GitHub] [arrow] westonpace commented on issue #13949: [java] reading multiple parquet files takes unresonable amount of memory

2022-08-23 Thread GitBox
westonpace commented on issue #13949: URL: https://github.com/apache/arrow/issues/13949#issuecomment-1224980434 I'm not an expert in the Java side of things but I am pretty familiar with how the dataset scanner (which is in C++) works. The dataset scanner is going to try and read multiple

[GitHub] [arrow-datafusion] kmitchener commented on pull request #3242: Add assertion for invariant in `create_physical_expression` and fix ViewTable projection

2022-08-23 Thread GitBox
kmitchener commented on PR #3242: URL: https://github.com/apache/arrow-datafusion/pull/3242#issuecomment-1224969592 Given the above sql, it results in this plan. Isn't this 1 too many projections? ``` create view v as select 1 as a, 2 as b, 3 as c; explain analyze select * from

[GitHub] [arrow-datafusion] sarahyurick commented on issue #2265: Support "IS NOT TRUE/FALSE" syntax

2022-08-23 Thread GitBox
sarahyurick commented on issue #2265: URL: https://github.com/apache/arrow-datafusion/issues/2265#issuecomment-1224961037 Mostly asking because if it's the latter, I could edit #3189 to be for "IS NOT TRUE/FALSE" instead. Otherwise, I'll close that PR. -- This is an automated message fro

[GitHub] [arrow-datafusion] kmitchener commented on pull request #3242: Add assertion for invariant in `create_physical_expression` and fix ViewTable projection

2022-08-23 Thread GitBox
kmitchener commented on PR #3242: URL: https://github.com/apache/arrow-datafusion/pull/3242#issuecomment-1224952773 > @matthewmturner @DaltonModlin @kmitchener Since this affects views, could you please review if you have time? LGTM. If you want to reproduce, this triggered the error

[GitHub] [arrow-datafusion] codecov-commenter commented on pull request #3242: Add assertion for invariant in `create_physical_expression` and fix ViewTable projection

2022-08-23 Thread GitBox
codecov-commenter commented on PR #3242: URL: https://github.com/apache/arrow-datafusion/pull/3242#issuecomment-1224952580 # [Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/3242?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_

[GitHub] [arrow-datafusion] kmitchener commented on a diff in pull request #3239: MINOR: documentation updates

2022-08-23 Thread GitBox
kmitchener commented on code in PR #3239: URL: https://github.com/apache/arrow-datafusion/pull/3239#discussion_r953143623 ## docs/source/user-guide/sql/data_types.md: ## @@ -22,30 +22,63 @@ DataFusion uses Arrow, and thus the Arrow type system, for query execution. The SQL typ

[GitHub] [arrow-datafusion] andygrove commented on pull request #3242: Add assertion for invariant in `create_physical_expression` and fix ViewTable projection

2022-08-23 Thread GitBox
andygrove commented on PR #3242: URL: https://github.com/apache/arrow-datafusion/pull/3242#issuecomment-1224909782 @matthewmturner @DaltonModlin @kmitchener Since this affects views, could you please review if you have time? -- This is an automated message from the Apache Git Service. To

[GitHub] [arrow-datafusion] andygrove commented on a diff in pull request #3239: MINOR: documentation updates

2022-08-23 Thread GitBox
andygrove commented on code in PR #3239: URL: https://github.com/apache/arrow-datafusion/pull/3239#discussion_r953124707 ## docs/source/user-guide/sql/data_types.md: ## @@ -22,30 +22,63 @@ DataFusion uses Arrow, and thus the Arrow type system, for query execution. The SQL type

[GitHub] [arrow] drin commented on a diff in pull request #13330: ARROW-16772: [C++] Implement encode and decode functions for Run-Length encoding

2022-08-23 Thread GitBox
drin commented on code in PR #13330: URL: https://github.com/apache/arrow/pull/13330#discussion_r953115528 ## cpp/src/arrow/compute/kernels/vector_run_length_encode.cc: ## @@ -0,0 +1,393 @@ +#include "arrow/compute/api_vector.h" +#include "arrow/compute/kernels/common.h" +#inclu

[GitHub] [arrow-datafusion] andygrove opened a new pull request, #3242: Add assertion for invariant in `create_physical_expression` and fix ViewTable projection

2022-08-23 Thread GitBox
andygrove opened a new pull request, #3242: URL: https://github.com/apache/arrow-datafusion/pull/3242 # Which issue does this PR close? Closes https://github.com/apache/arrow-datafusion/issues/3240 # Rationale for this change `create_physical_expression` acce

[GitHub] [arrow] zeroshade commented on pull request #13946: ARROW-17500: [Go] Kernel and KernelContext interfaces

2022-08-23 Thread GitBox
zeroshade commented on PR #13946: URL: https://github.com/apache/arrow/pull/13946#issuecomment-1224898332 I'll wait until tomorrow to merge this in order to give @cyb70289 time to comment if desired. -- This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [arrow] github-actions[bot] commented on pull request #13955: use a more future-proof test of str_like availability

2022-08-23 Thread GitBox
github-actions[bot] commented on PR #13955: URL: https://github.com/apache/arrow/pull/13955#issuecomment-1224893824 Thanks for opening a pull request! If this is not a [minor PR](https://github.com/apache/arrow/blob/master/CONTRIBUTING.md#Minor-Fixes). Could you open an issue

[GitHub] [arrow-datafusion] comphead opened a new pull request, #3241: Moved nullif out of unary

2022-08-23 Thread GitBox
comphead opened a new pull request, #3241: URL: https://github.com/apache/arrow-datafusion/pull/3241 # Which issue does this PR close? Closes #3069. # Rationale for this change Move not unary function out of unary list # What changes are included in this PR?

[GitHub] [arrow] kou merged pull request #13939: ARROW-17494: [C++] Fix substrait tests linkage on static builds

2022-08-23 Thread GitBox
kou merged PR #13939: URL: https://github.com/apache/arrow/pull/13939 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.or

[GitHub] [arrow-datafusion] andygrove opened a new issue, #3240: View TableProvider ignores projections, resulting in invalid plans

2022-08-23 Thread GitBox
andygrove opened a new issue, #3240: URL: https://github.com/apache/arrow-datafusion/issues/3240 **Describe the bug** View TableProvider ignores projections, resulting in invalid plans. **To Reproduce** TBD - will post PR with test case soon **Expected behavior** Should

[GitHub] [arrow] github-actions[bot] commented on pull request #13911: ARROW-17081: [Java][Datasets] Move JNI build configuration from cpp/ to java/

2022-08-23 Thread GitBox
github-actions[bot] commented on PR #13911: URL: https://github.com/apache/arrow/pull/13911#issuecomment-1224885050 Revision: 8bf75b650b159bd77fb80242617326a623482601 Submitted crossbow builds: [ursacomputing/crossbow @ actions-2baa75e9b9](https://github.com/ursacomputing/crossbow/bra

[GitHub] [arrow] kou commented on pull request #13911: ARROW-17081: [Java][Datasets] Move JNI build configuration from cpp/ to java/

2022-08-23 Thread GitBox
kou commented on PR #13911: URL: https://github.com/apache/arrow/pull/13911#issuecomment-1224883295 @github-actions crossbow submit java-jars -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

  1   2   3   4   >