mustafasrepo commented on code in PR #3916:
URL: https://github.com/apache/arrow-datafusion/pull/3916#discussion_r1002931293
##
datafusion/expr/src/window_frame.rs:
##
@@ -132,70 +125,72 @@ pub enum WindowFrameBound {
///
/// 5. UNBOUNDED FOLLOWING
/// The frame b
mustafasrepo commented on code in PR #3916:
URL: https://github.com/apache/arrow-datafusion/pull/3916#discussion_r1002930609
##
datafusion/common/src/scalar.rs:
##
@@ -476,35 +480,144 @@ macro_rules! impl_op {
(ScalarValue::Int8(lhs), ScalarValue::Int8(rhs)) => {
Dandandan merged PR #438:
URL: https://github.com/apache/arrow-ballista/pull/438
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arro
JkSelf commented on code in PR #14151:
URL: https://github.com/apache/arrow/pull/14151#discussion_r1002895087
##
java/dataset/src/main/java/org/apache/arrow/dataset/scanner/ArrowScannerReader.java:
##
@@ -0,0 +1,112 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) und
JkSelf commented on code in PR #14151:
URL: https://github.com/apache/arrow/pull/14151#discussion_r1002893145
##
java/dataset/src/test/java/org/apache/arrow/dataset/file/TestDatasetFileWriter.java:
##
@@ -0,0 +1,140 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) und
Ted-Jiang commented on issue #412:
URL: https://github.com/apache/arrow-ballista/issues/412#issuecomment-1288380377
@Dandandan I think this is not a bug, like the situation if the data is
skew, all data write to the shuffle read partiton-1. IMO we still should
launch R executors. 😂
--
T
kou commented on code in PR #14481:
URL: https://github.com/apache/arrow/pull/14481#discussion_r1002862240
##
dev/release/setup-centos7.sh:
##
@@ -0,0 +1,90 @@
+
+#!/bin/sh
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.
kou commented on code in PR #14481:
URL: https://github.com/apache/arrow/pull/14481#discussion_r1002861908
##
dev/release/VERIFY.md:
##
@@ -50,15 +50,28 @@ You can install them by the followings on Debian GNU/Linux
and Ubuntu:
You can install them by the followings on CentOS 7
kou commented on code in PR #14351:
URL: https://github.com/apache/arrow/pull/14351#discussion_r1002860262
##
cpp/src/arrow/util/crc32.cc:
##
@@ -0,0 +1,961 @@
+// Licensed to the Apache Software Foundation (ASF) under one
Review Comment:
Could you add the information to the
bkmgit commented on code in PR #14481:
URL: https://github.com/apache/arrow/pull/14481#discussion_r1002851546
##
dev/release/setup-centos7.sh:
##
@@ -0,0 +1,90 @@
+
+#!/bin/sh
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements
bkmgit commented on code in PR #14481:
URL: https://github.com/apache/arrow/pull/14481#discussion_r1002847734
##
dev/release/setup-centos7.sh:
##
@@ -0,0 +1,90 @@
+
+#!/bin/sh
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements
bkmgit commented on code in PR #14481:
URL: https://github.com/apache/arrow/pull/14481#discussion_r1002847567
##
dev/release/setup-centos7.sh:
##
@@ -0,0 +1,90 @@
+
+#!/bin/sh
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements
bkmgit commented on code in PR #14481:
URL: https://github.com/apache/arrow/pull/14481#discussion_r1002846163
##
dev/release/VERIFY.md:
##
@@ -50,15 +50,28 @@ You can install them by the followings on Debian GNU/Linux
and Ubuntu:
You can install them by the followings on CentO
tustvold commented on code in PR #3885:
URL: https://github.com/apache/arrow-datafusion/pull/3885#discussion_r1002828791
##
datafusion/core/src/execution/options.rs:
##
@@ -168,56 +170,31 @@ pub struct ParquetReadOptions<'a> {
pub file_extension: &'a str,
/// Partition
Kikkon commented on PR #3933:
URL:
https://github.com/apache/arrow-datafusion/pull/3933#issuecomment-1288312967
> Is there any chance you can write some tests for this code?
Sure, I will add tests later.
--
This is an automated message from the Apache Git Service.
To respond to the
mapleFU commented on code in PR #14351:
URL: https://github.com/apache/arrow/pull/14351#discussion_r1002825053
##
cpp/src/arrow/util/crc32.cc:
##
@@ -0,0 +1,961 @@
+// Licensed to the Apache Software Foundation (ASF) under one
Review Comment:
> Could you also add the origina
mapleFU commented on code in PR #14351:
URL: https://github.com/apache/arrow/pull/14351#discussion_r1002824724
##
cpp/src/arrow/util/crc32.cc:
##
@@ -0,0 +1,961 @@
+// Licensed to the Apache Software Foundation (ASF) under one
Review Comment:
Will do it tonight
--
This i
tustvold commented on code in PR #3885:
URL: https://github.com/apache/arrow-datafusion/pull/3885#discussion_r1002820504
##
datafusion/core/src/config.rs:
##
@@ -237,6 +247,29 @@ impl BuiltInConfigs {
to reduce the number of rows decoded.",
fal
tustvold commented on code in PR #3612:
URL: https://github.com/apache/arrow-datafusion/pull/3612#discussion_r1002816676
##
datafusion/proto/proto/datafusion.proto:
##
@@ -762,8 +762,9 @@ message StructValue {
message ScalarValue{
oneof value {
-// Null value of
tustvold commented on code in PR #3612:
URL: https://github.com/apache/arrow-datafusion/pull/3612#discussion_r1002816676
##
datafusion/proto/proto/datafusion.proto:
##
@@ -762,8 +762,9 @@ message StructValue {
message ScalarValue{
oneof value {
-// Null value of
andygrove merged PR #433:
URL: https://github.com/apache/arrow-ballista/pull/433
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arro
kou commented on code in PR #14362:
URL: https://github.com/apache/arrow/pull/14362#discussion_r1002774927
##
docker-compose.yml:
##
@@ -488,17 +488,36 @@ services:
shm_size: *shm-size
ulimits: *ulimits
environment: &cuda-environment
- <<: *ccache
+ <<:
kou commented on code in PR #14351:
URL: https://github.com/apache/arrow/pull/14351#discussion_r1002776836
##
cpp/src/arrow/util/crc32.cc:
##
@@ -0,0 +1,961 @@
+// Licensed to the Apache Software Foundation (ASF) under one
Review Comment:
Could you also add the original sour
kou commented on code in PR #14351:
URL: https://github.com/apache/arrow/pull/14351#discussion_r1002776531
##
cpp/src/arrow/util/crc32.cc:
##
@@ -0,0 +1,961 @@
+// Licensed to the Apache Software Foundation (ASF) under one
Review Comment:
Could you put this to `cpp/src/arrow
kou commented on code in PR #14472:
URL: https://github.com/apache/arrow/pull/14472#discussion_r1002771022
##
dev/tasks/java-jars/github.yml:
##
@@ -48,47 +50,65 @@ jobs:
{% endif %}
build-cpp-macos:
-name: Build C++ libraries macOS
-runs-on: macos-latest
+
kou commented on code in PR #14033:
URL: https://github.com/apache/arrow/pull/14033#discussion_r1002770060
##
.github/workflows/integration.yml:
##
@@ -85,7 +85,11 @@ jobs:
env:
ARCHERY_DOCKER_USER: ${{ secrets.DOCKERHUB_USER }}
ARCHERY_DOCKER_PASS
kou commented on code in PR #14033:
URL: https://github.com/apache/arrow/pull/14033#discussion_r1002769208
##
.github/workflows/integration.yml:
##
@@ -85,7 +85,11 @@ jobs:
env:
ARCHERY_DOCKER_USER: ${{ secrets.DOCKERHUB_USER }}
ARCHERY_DOCKER_PASS
kou commented on code in PR #14481:
URL: https://github.com/apache/arrow/pull/14481#discussion_r1002766539
##
dev/release/VERIFY.md:
##
@@ -50,15 +50,28 @@ You can install them by the followings on Debian GNU/Linux
and Ubuntu:
You can install them by the followings on CentOS 7
JacekPliszka commented on PR #14482:
URL: https://github.com/apache/arrow/pull/14482#issuecomment-1288189273
The title has been changed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
andygrove commented on PR #438:
URL: https://github.com/apache/arrow-ballista/pull/438#issuecomment-1288185864
@avantgardnerio fyi
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific com
andygrove closed pull request #365: Add release verification guide
URL: https://github.com/apache/arrow-ballista/pull/365
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To uns
andygrove opened a new pull request, #438:
URL: https://github.com/apache/arrow-ballista/pull/438
# Which issue does this PR close?
N/A
# Rationale for this change
Make all benchmark code public so others can run the same benchmarks and
help find issues.
bkmgit commented on PR #14482:
URL: https://github.com/apache/arrow/pull/14482#issuecomment-1288180423
Thanks for your contribution. To make it easier to determine which areas
this affects, please change the title to:
`ARROW-18137: [C++][Python][Docs] adding info about TableGroupBy.ag
bkmgit commented on PR #14482:
URL: https://github.com/apache/arrow/pull/14482#issuecomment-1288180376
Thanks for your contribution. To make it easier to determine which areas
this affects, please change the title to:
`ARROW-18137: [C++][Python][Docs] adding info about TableGroupBy.ag
github-actions[bot] commented on PR #14482:
URL: https://github.com/apache/arrow/pull/14482#issuecomment-1288174614
https://issues.apache.org/jira/browse/ARROW-18137
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
JacekPliszka opened a new pull request, #14482:
URL: https://github.com/apache/arrow/pull/14482
I have realized that pandas drop_duplicates functionality can be easily
emulated with group_by(...).aggregate([]) and is much faster than
to_pandas().drop_duplicates()
Please consider this
Dandandan commented on PR #3932:
URL:
https://github.com/apache/arrow-datafusion/pull/3932#issuecomment-1288174097
Thanks @jackwener
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
Dandandan closed issue #3904: [DOC] - There are unsupported DDL in the official
documentation
URL: https://github.com/apache/arrow-datafusion/issues/3904
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
Dandandan merged PR #3932:
URL: https://github.com/apache/arrow-datafusion/pull/3932
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@
github-actions[bot] commented on PR #14481:
URL: https://github.com/apache/arrow/pull/14481#issuecomment-1288159675
https://issues.apache.org/jira/browse/ARROW-18136
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
alamb commented on issue #3928:
URL:
https://github.com/apache/arrow-datafusion/issues/3928#issuecomment-1288159111
See also- https://github.com/apache/arrow-datafusion/pull/3612 - the
serialization code is a bit of a mess now but hopefully we can get it better
--
This is an automated me
alamb commented on PR #3933:
URL:
https://github.com/apache/arrow-datafusion/pull/3933#issuecomment-1288158919
Looks good @Kikkon -- thank you!
Is there any chance you can write some tests for this code?
--
This is an automated message from the Apache Git Service.
To respond to th
andygrove closed issue #353: Scheduler silently replaces `ParquetExec` with
`EmptyExec` if data path is not correctly mounted in container
URL: https://github.com/apache/arrow-ballista/issues/353
--
This is an automated message from the Apache Git Service.
To respond to the message, please lo
andygrove merged PR #414:
URL: https://github.com/apache/arrow-ballista/pull/414
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arro
andygrove commented on PR #414:
URL: https://github.com/apache/arrow-ballista/pull/414#issuecomment-1288155698
I am going to go ahead and merge this so that I can cut the RC today.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitH
andygrove commented on PR #434:
URL: https://github.com/apache/arrow-ballista/pull/434#issuecomment-1288154509
@rahulpenti I ran this again. There is no `wheels` directory under
`python/target`,
--
This is an automated message from the Apache Git Service.
To respond to the message, please
Kikkon commented on issue #3873:
URL:
https://github.com/apache/arrow-datafusion/issues/3873#issuecomment-1288151129
@alamb If I understand correctly, just modify the return result of
create_initial_plan, like this #3933.
--
This is an automated message from the Apache Git Service.
To re
Kikkon opened a new pull request, #3933:
URL: https://github.com/apache/arrow-datafusion/pull/3933
# Which issue does this PR close?
Closes #3873
# Rationale for this change
Refer to this issue #3873
# What changes are included in this PR?
Make so
github-actions[bot] commented on PR #14481:
URL: https://github.com/apache/arrow/pull/14481#issuecomment-1288121772
Thanks for opening a pull request!
If this is not a [minor
PR](https://github.com/apache/arrow/blob/master/CONTRIBUTING.md#Minor-Fixes).
Could you open an issue
timvw commented on PR #2891:
URL: https://github.com/apache/arrow-rs/pull/2891#issuecomment-1288119774
Also verified that when AWS_ACCESS_KEY_ID, AWS_SECRET_ACCESS_KEY and
AWS_PROFILE are set that the first two get preference over AWS_PROFILE (similar
to how aws cli behaves).
timvw commented on PR #2891:
URL: https://github.com/apache/arrow-rs/pull/2891#issuecomment-1288116861
Works for me (tested on commit (2079a67c5))
cargo test --package object_store --features aws_profile --lib
aws::tests::s3_with_sso_profile -- --exact
```rust
#[tokio:
retikulum commented on issue #3928:
URL:
https://github.com/apache/arrow-datafusion/issues/3928#issuecomment-1288108295
It looks interesting. Can you assign it to me?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use th
jackwener opened a new pull request, #3932:
URL: https://github.com/apache/arrow-datafusion/pull/3932
# Which issue does this PR close?
Closes #3904.
# Rationale for this change
# What changes are included in this PR?
fix doc about `CREATE TABLE IF NOT
jackwener commented on PR #3931:
URL:
https://github.com/apache/arrow-datafusion/pull/3931#issuecomment-1288101874
@ygf11 thanks, have resolved
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
rtpsw commented on code in PR #14385:
URL: https://github.com/apache/arrow/pull/14385#discussion_r1002701934
##
cpp/proto/substrait/extension_rels.proto:
##
@@ -0,0 +1,36 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements
jhorstmann commented on issue #1992:
URL:
https://github.com/apache/arrow-datafusion/issues/1992#issuecomment-1288095217
> PG not support negative timestamp
This sounded surprising, it seems what is not supported is the input syntax
starting with a minus sign. Negative timestamps are
alamb commented on code in PR #3612:
URL: https://github.com/apache/arrow-datafusion/pull/3612#discussion_r1002693944
##
datafusion/proto/src/from_proto.rs:
##
@@ -1359,184 +1246,6 @@ fn vec_to_array(v: Vec) -> [T; N]
{
})
}
-//Does not typecheck lists
-fn typechecked_s
alamb commented on code in PR #3612:
URL: https://github.com/apache/arrow-datafusion/pull/3612#discussion_r1002693845
##
datafusion/proto/proto/datafusion.proto:
##
@@ -803,48 +804,9 @@ message Decimal128{
int64 s = 3;
}
-// Contains all valid datafusion scalar type except
rtpsw commented on PR #14385:
URL: https://github.com/apache/arrow/pull/14385#issuecomment-1288086193
> @rtpsw Looks pretty good! There seems to be many style changes that seems
orthogonal. Are those changes automatically made? Is it easy to separate out
the style change from the actual cha
ygf11 commented on code in PR #3931:
URL: https://github.com/apache/arrow-datafusion/pull/3931#discussion_r1002683658
##
datafusion/expr/src/expr.rs:
##
@@ -353,6 +348,22 @@ pub struct GetIndexedField {
pub key: ScalarValue,
}
+/// BETWEEN expression
+#[derive(Clone, Par
ygf11 commented on code in PR #3931:
URL: https://github.com/apache/arrow-datafusion/pull/3931#discussion_r1002683871
##
datafusion/expr/src/expr.rs:
##
@@ -353,6 +348,22 @@ pub struct GetIndexedField {
pub key: ScalarValue,
}
+/// BETWEEN expression
+#[derive(Clone, Par
ygf11 commented on code in PR #3931:
URL: https://github.com/apache/arrow-datafusion/pull/3931#discussion_r1002683658
##
datafusion/expr/src/expr.rs:
##
@@ -353,6 +348,22 @@ pub struct GetIndexedField {
pub key: ScalarValue,
}
+/// BETWEEN expression
+#[derive(Clone, Par
ygf11 commented on code in PR #3931:
URL: https://github.com/apache/arrow-datafusion/pull/3931#discussion_r1002683636
##
datafusion/expr/src/expr.rs:
##
@@ -353,6 +348,22 @@ pub struct GetIndexedField {
pub key: ScalarValue,
}
+/// BETWEEN expression
+#[derive(Clone, Par
alamb commented on issue #3904:
URL:
https://github.com/apache/arrow-datafusion/issues/3904#issuecomment-1288076322
I think the problem is with this example from
https://arrow.apache.org/datafusion/user-guide/sql/ddl.html
> CREATE TABLE valuetable IF NOT EXISTS AS
VALUES(1,'HELLO'),
rtpsw commented on PR #14352:
URL: https://github.com/apache/arrow/pull/14352#issuecomment-1288067166
> @lidavidm, are you a good person to review this? or can you suggest
someone? Also, note this PR includes a new [SWMR
gadget](https://github.com/apache/arrow/pull/14352/files#diff-f53040e5
HaoYang670 commented on issue #3770:
URL:
https://github.com/apache/arrow-datafusion/issues/3770#issuecomment-1288065309
Do we need to consider the schema infomation of the parent query when
optimizing the subquery?
--
This is an automated message from the Apache Git Service.
To respond
Dandandan merged PR #436:
URL: https://github.com/apache/arrow-ballista/pull/436
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arro
github-actions[bot] commented on PR #14480:
URL: https://github.com/apache/arrow/pull/14480#issuecomment-1288034727
https://issues.apache.org/jira/browse/ARROW-18135
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
rtpsw opened a new pull request, #14480:
URL: https://github.com/apache/arrow/pull/14480
See https://issues.apache.org/jira/browse/ARROW-18135
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
jackwener opened a new pull request, #3931:
URL: https://github.com/apache/arrow-datafusion/pull/3931
# Which issue does this PR close?
Part of #2175 and #3807
# Rationale for this change
# What changes are included in this PR?
Refactor Expr::Cast to u
viirya commented on PR #2912:
URL: https://github.com/apache/arrow-rs/pull/2912#issuecomment-1288032679
Thanks @tustvold
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
viirya closed issue #2911: Support decimal256 array in sort kernels
URL: https://github.com/apache/arrow-rs/issues/2911
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsub
viirya merged PR #2912:
URL: https://github.com/apache/arrow-rs/pull/2912
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apach
73 matches
Mail list logo
