[GitHub] [arrow] ursabot commented on pull request #14625: ARROW-18315: [CI][deb][RPM] Pin createrepo_c on Travis CI arm64-graviton

2022-11-14 Thread GitBox
ursabot commented on PR #14625: URL: https://github.com/apache/arrow/pull/14625#issuecomment-1314918666 Benchmark runs are scheduled for baseline = aec771ddcc427fcdc9770c68bbcdee71c222dc98 and contender = 9f5a5bb7c1deeab7819cbcee29f3f8eefbd3f60b. 9f5a5bb7c1deeab7819cbcee29f3f8eefbd3f60b is

[GitHub] [arrow] jorisvandenbossche merged pull request #14633: ARROW-18257: [Python] pass back time types with correct type class

2022-11-14 Thread GitBox
jorisvandenbossche merged PR #14633: URL: https://github.com/apache/arrow/pull/14633 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@

[GitHub] [arrow] kshitij12345 commented on pull request #14550: ARROW-17301: [C++] Implement compute function "binary_slice"

2022-11-14 Thread GitBox
kshitij12345 commented on PR #14550: URL: https://github.com/apache/arrow/pull/14550#issuecomment-1314890254 @pitrou PTAL :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [arrow-rs] Jefffrey commented on a diff in pull request #3101: Parse Time32/Time64 from formatted string

2022-11-14 Thread GitBox
Jefffrey commented on code in PR #3101: URL: https://github.com/apache/arrow-rs/pull/3101#discussion_r1022404078 ## arrow-cast/src/parse.rs: ## @@ -199,10 +199,123 @@ impl Parser for TimestampSecondType { } } -parser_primitive!(Time64NanosecondType); -parser_primitive!(T

[GitHub] [arrow] github-actions[bot] commented on pull request #14642: ARROW-18322: [Python] source installation from pip without flight

2022-11-14 Thread GitBox
github-actions[bot] commented on PR #14642: URL: https://github.com/apache/arrow/pull/14642#issuecomment-1314880408 https://issues.apache.org/jira/browse/ARROW-18322 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [arrow] AlenkaF opened a new pull request, #14642: ARROW-18322: [Python] source installation from pip without flight

2022-11-14 Thread GitBox
AlenkaF opened a new pull request, #14642: URL: https://github.com/apache/arrow/pull/14642 This PR adds the use of `PYARROW_WITH_FLIGHT` environment variable when building PyArrow C++. With this change PyArrow will be able to build successfully even when Arrow C++ is installed without Arrow

[GitHub] [arrow-rs] Jefffrey commented on a diff in pull request #3101: Parse Time32/Time64 from formatted string

2022-11-14 Thread GitBox
Jefffrey commented on code in PR #3101: URL: https://github.com/apache/arrow-rs/pull/3101#discussion_r1022390861 ## arrow-cast/src/parse.rs: ## @@ -199,10 +199,123 @@ impl Parser for TimestampSecondType { } } -parser_primitive!(Time64NanosecondType); -parser_primitive!(T

[GitHub] [arrow-rs] tustvold commented on pull request #3101: Parse Time32/Time64 from formatted string

2022-11-14 Thread GitBox
tustvold commented on PR #3101: URL: https://github.com/apache/arrow-rs/pull/3101#issuecomment-1314868053 > 4. consider the timezone I originally was going to suggest this, but I decided against it as the semantics are actually a little bit funky. In particular, courtesy of the wonde

[GitHub] [arrow] github-actions[bot] commented on pull request #14641: ARROW-15716: [Dataset][Python] Parse a list of fragment paths to gather filters

2022-11-14 Thread GitBox
github-actions[bot] commented on PR #14641: URL: https://github.com/apache/arrow/pull/14641#issuecomment-1314850659 :warning: Ticket **has not been started in JIRA**, please click 'Start Progress'. -- This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [arrow] github-actions[bot] commented on pull request #14641: ARROW-15716: [Dataset][Python] Parse a list of fragment paths to gather filters

2022-11-14 Thread GitBox
github-actions[bot] commented on PR #14641: URL: https://github.com/apache/arrow/pull/14641#issuecomment-1314850629 https://issues.apache.org/jira/browse/ARROW-15716 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [arrow] vibhatha opened a new pull request, #14641: ARROW-15716: [Dataset][Python] Parse a list of fragment paths to gather filters

2022-11-14 Thread GitBox
vibhatha opened a new pull request, #14641: URL: https://github.com/apache/arrow/pull/14641 Updated `parse` function in `Partitioning` to accept a list of paths and produce a single expression. -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [arrow] vibhatha commented on pull request #14373: ARROW-17292: [C++] Segmentation fault on arrow-compute-hash-join-node-test on macos nightlies

2022-11-14 Thread GitBox
vibhatha commented on PR #14373: URL: https://github.com/apache/arrow/pull/14373#issuecomment-1314827298 @westonpace We didn't finalize this ticket, right? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [arrow] vibhatha commented on a diff in pull request #14292: ARROW-15592: [C++] Add support for custom output field names in a substrait::PlanRel

2022-11-14 Thread GitBox
vibhatha commented on code in PR #14292: URL: https://github.com/apache/arrow/pull/14292#discussion_r1022357896 ## cpp/src/arrow/engine/substrait/serde.cc: ## @@ -124,6 +107,24 @@ compute::Declaration ProjectByNamesDeclaration(compute::Declaration input, compute::Proje

[GitHub] [arrow] westonpace commented on a diff in pull request #14292: ARROW-15592: [C++] Add support for custom output field names in a substrait::PlanRel

2022-11-14 Thread GitBox
westonpace commented on code in PR #14292: URL: https://github.com/apache/arrow/pull/14292#discussion_r1022356737 ## cpp/src/arrow/engine/substrait/serde.cc: ## @@ -124,6 +107,24 @@ compute::Declaration ProjectByNamesDeclaration(compute::Declaration input, compute::Pro

[GitHub] [arrow] westonpace commented on a diff in pull request #14186: ARROW-17520: [C++] Implement SubStrait SetRel (UnionAll)

2022-11-14 Thread GitBox
westonpace commented on code in PR #14186: URL: https://github.com/apache/arrow/pull/14186#discussion_r1022350402 ## cpp/src/arrow/engine/substrait/relation_internal.cc: ## @@ -619,6 +620,49 @@ Result FromProto(const substrait::Rel& rel, const ExtensionSet&

[GitHub] [arrow] westonpace commented on pull request #14373: ARROW-17292: [C++] Segmentation fault on arrow-compute-hash-join-node-test on macos nightlies

2022-11-14 Thread GitBox
westonpace commented on PR #14373: URL: https://github.com/apache/arrow/pull/14373#issuecomment-1314817257 Should we close this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

[GitHub] [arrow] vibhatha commented on a diff in pull request #14174: ARROW-17486: [C++] Substrait To Arrow Emit feature testing

2022-11-14 Thread GitBox
vibhatha commented on code in PR #14174: URL: https://github.com/apache/arrow/pull/14174#discussion_r1022350631 ## cpp/src/arrow/engine/substrait/test_util.h: ## @@ -0,0 +1,118 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agre

[GitHub] [arrow] westonpace commented on a diff in pull request #14174: ARROW-17486: [C++] Substrait To Arrow Emit feature testing

2022-11-14 Thread GitBox
westonpace commented on code in PR #14174: URL: https://github.com/apache/arrow/pull/14174#discussion_r1022347947 ## cpp/src/arrow/engine/substrait/serde_test.cc: ## @@ -3692,5 +3536,641 @@ TEST(Substrait, ReadRelWithGlobFiles) { buf, {}, {}, &options);

[GitHub] [arrow] ursabot commented on pull request #14640: ARROW-18327: [CI][Release] verify-rc-source-*-macos-amd64 are failed

2022-11-14 Thread GitBox
ursabot commented on PR #14640: URL: https://github.com/apache/arrow/pull/14640#issuecomment-1314797333 ['Python', 'R'] benchmarks have high level of regressions. [test-mac-arm](https://conbench.ursa.dev/compare/runs/bd04b87ed7d24f2491dcb20f1c17a0e9...cfa5a691be2b432ab174e53830416ccd/)

[GitHub] [arrow] ursabot commented on pull request #14640: ARROW-18327: [CI][Release] verify-rc-source-*-macos-amd64 are failed

2022-11-14 Thread GitBox
ursabot commented on PR #14640: URL: https://github.com/apache/arrow/pull/14640#issuecomment-1314797082 Benchmark runs are scheduled for baseline = 14aa41780fea7ec8411200ea5de8c405e05d3b9c and contender = aec771ddcc427fcdc9770c68bbcdee71c222dc98. aec771ddcc427fcdc9770c68bbcdee71c222dc98 is

[GitHub] [arrow-rs] ursabot commented on pull request #3117: Add downcast_array (#2901)

2022-11-14 Thread GitBox
ursabot commented on PR #3117: URL: https://github.com/apache/arrow-rs/pull/3117#issuecomment-1314790838 Benchmark runs are scheduled for baseline = b0b5d8b4f57049d72403a749e109829ff35a6b64 and contender = 5c2801d08edbe1573d6c23c55b7333f0aedbdc3c. 5c2801d08edbe1573d6c23c55b7333f0aedbdc3c i

[GitHub] [arrow-rs] tustvold closed issue #2901: API to take back ownership of an ArrayRef

2022-11-14 Thread GitBox
tustvold closed issue #2901: API to take back ownership of an ArrayRef URL: https://github.com/apache/arrow-rs/issues/2901 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[GitHub] [arrow-rs] tustvold merged pull request #3117: Add downcast_array (#2901)

2022-11-14 Thread GitBox
tustvold merged PR #3117: URL: https://github.com/apache/arrow-rs/pull/3117 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apa

[GitHub] [arrow-rs] viirya commented on a diff in pull request #3117: Add downcast_array (#2901)

2022-11-14 Thread GitBox
viirya commented on code in PR #3117: URL: https://github.com/apache/arrow-rs/pull/3117#discussion_r1022328453 ## arrow-array/src/cast.rs: ## @@ -550,6 +551,38 @@ array_downcast_fn!(as_union_array, UnionArray); array_downcast_fn!(as_map_array, MapArray); array_downcast_fn!(as_

[GitHub] [arrow-datafusion] jackwener commented on a diff in pull request #4208: Add try_optimize method

2022-11-14 Thread GitBox
jackwener commented on code in PR #4208: URL: https://github.com/apache/arrow-datafusion/pull/4208#discussion_r1022313759 ## datafusion/optimizer/src/decorrelate_where_exists.rs: ## @@ -20,7 +20,7 @@ use crate::utils::{ verify_not_disjunction, }; use crate::{utils, Optimi

[GitHub] [arrow-datafusion] jackwener commented on pull request #4212: Remove alias in Union

2022-11-14 Thread GitBox
jackwener commented on PR #4212: URL: https://github.com/apache/arrow-datafusion/pull/4212#issuecomment-1314762666 > W: Failed to fetch http://deb.debian.org/debian/dists/bullseye/InRelease Could not connect to debian.map.fastlydns.net:80 (146.75.30.132), connection timed out Unable to co

[GitHub] [arrow-datafusion] ursabot commented on pull request #4141: fix: shouldn't pass alias through into subquery.

2022-11-14 Thread GitBox
ursabot commented on PR #4141: URL: https://github.com/apache/arrow-datafusion/pull/4141#issuecomment-1314753051 Benchmark runs are scheduled for baseline = 9de893e54bba2c70782f4e684da70653b9241499 and contender = d91ce0684646f07edc8f182214f15845a9efab97. d91ce0684646f07edc8f182214f15845a

[GitHub] [arrow-datafusion] liukun4515 merged pull request #4141: fix: shouldn't pass alias through into subquery.

2022-11-14 Thread GitBox
liukun4515 merged PR #4141: URL: https://github.com/apache/arrow-datafusion/pull/4141 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...

[GitHub] [arrow-datafusion] liukun4515 closed issue #4123: Bug in interpreting correctly parsed SQL with aliases

2022-11-14 Thread GitBox
liukun4515 closed issue #4123: Bug in interpreting correctly parsed SQL with aliases URL: https://github.com/apache/arrow-datafusion/issues/4123 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [arrow-datafusion] liukun4515 commented on pull request #4141: fix: shouldn't pass alias through into subquery.

2022-11-14 Thread GitBox
liukun4515 commented on PR #4141: URL: https://github.com/apache/arrow-datafusion/pull/4141#issuecomment-1314750164 Thanks @jackwener -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [arrow-rs] tustvold commented on a diff in pull request #3117: Add downcast_array (#2901)

2022-11-14 Thread GitBox
tustvold commented on code in PR #3117: URL: https://github.com/apache/arrow-rs/pull/3117#discussion_r1022295908 ## arrow-array/src/cast.rs: ## @@ -550,6 +551,38 @@ array_downcast_fn!(as_union_array, UnionArray); array_downcast_fn!(as_map_array, MapArray); array_downcast_fn!(a

[GitHub] [arrow-ballista] dependabot[bot] opened a new pull request, #518: Update arrow requirement from 26.0.0 to 27.0.0

2022-11-14 Thread GitBox
dependabot[bot] opened a new pull request, #518: URL: https://github.com/apache/arrow-ballista/pull/518 Updates the requirements on [arrow](https://github.com/apache/arrow-rs) to permit the latest version. Changelog Sourced from https://github.com/apache/arrow-rs/blob/master/CHANGE

[GitHub] [arrow-ballista] dependabot[bot] commented on pull request #518: Update arrow requirement from 26.0.0 to 27.0.0

2022-11-14 Thread GitBox
dependabot[bot] commented on PR #518: URL: https://github.com/apache/arrow-ballista/pull/518#issuecomment-1314745079 The following labels could not be found: `auto-dependencies`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [arrow-rs] tustvold commented on a diff in pull request #3117: Add downcast_array (#2901)

2022-11-14 Thread GitBox
tustvold commented on code in PR #3117: URL: https://github.com/apache/arrow-rs/pull/3117#discussion_r1022295908 ## arrow-array/src/cast.rs: ## @@ -550,6 +551,38 @@ array_downcast_fn!(as_union_array, UnionArray); array_downcast_fn!(as_map_array, MapArray); array_downcast_fn!(a

[GitHub] [arrow-rs] viirya commented on a diff in pull request #3117: Add downcast_array (#2901)

2022-11-14 Thread GitBox
viirya commented on code in PR #3117: URL: https://github.com/apache/arrow-rs/pull/3117#discussion_r1022293554 ## arrow-array/src/cast.rs: ## @@ -550,6 +551,38 @@ array_downcast_fn!(as_union_array, UnionArray); array_downcast_fn!(as_map_array, MapArray); array_downcast_fn!(as_

[GitHub] [arrow-rs] tustvold commented on a diff in pull request #3117: Add downcast_array (#2901)

2022-11-14 Thread GitBox
tustvold commented on code in PR #3117: URL: https://github.com/apache/arrow-rs/pull/3117#discussion_r1022291987 ## arrow-array/src/cast.rs: ## @@ -550,6 +551,38 @@ array_downcast_fn!(as_union_array, UnionArray); array_downcast_fn!(as_map_array, MapArray); array_downcast_fn!(a

[GitHub] [arrow-datafusion] jackwener commented on pull request #4212: Remove alias in Union

2022-11-14 Thread GitBox
jackwener commented on PR #4212: URL: https://github.com/apache/arrow-datafusion/pull/4212#issuecomment-1314732048 @alamb @liukun4515 @andygrove @mingmwang , how do you think about it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [arrow-rs] tustvold commented on a diff in pull request #3115: Add some initial APIs for copy-on-write support

2022-11-14 Thread GitBox
tustvold commented on code in PR #3115: URL: https://github.com/apache/arrow-rs/pull/3115#discussion_r1022289201 ## arrow-array/src/array/mod.rs: ## @@ -372,6 +372,28 @@ impl<'a, T: Array> Array for &'a T { } } +/// A kind of `Array` which can be downcasted by `downcast_

[GitHub] [arrow-rs] tustvold opened a new pull request, #3117: Add downcast_array (#2901)

2022-11-14 Thread GitBox
tustvold opened a new pull request, #3117: URL: https://github.com/apache/arrow-rs/pull/3117 # Which issue does this PR close? Closes #2901 # Rationale for this change Make this technique more discoverable # What changes are included in this PR?

[GitHub] [arrow-datafusion] jackwener opened a new pull request, #4212: Remove alias in Union

2022-11-14 Thread GitBox
jackwener opened a new pull request, #4212: URL: https://github.com/apache/arrow-datafusion/pull/4212 # Which issue does this PR close? Closes #. # Rationale for this change Find in #4192 , I find alias should'n be in `Union`. And it looks like part o

[GitHub] [arrow-rs] waitingkuo commented on a diff in pull request #3101: Parse Time32/Time64 from formatted string

2022-11-14 Thread GitBox
waitingkuo commented on code in PR #3101: URL: https://github.com/apache/arrow-rs/pull/3101#discussion_r1022284434 ## arrow-cast/src/parse.rs: ## @@ -199,10 +199,123 @@ impl Parser for TimestampSecondType { } } -parser_primitive!(Time64NanosecondType); -parser_primitive!

[GitHub] [arrow-rs] waitingkuo commented on a diff in pull request #3101: Parse Time32/Time64 from formatted string

2022-11-14 Thread GitBox
waitingkuo commented on code in PR #3101: URL: https://github.com/apache/arrow-rs/pull/3101#discussion_r1022272744 ## arrow-cast/src/parse.rs: ## @@ -199,10 +199,123 @@ impl Parser for TimestampSecondType { } } -parser_primitive!(Time64NanosecondType); -parser_primitive!

[GitHub] [arrow-datafusion] pjmore commented on issue #1999: Error occurs when only using partition columns in query

2022-11-14 Thread GitBox
pjmore commented on issue #1999: URL: https://github.com/apache/arrow-datafusion/issues/1999#issuecomment-1314715824 @Jefffrey Yeah you're right this was fixed by #2000 and I should've closed it then. Thanks for the heads up on this one. -- This is an automated message from the Apache Gi

[GitHub] [arrow-datafusion] pjmore closed issue #1999: Error occurs when only using partition columns in query

2022-11-14 Thread GitBox
pjmore closed issue #1999: Error occurs when only using partition columns in query URL: https://github.com/apache/arrow-datafusion/issues/1999 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[GitHub] [arrow-rs] viirya commented on a diff in pull request #3115: Add some initial APIs for copy-on-write support

2022-11-14 Thread GitBox
viirya commented on code in PR #3115: URL: https://github.com/apache/arrow-rs/pull/3115#discussion_r1022282147 ## arrow-array/src/array/mod.rs: ## @@ -372,6 +372,28 @@ impl<'a, T: Array> Array for &'a T { } } +/// A kind of `Array` which can be downcasted by `downcast_ar

[GitHub] [arrow-datafusion] jackwener commented on pull request #4192: add `propagate_empty_relation` optimizer rule

2022-11-14 Thread GitBox
jackwener commented on PR #4192: URL: https://github.com/apache/arrow-datafusion/pull/4192#issuecomment-1314713832 Thanks @mingmwang @alamb @Dandandan review❤️ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[GitHub] [arrow-rs] viirya commented on a diff in pull request #3115: Add some initial APIs for copy-on-write support

2022-11-14 Thread GitBox
viirya commented on code in PR #3115: URL: https://github.com/apache/arrow-rs/pull/3115#discussion_r1022281252 ## arrow-array/src/array/mod.rs: ## @@ -372,6 +372,28 @@ impl<'a, T: Array> Array for &'a T { } } +/// A kind of `Array` which can be downcasted by `downcast_ar

[GitHub] [arrow-rs] tustvold commented on a diff in pull request #3115: Add some initial APIs for copy-on-write support

2022-11-14 Thread GitBox
tustvold commented on code in PR #3115: URL: https://github.com/apache/arrow-rs/pull/3115#discussion_r1022279925 ## arrow-array/src/array/mod.rs: ## @@ -372,6 +372,28 @@ impl<'a, T: Array> Array for &'a T { } } +/// A kind of `Array` which can be downcasted by `downcast_

[GitHub] [arrow-rs] tustvold commented on pull request #3115: Add some initial APIs for copy-on-write support

2022-11-14 Thread GitBox
tustvold commented on PR #3115: URL: https://github.com/apache/arrow-rs/pull/3115#issuecomment-1314712562 There is some overlap with #2902 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[GitHub] [arrow-rs] tustvold commented on a diff in pull request #3115: Add some initial APIs for copy-on-write support

2022-11-14 Thread GitBox
tustvold commented on code in PR #3115: URL: https://github.com/apache/arrow-rs/pull/3115#discussion_r1022279925 ## arrow-array/src/array/mod.rs: ## @@ -372,6 +372,28 @@ impl<'a, T: Array> Array for &'a T { } } +/// A kind of `Array` which can be downcasted by `downcast_

[GitHub] [arrow-datafusion] mingmwang commented on issue #4211: Null-Aware Anti Join Support

2022-11-14 Thread GitBox
mingmwang commented on issue #4211: URL: https://github.com/apache/arrow-datafusion/issues/4211#issuecomment-1314711361 @alamb @jackwener @liukun4515 Please share your thoughts. -- This is an automated message from the Apache Git Service. To respond to the message, please log on t

[GitHub] [arrow-rs] tustvold opened a new pull request, #3116: Cleanup parquet tests

2022-11-14 Thread GitBox
tustvold opened a new pull request, #3116: URL: https://github.com/apache/arrow-rs/pull/3116 # Which issue does this PR close? Closes #. # Rationale for this change Cleans up some test duplication noticed whilst reviewing #3103 # What changes are i

[GitHub] [arrow-rs] jiacai2050 closed issue #2916: Perf about ParquetRecordBatchStream vs ParquetRecordBatchReader

2022-11-14 Thread GitBox
jiacai2050 closed issue #2916: Perf about ParquetRecordBatchStream vs ParquetRecordBatchReader URL: https://github.com/apache/arrow-rs/issues/2916 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [arrow-datafusion] mingmwang opened a new issue, #4211: Null-Aware Anti Join Support

2022-11-14 Thread GitBox
mingmwang opened a new issue, #4211: URL: https://github.com/apache/arrow-datafusion/issues/4211 **Is your feature request related to a problem or challenge? Please describe what you are trying to do.** A clear and concise description of what the problem is. Ex. I'm always frustrated whe

[GitHub] [arrow-datafusion-python] francis-du commented on issue #7: Release version 0.7.0

2022-11-14 Thread GitBox
francis-du commented on issue #7: URL: https://github.com/apache/arrow-datafusion-python/issues/7#issuecomment-1314702972 > `maturin publish` sounds good. Is publishing to PyPi enough for this release? How important is it to publish wheels? I think `maturin publish` should upload whe

[GitHub] [arrow] kou merged pull request #14625: ARROW-18315: [CI][deb][RPM] Pin createrepo_c on Travis CI arm64-graviton

2022-11-14 Thread GitBox
kou merged PR #14625: URL: https://github.com/apache/arrow/pull/14625 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.or

[GitHub] [arrow] kou merged pull request #14640: ARROW-18327: [CI][Release] verify-rc-source-*-macos-amd64 are failed

2022-11-14 Thread GitBox
kou merged PR #14640: URL: https://github.com/apache/arrow/pull/14640 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.or

[GitHub] [arrow] kou commented on pull request #14625: ARROW-18315: [CI][deb][RPM] Pin createrepo_c on Travis CI arm64-graviton

2022-11-14 Thread GitBox
kou commented on PR #14625: URL: https://github.com/apache/arrow/pull/14625#issuecomment-1314699947 +1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mai

[GitHub] [arrow] kou commented on pull request #14640: ARROW-18327: [CI][Release] verify-rc-source-*-macos-amd64 are failed

2022-11-14 Thread GitBox
kou commented on PR #14640: URL: https://github.com/apache/arrow/pull/14640#issuecomment-1314699527 +1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mai

[GitHub] [arrow-datafusion-python] francis-du commented on issue #7: Release version 0.7.0

2022-11-14 Thread GitBox
francis-du commented on issue #7: URL: https://github.com/apache/arrow-datafusion-python/issues/7#issuecomment-1314697946 > If we are ok with just running `maturin publish` for now, I think we could go ahead and create a release candidate, vote on it, then run that command to publish?

[GitHub] [arrow-datafusion] HaoYang670 commented on issue #4191: scalar function `round` ignores second parameter

2022-11-14 Thread GitBox
HaoYang670 commented on issue #4191: URL: https://github.com/apache/arrow-datafusion/issues/4191#issuecomment-1314694661 Not sure, but I wonder could we support this is logical phase? Given the following 2 lemmas: ```coq 1. forall source: FloatArray, round(source) = round(source, 0

[GitHub] [arrow] ursabot commented on pull request #14630: ARROW-18325: [Docs][Python] Add Python 3.11 to python/install.rst

2022-11-14 Thread GitBox
ursabot commented on PR #14630: URL: https://github.com/apache/arrow/pull/14630#issuecomment-1314689810 Benchmark runs are scheduled for baseline = 3d07ff3a5af17642d98d7451a2f4b5f3a1ea65f2 and contender = 14aa41780fea7ec8411200ea5de8c405e05d3b9c. 14aa41780fea7ec8411200ea5de8c405e05d3b9c is

[GitHub] [arrow-rs] tustvold commented on a diff in pull request #3103: Expose `SortingColumn` in parquet files

2022-11-14 Thread GitBox
tustvold commented on code in PR #3103: URL: https://github.com/apache/arrow-rs/pull/3103#discussion_r1022249268 ## parquet/src/file/metadata.rs: ## @@ -353,6 +377,15 @@ impl RowGroupMetaDataBuilder { self } +/// Sets the sorting order for columns +pub fn

[GitHub] [arrow-rs] viirya opened a new pull request, #3115: Add some initial APIs for copy-on-write support

2022-11-14 Thread GitBox
viirya opened a new pull request, #3115: URL: https://github.com/apache/arrow-rs/pull/3115 # Which issue does this PR close? Part of #1981. # Rationale for this change I've played around with the code to add some initial APIs for copy-on-write support. T

[GitHub] [arrow-datafusion] ygf11 opened a new issue, #4210: Add ambiguous check when generate projection plan

2022-11-14 Thread GitBox
ygf11 opened a new issue, #4210: URL: https://github.com/apache/arrow-datafusion/issues/4210 **Describe the bug** When the two table both has `c0`, then the following sql will work: ```sql ❯ explain select c0 from test0, test1; +---+---

[GitHub] [arrow-rs] tustvold commented on issue #3114: Improve schema merging

2022-11-14 Thread GitBox
tustvold commented on issue #3114: URL: https://github.com/apache/arrow-rs/issues/3114#issuecomment-1314666050 I would have thought this logic would exist within the query engine, i.e. DataFusion, not the compute engine? -- This is an automated message from the Apache Git Service. To resp

[GitHub] [arrow-rs] tustvold commented on issue #3086: Change Field::metadata to HashMap

2022-11-14 Thread GitBox
tustvold commented on issue #3086: URL: https://github.com/apache/arrow-rs/issues/3086#issuecomment-1314664688 Nothing like a good old-fashioned scream test? i.e. remove them and see if anyone complains :sweat_smile: -- This is an automated message from the Apache Git Service. To respond

[GitHub] [arrow-rs] ursabot commented on pull request #3110: Add PrimitiveArray::unary_opt

2022-11-14 Thread GitBox
ursabot commented on PR #3110: URL: https://github.com/apache/arrow-rs/pull/3110#issuecomment-1314647644 Benchmark runs are scheduled for baseline = 81ce601bef0b4e0c40a129c98e12e3acfae58c58 and contender = b0b5d8b4f57049d72403a749e109829ff35a6b64. b0b5d8b4f57049d72403a749e109829ff35a6b64 i

[GitHub] [arrow-rs] tustvold merged pull request #3110: Add PrimitiveArray::unary_opt

2022-11-14 Thread GitBox
tustvold merged PR #3110: URL: https://github.com/apache/arrow-rs/pull/3110 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apa

[GitHub] [arrow-rs] askoa commented on issue #3086: Change Field::metadata to HashMap

2022-11-14 Thread GitBox
askoa commented on issue #3086: URL: https://github.com/apache/arrow-rs/issues/3086#issuecomment-1314632679 I was wondering if there is a way to determine the impact of removing `cmp` and `hash` functions? -- This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [arrow-rs] tustvold commented on pull request #3102: parquet bloom filter part II: read sbbf bitset from row group reader, update API, and add cli demo

2022-11-14 Thread GitBox
tustvold commented on PR #3102: URL: https://github.com/apache/arrow-rs/pull/3102#issuecomment-1314627789 I think it unlikely that a subsequent addition would omit sufficient information to properly identify its location in the file, but as you say, the result would simply be overestimating

[GitHub] [arrow-rs] Jimexist commented on a diff in pull request #3102: parquet bloom filter part II: read sbbf bitset from row group reader, update API, and add cli demo

2022-11-14 Thread GitBox
Jimexist commented on code in PR #3102: URL: https://github.com/apache/arrow-rs/pull/3102#discussion_r100568 ## parquet/src/bloom_filter/mod.rs: ## @@ -79,6 +81,33 @@ fn block_check(block: &Block, hash: u32) -> bool { /// A split block Bloom filter pub struct Sbbf(Vec);

[GitHub] [arrow-rs] Jimexist commented on pull request #3102: parquet bloom filter part II: read sbbf bitset from row group reader, update API, and add cli demo

2022-11-14 Thread GitBox
Jimexist commented on PR #3102: URL: https://github.com/apache/arrow-rs/pull/3102#issuecomment-1314625409 > Once we have read the file metadata we know the byte ranges of the column chunks, and page indexes, as well as the offsets of the bloom filter data for each column chunk. It should th

[GitHub] [arrow-rs] ursabot commented on pull request #3111: Updates release instructions for new crates

2022-11-14 Thread GitBox
ursabot commented on PR #3111: URL: https://github.com/apache/arrow-rs/pull/3111#issuecomment-1314614721 Benchmark runs are scheduled for baseline = 19f372d82315e0df29c9b545bb011b0cbd45ceda and contender = 81ce601bef0b4e0c40a129c98e12e3acfae58c58. 81ce601bef0b4e0c40a129c98e12e3acfae58c58 i

[GitHub] [arrow-rs] tustvold commented on pull request #3112: Remove dangling `csv` and `ipc` tests in `arrow/Cargo.toml`

2022-11-14 Thread GitBox
tustvold commented on PR #3112: URL: https://github.com/apache/arrow-rs/pull/3112#issuecomment-1314608674 I wonder if the issue is the `include` directive excludes the integration tests? -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [arrow-rs] tustvold commented on a diff in pull request #3113: Include field name in merge error message

2022-11-14 Thread GitBox
tustvold commented on code in PR #3113: URL: https://github.com/apache/arrow-rs/pull/3113#discussion_r1022208028 ## arrow-schema/src/field.rs: ## @@ -443,6 +443,15 @@ mod test { use std::collections::hash_map::DefaultHasher; use std::hash::{Hash, Hasher}; +#[test

[GitHub] [arrow-rs] tustvold merged pull request #3111: Updates release instructions for new crates

2022-11-14 Thread GitBox
tustvold merged PR #3111: URL: https://github.com/apache/arrow-rs/pull/3111 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apa

[GitHub] [arrow] ursabot commented on pull request #14634: ARROW-18302: [Python][Packaging] Update minimum vcpkg required version

2022-11-14 Thread GitBox
ursabot commented on PR #14634: URL: https://github.com/apache/arrow/pull/14634#issuecomment-1314601282 Benchmark runs are scheduled for baseline = 7a5f4c49f9353a5e88cca3eb0d445c24e22da9df and contender = 3d07ff3a5af17642d98d7451a2f4b5f3a1ea65f2. 3d07ff3a5af17642d98d7451a2f4b5f3a1ea65f2 is

[GitHub] [arrow-rs] andygrove opened a new issue, #3114: Improve schema merging

2022-11-14 Thread GitBox
andygrove opened a new issue, #3114: URL: https://github.com/apache/arrow-rs/issues/3114 **Is your feature request related to a problem or challenge? Please describe what you are trying to do.** I am trying to work with the nyctaxi parquet data set which has one file per month. O

[GitHub] [arrow-adbc] kou commented on pull request #174: chore: set up release process

2022-11-14 Thread GitBox
kou commented on PR #174: URL: https://github.com/apache/arrow-adbc/pull/174#issuecomment-1314576568 No problem! We can work on this together! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [arrow-datafusion] andre-cc-natzka commented on pull request #4156: Full support for time32 and time64 literal values (`ScalarValue`)

2022-11-14 Thread GitBox
andre-cc-natzka commented on PR #4156: URL: https://github.com/apache/arrow-datafusion/pull/4156#issuecomment-1314574846 So, I have added the tests required by @alamb and I rebased the branch on top of the most recent version of the master. I had a few troubles while rebasing but I could s

[GitHub] [arrow-datafusion] viirya commented on a diff in pull request #4102: Add parser option for parsing SQL numeric literals as decimal

2022-11-14 Thread GitBox
viirya commented on code in PR #4102: URL: https://github.com/apache/arrow-datafusion/pull/4102#discussion_r1022184509 ## datafusion/sql/src/planner.rs: ## @@ -2919,19 +2987,103 @@ fn extract_possible_join_keys( } } -// Parse number in sql string, convert to Expr::Litera

[GitHub] [arrow-datafusion] viirya commented on a diff in pull request #4102: Add parser option for parsing SQL numeric literals as decimal

2022-11-14 Thread GitBox
viirya commented on code in PR #4102: URL: https://github.com/apache/arrow-datafusion/pull/4102#discussion_r1022183556 ## datafusion/sql/src/planner.rs: ## @@ -2919,19 +2987,103 @@ fn extract_possible_join_keys( } } -// Parse number in sql string, convert to Expr::Litera

[GitHub] [arrow-adbc] lidavidm commented on pull request #174: chore: set up release process

2022-11-14 Thread GitBox
lidavidm commented on PR #174: URL: https://github.com/apache/arrow-adbc/pull/174#issuecomment-1314569771 > > Assuming for now that GLib/Ruby won't be included, nor will distro packages > > Can I work on it as a follow-up task after this is merged? That would be much appreciate

[GitHub] [arrow-rs] andygrove opened a new pull request, #3113: Include field name in merge error message

2022-11-14 Thread GitBox
andygrove opened a new pull request, #3113: URL: https://github.com/apache/arrow-rs/pull/3113 # Which issue does this PR close? Closes https://github.com/apache/arrow-rs/issues/3095 # Rationale for this change Follow on from https://github.com/apache/arro

[GitHub] [arrow] kou merged pull request #14630: ARROW-18325: [Docs][Python] Add Python 3.11 to python/install.rst

2022-11-14 Thread GitBox
kou merged PR #14630: URL: https://github.com/apache/arrow/pull/14630 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.or

[GitHub] [arrow-adbc] kou commented on pull request #174: chore: set up release process

2022-11-14 Thread GitBox
kou commented on PR #174: URL: https://github.com/apache/arrow-adbc/pull/174#issuecomment-1314567363 > Assuming for now that GLib/Ruby won't be included, nor will distro packages Can I work on it as a follow-up task after this is merged? -- This is an automated message from the Apac

[GitHub] [arrow] github-actions[bot] commented on pull request #14640: ARROW-18327: [CI][Release] verify-rc-source-*-macos-amd64 are failed

2022-11-14 Thread GitBox
github-actions[bot] commented on PR #14640: URL: https://github.com/apache/arrow/pull/14640#issuecomment-1314566636 Revision: 58169a09c12c2dd06408eee2a56a8786125c7ec9 Submitted crossbow builds: [ursacomputing/crossbow @ actions-5cf0e7533f](https://github.com/ursacomputing/crossbow/bra

[GitHub] [arrow-datafusion] comphead commented on issue #3997: change` date_part` return types to f64

2022-11-14 Thread GitBox
comphead commented on issue #3997: URL: https://github.com/apache/arrow-datafusion/issues/3997#issuecomment-1314566562 waiting for #4199 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[GitHub] [arrow] kou commented on pull request #14640: ARROW-18327: [CI][Release] verify-rc-source-*-macos-amd64 are failed

2022-11-14 Thread GitBox
kou commented on PR #14640: URL: https://github.com/apache/arrow/pull/14640#issuecomment-1314565177 @github-actions crossbow submit verify-rc-source-*-macos-amd64 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [arrow] github-actions[bot] commented on pull request #14640: ARROW-18327: [CI][Release] verify-rc-source-*-macos-amd64 are failed

2022-11-14 Thread GitBox
github-actions[bot] commented on PR #14640: URL: https://github.com/apache/arrow/pull/14640#issuecomment-1314565132 :warning: Ticket **has not been started in JIRA**, please click 'Start Progress'. -- This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [arrow] github-actions[bot] commented on pull request #14640: ARROW-18327: [CI][Release] verify-rc-source-*-macos-amd64 are failed

2022-11-14 Thread GitBox
github-actions[bot] commented on PR #14640: URL: https://github.com/apache/arrow/pull/14640#issuecomment-1314565117 :warning: Ticket **has no components in JIRA**, make sure you assign one. -- This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [arrow] github-actions[bot] commented on pull request #14640: ARROW-18327: [CI][Release] verify-rc-source-*-macos-amd64 are failed

2022-11-14 Thread GitBox
github-actions[bot] commented on PR #14640: URL: https://github.com/apache/arrow/pull/14640#issuecomment-1314565102 https://issues.apache.org/jira/browse/ARROW-18327 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [arrow] kou opened a new pull request, #14640: ARROW-18327: [CI][Release] verify-rc-source-*-macos-amd64 are failed

2022-11-14 Thread GitBox
kou opened a new pull request, #14640: URL: https://github.com/apache/arrow/pull/14640 https://github.com/ursacomputing/crossbow/actions/runs/3461688619/jobs/5779609972#step:3:127 ==> Pouring python@3.11--3.11.0.big_sur.bottle.tar.gz Error: The `brew link` step did not comp

[GitHub] [arrow] benibus commented on pull request #14100: ARROW-4709: [C++] Optimize for ordered JSON fields

2022-11-14 Thread GitBox
benibus commented on PR #14100: URL: https://github.com/apache/arrow/pull/14100#issuecomment-1314562078 Rebased on the latest changes. I compared against master locally and I'm seeing roughly +12/16/25% bytes/sec for 10/100/1000 fields (in the ordered/non-sparse cases). -- This is

[GitHub] [arrow-datafusion] viirya commented on a diff in pull request #4102: Add parser option for parsing SQL numeric literals as decimal

2022-11-14 Thread GitBox
viirya commented on code in PR #4102: URL: https://github.com/apache/arrow-datafusion/pull/4102#discussion_r1022176824 ## datafusion/sql/src/planner.rs: ## @@ -2671,6 +2694,49 @@ impl<'a, S: ContextProvider> SqlToRel<'a, S> { Ok(lit(ScalarValue::new_list(Some(values

[GitHub] [arrow] github-actions[bot] commented on pull request #14625: ARROW-18315: [CI][deb][RPM] Pin createrepo_c on Travis CI arm64-graviton

2022-11-14 Thread GitBox
github-actions[bot] commented on PR #14625: URL: https://github.com/apache/arrow/pull/14625#issuecomment-1314561176 Revision: 6cf1d1dba3254101e2e841f5c69c33d2f92c13a1 Submitted crossbow builds: [ursacomputing/crossbow @ actions-0635118bc5](https://github.com/ursacomputing/crossbow/bra

[GitHub] [arrow] kou commented on pull request #14625: ARROW-18315: [CI][deb][RPM] Pin createrepo_c on Travis CI arm64-graviton

2022-11-14 Thread GitBox
kou commented on PR #14625: URL: https://github.com/apache/arrow/pull/14625#issuecomment-1314558315 @github-actions crossbow submit -g linux-arm64 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [arrow-datafusion] andygrove commented on a diff in pull request #4102: Add parser option for parsing SQL numeric literals as decimal

2022-11-14 Thread GitBox
andygrove commented on code in PR #4102: URL: https://github.com/apache/arrow-datafusion/pull/4102#discussion_r1022173833 ## datafusion/sql/src/planner.rs: ## @@ -2671,6 +2694,49 @@ impl<'a, S: ContextProvider> SqlToRel<'a, S> { Ok(lit(ScalarValue::new_list(Some(val

[GitHub] [arrow] github-actions[bot] commented on pull request #14639: ARROW-18326: [Go] Add option to support dictionary deltas with IPC

2022-11-14 Thread GitBox
github-actions[bot] commented on PR #14639: URL: https://github.com/apache/arrow/pull/14639#issuecomment-1314555294 Thanks for opening a pull request! If this is not a [minor PR](https://github.com/apache/arrow/blob/master/CONTRIBUTING.md#Minor-Fixes). Could you open an issue

  1   2   3   4   >