[GitHub] [arrow-datafusion] avantgardnerio commented on pull request #4834: (#4462) Postgres compatibility tests using sqllogictest

2023-01-20 Thread GitBox
avantgardnerio commented on PR #4834: URL: https://github.com/apache/arrow-datafusion/pull/4834#issuecomment-1398604791 > 1. Don't orchestrate the postgres containers with rust test code Good catch... I :100: % agree with this. -- This is an automated message from the Apache Git Se

[GitHub] [arrow-datafusion] mustafasrepo opened a new pull request, #5003: Support for bounded execution when window frame involves UNBOUNDED PRECEDING

2023-01-20 Thread GitBox
mustafasrepo opened a new pull request, #5003: URL: https://github.com/apache/arrow-datafusion/pull/5003 # Which issue does this PR close? Closes [#4978](https://github.com/apache/arrow-datafusion/issues/4978) # Rationale for this change Currently, queries tha

[GitHub] [arrow] LucyMcGowan commented on issue #14826: write_dataset is crashing on my machine

2023-01-20 Thread GitBox
LucyMcGowan commented on issue #14826: URL: https://github.com/apache/arrow/issues/14826#issuecomment-1398595442 Installing the most recent version of R fixed this! Thank you @assignUser -- do you want me to close the issue? -- This is an automated message from the Apache Git Service. To

[GitHub] [arrow] github-actions[bot] commented on pull request #33808: GH-20272: [C++] Bump version of bundled AWS SDK

2023-01-20 Thread GitBox
github-actions[bot] commented on PR #33808: URL: https://github.com/apache/arrow/pull/33808#issuecomment-1398593959 * Closes: #20272 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[GitHub] [arrow] js8544 opened a new pull request, #33808: GH-20272: [C++] Bump version of bundled AWS SDK

2023-01-20 Thread GitBox
js8544 opened a new pull request, #33808: URL: https://github.com/apache/arrow/pull/33808 ### Rationale for this change Bump AWS SDK version to 1.10.55. ### What changes are included in this PR? Bump AWS SDK version to 1.10.55. -- This is an aut

[GitHub] [arrow-datafusion] mustafasrepo commented on a diff in pull request #4989: Add support for linear range calculation in WINDOW functions

2023-01-20 Thread GitBox
mustafasrepo commented on code in PR #4989: URL: https://github.com/apache/arrow-datafusion/pull/4989#discussion_r1082729694 ## datafusion/common/src/utils.rs: ## @@ -22,8 +22,16 @@ use arrow::array::ArrayRef; use arrow::compute::SortOptions; use std::cmp::Ordering; +/// Giv

[GitHub] [arrow] ablack3 commented on issue #33807: Using dplyr::tally with an Arrow FileSystemDataset crashes R

2023-01-20 Thread GitBox
ablack3 commented on issue #33807: URL: https://github.com/apache/arrow/issues/33807#issuecomment-1398589729 This might be a clue ``` *** caught illegal operation *** address 0x13d7349a8, cause 'illegal opcode' Traceback: 1: Array__GetScalar(Array$create(x, ty

[GitHub] [arrow] wjones127 commented on a diff in pull request #33694: MINOR: [C++][Parquet] Rephrase decimal annotation

2023-01-20 Thread GitBox
wjones127 commented on code in PR #33694: URL: https://github.com/apache/arrow/pull/33694#discussion_r1082720103 ## cpp/src/parquet/properties.h: ## @@ -452,19 +452,39 @@ class PARQUET_EXPORT WriterProperties { return this->disable_statistics(path->ToDotString()); }

[GitHub] [arrow] ursabot commented on pull request #33764: GH-15109: [Python] Allow creation of non empty struct array with zero field

2023-01-20 Thread GitBox
ursabot commented on PR #33764: URL: https://github.com/apache/arrow/pull/33764#issuecomment-1398577405 ['Python', 'R'] benchmarks have high level of regressions. [test-mac-arm](https://conbench.ursa.dev/compare/runs/2e36b6e440484302ad20c5b43dc9a58c...2eb76bfb924947cb97a14cbb8822eecf/)

[GitHub] [arrow-datafusion] ursabot commented on pull request #5002: Bump sqllogictest to v0.11.1

2023-01-20 Thread GitBox
ursabot commented on PR #5002: URL: https://github.com/apache/arrow-datafusion/pull/5002#issuecomment-1398576985 Benchmark runs are scheduled for baseline = 03601bee545599a8be3ef982bc98f7b3a71fb3df and contender = 92d0a054c23e5fba91718db32ccd933ce86dd2b6. 92d0a054c23e5fba91718db32ccd933ce

[GitHub] [arrow] ursabot commented on pull request #33764: GH-15109: [Python] Allow creation of non empty struct array with zero field

2023-01-20 Thread GitBox
ursabot commented on PR #33764: URL: https://github.com/apache/arrow/pull/33764#issuecomment-1398576941 Benchmark runs are scheduled for baseline = e920474d7f1dbc7702c08117481db0cd4297b581 and contender = fc1f9ebbc4c3ae77d5cfc2f9322f4373d3d19b8a. fc1f9ebbc4c3ae77d5cfc2f9322f4373d3d19b8a is

[GitHub] [arrow-datafusion] xudong963 merged pull request #5002: Bump sqllogictest to v0.11.1

2023-01-20 Thread GitBox
xudong963 merged PR #5002: URL: https://github.com/apache/arrow-datafusion/pull/5002 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@

[GitHub] [arrow-rs] tustvold closed issue #3159: Support Nested Types in Row Format

2023-01-20 Thread GitBox
tustvold closed issue #3159: Support Nested Types in Row Format URL: https://github.com/apache/arrow-rs/issues/3159 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscri

[GitHub] [arrow] wjones127 commented on a diff in pull request #33694: MINOR: [C++][Parquet] Rephrase decimal annotation

2023-01-20 Thread GitBox
wjones127 commented on code in PR #33694: URL: https://github.com/apache/arrow/pull/33694#discussion_r1082703943 ## cpp/src/parquet/properties.h: ## @@ -452,19 +452,39 @@ class PARQUET_EXPORT WriterProperties { return this->disable_statistics(path->ToDotString()); }

[GitHub] [arrow-adbc] paleolimbot commented on issue #366: [Discuss] Is the conventional commit format working?

2023-01-20 Thread GitBox
paleolimbot commented on issue #366: URL: https://github.com/apache/arrow-adbc/issues/366#issuecomment-1398565056 I rather like reading the conventional commit PR notifications...it's not perfectly consistent but it's *more* consistent than Arrow's "language-only" component. I'd like to ado

[GitHub] [arrow-rs] DDtKey commented on a diff in pull request #3365: Add csv-core based reader (#3338)

2023-01-20 Thread GitBox
DDtKey commented on code in PR #3365: URL: https://github.com/apache/arrow-rs/pull/3365#discussion_r1081030906 ## arrow-csv/src/reader/records.rs: ## @@ -0,0 +1,266 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See

[GitHub] [arrow-adbc] lidavidm merged pull request #364: ci: download arch-specific golang

2023-01-20 Thread GitBox
lidavidm merged PR #364: URL: https://github.com/apache/arrow-adbc/pull/364 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apa

[GitHub] [arrow] ursabot commented on pull request #33780: GH-33779: [R] Nightly builds (R 3.5 and 3.6) failing due to field refs test

2023-01-20 Thread GitBox
ursabot commented on PR #33780: URL: https://github.com/apache/arrow/pull/33780#issuecomment-1398538971 ['Python', 'R'] benchmarks have high level of regressions. [test-mac-arm](https://conbench.ursa.dev/compare/runs/ad7d2fade4df48c7b3718a3d97031fd1...2e36b6e440484302ad20c5b43dc9a58c/)

[GitHub] [arrow] ursabot commented on pull request #33780: GH-33779: [R] Nightly builds (R 3.5 and 3.6) failing due to field refs test

2023-01-20 Thread GitBox
ursabot commented on PR #33780: URL: https://github.com/apache/arrow/pull/33780#issuecomment-1398538353 Benchmark runs are scheduled for baseline = 4c698fb3c2a2b4ee046c6ad6e992e81ed90c7b0e and contender = e920474d7f1dbc7702c08117481db0cd4297b581. e920474d7f1dbc7702c08117481db0cd4297b581 is

[GitHub] [arrow-rs] alamb commented on pull request #3578: Use native types in PageIndex (#3575)

2023-01-20 Thread GitBox
alamb commented on PR #3578: URL: https://github.com/apache/arrow-rs/pull/3578#issuecomment-1398536300 cc @Ted-Jiang -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To uns

[GitHub] [arrow-adbc] lidavidm commented on pull request #365: feat(r): Add R Driver Manager

2023-01-20 Thread GitBox
lidavidm commented on PR #365: URL: https://github.com/apache/arrow-adbc/pull/365#issuecomment-1398533476 For those cpplint failures, you might need something like this: https://github.com/apache/arrow-adbc/blob/1568815791594d6cd2e4cf1299d4d33e6aded78b/c/driver/sqlite/statement_reader

[GitHub] [arrow-rs] tustvold commented on a diff in pull request #3578: Use native types in PageIndex (#3575)

2023-01-20 Thread GitBox
tustvold commented on code in PR #3578: URL: https://github.com/apache/arrow-rs/pull/3578#discussion_r1082678855 ## parquet/src/util/bit_util.rs: ## @@ -17,76 +17,104 @@ use std::{cmp, mem::size_of}; -use crate::data_type::AsBytes; +use crate::data_type::{AsBytes, ByteArray

[GitHub] [arrow-datafusion] ursabot commented on pull request #4984: minor: Update data type support documentation

2023-01-20 Thread GitBox
ursabot commented on PR #4984: URL: https://github.com/apache/arrow-datafusion/pull/4984#issuecomment-1398518494 Benchmark runs are scheduled for baseline = 5dd5ffd5ea84d843b9ef34d0eaa9ac992618f6e2 and contender = 03601bee545599a8be3ef982bc98f7b3a71fb3df. 03601bee545599a8be3ef982bc98f7b3a

[GitHub] [arrow-adbc] lidavidm commented on pull request #364: ci: download arch-specific golang

2023-01-20 Thread GitBox
lidavidm commented on PR #364: URL: https://github.com/apache/arrow-adbc/pull/364#issuecomment-1398515942 Ok, it works now. One of the Go builds is a little flaky. https://github.com/lidavidm/arrow-adbc/actions/runs/3968565812/jobs/6801899981 -- This is an automated message from the Apach

[GitHub] [arrow-rs] tustvold commented on a diff in pull request #3578: Use native types in PageIndex (#3575)

2023-01-20 Thread GitBox
tustvold commented on code in PR #3578: URL: https://github.com/apache/arrow-rs/pull/3578#discussion_r1082672997 ## parquet/src/bin/parquet-index.rs: ## @@ -132,7 +132,7 @@ fn compute_row_counts(offset_index: &[PageLocation], rows: i64) -> Vec { } /// Prints index informati

[GitHub] [arrow-rs] tustvold commented on a diff in pull request #3578: Use native types in PageIndex (#3575)

2023-01-20 Thread GitBox
tustvold commented on code in PR #3578: URL: https://github.com/apache/arrow-rs/pull/3578#discussion_r1082672397 ## parquet/src/file/page_index/index.rs: ## @@ -53,14 +53,14 @@ pub enum Index { /// will only return pageLocations without min_max index, /// `NONE` repres

[GitHub] [arrow-rs] tustvold commented on a diff in pull request #3578: Use native types in PageIndex (#3575)

2023-01-20 Thread GitBox
tustvold commented on code in PR #3578: URL: https://github.com/apache/arrow-rs/pull/3578#discussion_r1082671978 ## parquet/src/util/bit_util.rs: ## @@ -17,76 +17,104 @@ use std::{cmp, mem::size_of}; -use crate::data_type::AsBytes; +use crate::data_type::{AsBytes, ByteArray

[GitHub] [arrow-rs] tustvold commented on a diff in pull request #3578: Use native types in PageIndex (#3575)

2023-01-20 Thread GitBox
tustvold commented on code in PR #3578: URL: https://github.com/apache/arrow-rs/pull/3578#discussion_r1082671374 ## parquet/src/file/statistics.rs: ## @@ -181,11 +181,11 @@ pub fn from_thrift( // min/max statistics for INT96 columns. let

[GitHub] [arrow-datafusion-python] andygrove opened a new pull request, #147: Rename default branch from master to main

2023-01-20 Thread GitBox
andygrove opened a new pull request, #147: URL: https://github.com/apache/arrow-datafusion-python/pull/147 # Which issue does this PR close? Part of https://github.com/apache/arrow-datafusion-python/issues/144 # Rationale for this change See issue # Wh

[GitHub] [arrow-datafusion] mustafasrepo commented on a diff in pull request #4989: Add support for linear range calculation in WINDOW functions

2023-01-20 Thread GitBox
mustafasrepo commented on code in PR #4989: URL: https://github.com/apache/arrow-datafusion/pull/4989#discussion_r1082669525 ## datafusion/common/src/utils.rs: ## @@ -103,6 +111,53 @@ where Ok(low) } +/// This function searches for a tuple of given values (`target`) amon

[GitHub] [arrow-rs] tustvold commented on a diff in pull request #3578: Use native types in PageIndex (#3575)

2023-01-20 Thread GitBox
tustvold commented on code in PR #3578: URL: https://github.com/apache/arrow-rs/pull/3578#discussion_r1082668780 ## parquet/src/util/bit_util.rs: ## @@ -17,76 +17,104 @@ use std::{cmp, mem::size_of}; -use crate::data_type::AsBytes; +use crate::data_type::{AsBytes, ByteArray

[GitHub] [arrow] thisisnic merged pull request #33748: GH-33746: [R] Update NEWS.md for 11.0.0

2023-01-20 Thread GitBox
thisisnic merged PR #33748: URL: https://github.com/apache/arrow/pull/33748 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apa

[GitHub] [arrow] westonpace commented on issue #33699: [CI][C++] Nightly tests for valgrind have been failing for the last

2023-01-20 Thread GitBox
westonpace commented on issue #33699: URL: https://github.com/apache/arrow/issues/33699#issuecomment-1398508810 Alternatively, we could try reducing the runtime of these tests when valgrind is enabled. `parquet-arrow-test` for example tries many different type variations (8 different combi

[GitHub] [arrow-datafusion] xudong963 commented on a diff in pull request #5002: Bump sqllogictest to v0.11.1

2023-01-20 Thread GitBox
xudong963 commented on code in PR #5002: URL: https://github.com/apache/arrow-datafusion/pull/5002#discussion_r1082666973 ## datafusion/core/tests/sqllogictests/src/main.rs: ## @@ -109,7 +109,7 @@ pub async fn main() -> Result<()> { info!("Using complete mode to com

[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #5002: Bump sqllogictest to v0.11.1

2023-01-20 Thread GitBox
alamb commented on code in PR #5002: URL: https://github.com/apache/arrow-datafusion/pull/5002#discussion_r1082665326 ## datafusion/core/tests/sqllogictests/src/main.rs: ## @@ -109,7 +109,7 @@ pub async fn main() -> Result<()> { info!("Using complete mode to complet

[GitHub] [arrow-datafusion] alamb closed pull request #4922: Update sqllogictest requirement from 0.10.0 to 0.11.1

2023-01-20 Thread GitBox
alamb closed pull request #4922: Update sqllogictest requirement from 0.10.0 to 0.11.1 URL: https://github.com/apache/arrow-datafusion/pull/4922 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [arrow-datafusion] dependabot[bot] commented on pull request #4922: Update sqllogictest requirement from 0.10.0 to 0.11.1

2023-01-20 Thread GitBox
dependabot[bot] commented on PR #4922: URL: https://github.com/apache/arrow-datafusion/pull/4922#issuecomment-1398506919 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor ve

[GitHub] [arrow-datafusion] alamb commented on pull request #4922: Update sqllogictest requirement from 0.10.0 to 0.11.1

2023-01-20 Thread GitBox
alamb commented on PR #4922: URL: https://github.com/apache/arrow-datafusion/pull/4922#issuecomment-1398506861 Dupe of https://github.com/apache/arrow-datafusion/pull/4922 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[GitHub] [arrow-datafusion] alamb commented on pull request #4960: Update pyo3 requirement from 0.17.1 to 0.18.0

2023-01-20 Thread GitBox
alamb commented on PR #4960: URL: https://github.com/apache/arrow-datafusion/pull/4960#issuecomment-1398505810 This needs to wait for arrow to update pyo3, which conveniently @viirya did in https://github.com/apache/arrow-rs/pull/3557 -- This is an automated message from the Apache Git S

[GitHub] [arrow-datafusion] xudong963 merged pull request #4984: minor: Update data type support documentation

2023-01-20 Thread GitBox
xudong963 merged PR #4984: URL: https://github.com/apache/arrow-datafusion/pull/4984 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@

[GitHub] [arrow] westonpace commented on issue #33699: [CI][C++] Nightly tests for valgrind have been failing for the last

2023-01-20 Thread GitBox
westonpace commented on issue #33699: URL: https://github.com/apache/arrow/issues/33699#issuecomment-1398505553 I tried looking into this a bit more today. I ran the `parquet-reader-test` on master, on the same commit that last passed (df4cb9588) and on a really old commit (54ff2d817ea

[GitHub] [arrow-datafusion] alamb commented on pull request #4922: Update sqllogictest requirement from 0.10.0 to 0.11.1

2023-01-20 Thread GitBox
alamb commented on PR #4922: URL: https://github.com/apache/arrow-datafusion/pull/4922#issuecomment-1398501978 Pushed 48e3681 for updated API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [arrow-datafusion-python] andygrove commented on issue #144: Change default branch name from master to main

2023-01-20 Thread GitBox
andygrove commented on issue #144: URL: https://github.com/apache/arrow-datafusion-python/issues/144#issuecomment-1398500876 INFRA issue: https://issues.apache.org/jira/browse/INFRA-24106 -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [arrow-rs] bmmeijers commented on a diff in pull request #3578: Use native types in PageIndex (#3575)

2023-01-20 Thread GitBox
bmmeijers commented on code in PR #3578: URL: https://github.com/apache/arrow-rs/pull/3578#discussion_r1082651910 ## parquet/src/bin/parquet-index.rs: ## @@ -132,7 +132,7 @@ fn compute_row_counts(offset_index: &[PageLocation], rows: i64) -> Vec { } /// Prints index informat

[GitHub] [arrow-datafusion] xudong963 opened a new pull request, #5002: Bump sqllogictest to v0.11.1

2023-01-20 Thread GitBox
xudong963 opened a new pull request, #5002: URL: https://github.com/apache/arrow-datafusion/pull/5002 # Which issue does this PR close? Closes #. # Rationale for this change # What changes are included in this PR? # Are these changes tested?

[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #4995: [Feature] support describe file

2023-01-20 Thread GitBox
alamb commented on code in PR #4995: URL: https://github.com/apache/arrow-datafusion/pull/4995#discussion_r1082633781 ## datafusion/core/src/datasource/listing/table.rs: ## @@ -67,6 +67,10 @@ pub struct ListingTableConfig { pub file_schema: Option, /// Optional `Listin

[GitHub] [arrow-datafusion-python] jdye64 commented on pull request #145: Substrait bindings

2023-01-20 Thread GitBox
jdye64 commented on PR #145: URL: https://github.com/apache/arrow-datafusion-python/pull/145#issuecomment-1398497972 Hey @andygrove thanks! However, something is broken with the Github actions setup. While this PR showed all the CI passing that was actually a red herring. Only a single RAT

[GitHub] [arrow] rtpsw commented on pull request #33676: GH-33673: [C++] Standardize as-of-join convention for past and future tolerance

2023-01-20 Thread GitBox
rtpsw commented on PR #33676: URL: https://github.com/apache/arrow/pull/33676#issuecomment-1398491977 Ping @westonpace - it would be great if this can be reviewed quickly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [arrow-datafusion] ozankabak commented on a diff in pull request #4989: Add support for linear range calculation in WINDOW functions

2023-01-20 Thread GitBox
ozankabak commented on code in PR #4989: URL: https://github.com/apache/arrow-datafusion/pull/4989#discussion_r1082640117 ## datafusion/common/src/utils.rs: ## @@ -103,6 +111,53 @@ where Ok(low) } +/// This function searches for a tuple of given values (`target`) among t

[GitHub] [arrow-rs] Sach1nAgarwal commented on pull request #3576: Propagate EOF Error from AsyncRead

2023-01-20 Thread GitBox
Sach1nAgarwal commented on PR #3576: URL: https://github.com/apache/arrow-rs/pull/3576#issuecomment-1398490172 I will try to write a test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[GitHub] [arrow-ballista] thinkharderdev commented on pull request #560: Cluster state refactor part 1

2023-01-20 Thread GitBox
thinkharderdev commented on PR #560: URL: https://github.com/apache/arrow-ballista/pull/560#issuecomment-1398487737 I'll plan on merging this tomorrow morning -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[GitHub] [arrow-adbc] lidavidm commented on pull request #356: feat(go/adbc/driver/pkg/cmake): cmake build for Go shared library drivers

2023-01-20 Thread GitBox
lidavidm commented on PR #356: URL: https://github.com/apache/arrow-adbc/pull/356#issuecomment-1398487632 Something about the Go build in the sdist is flaky, when it tries to remove the generated header. Maybe instead of removing it, we just add a .gitignore and move on? -- This is an au

[GitHub] [arrow] ursabot commented on pull request #15223: GH-15203: [Java] Implement writing compressed files

2023-01-20 Thread GitBox
ursabot commented on PR #15223: URL: https://github.com/apache/arrow/pull/15223#issuecomment-1398486539 ['Python', 'R'] benchmarks have high level of regressions. [test-mac-arm](https://conbench.ursa.dev/compare/runs/200a70d5895c419f9ee6659640af67d5...ad7d2fade4df48c7b3718a3d97031fd1/)

[GitHub] [arrow-rs] ursabot commented on pull request #3576: Propagate EOF Error from AsyncRead

2023-01-20 Thread GitBox
ursabot commented on PR #3576: URL: https://github.com/apache/arrow-rs/pull/3576#issuecomment-1398486113 Benchmark runs are scheduled for baseline = a61da1e655e76e8676f1cdb021b13551e720b0de and contender = a1cedb4fdfb561eda4e836a6c8fcb898d7a37029. a1cedb4fdfb561eda4e836a6c8fcb898d7a37029 i

[GitHub] [arrow-datafusion] ursabot commented on pull request #5001: Minor: Document how to create `ListingTables`

2023-01-20 Thread GitBox
ursabot commented on PR #5001: URL: https://github.com/apache/arrow-datafusion/pull/5001#issuecomment-1398486164 Benchmark runs are scheduled for baseline = e566bfc4af0ffb53717a784ab423d407473b62a0 and contender = 6d770ad0d747e9e87752888ddd3dd69d6765. 6d770ad0d747e9e87752888ddd3dd

[GitHub] [arrow-datafusion] ursabot commented on pull request #5000: Allow overriding error type in DataFusion Result

2023-01-20 Thread GitBox
ursabot commented on PR #5000: URL: https://github.com/apache/arrow-datafusion/pull/5000#issuecomment-1398486195 Benchmark runs are scheduled for baseline = 6d770ad0d747e9e87752888ddd3dd69d6765 and contender = 5dd5ffd5ea84d843b9ef34d0eaa9ac992618f6e2. 5dd5ffd5ea84d843b9ef34d0eaa9ac992

[GitHub] [arrow-datafusion] ursabot commented on pull request #4944: Only add outer filter once when transforming exists/in subquery to join

2023-01-20 Thread GitBox
ursabot commented on PR #4944: URL: https://github.com/apache/arrow-datafusion/pull/4944#issuecomment-1398486136 Benchmark runs are scheduled for baseline = 22d106a6564345a746699cd5eb1fc84b9267ce83 and contender = e566bfc4af0ffb53717a784ab423d407473b62a0. e566bfc4af0ffb53717a784ab423d4074

[GitHub] [arrow] ursabot commented on pull request #15223: GH-15203: [Java] Implement writing compressed files

2023-01-20 Thread GitBox
ursabot commented on PR #15223: URL: https://github.com/apache/arrow/pull/15223#issuecomment-1398486089 Benchmark runs are scheduled for baseline = e4019add4189a9abe25f8ff6f12099ed19921104 and contender = 4c698fb3c2a2b4ee046c6ad6e992e81ed90c7b0e. 4c698fb3c2a2b4ee046c6ad6e992e81ed90c7b0e is

[GitHub] [arrow-datafusion] tustvold commented on a diff in pull request #4999: Add dictionary_expresions feature (#4386)

2023-01-20 Thread GitBox
tustvold commented on code in PR #4999: URL: https://github.com/apache/arrow-datafusion/pull/4999#discussion_r1082628665 ## datafusion/physical-expr/Cargo.toml: ## @@ -35,12 +35,15 @@ path = "src/lib.rs" [features] crypto_expressions = ["md-5", "sha2", "blake2", "blake3"] def

[GitHub] [arrow-datafusion] tustvold commented on a diff in pull request #4999: Add dictionary_expresions feature (#4386)

2023-01-20 Thread GitBox
tustvold commented on code in PR #4999: URL: https://github.com/apache/arrow-datafusion/pull/4999#discussion_r1082628665 ## datafusion/physical-expr/Cargo.toml: ## @@ -35,12 +35,15 @@ path = "src/lib.rs" [features] crypto_expressions = ["md-5", "sha2", "blake2", "blake3"] def

[GitHub] [arrow-datafusion] xudong963 merged pull request #5000: Allow overriding error type in DataFusion Result

2023-01-20 Thread GitBox
xudong963 merged PR #5000: URL: https://github.com/apache/arrow-datafusion/pull/5000 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@

[GitHub] [arrow-datafusion] xudong963 commented on a diff in pull request #5000: Allow overriding error type in DataFusion Result

2023-01-20 Thread GitBox
xudong963 commented on code in PR #5000: URL: https://github.com/apache/arrow-datafusion/pull/5000#discussion_r1082629158 ## datafusion/common/src/error.rs: ## @@ -34,7 +34,7 @@ use parquet::errors::ParquetError; use sqlparser::parser::ParserError; /// Result type for operat

[GitHub] [arrow-datafusion] tustvold commented on a diff in pull request #4999: Add dictionary_expresions feature (#4386)

2023-01-20 Thread GitBox
tustvold commented on code in PR #4999: URL: https://github.com/apache/arrow-datafusion/pull/4999#discussion_r1082628665 ## datafusion/physical-expr/Cargo.toml: ## @@ -35,12 +35,15 @@ path = "src/lib.rs" [features] crypto_expressions = ["md-5", "sha2", "blake2", "blake3"] def

[GitHub] [arrow-datafusion-python] andygrove closed issue #132: Add Python bindings for substrait module

2023-01-20 Thread GitBox
andygrove closed issue #132: Add Python bindings for substrait module URL: https://github.com/apache/arrow-datafusion-python/issues/132 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[GitHub] [arrow-datafusion-python] andygrove merged pull request #145: Substrait bindings

2023-01-20 Thread GitBox
andygrove merged PR #145: URL: https://github.com/apache/arrow-datafusion-python/pull/145 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubsc

[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #4999: Add dictionary_expresions feature (#4386)

2023-01-20 Thread GitBox
alamb commented on code in PR #4999: URL: https://github.com/apache/arrow-datafusion/pull/4999#discussion_r1082625326 ## datafusion/physical-expr/Cargo.toml: ## @@ -35,12 +35,15 @@ path = "src/lib.rs" [features] crypto_expressions = ["md-5", "sha2", "blake2", "blake3"] defaul

[GitHub] [arrow-datafusion] xudong963 merged pull request #5001: Minor: Document how to create `ListingTables`

2023-01-20 Thread GitBox
xudong963 merged PR #5001: URL: https://github.com/apache/arrow-datafusion/pull/5001 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@

[GitHub] [arrow-rs] tustvold merged pull request #3576: Parquet:: Correct error return

2023-01-20 Thread GitBox
tustvold merged PR #3576: URL: https://github.com/apache/arrow-rs/pull/3576 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apa

[GitHub] [arrow-rs] tustvold commented on pull request #3576: Parquet:: Correct error return

2023-01-20 Thread GitBox
tustvold commented on PR #3576: URL: https://github.com/apache/arrow-rs/pull/3576#issuecomment-1398478773 I more meant that perhaps we should write a unit test for this, to ensure we don't accidentally break it in future. I'll see what I can come up with. Thank you for finding and fixing th

[GitHub] [arrow-datafusion] alamb commented on pull request #4944: Only add outer filter once when transforming exists/in subquery to join

2023-01-20 Thread GitBox
alamb commented on PR #4944: URL: https://github.com/apache/arrow-datafusion/pull/4944#issuecomment-1398477716 Thanks @avantgardnerio and @ygf11 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [arrow-datafusion] alamb closed issue #4914: The filter of outer table happens multiple time after optimizing in-subquery to join

2023-01-20 Thread GitBox
alamb closed issue #4914: The filter of outer table happens multiple time after optimizing in-subquery to join URL: https://github.com/apache/arrow-datafusion/issues/4914 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[GitHub] [arrow-datafusion] alamb merged pull request #4944: Only add outer filter once when transforming exists/in subquery to join

2023-01-20 Thread GitBox
alamb merged PR #4944: URL: https://github.com/apache/arrow-datafusion/pull/4944 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arro

[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #4834: (#4462) Postgres compatibility tests using sqllogictest

2023-01-20 Thread GitBox
alamb commented on code in PR #4834: URL: https://github.com/apache/arrow-datafusion/pull/4834#discussion_r1082610209 ## datafusion/core/tests/sqllogictests/src/engines/datafusion/normalize.rs: ## @@ -0,0 +1,153 @@ +// Licensed to the Apache Software Foundation (ASF) under one +

[GitHub] [arrow-rs] tustvold commented on a diff in pull request #3578: Use native types in PageIndex (#3575)

2023-01-20 Thread GitBox
tustvold commented on code in PR #3578: URL: https://github.com/apache/arrow-rs/pull/3578#discussion_r1082605700 ## parquet/src/bin/parquet-index.rs: ## @@ -132,7 +132,7 @@ fn compute_row_counts(offset_index: &[PageLocation], rows: i64) -> Vec { } /// Prints index informati

[GitHub] [arrow-adbc] lidavidm commented on pull request #364: ci: download arch-specific golang

2023-01-20 Thread GitBox
lidavidm commented on PR #364: URL: https://github.com/apache/arrow-adbc/pull/364#issuecomment-1398474029 Oh wait I see now. Hmm, how to handle this... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [arrow-ballista] thinkharderdev commented on pull request #560: Cluster state refactor part 1

2023-01-20 Thread GitBox
thinkharderdev commented on PR #560: URL: https://github.com/apache/arrow-ballista/pull/560#issuecomment-1398473523 > I'm not as familiar with the overall Ballista architecture as I'd like to be, but this PR still makes a lot of sense. > > I _love_ seeing this stuff come out of the `e

[GitHub] [arrow-adbc] lidavidm commented on pull request #364: ci: download arch-specific golang

2023-01-20 Thread GitBox
lidavidm commented on PR #364: URL: https://github.com/apache/arrow-adbc/pull/364#issuecomment-1398473525 H, the docker in CI doesn't seem to want to use the ARCH parameter. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [arrow-rs] Sach1nAgarwal commented on pull request #3576: Parquet:: Correct error return

2023-01-20 Thread GitBox
Sach1nAgarwal commented on PR #3576: URL: https://github.com/apache/arrow-rs/pull/3576#issuecomment-1398472653 If I am sending wrong parquet file this function is not returning error, and its getting crashed while decoding -- This is an automated message from the Apache Git Service. To re

[GitHub] [arrow-ballista] thinkharderdev commented on a diff in pull request #560: Cluster state refactor part 1

2023-01-20 Thread GitBox
thinkharderdev commented on code in PR #560: URL: https://github.com/apache/arrow-ballista/pull/560#discussion_r1082613818 ## ballista/core/src/serde/generated/ballista.rs: ## @@ -1985,7 +1985,7 @@ pub mod executor_grpc_client { pub mod scheduler_grpc_server { #![allow(unu

[GitHub] [arrow-datafusion] mustafasrepo commented on a diff in pull request #4989: Add support for linear range calculation in WINDOW functions

2023-01-20 Thread GitBox
mustafasrepo commented on code in PR #4989: URL: https://github.com/apache/arrow-datafusion/pull/4989#discussion_r1082607725 ## datafusion/common/src/utils.rs: ## @@ -103,6 +111,53 @@ where Ok(low) } +/// This function searches for a tuple of given values (`target`) amon

[GitHub] [arrow-datafusion] mustafasrepo commented on a diff in pull request #4989: Add support for linear range calculation in WINDOW functions

2023-01-20 Thread GitBox
mustafasrepo commented on code in PR #4989: URL: https://github.com/apache/arrow-datafusion/pull/4989#discussion_r1082607725 ## datafusion/common/src/utils.rs: ## @@ -103,6 +111,53 @@ where Ok(low) } +/// This function searches for a tuple of given values (`target`) amon

[GitHub] [arrow] js8544 commented on pull request #33806: GH-33723: [C++] re2::RE2::RE2() result must be checked

2023-01-20 Thread GitBox
js8544 commented on PR #33806: URL: https://github.com/apache/arrow/pull/33806#issuecomment-1398468161 cc @kou -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscri

[GitHub] [arrow] js8544 commented on a diff in pull request #33806: GH-33723: [C++] re2::RE2::RE2() result must be checked

2023-01-20 Thread GitBox
js8544 commented on code in PR #33806: URL: https://github.com/apache/arrow/pull/33806#discussion_r1082609589 ## cpp/src/arrow/compute/kernels/scalar_string_ascii.cc: ## @@ -1505,6 +1508,13 @@ struct MatchLike { static const RE2 kLikePatternIsStartsWith(R"(([^%_]*[^\\%_])?%

[GitHub] [arrow-datafusion] mustafasrepo commented on a diff in pull request #4989: Add support for linear range calculation in WINDOW functions

2023-01-20 Thread GitBox
mustafasrepo commented on code in PR #4989: URL: https://github.com/apache/arrow-datafusion/pull/4989#discussion_r1082607725 ## datafusion/common/src/utils.rs: ## @@ -103,6 +111,53 @@ where Ok(low) } +/// This function searches for a tuple of given values (`target`) amon

[GitHub] [arrow-rs] tustvold opened a new pull request, #3578: Use native types in PageIndex (#3575)

2023-01-20 Thread GitBox
tustvold opened a new pull request, #3578: URL: https://github.com/apache/arrow-rs/pull/3578 # Which issue does this PR close? Closes #3575 Relates to #3577 # Rationale for this change See tickets # What changes are included in this PR?

[GitHub] [arrow] paleolimbot commented on issue #33721: [R][CI] MacOS install from local job is failing

2023-01-20 Thread GitBox
paleolimbot commented on issue #33721: URL: https://github.com/apache/arrow/issues/33721#issuecomment-1398461365 Still failing (although it got much farther this time through): https://github.com/ursacomputing/crossbow/actions/runs/3963610605/jobs/6791635742#step:7:1598 -- This is an auto

[GitHub] [arrow] raulcd commented on pull request #33791: GH-33782: [Release] Vote email number of issues is querying JIRA and producing a wrong number

2023-01-20 Thread GitBox
raulcd commented on PR #33791: URL: https://github.com/apache/arrow/pull/33791#issuecomment-1398456679 It seems we have to modify the test to match the new URL: https://github.com/apache/arrow/blob/master/dev/release/02-source-test.rb#L152 -- This is an automated message from the Apache G

[GitHub] [arrow] github-actions[bot] commented on pull request #33806: GH-33723: [C++] re2::RE2::RE2() result must be checked

2023-01-20 Thread GitBox
github-actions[bot] commented on PR #33806: URL: https://github.com/apache/arrow/pull/33806#issuecomment-1398454575 * Closes: #33723 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[GitHub] [arrow] js8544 opened a new pull request, #33806: GH-33723: [C++] re2::RE2::RE2() result must be checked

2023-01-20 Thread GitBox
js8544 opened a new pull request, #33806: URL: https://github.com/apache/arrow/pull/33806 ### Rationale for this change RE2 construction needs to be checked. ### What changes are included in this PR? Check all RE2 object status. ### Are thes

[GitHub] [arrow] github-actions[bot] commented on pull request #14596: ARROW-18258: [Docker] Substrait Integration Testing

2023-01-20 Thread GitBox
github-actions[bot] commented on PR #14596: URL: https://github.com/apache/arrow/pull/14596#issuecomment-1398447848 Revision: 1dd67bcf878afaa8abc3c3de4aad0d2f9fa0c244 Submitted crossbow builds: [ursacomputing/crossbow @ actions-46f7ecb174](https://github.com/ursacomputing/crossbow/bra

[GitHub] [arrow] vibhatha commented on pull request #14596: ARROW-18258: [Docker] Substrait Integration Testing

2023-01-20 Thread GitBox
vibhatha commented on PR #14596: URL: https://github.com/apache/arrow/pull/14596#issuecomment-139813 @github-actions crossbow submit test-conda-python-3.9-substrait -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

[GitHub] [arrow] paleolimbot commented on issue #33701: [R] Link-time optimization reports violations of one-definition rule in the R package

2023-01-20 Thread GitBox
paleolimbot commented on issue #33701: URL: https://github.com/apache/arrow/issues/33701#issuecomment-1398444291 Adding those patches to #33722 I get test segfaults: https://github.com/apache/arrow/actions/runs/3961611391/jobs/6787262761#step:6:13839 Unless somebody who actually knows

[GitHub] [arrow] felipecrv commented on pull request #15083: GH-33566: [C++] Add support for nullary and n-ary aggregate functions

2023-01-20 Thread GitBox
felipecrv commented on PR #15083: URL: https://github.com/apache/arrow/pull/15083#issuecomment-1398443771 > Some of these failing CI checks are a segmentation fault in the group_by method so I think they are relevant: https://github.com/apache/arrow/actions/runs/3944389169/jobs/6750236015

[GitHub] [arrow-datafusion] alamb commented on pull request #4972: Simplify GroupByHash implementation (to prepare for more work)

2023-01-20 Thread GitBox
alamb commented on PR #4972: URL: https://github.com/apache/arrow-datafusion/pull/4972#issuecomment-1398440863 I plan to merge this tomorrow unless anyone would like more time to review or comment cc @tustvold @Dandandan @crepererum -- This is an automated message from the Apac

[GitHub] [arrow] felipecrv commented on a diff in pull request #15083: GH-33566: [C++] Add support for nullary and n-ary aggregate functions

2023-01-20 Thread GitBox
felipecrv commented on code in PR #15083: URL: https://github.com/apache/arrow/pull/15083#discussion_r1082577383 ## python/pyarrow/table.pxi: ## @@ -5358,36 +5358,45 @@ list[tuple(str, str, FunctionOptions)] values_sum: [[3,7,5]] keys: [["a","b","

[GitHub] [arrow] felipecrv commented on a diff in pull request #15083: GH-33566: [C++] Add support for nullary and n-ary aggregate functions

2023-01-20 Thread GitBox
felipecrv commented on code in PR #15083: URL: https://github.com/apache/arrow/pull/15083#discussion_r1082576559 ## python/pyarrow/table.pxi: ## @@ -5358,36 +5358,45 @@ list[tuple(str, str, FunctionOptions)] values_sum: [[3,7,5]] keys: [["a","b","

[GitHub] [arrow-rs] tustvold commented on a diff in pull request #3574: Add external variant to ParquetError (#3285)

2023-01-20 Thread GitBox
tustvold commented on code in PR #3574: URL: https://github.com/apache/arrow-rs/pull/3574#discussion_r1082574357 ## parquet/src/errors.rs: ## @@ -17,12 +17,13 @@ //! Common Parquet errors and macros. +use std::error::Error; use std::{cell, io, result, str}; #[cfg(featur

[GitHub] [arrow-rs] alamb commented on a diff in pull request #3574: Add external variant to ParquetError (#3285)

2023-01-20 Thread GitBox
alamb commented on code in PR #3574: URL: https://github.com/apache/arrow-rs/pull/3574#discussion_r1082566616 ## parquet/src/column/mod.rs: ## @@ -36,18 +36,18 @@ //! repetition levels and read them to verify write/read correctness. //! //! ```rust,no_run -//! use std::{fs, p

[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #4989: Add support for linear range calculation in WINDOW functions

2023-01-20 Thread GitBox
alamb commented on code in PR #4989: URL: https://github.com/apache/arrow-datafusion/pull/4989#discussion_r1082548503 ## datafusion/common/src/utils.rs: ## @@ -22,8 +22,16 @@ use arrow::array::ArrayRef; use arrow::compute::SortOptions; use std::cmp::Ordering; +/// Given colu

[GitHub] [arrow] aayushpandey014 commented on issue #33797: [C++] Add decimal version of Round benchmarks

2023-01-20 Thread GitBox
aayushpandey014 commented on issue #33797: URL: https://github.com/apache/arrow/issues/33797#issuecomment-1398424760 Hey. I want to contribute in this repository please assign it to me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

<    1   2   3   4   5   >