fgenoese commented on issue #29844:
URL: https://github.com/apache/arrow/issues/29844#issuecomment-1465114620
This issue seems to be connected:
https://github.com/streamlit/streamlit/issues/1002#issuecomment-916885614
Basically, when loading a geojson with geopandas the shape fails
dinimar commented on PR #34537:
URL: https://github.com/apache/arrow/pull/34537#issuecomment-1465107553
cc @rok @pitrou @benibus
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific com
codecov-commenter commented on PR #395:
URL: https://github.com/apache/arrow-julia/pull/395#issuecomment-1465099481
##
[Codecov](https://codecov.io/gh/apache/arrow-julia/pull/395?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apac
yukkit opened a new pull request, #5559:
URL: https://github.com/apache/arrow-datafusion/pull/5559
# Which issue does this PR close?
Closes #5361 .
# Rationale for this change
# What changes are included in this PR?
# Are these changes teste
comphead commented on code in PR #:
URL: https://github.com/apache/arrow-datafusion/pull/#discussion_r1133172510
##
datafusion/core/tests/sql/expr.rs:
##
@@ -1313,6 +1313,23 @@ async fn test_extract_date_part() -> Result<()> {
Ok(())
}
+#[tokio::test]
+async fn t
viirya commented on PR #3846:
URL: https://github.com/apache/arrow-rs/pull/3846#issuecomment-1465067951
https://github.com/apache/arrow-rs/blob/9ce0ebb06550be943febc226f61bf083016d7652/parquet/src/format.rs#L453
--
This is an automated message from the Apache Git Service.
To respond to th
baumgold commented on issue #393:
URL: https://github.com/apache/arrow-julia/issues/393#issuecomment-1465065885
I’m certainly interested! Thanks for this hard work, @svilupp !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
Weijun-H opened a new pull request, #3846:
URL: https://github.com/apache/arrow-rs/pull/3846
# Which issue does this PR close?
Closes #3844
# Rationale for this change
# What changes are included in this PR?
# Are there any user-facing chan
Jefffrey opened a new issue, #5558:
URL: https://github.com/apache/arrow-datafusion/issues/5558
**Describe the bug**
If calling `describe(...)` on a dataframe without a numeric type method then
it returns an error.
**To Reproduce**
```rust
ctx.sql("select
Jefffrey opened a new issue, #5557:
URL: https://github.com/apache/arrow-datafusion/issues/5557
**Describe the bug**
If trying to get median on empty input/dataframe a confusing error is
returned
**To Reproduce**
```sql
DataFusion CLI v20.0.0
❯ select media
Jefffrey commented on PR #5556:
URL:
https://github.com/apache/arrow-datafusion/pull/5556#issuecomment-1465044015
cc @jiangzhx
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comme
ianmcook commented on issue #33958:
URL: https://github.com/apache/arrow/issues/33958#issuecomment-1465043962
Duplicate of 14752
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comme
Jefffrey opened a new pull request, #5556:
URL: https://github.com/apache/arrow-datafusion/pull/5556
# Which issue does this PR close?
Closes #.
# Rationale for this change
Revert workaround applied by
https://github.com/apache/arrow-datafusion/pull/5468
jychen7 commented on issue #5547:
URL:
https://github.com/apache/arrow-datafusion/issues/5547#issuecomment-1465043866
I am not sure how it may inspire Datafusion yet, just for reference, there
are two improvements in DuckDB about parallelize `distinct`
- without groupby, https://github.c
ianmcook commented on issue #33958:
URL: https://github.com/apache/arrow/issues/33958#issuecomment-1465043799
Duplicate of #4752
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comme
ianmcook commented on issue #33958:
URL: https://github.com/apache/arrow/issues/33958#issuecomment-1465043586
Closed as dup of #4752
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
Weijun-H opened a new pull request, #:
URL: https://github.com/apache/arrow-datafusion/pull/
# Which issue does this PR close?
Closes #2785
# Rationale for this change
Explain #2785
# What changes are included in this PR?
Add `EXTRACT( EPOCH
ozankabak commented on PR #5290:
URL:
https://github.com/apache/arrow-datafusion/pull/5290#issuecomment-1465039603
@mingmwang, it seems you are busy these days. I think it might be a good
idea to create a PR to get the new/extended test suite and a base (passing)
implementation in.
jaylmiller commented on issue #258:
URL:
https://github.com/apache/arrow-datafusion/issues/258#issuecomment-1465038530
I've made a little PR for this. But I'm not sure about how to go about
measuring the performance improvements... @alamb do you know of any existing
benches in the codebase
rok commented on issue #34536:
URL: https://github.com/apache/arrow/issues/34536#issuecomment-1465035138
Benchmarking with overridden defaults makes a lot of sense yes! Do you think
different bitwidth ranges (of random data) have different optimal results? If
they have strong influence we m
jaylmiller opened a new pull request, #5554:
URL: https://github.com/apache/arrow-datafusion/pull/5554
# Which issue does this PR close?
Closes #258.
# Rationale for this change
The count distinct physical expr was doing alot of unnecessary hashing when
it is ran on dictionary t
ianmcook commented on issue #34255:
URL: https://github.com/apache/arrow/issues/34255#issuecomment-1465028475
https://arrow.apache.org/community/#meetings
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
svilupp commented on issue #393:
URL: https://github.com/apache/arrow-julia/issues/393#issuecomment-1465018021
I’ve already implemented most of the changes locally. I’ll post some
benchmarks and learnings here tomorrow, and open the relevant PRs, if there is
interest.
--
This is an autom
lidavidm commented on PR #28:
URL:
https://github.com/apache/arrow-flight-sql-postgresql/pull/28#issuecomment-1465017593
Ah, thanks for the clarification. That's even better!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
kou commented on PR #28:
URL:
https://github.com/apache/arrow-flight-sql-postgresql/pull/28#issuecomment-1465001257
I reconsidered `COPY`.
We may not need to use `COPY` because we don't use the PostgreSQL's wire
protocol. We use SPI (Server Programming Interface,
https://www.postgre
dependabot[bot] opened a new pull request, #267:
URL: https://github.com/apache/arrow-datafusion-python/pull/267
Bumps [futures](https://github.com/rust-lang/futures-rs) from 0.3.26 to
0.3.27.
Release notes
Sourced from https://github.com/rust-lang/futures-rs/releases";>futures's
comphead commented on code in PR #5542:
URL: https://github.com/apache/arrow-datafusion/pull/5542#discussion_r1133137618
##
datafusion/optimizer/src/simplify_expressions/expr_simplifier.rs:
##
@@ -390,6 +390,22 @@ impl<'a, S: SimplifyInfo> ExprRewriter for Simplifier<'a,
S> {
dinimar commented on issue #33957:
URL: https://github.com/apache/arrow/issues/33957#issuecomment-1464991495
@pitrou I'm new at benchmarks in this project. Could you please explain
which file should be changed and provide some examples of benchmarks?
--
This is an automated message from t
ursabot commented on PR #5485:
URL:
https://github.com/apache/arrow-datafusion/pull/5485#issuecomment-1464976198
Benchmark runs are scheduled for baseline =
c5ae3e80cde3ba4b70f6e2698652b87bd2302e81 and contender =
ecbc843a1a8c38b2466748bc92a6e22ce08d51ed.
ecbc843a1a8c38b2466748bc92a6e22ce
alamb commented on code in PR #5485:
URL: https://github.com/apache/arrow-datafusion/pull/5485#discussion_r1133130150
##
datafusion/core/tests/sql/aggregates.rs:
##
@@ -99,11 +99,11 @@ async fn aggregate_timestamps_count() -> Result<()> {
.await;
let expected = vec![
alamb closed issue #5444: Expr.alias function not work with count aggregation
URL: https://github.com/apache/arrow-datafusion/issues/5444
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
alamb merged PR #5485:
URL: https://github.com/apache/arrow-datafusion/pull/5485
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arro
ursabot commented on PR #5552:
URL:
https://github.com/apache/arrow-datafusion/pull/5552#issuecomment-1464970160
Benchmark runs are scheduled for baseline =
dd98aabdaebcfc30ec4c370be93f6663de50e02f and contender =
c5ae3e80cde3ba4b70f6e2698652b87bd2302e81.
c5ae3e80cde3ba4b70f6e2698652b87bd
alamb commented on PR #5536:
URL:
https://github.com/apache/arrow-datafusion/pull/5536#issuecomment-1464967666
It appears that using parquet-test-utils was masking a breakage in the
feature flag for regular expressions. I fixed it in
https://github.com/apache/arrow-datafusion/pull/5536/co
alamb merged PR #5552:
URL: https://github.com/apache/arrow-datafusion/pull/5552
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arro
mapleFU commented on issue #34510:
URL: https://github.com/apache/arrow/issues/34510#issuecomment-1464950991
Learned a lot, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
quinnj merged PR #394:
URL: https://github.com/apache/arrow-julia/pull/394
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apac
quinnj commented on issue #391:
URL: https://github.com/apache/arrow-julia/issues/391#issuecomment-1464949249
H.I do see the issue on 1.9-rc1, but not on a recent julia#master
(as of 4 days ago).
--
This is an automated message from the Apache Git Service.
To respond to the messag
codecov-commenter commented on PR #394:
URL: https://github.com/apache/arrow-julia/pull/394#issuecomment-1464949140
##
[Codecov](https://codecov.io/gh/apache/arrow-julia/pull/394?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apac
tustvold commented on PR #3835:
URL: https://github.com/apache/arrow-rs/pull/3835#issuecomment-1464948773
FYI added timezone support in https://github.com/apache/arrow-rs/pull/3845
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitH
tustvold commented on code in PR #3845:
URL: https://github.com/apache/arrow-rs/pull/3845#discussion_r1133117710
##
arrow-array/src/types.rs:
##
@@ -287,30 +287,28 @@ impl ArrowTemporalType for DurationMicrosecondType {}
impl ArrowTemporalType for DurationNanosecondType {}
/
tustvold opened a new pull request, #3845:
URL: https://github.com/apache/arrow-rs/pull/3845
# Which issue does this PR close?
Closes #.
# Rationale for this change
# What changes are included in this PR?
# Are there any user-facing changes
ericphanson commented on issue #393:
URL: https://github.com/apache/arrow-julia/issues/393#issuecomment-1464942972
Oops, misclick
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comm
quinnj commented on issue #393:
URL: https://github.com/apache/arrow-julia/issues/393#issuecomment-1464942431
Wow! Thanks for the detailed research/investigation/writeup @svilupp! I
think most of what you mentioned all sounds like things we should indeed do.
I'm currently bogged down in a f
alamb commented on PR #3839:
URL: https://github.com/apache/arrow-rs/pull/3839#issuecomment-1464923448
> I would like to understand the use-case more before merging this,
I wonder if it is something like flushing the cache, or being able to take
some different action if the item i
ursabot commented on PR #5553:
URL:
https://github.com/apache/arrow-datafusion/pull/5553#issuecomment-1464920466
Benchmark runs are scheduled for baseline =
aaa4e1496ba89daa03de47dc1feed7d7e57f62a8 and contender =
dd98aabdaebcfc30ec4c370be93f6663de50e02f.
dd98aabdaebcfc30ec4c370be93f6663d
jackwener merged PR #5553:
URL: https://github.com/apache/arrow-datafusion/pull/5553
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@
jackwener commented on code in PR #5553:
URL: https://github.com/apache/arrow-datafusion/pull/5553#discussion_r1133088625
##
datafusion/core/tests/sqllogictests/README.md:
##
@@ -19,25 +19,41 @@
Overview
-This is the Datafusion implementation of
[sqllogictest](https:/
tustvold commented on code in PR #3802:
URL: https://github.com/apache/arrow-rs/pull/3802#discussion_r1133079167
##
object_store/src/aws/credential.rs:
##
@@ -84,7 +84,7 @@ const AUTH_HEADER: &str = "authorization";
const ALL_HEADERS: &[&str; 4] = &[DATE_HEADER, HASH_HEADER, TO
tustvold commented on code in PR #3802:
URL: https://github.com/apache/arrow-rs/pull/3802#discussion_r1133078969
##
object_store/src/gcp/credential.rs:
##
@@ -466,33 +474,216 @@ impl ApplicationDefaultCredentialsFile {
}
}
-const DEFAULT_TOKEN_GCP_URI: &str =
"https://a
tustvold commented on code in PR #3802:
URL: https://github.com/apache/arrow-rs/pull/3802#discussion_r1133078886
##
object_store/Cargo.toml:
##
@@ -41,6 +41,7 @@ tokio = { version = "1.25.0", features = ["sync", "macros",
"rt", "time", "io-ut
tracing = { version = "0.1" }
url
tustvold commented on code in PR #3802:
URL: https://github.com/apache/arrow-rs/pull/3802#discussion_r1133078703
##
.github/workflows/object_store.yml:
##
@@ -56,7 +56,7 @@ jobs:
- name: Run clippy with aws_profile feature
run: cargo clippy -p object_store --feat
tustvold commented on PR #3839:
URL: https://github.com/apache/arrow-rs/pull/3839#issuecomment-1464902004
I would like to understand the use-case more before merging this, I'm not a
massive fan of breaking encapsulation in this way, it undermines the decorator
pattern, and would rather avoi
ursabot commented on PR #5511:
URL:
https://github.com/apache/arrow-datafusion/pull/5511#issuecomment-1464900576
Benchmark runs are scheduled for baseline =
9587339b0fb060f8d153bbb0f8de6a740195ccea and contender =
aaa4e1496ba89daa03de47dc1feed7d7e57f62a8.
aaa4e1496ba89daa03de47dc1feed7d7e
alamb merged PR #5511:
URL: https://github.com/apache/arrow-datafusion/pull/5511
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arro
alamb commented on PR #5553:
URL:
https://github.com/apache/arrow-datafusion/pull/5553#issuecomment-1464899289
FYI @melgenek
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment
alamb opened a new pull request, #5553:
URL: https://github.com/apache/arrow-datafusion/pull/5553
# Which issue does this PR close?
N/A
# Rationale for this change
I keep pointing / suggesting people use these tests so I want to make it as
easy as possible to use
dinimar commented on PR #34537:
URL: https://github.com/apache/arrow/pull/34537#issuecomment-1464897845
@benibus please review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment
alamb commented on PR #5536:
URL:
https://github.com/apache/arrow-datafusion/pull/5536#issuecomment-1464897563
> I do wonder if the test_util module should be behind some feature flag,
but definitely not a blocker to this PR
Yeah, I agree that would probably be a good idea; Let's do
alamb commented on PR #5509:
URL:
https://github.com/apache/arrow-datafusion/pull/5509#issuecomment-1464897079
Thank you @ygf11 for the review
I plan to merge this PR tomorrow unless anyone else would like more time to
review.
--
This is an automated message from the Apache Git
alamb commented on code in PR #5542:
URL: https://github.com/apache/arrow-datafusion/pull/5542#discussion_r1133074974
##
datafusion/optimizer/src/simplify_expressions/expr_simplifier.rs:
##
@@ -390,6 +390,22 @@ impl<'a, S: SimplifyInfo> ExprRewriter for Simplifier<'a,
S> {
alamb commented on code in PR #3839:
URL: https://github.com/apache/arrow-rs/pull/3839#discussion_r1133074897
##
object_store/src/aws/mod.rs:
##
@@ -169,6 +170,10 @@ impl std::fmt::Display for AmazonS3 {
#[async_trait]
impl ObjectStore for AmazonS3 {
+fn as_any(&self) ->
alamb commented on PR #3839:
URL: https://github.com/apache/arrow-rs/pull/3839#issuecomment-1464895729
There appears to be some CI errors.
I think adding a `as_any` function is probably fine> it would have wider
support from older rust versions, and there are many existing examples o
ygf11 commented on code in PR #5509:
URL: https://github.com/apache/arrow-datafusion/pull/5509#discussion_r1133074480
##
datafusion/expr/src/logical_plan/builder.rs:
##
@@ -947,16 +939,16 @@ impl LogicalPlanBuilder {
let right_key = r.into();
ursabot commented on PR #3824:
URL: https://github.com/apache/arrow-rs/pull/3824#issuecomment-1464891545
Benchmark runs are scheduled for baseline =
c96274a562625f091ca4c06fca21ac35ef330358 and contender =
9ce0ebb06550be943febc226f61bf083016d7652.
9ce0ebb06550be943febc226f61bf083016d7652 i
alamb closed issue #3742: Support for Async JSON Writer
URL: https://github.com/apache/arrow-rs/issues/3742
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-ma
alamb merged PR #3824:
URL: https://github.com/apache/arrow-rs/pull/3824
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache
alamb commented on PR #3824:
URL: https://github.com/apache/arrow-rs/pull/3824#issuecomment-1464891217
Thanks everyone@!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
alamb closed issue #3740: Support for Async CSV Writer
URL: https://github.com/apache/arrow-rs/issues/3740
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mai
alamb commented on code in PR #5520:
URL: https://github.com/apache/arrow-datafusion/pull/5520#discussion_r1133071239
##
datafusion/core/src/datasource/memory.rs:
##
@@ -143,22 +147,95 @@ impl TableProvider for MemTable {
_filters: &[Expr],
_limit: Option,
dinimar commented on issue #14939:
URL: https://github.com/apache/arrow/issues/14939#issuecomment-1464886636
@benibus Big thanks! You helped me a lot. I completed work on the issue.
PR in progress
--
This is an automated message from the Apache Git Service.
To respond to the message, pl
github-actions[bot] commented on PR #34537:
URL: https://github.com/apache/arrow/pull/34537#issuecomment-1464886291
* Closes: #14939
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
github-actions[bot] commented on PR #34537:
URL: https://github.com/apache/arrow/pull/34537#issuecomment-1464886131
Thanks for opening a pull request!
If this is not a [minor
PR](https://github.com/apache/arrow/blob/main/CONTRIBUTING.md#Minor-Fixes).
Could you open an issue f
dinimar opened a new pull request, #34537:
URL: https://github.com/apache/arrow/pull/34537
### Rationale for this change
Described in the issue
### What changes are included in this PR?
- added implementations for `FieldPath::Get(const Table& table)` and
`FindAll
ursabot commented on PR #5345:
URL:
https://github.com/apache/arrow-datafusion/pull/5345#issuecomment-1464881728
Benchmark runs are scheduled for baseline =
860918d17b6bde396b04d718ee1c76d93054bf11 and contender =
9587339b0fb060f8d153bbb0f8de6a740195ccea.
9587339b0fb060f8d153bbb0f8de6a740
jackwener closed issue #5344: Add back Distinct for where-exists if subquery is
a DISTINCT
URL: https://github.com/apache/arrow-datafusion/issues/5344
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
jackwener merged PR #5345:
URL: https://github.com/apache/arrow-datafusion/pull/5345
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@
ygf11 commented on PR #5345:
URL:
https://github.com/apache/arrow-datafusion/pull/5345#issuecomment-1464870297
Thanks from your ideas, learned a lot! @mingmwang @alamb @jackwener
And I fixed the merge conflict.
--
This is an automated message from the Apache Git Service.
To respon
tustvold commented on PR #3824:
URL: https://github.com/apache/arrow-rs/pull/3824#issuecomment-1464870290
Fine with me, was just a suggestion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
tustvold commented on issue #34510:
URL: https://github.com/apache/arrow/issues/34510#issuecomment-1464864258
> why DELTA_BINARY_PACKED is deeply flawed
The paper they link to actually explains why the approach is problematic -
http://arxiv.org/pdf/1209.2137v5.pdf. The whole paper is
leprechaunt33 commented on issue #33049:
URL: https://github.com/apache/arrow/issues/33049#issuecomment-1464857986
> > which only occurs when vaex is forced to do a df.take on rows which
contain a string column whose unfiltered in memory representation is larger
than 2GB.
>
> That so
81 matches
Mail list logo
