candiduslynx commented on PR #35973:
URL: https://github.com/apache/arrow/pull/35973#issuecomment-1581993313
> Looks like you've got some tests failing with `Too many releases`, you can
enable that check locally by using the `-tags assert` flag when you run `go
test`
Yeah, I forgot t
mapleFU commented on PR #35989:
URL: https://github.com/apache/arrow/pull/35989#issuecomment-1581985853
Another problem is that:
```c++
template
static std::shared_ptr MakeTypedColumnStats(
const format::ColumnMetaData& metadata, const ColumnDescriptor* descr) {
// I
ursabot commented on PR #35667:
URL: https://github.com/apache/arrow/pull/35667#issuecomment-1581972140
Benchmark runs are scheduled for baseline =
c62ce6b179f67ff57fa1571b01f356739727c0c9 and contender =
a0d28deefd660adc6b14c4ac5fe4ed4175d4fedb.
a0d28deefd660adc6b14c4ac5fe4ed4175d4fedb is
jorisvandenbossche commented on PR #743:
URL: https://github.com/apache/arrow-adbc/pull/743#issuecomment-1581971309
> Weirdly enough, the documentation is not public, but the
[implementation](https://github.com/apache/infrastructure-p6/blob/production/modules/gitbox/files/asfgit/package/asfy
westonpace commented on code in PR #35514:
URL: https://github.com/apache/arrow/pull/35514#discussion_r1222497897
##
python/pyarrow/src/arrow/python/udf.cc:
##
@@ -15,15 +15,19 @@
// specific language governing permissions and limitations
// under the License.
-#include "arr
oridag opened a new issue, #6597:
URL: https://github.com/apache/arrow-datafusion/issues/6597
### Describe the bug
Same as title
### To Reproduce
```rust
use datafusion::prelude::*;
use datafusion_expr::BuiltinScalarFunction;
#[tokio::main]
async fn main(
kou commented on code in PR #35977:
URL: https://github.com/apache/arrow/pull/35977#discussion_r1222513086
##
matlab/test/arrow/args/tParseValidElements.m:
##
@@ -0,0 +1,163 @@
+% Licensed to the Apache Software Foundation (ASF) under one or more
+% contributor license agreement
mapleFU commented on PR #35989:
URL: https://github.com/apache/arrow/pull/35989#issuecomment-1581935377
Some notes:
1. Builder of `Statistics` will always have `has_null_count_`, and ignore
`has_distinct_count_` (not build when building `EncodedStatistics`).
`has_min_max_` will be `false
github-actions[bot] commented on PR #35962:
URL: https://github.com/apache/arrow/pull/35962#issuecomment-1581923237
Revision: 7f8d3005999f789eb0f934ee5d3ab239e36d6f44
Submitted crossbow builds: [ursacomputing/crossbow @
actions-28f35f37d0](https://github.com/ursacomputing/crossbow/bra
kou commented on PR #35962:
URL: https://github.com/apache/arrow/pull/35962#issuecomment-1581921273
@github-actions crossbow submit ubuntu-focal-* debian-bookworm-*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
U
jackwener opened a new issue, #6596:
URL: https://github.com/apache/arrow-datafusion/issues/6596
### Describe the bug
Some expression return wrong expression like.
Internal error: Optimizer rule 'simplify_expressions' failed, due to
generate a different schema, original schema:
jackwener opened a new pull request, #6595:
URL: https://github.com/apache/arrow-datafusion/pull/6595
# Which issue does this PR close?
Closes #.
# Rationale for this change
# What changes are included in this PR?
# Are these changes tested?
hkpeaks commented on issue #35688:
URL: https://github.com/apache/arrow/issues/35688#issuecomment-1581888480
@ zeroshade, now I know who are you, Matt Topol, the Arrow In Memory
Analytics author.
--
This is an automated message from the Apache Git Service.
To respond to the message, pleas
jiangzhx opened a new pull request, #6594:
URL: https://github.com/apache/arrow-datafusion/pull/6594
# Which issue does this PR close?
```
use datafusion::prelude::*;
use datafusion_expr::BuiltinScalarFunction;
#[tokio::main]
async fn main() -> datafusion::erro
h-vetinari commented on issue #35986:
URL: https://github.com/apache/arrow/issues/35986#issuecomment-1581882767
Ah, nevermind, that's most likely because we switched our grpc builds to be
shared in conda-forge...
--
This is an automated message from the Apache Git Service.
To respond to t
h-vetinari commented on issue #35986:
URL: https://github.com/apache/arrow/issues/35986#issuecomment-1581882255
Next issue on windows:
```
[102/129] Linking CXX shared library release\arrow_flight.dll
FAILED: release/arrow_flight.dll release/arrow_flight.lib
cmd.exe /C "cd . &&
h-vetinari commented on issue #35987:
URL: https://github.com/apache/arrow/issues/35987#issuecomment-1581864432
> I think that
[protocolbuffers/protobuf#12983](https://github.com/protocolbuffers/protobuf/pull/12983)
solves this but it's not released yet.
I have a feeling that this mi
h-vetinari commented on issue #35986:
URL: https://github.com/apache/arrow/issues/35986#issuecomment-1581863394
I had searched for issues before opening one, but hadn't seen #35538 for
some reason, sorry. I'm backporting
https://github.com/apache/arrow/commit/b80c6551570b8324298a12dc36be1b5
mapleFU opened a new pull request, #35989:
URL: https://github.com/apache/arrow/pull/35989
### Rationale for this change
### What changes are included in this PR?
1. This patch does some tiny optimizations on Parquet C++ Statistics. It
does:
```
For mi
h-vetinari commented on issue #35986:
URL: https://github.com/apache/arrow/issues/35986#issuecomment-1581858889
Looking at #35987, it seems that `main` has already progress a bit further
on this, and looking at the affected file, I see
https://github.com/apache/arrow/commit/b80c6551570b8324
h-vetinari commented on issue #35987:
URL: https://github.com/apache/arrow/issues/35987#issuecomment-1581857392
I opened a very similar issue just ahead of you: #35986 ;-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
wgtmac commented on code in PR #35825:
URL: https://github.com/apache/arrow/pull/35825#discussion_r1222363698
##
cpp/examples/parquet/parquet_arrow/reader_writer.cc:
##
@@ -137,4 +137,4 @@ int main(int argc, char** argv) {
read_single_rowgroup();
read_single_column();
r
web3creator commented on issue #6586:
URL:
https://github.com/apache/arrow-datafusion/issues/6586#issuecomment-1581843667
> hi @web3creator . if your query like `SELECT c1,c2,c3 from
aggregate_test_100 GROUP BY c1,c2,c3` will get all unique combinations for c1
and c2 and c3 your result sho
r4ntix commented on issue #6577:
URL:
https://github.com/apache/arrow-datafusion/issues/6577#issuecomment-1581839680
@alamb @jiangzhx Thanks.
From #2071 's comment, I see that it can make sense.
I will try to add datafusion-cli test to the CI Job.
--
This is an automated message fr
ursabot commented on PR #35895:
URL: https://github.com/apache/arrow/pull/35895#issuecomment-1581839244
Benchmark runs are scheduled for baseline =
daacbcc4c5f0e435b2158896584a4385dbf38986 and contender =
c62ce6b179f67ff57fa1571b01f356739727c0c9.
c62ce6b179f67ff57fa1571b01f356739727c0c9 is
jackwener commented on PR #6578:
URL:
https://github.com/apache/arrow-datafusion/pull/6578#issuecomment-1581836703
Thanks @alamb review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
jackwener merged PR #6578:
URL: https://github.com/apache/arrow-datafusion/pull/6578
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@
adamreeve commented on code in PR #35496:
URL: https://github.com/apache/arrow/pull/35496#discussion_r1222407723
##
csharp/src/Apache.Arrow/C/CArrowArrayStreamImporter.cs:
##
@@ -0,0 +1,137 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributo
CurtHagenlocher commented on code in PR #35496:
URL: https://github.com/apache/arrow/pull/35496#discussion_r1222406492
##
csharp/src/Apache.Arrow/C/CArrowArrayStreamImporter.cs:
##
@@ -0,0 +1,137 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more cont
CurtHagenlocher commented on code in PR #35496:
URL: https://github.com/apache/arrow/pull/35496#discussion_r1222406492
##
csharp/src/Apache.Arrow/C/CArrowArrayStreamImporter.cs:
##
@@ -0,0 +1,137 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more cont
CurtHagenlocher commented on code in PR #35496:
URL: https://github.com/apache/arrow/pull/35496#discussion_r1222404105
##
csharp/src/Apache.Arrow/C/CArrowArrayExporter.cs:
##
@@ -0,0 +1,211 @@
+// Licensed to the Apache Software Foundation (ASF) under one or more
+// contributor
CurtHagenlocher commented on code in PR #35496:
URL: https://github.com/apache/arrow/pull/35496#discussion_r1222401359
##
csharp/src/Apache.Arrow/C/CArrowArrayStreamImporter.cs:
##
@@ -0,0 +1,137 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more cont
github-actions[bot] commented on PR #35962:
URL: https://github.com/apache/arrow/pull/35962#issuecomment-1581820714
Revision: 7f8d3005999f789eb0f934ee5d3ab239e36d6f44
Submitted crossbow builds: [ursacomputing/crossbow @
actions-730c58ec5f](https://github.com/ursacomputing/crossbow/bra
kou commented on PR #35962:
URL: https://github.com/apache/arrow/pull/35962#issuecomment-1581818730
@github-actions crossbow submit ubuntu-jammy-* ubuntu-kinetic-*
debian-bullseye-* test-ubuntu-*-cpp test-debian-*-cpp-*
--
This is an automated message from the Apache Git Service.
To respo
jiangzhx commented on issue #6586:
URL:
https://github.com/apache/arrow-datafusion/issues/6586#issuecomment-1581811693
hi @web3creator .
if your query like
`SELECT c1,c2,c3 from aggregate_test_100 GROUP BY c1,c2,c3`
will get all unique combinations for c1 and c2 and c3
your res
kou commented on PR #35962:
URL: https://github.com/apache/arrow/pull/35962#issuecomment-1581806571
I think that it's not related to the problem.
I've opened #35987. See it for details.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
parkma99 opened a new pull request, #6593:
URL: https://github.com/apache/arrow-datafusion/pull/6593
# Which issue does this PR close?
Closes #6561
# Rationale for this change
# What changes are included in this PR?
# Are these changes test
CurtHagenlocher commented on code in PR #35496:
URL: https://github.com/apache/arrow/pull/35496#discussion_r1222376209
##
csharp/src/Apache.Arrow/C/CArrowArrayStreamImporter.cs:
##
@@ -0,0 +1,137 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more cont
web3creator commented on issue #6586:
URL:
https://github.com/apache/arrow-datafusion/issues/6586#issuecomment-158171
> HI @web3creator your query
>
> ```
> "SELECT c1,c2 from aggregate_test_100 GROUP BY c1,c2",
> ```
>
> groups by both c1, c2. in this ca
CurtHagenlocher commented on code in PR #35810:
URL: https://github.com/apache/arrow/pull/35810#discussion_r1210389059
##
csharp/src/Apache.Arrow/C/CArrowArrayExporter.cs:
##
@@ -203,6 +207,10 @@ private unsafe static void ReleaseArray(CArrowArray*
cArray)
private unsa
jackwener commented on issue #5821:
URL:
https://github.com/apache/arrow-datafusion/issues/5821#issuecomment-1581798414
I'm working on it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
CurtHagenlocher commented on code in PR #35496:
URL: https://github.com/apache/arrow/pull/35496#discussion_r1222376209
##
csharp/src/Apache.Arrow/C/CArrowArrayStreamImporter.cs:
##
@@ -0,0 +1,137 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more cont
CurtHagenlocher commented on code in PR #35496:
URL: https://github.com/apache/arrow/pull/35496#discussion_r1222376209
##
csharp/src/Apache.Arrow/C/CArrowArrayStreamImporter.cs:
##
@@ -0,0 +1,137 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more cont
JuliaTagBot commented on issue #67:
URL: https://github.com/apache/arrow-julia/issues/67#issuecomment-1581793722
Triggering TagBot for merged registry pull request:
https://github.com/JuliaRegistries/General/pull/85100
--
This is an automated message from the Apache Git Service.
To respon
JuliaTagBot commented on issue #67:
URL: https://github.com/apache/arrow-julia/issues/67#issuecomment-1581793596
Triggering TagBot for merged registry pull request:
https://github.com/JuliaRegistries/General/pull/85101
--
This is an automated message from the Apache Git Service.
To respon
adamreeve commented on code in PR #35496:
URL: https://github.com/apache/arrow/pull/35496#discussion_r1222372263
##
csharp/src/Apache.Arrow/C/CArrowArrayStreamImporter.cs:
##
@@ -0,0 +1,137 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributo
jackwener commented on code in PR #6578:
URL: https://github.com/apache/arrow-datafusion/pull/6578#discussion_r1222365210
##
datafusion/expr/src/type_coercion/binary.rs:
##
@@ -738,6 +740,8 @@ fn temporal_coercion(lhs_type: &DataType, rhs_type:
&DataType) -> Option
Some(Interv
lidavidm merged PR #743:
URL: https://github.com/apache/arrow-adbc/pull/743
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apa
lidavidm commented on PR #743:
URL: https://github.com/apache/arrow-adbc/pull/743#issuecomment-1581780216
It's some magic on the Apache infrastructure side.
Weirdly enough, the documentation is not public, but the
[implementation](https://github.com/apache/infrastructure-p6/blob/produ
kou commented on PR #455:
URL: https://github.com/apache/arrow-julia/pull/455#issuecomment-1581779458
Passed: https://lists.apache.org/thread/bfzng91j51vo3ygtsh8fzl5fmc3kcy2z
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
krlmlr commented on PR #743:
URL: https://github.com/apache/arrow-adbc/pull/743#issuecomment-1581778866
Interesting! Which tool processes this file?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
kou merged PR #35918:
URL: https://github.com/apache/arrow/pull/35918
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.or
lidavidm opened a new pull request, #743:
URL: https://github.com/apache/arrow-adbc/pull/743
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-
lidavidm commented on PR #742:
URL: https://github.com/apache/arrow-adbc/pull/742#issuecomment-1581776805
See https://github.com/apache/arrow-adbc/pull/743
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
paleolimbot opened a new pull request, #214:
URL: https://github.com/apache/arrow-nanoarrow/pull/214
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubsc
kou commented on code in PR #35985:
URL: https://github.com/apache/arrow/pull/35985#discussion_r1222344262
##
swift/Arrow/Sources/Arrow/ArrowArray.swift:
##
@@ -182,3 +182,52 @@ public class Date64Array: ArrowArray {
}
}
}
+
+public class Time32Array: FixedArray {
krlmlr commented on PR #742:
URL: https://github.com/apache/arrow-adbc/pull/742#issuecomment-1581759555
What should happen if parameters are required but not provided? What if
there's a mismatch (parameter count or parameter names)?
--
This is an automated message from the Apache Git Serv
krlmlr opened a new pull request, #742:
URL: https://github.com/apache/arrow-adbc/pull/742
Needs tests on the C side and perhaps also on the R side. Please advise.
Closes #734.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to G
paleolimbot merged PR #733:
URL: https://github.com/apache/arrow-adbc/pull/733
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.
paleolimbot merged PR #212:
URL: https://github.com/apache/arrow-nanoarrow/pull/212
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@a
comphead commented on code in PR #6591:
URL: https://github.com/apache/arrow-datafusion/pull/6591#discussion_r1222320474
##
datafusion/core/tests/sqllogictests/test_files/scalar.slt:
##
@@ -911,15 +911,15 @@ SELECT not(true), not(false)
false true
-query BB
-SELECT not(
comphead commented on issue #6524:
URL:
https://github.com/apache/arrow-datafusion/issues/6524#issuecomment-1581701662
@dadepo are you trying to show the result? reg to the stacktrace it failed
on console output , not on the computation itself
```
14: std::io::stdio::_print
comphead commented on issue #6586:
URL:
https://github.com/apache/arrow-datafusion/issues/6586#issuecomment-1581698361
HI @web3creator
your query
```
"SELECT c1,c2 from aggregate_test_100 GROUP BY c1,c2",
```
groups by both c1, c2. in this case you will get all u
ursabot commented on PR #35899:
URL: https://github.com/apache/arrow/pull/35899#issuecomment-1581697127
Benchmark runs are scheduled for baseline =
77d8bc59fbbd44b285d4f1abf02f215ec33d8ad8 and contender =
daacbcc4c5f0e435b2158896584a4385dbf38986.
daacbcc4c5f0e435b2158896584a4385dbf38986 is
baumgold commented on issue #458:
URL: https://github.com/apache/arrow-julia/issues/458#issuecomment-1581675112
@quinnj - I think I managed to do it. See my latest comment in #456.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Git
baumgold commented on PR #456:
URL: https://github.com/apache/arrow-julia/pull/456#issuecomment-1581674295
I was able to reproduce this with the following:
```julia
julia> NT = @NamedTuple{x::Int, y::Union{Missing,Int}};
julia> data = NT[(x=1,y=2), (x=2,y=missing), (x=3,y=4),
baumgold commented on code in PR #456:
URL: https://github.com/apache/arrow-julia/pull/456#discussion_r1220575400
##
src/ArrowTypes/src/ArrowTypes.jl:
##
@@ -348,6 +348,8 @@ function default(::Type{A}) where {A <: AbstractVector{T}}
where {T}
return a
end
+default(::Typ
baumgold commented on issue #458:
URL: https://github.com/apache/arrow-julia/issues/458#issuecomment-1581620721
I’ve been working to come up with a simple reproducible example. Been tied
up with some other stuff today but hope to spend more time tonight and
tomorrow. Will let you know as so
quinnj commented on issue #458:
URL: https://github.com/apache/arrow-julia/issues/458#issuecomment-1581579311
I have a relatively easy fix for @Moelf's case. I've been trying to figure
out a way to reproduce @baumgold's error, but have been unsuccessful so far.
--
This is an automated mes
dependabot[bot] closed pull request #51: Update datafusion-expr requirement
from 24.0.0 to 25.0.0
URL: https://github.com/apache/arrow-ballista-python/pull/51
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
dependabot[bot] commented on PR #51:
URL:
https://github.com/apache/arrow-ballista-python/pull/51#issuecomment-1581569154
Superseded by #56.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
dependabot[bot] opened a new pull request, #56:
URL: https://github.com/apache/arrow-ballista-python/pull/56
Updates the requirements on
[datafusion-expr](https://github.com/apache/arrow-datafusion) to permit the
latest version.
Changelog
Sourced from https://github.com/apache/arr
dependabot[bot] commented on PR #56:
URL:
https://github.com/apache/arrow-ballista-python/pull/56#issuecomment-1581569133
The following labels could not be found: `auto-dependencies`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
dependabot[bot] closed pull request #50: Update datafusion requirement from
24.0.0 to 25.0.0
URL: https://github.com/apache/arrow-ballista-python/pull/50
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
dependabot[bot] commented on PR #50:
URL:
https://github.com/apache/arrow-ballista-python/pull/50#issuecomment-1581568845
Superseded by #55.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
dependabot[bot] commented on PR #55:
URL:
https://github.com/apache/arrow-ballista-python/pull/55#issuecomment-1581568816
The following labels could not be found: `auto-dependencies`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
dependabot[bot] opened a new pull request, #55:
URL: https://github.com/apache/arrow-ballista-python/pull/55
Updates the requirements on
[datafusion](https://github.com/apache/arrow-datafusion) to permit the latest
version.
Changelog
Sourced from https://github.com/apache/arrow-da
dependabot[bot] closed pull request #52: Update datafusion-common requirement
from 24.0.0 to 25.0.0
URL: https://github.com/apache/arrow-ballista-python/pull/52
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
dependabot[bot] commented on PR #54:
URL:
https://github.com/apache/arrow-ballista-python/pull/54#issuecomment-1581567794
The following labels could not be found: `auto-dependencies`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
dependabot[bot] commented on PR #52:
URL:
https://github.com/apache/arrow-ballista-python/pull/52#issuecomment-1581567823
Superseded by #54.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
dependabot[bot] opened a new pull request, #54:
URL: https://github.com/apache/arrow-ballista-python/pull/54
Updates the requirements on
[datafusion-common](https://github.com/apache/arrow-datafusion) to permit the
latest version.
Changelog
Sourced from https://github.com/apache/a
github-actions[bot] commented on PR #35985:
URL: https://github.com/apache/arrow/pull/35985#issuecomment-1581566275
:warning: GitHub issue #35969 **has been automatically assigned in GitHub**
to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the mes
abandy opened a new pull request, #35985:
URL: https://github.com/apache/arrow/pull/35985
Changes:
- Updated code to use ArrowType instead of ArrowType.info to store the arrow
type in classes and structs. This was done due to Time32 and Time64 requiring
additional information beyond jus
icexelloss commented on code in PR #35953:
URL: https://github.com/apache/arrow/pull/35953#discussion_r1222192926
##
cpp/src/arrow/acero/exec_plan.h:
##
@@ -602,6 +603,9 @@ struct ARROW_ACERO_EXPORT QueryOptions {
/// If this field is not set then it will be treated as kWarn
icexelloss commented on code in PR #35874:
URL: https://github.com/apache/arrow/pull/35874#discussion_r1222189098
##
cpp/src/arrow/acero/asof_join_node.cc:
##
@@ -529,7 +529,7 @@ class KeyHasher {
size_t index_;
std::vector indices_;
std::vector metadata_;
- const Reco
tustvold commented on PR #6587:
URL:
https://github.com/apache/arrow-datafusion/pull/6587#issuecomment-1581527256
As an added bonus for non-nullable primitives this conversion will now be
zero-copy
--
This is an automated message from the Apache Git Service.
To respond to the message, pl
viirya commented on code in PR #4382:
URL: https://github.com/apache/arrow-rs/pull/4382#discussion_r1222187299
##
arrow-array/src/array/map_array.rs:
##
@@ -40,6 +40,106 @@ pub struct MapArray {
}
impl MapArray {
+/// Create a new [`MapArray`] from the provided parts
+
viirya commented on code in PR #4382:
URL: https://github.com/apache/arrow-rs/pull/4382#discussion_r1222185583
##
arrow-array/src/array/map_array.rs:
##
@@ -40,6 +40,106 @@ pub struct MapArray {
}
impl MapArray {
+/// Create a new [`MapArray`] from the provided parts
+
viirya commented on code in PR #4382:
URL: https://github.com/apache/arrow-rs/pull/4382#discussion_r1222184850
##
arrow-array/src/array/list_array.rs:
##
@@ -103,7 +104,7 @@ impl
GenericListArray {
let len = offsets.len() - 1; // Offsets guaranteed to not be empty
rtpsw commented on PR #35953:
URL: https://github.com/apache/arrow/pull/35953#issuecomment-1581522364
> I think we should consolidate the discussion first, figure out what is
needed to be done
The situation is that we have #35902 as a fix related to `StopProducing`, as
[mentioned by
rtpsw commented on code in PR #35953:
URL: https://github.com/apache/arrow/pull/35953#discussion_r1222178918
##
cpp/src/arrow/acero/exec_plan.h:
##
@@ -602,6 +603,9 @@ struct ARROW_ACERO_EXPORT QueryOptions {
/// If this field is not set then it will be treated as kWarn unles
ursabot commented on PR #35293:
URL: https://github.com/apache/arrow/pull/35293#issuecomment-1581513910
Benchmark runs are scheduled for baseline =
fe6c067e690ab28392d19388810725ce9f7ad646 and contender =
77d8bc59fbbd44b285d4f1abf02f215ec33d8ad8.
77d8bc59fbbd44b285d4f1abf02f215ec33d8ad8 is
quinnj commented on issue #458:
URL: https://github.com/apache/arrow-julia/issues/458#issuecomment-1581508553
It'd be nice to have a repro from @baumgold's original error, because it
seems like a different thing than what @Moelf is showing later on.
--
This is an automated message from th
alamb commented on code in PR #6592:
URL: https://github.com/apache/arrow-datafusion/pull/6592#discussion_r1222156771
##
datafusion/physical-expr/src/window/mod.rs:
##
@@ -32,6 +32,7 @@ mod window_frame_state;
pub use aggregate::PlainAggregateWindowExpr;
pub use built_in::Buil
alamb opened a new pull request, #6592:
URL: https://github.com/apache/arrow-datafusion/pull/6592
# Which issue does this PR close?
Related to #5781
# Rationale for this change
As I begin working out how to expose User Defined Window Functions, I want
to
1. Make sur
lidavidm commented on PR #697:
URL: https://github.com/apache/arrow-adbc/pull/697#issuecomment-1581486928
If possible - can we create GitHub issues for followups? (I suppose you may
have your own work queue but it'd be nice to make at least some of that public)
--
This is an automated mes
lidavidm commented on PR #697:
URL: https://github.com/apache/arrow-adbc/pull/697#issuecomment-1581486442
Thanks @davidhcoe @eerhardt @CurtHagenlocher!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
lidavidm merged PR #697:
URL: https://github.com/apache/arrow-adbc/pull/697
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apa
lidavidm commented on PR #697:
URL: https://github.com/apache/arrow-adbc/pull/697#issuecomment-1581486099
Yup, we just use the button here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
eerhardt commented on PR #697:
URL: https://github.com/apache/arrow-adbc/pull/697#issuecomment-1581483309
@lidavidm - It looks like I have merge permissions here since I'm a
committer on apache/arrow. But I'm unsure on the process. Can I just click the
green button in GitHub? In apache/arro
1 - 100 of 429 matches
Mail list logo
