kskalski opened a new pull request, #4894:
URL: https://github.com/apache/arrow-rs/pull/4894
# Which issue does this PR close?
Closes #4814.
# Rationale for this change
Preserves fields with unknown type in inferred schema (see more discussion
in the issue)
# Wha
backkem commented on issue #7731:
URL:
https://github.com/apache/arrow-datafusion/issues/7731#issuecomment-1748156188
Yes, I don't think it needs to be enabled by default.
I was looking into the adbc direction but the rust port seems less fleshed
out than the C and Go ones so far. I
github-actions[bot] commented on PR #38027:
URL: https://github.com/apache/arrow/pull/38027#issuecomment-1748147297
:warning: GitHub issue #37199 **has been automatically assigned in GitHub**
to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the mes
jsjtxietian opened a new pull request, #38027:
URL: https://github.com/apache/arrow/pull/38027
### Rationale for this change
Just like we have PrimitiveArray::raw_values, we could also have a span
converter for easier consumption.
### What changes are included in this PR?
mapleFU commented on PR #38025:
URL: https://github.com/apache/arrow/pull/38025#issuecomment-1748080758
Would you mind create an issue for this? I guess this is not a "minor" fix
for arrow github manangement
--
This is an automated message from the Apache Git Service.
To respond to the me
niyue commented on code in PR #37752:
URL: https://github.com/apache/arrow/pull/37752#discussion_r1346798834
##
cpp/src/gandiva/exported_funcs_registry_test.cc:
##
@@ -0,0 +1,28 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agr
github-actions[bot] commented on PR #37684:
URL: https://github.com/apache/arrow/pull/37684#issuecomment-1748045976
Revision: eca2134c73063c6ae88d6c7f7a534b6ef14d6295
Submitted crossbow builds: [ursacomputing/crossbow @
actions-09ced6cc0b](https://github.com/ursacomputing/crossbow/bra
kou commented on PR #37684:
URL: https://github.com/apache/arrow/pull/37684#issuecomment-1748044202
@github-actions crossbow submit r-binary-packages
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
niyue commented on PR #37867:
URL: https://github.com/apache/arrow/pull/37867#issuecomment-1748040639
@kou thanks so much for fixing the remaining issues!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
kou commented on code in PR #1152:
URL: https://github.com/apache/arrow-adbc/pull/1152#discussion_r1346641512
##
glib/example/README.md:
##
@@ -0,0 +1,48 @@
+
+
+# Arrow GLib example
+
+There are example codes in this directory.
+
+C example codes exist in this directory. Langua
ongchi commented on code in PR #7732:
URL: https://github.com/apache/arrow-datafusion/pull/7732#discussion_r1346747930
##
docs/source/user-guide/expressions.md:
##
@@ -22,60 +22,89 @@
DataFrame methods such as `select` and `filter` accept one or more logical
expressions and th
ongchi commented on code in PR #7732:
URL: https://github.com/apache/arrow-datafusion/pull/7732#discussion_r1346742806
##
docs/source/user-guide/expressions.md:
##
@@ -22,60 +22,89 @@
DataFrame methods such as `select` and `filter` accept one or more logical
expressions and th
ongchi commented on code in PR #7732:
URL: https://github.com/apache/arrow-datafusion/pull/7732#discussion_r1346734730
##
docs/source/user-guide/expressions.md:
##
@@ -213,14 +233,14 @@ Unlike to some databases the math functions in Datafusion
works the same way as
## Regula
ongchi commented on code in PR #7732:
URL: https://github.com/apache/arrow-datafusion/pull/7732#discussion_r1346731984
##
docs/source/conf.py:
##
@@ -118,4 +118,4 @@
myst_heading_anchors = 3
# enable nice rendering of checkboxes for the task lists
-myst_enable_extensions = [
kou commented on code in PR #37684:
URL: https://github.com/apache/arrow/pull/37684#discussion_r1346680441
##
dev/tasks/r/github.packages.yml:
##
@@ -56,6 +56,56 @@ jobs:
name: r-pkg__src__contrib
path: arrow/r/arrow_*.tar.gz
+ macos-cpp:
+name: C++
assignUser commented on PR #37684:
URL: https://github.com/apache/arrow/pull/37684#issuecomment-1747971250
As all checks pass now it seems that it was a flakey test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
assignUser commented on code in PR #37684:
URL: https://github.com/apache/arrow/pull/37684#discussion_r1346725275
##
cpp/cmake_modules/snappy.diff:
##
@@ -0,0 +1,30 @@
+diff --git a/CMakeLists.txt b/CMakeLists.txt
+index c3062e2..d946037 100644
+--- a/CMakeLists.txt
b/CMake
ongchi commented on code in PR #7732:
URL: https://github.com/apache/arrow-datafusion/pull/7732#discussion_r1346722075
##
datafusion/expr/src/expr_fn.rs:
##
@@ -103,6 +105,50 @@ pub fn or(left: Expr, right: Expr) -> Expr {
))
}
+// There is a solid implementation elsewhe
devinjdangelo commented on issue #6569:
URL:
https://github.com/apache/arrow-datafusion/issues/6569#issuecomment-1747927404
@alamb I made some progress on inserts to sorted tables
https://github.com/apache/arrow-datafusion/issues/7354
This also got me thinking about inserts to partit
devinjdangelo opened a new issue, #7744:
URL: https://github.com/apache/arrow-datafusion/issues/7744
### Is your feature request related to a problem or challenge?
It is currently unsupported to run an insert into query for a listing table
which is partitioned by a column.
###
paleolimbot opened a new pull request, #1163:
URL: https://github.com/apache/arrow-adbc/pull/1163
The existing code should have worked (and probably still did), but I'd like
to eliminate any complexity arising from managing multiple driver versions for
the purposes of eliminating potential
kou commented on code in PR #37684:
URL: https://github.com/apache/arrow/pull/37684#discussion_r1346676810
##
cpp/cmake_modules/snappy.diff:
##
@@ -0,0 +1,30 @@
+diff --git a/CMakeLists.txt b/CMakeLists.txt
+index c3062e2..d946037 100644
+--- a/CMakeLists.txt
b/CMakeLists.t
devinjdangelo opened a new pull request, #7743:
URL: https://github.com/apache/arrow-datafusion/pull/7743
## Which issue does this PR close?
Closes #7354
## Rationale for this change
See issue
## What changes are included in this PR?
Allows specifying a `re
paleolimbot commented on code in PR #37684:
URL: https://github.com/apache/arrow/pull/37684#discussion_r1346662583
##
r/configure:
##
@@ -175,12 +165,6 @@ find_arrow () {
# 2. Use pkg-config to find arrow on the system
_LIBARROW_FOUND="`${PKG_CONFIG} --variable=prefix
comphead commented on PR #7735:
URL:
https://github.com/apache/arrow-datafusion/pull/7735#issuecomment-1747868706
> > Having another verbose pair makes much more sense for me.
>
> I agree
Added `SHOW ALL VERBOSE`, `SHOW param VERBOSE` support.
User doc updated
--
This is
kou commented on code in PR #38020:
URL: https://github.com/apache/arrow/pull/38020#discussion_r1346638994
##
matlab/test/arrow/buffer/tBuffer.m:
##
@@ -0,0 +1,206 @@
+%TBUFFER Unit tests for arrow.buffer.Buffer
+
+% Licensed to the Apache Software Foundation (ASF) under one or
sgilmore10 commented on code in PR #38020:
URL: https://github.com/apache/arrow/pull/38020#discussion_r1346621986
##
matlab/test/arrow/buffer/tBuffer.m:
##
@@ -0,0 +1,206 @@
+%TBUFFER Unit tests for arrow.buffer.Buffer
+
+% Licensed to the Apache Software Foundation (ASF) under
jayzhan211 commented on code in PR #6796:
URL: https://github.com/apache/arrow-datafusion/pull/6796#discussion_r1346620948
##
datafusion/expr/src/logical_plan/builder.rs:
##
@@ -1038,6 +1042,114 @@ impl LogicalPlanBuilder {
pub fn unnest_column(self, column: impl Into) -> R
devinjdangelo commented on PR #7655:
URL:
https://github.com/apache/arrow-datafusion/pull/7655#issuecomment-1747826835
@alamb @tustvold I updated this branch to build against `arrow-rs` master
branch while we wait for the next release. Currently getting a compile error,
which I opened a PR
sgilmore10 commented on code in PR #38020:
URL: https://github.com/apache/arrow/pull/38020#discussion_r1346615131
##
matlab/src/cpp/arrow/matlab/proxy/factory.cc:
##
@@ -40,12 +40,14 @@
#include "arrow/matlab/io/feather/proxy/reader.h"
#include "arrow/matlab/io/csv/proxy/table
jayzhan211 commented on code in PR #6796:
URL: https://github.com/apache/arrow-datafusion/pull/6796#discussion_r1346614902
##
datafusion/expr/src/expr_schema.rs:
##
@@ -88,6 +88,32 @@ impl ExprSchemable for Expr {
.collect::>>()?;
Ok((fun.re
jayzhan211 commented on code in PR #6796:
URL: https://github.com/apache/arrow-datafusion/pull/6796#discussion_r1346614106
##
datafusion/expr/src/expr.rs:
##
@@ -970,6 +987,43 @@ impl Expr {
pub fn contains_outer(&self) -> bool {
!find_out_reference_exprs(self).is_
devinjdangelo opened a new pull request, #4893:
URL: https://github.com/apache/arrow-rs/pull/4893
# Which issue does this PR close?
Enables https://github.com/apache/arrow-datafusion/pull/7655
# Rationale for this change
#4871 rolled back this change, but without it
htt
jayzhan211 commented on PR #7461:
URL:
https://github.com/apache/arrow-datafusion/pull/7461#issuecomment-1747782727
> This PR appears to be stalled -- what do you think we should do with it
@jayzhan211 ?
Well, it depends on the review of #6796, since this PR is part of it.
--
This
esodan commented on PR #1152:
URL: https://github.com/apache/arrow-adbc/pull/1152#issuecomment-1747773899
> ⚠️ Please follow the [Conventional Commits format in
CONTRIBUTING.md](https://github.com/apache/arrow-adbc/blob/main/CONTRIBUTING.md)
for PR titles.
Should be done now.
--
T
esodan commented on PR #1152:
URL: https://github.com/apache/arrow-adbc/pull/1152#issuecomment-1747774427
> Could you also add a simple example like
https://github.com/apache/arrow/blob/main/c_glib/example/vala/build.vala ? Or
do you want me to do it?
I've added a C and Vala example
tustvold commented on PR #4876:
URL: https://github.com/apache/arrow-rs/pull/4876#issuecomment-1747750880
I need to sleep on it, but perhaps we just add it to the ObjectStore trait
with a default not implemented impl, it wouldn't be the weirdest thing there -
I'm looking at you append 😅
-
lidavidm merged PR #1099:
URL: https://github.com/apache/arrow-adbc/pull/1099
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.a
adamreeve opened a new pull request, #38025:
URL: https://github.com/apache/arrow/pull/38025
### Rationale for this change
After the changes in #35886, getting the compression level for a Parquet
column segfaults if the compression level or other options weren't previously
set
lidavidm commented on PR #37885:
URL: https://github.com/apache/arrow/pull/37885#issuecomment-1747728511
Thanks for the ping - I'll look at this tomorrow!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
aiguofer commented on issue #37987:
URL: https://github.com/apache/arrow/issues/37987#issuecomment-1747721655
Hey @jeremiahOkai . This issue is because some tools try to use an empty
username/password if none are provided. This was fixed in this PR
https://github.com/apache/arrow/issues/370
davidhcoe commented on PR #37885:
URL: https://github.com/apache/arrow/pull/37885#issuecomment-1747671061
@lidavidm - are you able to help at all?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
alamb commented on PR #7721:
URL:
https://github.com/apache/arrow-datafusion/pull/7721#issuecomment-1747670007
FYI @gruuya -- it is finally happening
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
alamb commented on issue #7731:
URL:
https://github.com/apache/arrow-datafusion/issues/7731#issuecomment-1747668435
I think having an (optional) FlightSQL backed remote table sounds like a
good idea to me.
--
This is an automated message from the Apache Git Service.
To respond to the me
alamb closed issue #3317: Review use of panics in `datafusion-row` crate
URL: https://github.com/apache/arrow-datafusion/issues/3317
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comme
alamb commented on issue #3317:
URL:
https://github.com/apache/arrow-datafusion/issues/3317#issuecomment-1747666484
Indeed in fact I think datafusion-row was removed a while ago, so this
ticket is no longer relevant. Thanks @qrilka
--
This is an automated message from the Apache Git Ser
github-actions[bot] commented on PR #37684:
URL: https://github.com/apache/arrow/pull/37684#issuecomment-1747665465
Revision: 99cfe8ae468aaa2a7183fa623e0423bf341fa6a3
Submitted crossbow builds: [ursacomputing/crossbow @
actions-a57a53186a](https://github.com/ursacomputing/crossbow/bra
assignUser commented on PR #37684:
URL: https://github.com/apache/arrow/pull/37684#issuecomment-1747662526
@github-actions crossbow submit r-binary-packages
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
alamb commented on PR #7461:
URL:
https://github.com/apache/arrow-datafusion/pull/7461#issuecomment-1747659642
This PR appears to be stalled -- what do you think we should do with it
@jayzhan211 ?
--
This is an automated message from the Apache Git Service.
To respond to the message, ple
assignUser commented on code in PR #37684:
URL: https://github.com/apache/arrow/pull/37684#discussion_r1346480719
##
cpp/cmake_modules/snappy.diff:
##
@@ -0,0 +1,30 @@
+diff --git a/CMakeLists.txt b/CMakeLists.txt
+index c3062e2..d946037 100644
+--- a/CMakeLists.txt
b/CMake
alamb closed issue #7722: `bounded_order_preserving_variants` configuration
setting is confusingly named
URL: https://github.com/apache/arrow-datafusion/issues/7722
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
alamb merged PR #7723:
URL: https://github.com/apache/arrow-datafusion/pull/7723
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arro
alamb commented on PR #7727:
URL:
https://github.com/apache/arrow-datafusion/pull/7727#issuecomment-1747657892
> I guess it is still possible to remove it, if we embed the data type info
in to individual aggregate expression protobuf node. But this will involve a
lot of changes just for re
kou commented on issue #38012:
URL: https://github.com/apache/arrow/issues/38012#issuecomment-1747643140
OK.
@sugibuchi Do you want to work on this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
tolleybot commented on code in PR #34616:
URL: https://github.com/apache/arrow/pull/34616#discussion_r1346465311
##
python/pyarrow/_dataset_parquet.pyx:
##
@@ -56,9 +63,180 @@ from pyarrow._parquet cimport (
cdef Expression _true = Expression._scalar(True)
-
ctypedef CParq
kou commented on code in PR #38020:
URL: https://github.com/apache/arrow/pull/38020#discussion_r1346457271
##
matlab/src/cpp/arrow/matlab/proxy/factory.cc:
##
@@ -40,12 +40,14 @@
#include "arrow/matlab/io/feather/proxy/reader.h"
#include "arrow/matlab/io/csv/proxy/table_writer
tolleybot commented on code in PR #34616:
URL: https://github.com/apache/arrow/pull/34616#discussion_r1346299229
##
python/pyarrow/_dataset_parquet.pyx:
##
@@ -711,6 +889,20 @@ cdef class ParquetFragmentScanOptions(FragmentScanOptions):
cdef ArrowReaderProperties* arrow_rea
tolleybot commented on code in PR #34616:
URL: https://github.com/apache/arrow/pull/34616#discussion_r1346456237
##
cpp/src/arrow/dataset/file_parquet.h:
##
@@ -226,6 +229,8 @@ class ARROW_DS_EXPORT ParquetFragmentScanOptions : public
FragmentScanOptions {
/// ScanOptions. A
tolleybot commented on code in PR #34616:
URL: https://github.com/apache/arrow/pull/34616#discussion_r1346455963
##
cpp/src/arrow/dataset/file_parquet.cc:
##
@@ -67,8 +72,24 @@ parquet::ReaderProperties MakeReaderProperties(
properties.disable_buffered_stream();
}
pr
tolleybot commented on code in PR #34616:
URL: https://github.com/apache/arrow/pull/34616#discussion_r1346455441
##
cpp/src/arrow/dataset/file_parquet_test.cc:
##
@@ -424,6 +425,34 @@ TEST_F(TestParquetFileSystemDataset,
WriteWithEmptyPartitioningSchema) {
TestWriteWithEmpty
assignUser commented on code in PR #37684:
URL: https://github.com/apache/arrow/pull/37684#discussion_r1346452562
##
dev/tasks/r/github.packages.yml:
##
@@ -56,6 +56,56 @@ jobs:
name: r-pkg__src__contrib
path: arrow/r/arrow_*.tar.gz
+ macos-cpp:
+nam
assignUser commented on code in PR #37684:
URL: https://github.com/apache/arrow/pull/37684#discussion_r1346438542
##
r/configure:
##
@@ -175,12 +165,6 @@ find_arrow () {
# 2. Use pkg-config to find arrow on the system
_LIBARROW_FOUND="`${PKG_CONFIG} --variable=prefix -
tschaub commented on issue #37807:
URL: https://github.com/apache/arrow/issues/37807#issuecomment-1747611641
Looks useful, @chelseajonesr.
My only real current use case has been to create Parquet data for tests.
I've written a [`test.ParquetFromJSON()`
function](https://github.com/p
lidavidm commented on issue #38012:
URL: https://github.com/apache/arrow/issues/38012#issuecomment-1747608070
Yes, we should update the docs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
viirya commented on PR #7727:
URL:
https://github.com/apache/arrow-datafusion/pull/7727#issuecomment-1747607020
No worries @alamb . Thanks for approval. 😄
I guess it is still possible to remove it, if we embed the data type info in
to individual aggregate expression protobuf node. B
lidavidm commented on PR #1162:
URL: https://github.com/apache/arrow-adbc/pull/1162#issuecomment-1747602608
I changed tacks on this halfway through so this is absolutely not ready, but
I'm probably not going to have time to finish this until late October so this
is just to remind/shame me i
lidavidm opened a new pull request, #1162:
URL: https://github.com/apache/arrow-adbc/pull/1162
Fixes #938.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e
kou commented on issue #38012:
URL: https://github.com/apache/arrow/issues/38012#issuecomment-1747592880
@lidavidm It seems that this is related to #10070 / #28047.
Should we update the document?
--
This is an automated message from the Apache Git Service.
To respond to the message, ple
conbench-apache-arrow[bot] commented on PR #37918:
URL: https://github.com/apache/arrow/pull/37918#issuecomment-1747590246
After merging your PR, Conbench analyzed the 6 benchmarking runs that have
been run so far on merge-commit 02de3c1789460304e958936b78d60f824921c250.
There were no
alamb commented on PR #7727:
URL:
https://github.com/apache/arrow-datafusion/pull/7727#issuecomment-1747589922
> @alamb You can see my previous commits which removed the `input_schema`
field. In CI, all unit tests and end-to-end tests can pass but `verify
benchmark results` gets failur
alamb commented on PR #7741:
URL:
https://github.com/apache/arrow-datafusion/pull/7741#issuecomment-1747588313
> I have tried to remove it at first comments, but encountered verify
benchmark results error too. The reason is explained in
https://github.com/apache/arrow-datafusion/pull/7727#
chelseajonesr commented on issue #37807:
URL: https://github.com/apache/arrow/issues/37807#issuecomment-1747581918
@tschaub I have an initial version of this using reflection here, in case
this is helpful:
https://github.com/chelseajonesr/rfarrow
I'm using this for a specific use c
tustvold merged PR #4889:
URL: https://github.com/apache/arrow-rs/pull/4889
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apa
kou commented on issue #38011:
URL: https://github.com/apache/arrow/issues/38011#issuecomment-1747569150
Thanks for your report.
Do you want to work on this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
alamb commented on PR #4892:
URL: https://github.com/apache/arrow-rs/pull/4892#issuecomment-1747566424
I think it is important to note that this is related to making Parquet
reading faster - as the connection between TCompactSliceInputProtocol and
reading parquet metadata may not be obvious
fatemehp commented on code in PR #37003:
URL: https://github.com/apache/arrow/pull/37003#discussion_r1346401165
##
cpp/src/parquet/reader_test.cc:
##
@@ -502,6 +502,25 @@ TEST_F(TestAllTypesPlain, ColumnSelectionOutOfRange) {
ASSERT_THROW(printer2.DebugPrint(ss, columns), Par
viirya commented on PR #7741:
URL:
https://github.com/apache/arrow-datafusion/pull/7741#issuecomment-1747563433
I have tried to remove it at first comments, but encountered `verify
benchmark results` error too. The reason is explained in
https://github.com/apache/arrow-datafusion/pull/7727
viirya commented on PR #7727:
URL:
https://github.com/apache/arrow-datafusion/pull/7727#issuecomment-1747558884
@alamb You can see my previous commits which removed the `input_schema`
field. In CI, all unit tests and end-to-end tests can pass but `verify
benchmark results` gets failures wh
zeroshade commented on PR #37877:
URL: https://github.com/apache/arrow/pull/37877#issuecomment-1747552085
The vote on the mailing list is officially passed, @bkietz you have an
outstanding change requested can you take a look at the updates and update your
review accordingly?
@pitrou
tustvold commented on code in PR #4892:
URL: https://github.com/apache/arrow-rs/pull/4892#discussion_r1346383547
##
parquet/src/arrow/async_reader/metadata.rs:
##
@@ -95,16 +94,14 @@ impl MetadataLoader {
// Did not fetch the entire file metadata in the initial read, ne
tustvold commented on PR #4892:
URL: https://github.com/apache/arrow-rs/pull/4892#issuecomment-1747533895
With the latest changes
```
open(default) time: [15.697 µs 15.705 µs 15.714 µs]
change: [-40.766% -40.682% -40.602%] (p = 0.00 <
0.05)
OleMussmann commented on PR #1099:
URL: https://github.com/apache/arrow-adbc/pull/1099#issuecomment-1747528680
No worries about the time, I hope you are better now @ywc88 . Thank you for
the review and your suggestions. I implemented them in two separate commits.
--
This is an automated m
carols10cents commented on PR #4876:
URL: https://github.com/apache/arrow-rs/pull/4876#issuecomment-1747528081
> I think I might be missing some context on why the pre-signed URL
functionality needs to be conflated with the ObjectStore trait.
TL;DR IOx; I'm happy to make changes to IO
viirya commented on PR #7727:
URL:
https://github.com/apache/arrow-datafusion/pull/7727#issuecomment-1747504076
I left a comment above to explain it and where/why it is failed in the CI
pipeline.
On Wed, Oct 4, 2023, 12:19 L. C. Hsieh ***@***.***> wrote:
> I am far from a la
viirya commented on PR #7727:
URL:
https://github.com/apache/arrow-datafusion/pull/7727#issuecomment-1747497267
I am far from a laptop but I tried to remove it at the first and the schema
seems necessary when deserializing from protobuf to physical aggregate plan
as aggregate expressio
OleMussmann commented on code in PR #1099:
URL: https://github.com/apache/arrow-adbc/pull/1099#discussion_r1346350878
##
c/validation/adbc_validation.cc:
##
@@ -945,6 +945,65 @@ void ConnectionTest::TestMetadataGetObjectsConstraints() {
// TODO: can't be done portably (need t
OleMussmann commented on code in PR #1099:
URL: https://github.com/apache/arrow-adbc/pull/1099#discussion_r1346349805
##
c/validation/adbc_validation.cc:
##
@@ -945,6 +945,65 @@ void ConnectionTest::TestMetadataGetObjectsConstraints() {
// TODO: can't be done portably (need t
WillAyd commented on issue #1100:
URL: https://github.com/apache/arrow-adbc/issues/1100#issuecomment-1747489456
Ah nice find. I think the upfront strlen check makes sense. Should likely be
done for all comparisons in the module
--
This is an automated message from the Apache Git Service.
github-actions[bot] commented on PR #38020:
URL: https://github.com/apache/arrow/pull/38020#issuecomment-1747482544
Thanks for opening a pull request!
If this is not a [minor
PR](https://github.com/apache/arrow/blob/main/CONTRIBUTING.md#Minor-Fixes).
Could you open an issue f
sgilmore10 opened a new pull request, #38020:
URL: https://github.com/apache/arrow/pull/38020
### Rationale for this change
To unblock use cases that are not satisfied by the default Arrow -> MATLAB
conversions (i.e. the `toMATLAB()` on `arrow.array.Array`), we would like
exp
lidavidm merged PR #1160:
URL: https://github.com/apache/arrow-adbc/pull/1160
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.a
paleolimbot commented on code in PR #37684:
URL: https://github.com/apache/arrow/pull/37684#discussion_r1346336236
##
r/configure:
##
@@ -175,12 +165,6 @@ find_arrow () {
# 2. Use pkg-config to find arrow on the system
_LIBARROW_FOUND="`${PKG_CONFIG} --variable=prefix
alamb commented on code in PR #7741:
URL: https://github.com/apache/arrow-datafusion/pull/7741#discussion_r1346320857
##
datafusion/core/src/physical_planner.rs:
##
@@ -2413,9 +2411,6 @@ mod tests {
"SUM(aggregate_test_100.c2)",
final_hash_agg.schema().
alamb commented on code in PR #7741:
URL: https://github.com/apache/arrow-datafusion/pull/7741#discussion_r1346319872
##
datafusion/physical-plan/src/aggregates/mod.rs:
##
@@ -283,10 +283,6 @@ pub struct AggregateExec {
pub input: Arc,
/// Schema after the aggregate is
OleMussmann commented on issue #1100:
URL: https://github.com/apache/arrow-adbc/issues/1100#issuecomment-1747452757
After some more testing, I think it works a bit different than stated in the
issue text above, my apologies. The bug is still there, the explanation might
be slightly differen
zeroshade commented on code in PR #1160:
URL: https://github.com/apache/arrow-adbc/pull/1160#discussion_r1346305530
##
go/adbc/driver/snowflake/driver.go:
##
@@ -67,6 +67,13 @@ const (
// "300ms", "1.5s" or "1m30s". ParseDuration accepts negative values
// but th
alamb commented on code in PR #7727:
URL: https://github.com/apache/arrow-datafusion/pull/7727#discussion_r1346300290
##
datafusion/physical-plan/src/aggregates/mod.rs:
##
@@ -285,7 +285,9 @@ pub struct AggregateExec {
schema: SchemaRef,
/// Input schema before any agg
alamb merged PR #7631:
URL: https://github.com/apache/arrow-datafusion/pull/7631
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arro
alamb commented on code in PR #7741:
URL: https://github.com/apache/arrow-datafusion/pull/7741#discussion_r1346278221
##
datafusion/physical-plan/src/aggregates/mod.rs:
##
@@ -283,10 +283,6 @@ pub struct AggregateExec {
pub input: Arc,
/// Schema after the aggregate is
tolleybot commented on code in PR #34616:
URL: https://github.com/apache/arrow/pull/34616#discussion_r1346299229
##
python/pyarrow/_dataset_parquet.pyx:
##
@@ -711,6 +889,20 @@ cdef class ParquetFragmentScanOptions(FragmentScanOptions):
cdef ArrowReaderProperties* arrow_rea
1 - 100 of 308 matches
Mail list logo
