kskalski opened a new issue, #4901:
URL: https://github.com/apache/arrow-rs/issues/4901
**Is your feature request related to a problem or challenge? Please describe
what you are trying to do.**
Right now `DataType::Null` is considered incompatible with any data type
other than `Null`, ho
Dandandan commented on PR #7754:
URL:
https://github.com/apache/arrow-datafusion/pull/7754#issuecomment-1752426208
Thanks @alamb
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific com
Dandandan merged PR #7754:
URL: https://github.com/apache/arrow-datafusion/pull/7754
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@
AlenkaF opened a new pull request, #38146:
URL: https://github.com/apache/arrow/pull/38146
### What changes are included in this PR?
The option to set custom path to timezone database through python API has
been implemented in https://github.com/apache/arrow/issues/35600 and is
docum
wgtmac commented on code in PR #37003:
URL: https://github.com/apache/arrow/pull/37003#discussion_r1349858700
##
cpp/src/parquet/file_reader.h:
##
@@ -58,6 +62,10 @@ class PARQUET_EXPORT RowGroupReader {
// column. Ownership is shared with the RowGroupReader.
std::shared_p
AlenkaF commented on PR #36496:
URL: https://github.com/apache/arrow/pull/36496#issuecomment-1752310300
Thank you all for the reviews and suggestions!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
AlenkaF merged PR #36496:
URL: https://github.com/apache/arrow/pull/36496
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apach
assignUser merged PR #38089:
URL: https://github.com/apache/arrow/pull/38089
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.ap
assignUser commented on PR #38089:
URL: https://github.com/apache/arrow/pull/38089#issuecomment-1752271688
I'll merge this so we get rid of the failing nightlies to reduce the noise
for the release prep.
--
This is an automated message from the Apache Git Service.
To respond to the messag
assignUser commented on PR #38080:
URL: https://github.com/apache/arrow/pull/38080#issuecomment-1752271130
I like the idea but this will cause conflicts with #38115 but as that is
done (imo) I will start on the 'get latest nightly binary'-feature now were I
can integrate this.
For y
orgadish commented on issue #38033:
URL: https://github.com/apache/arrow/issues/38033#issuecomment-1752264154
@thisisnic I've created a PR for this, but have not been able to load the
package in my local RStudio. I get the following errors:
```
Error in dyn.load(dll_copy_file) :
github-actions[bot] commented on PR #38144:
URL: https://github.com/apache/arrow/pull/38144#issuecomment-1752263951
:warning: GitHub issue #38033 **has been automatically assigned in GitHub**
to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the mes
orgadish opened a new pull request, #38144:
URL: https://github.com/apache/arrow/pull/38144
### Rationale for this change
#38033
### What changes are included in this PR?
- Added `add_pkg_name` helper.
- Added `code_name` private method to `DataType` class to store the string
ongchi commented on PR #7745:
URL:
https://github.com/apache/arrow-datafusion/pull/7745#issuecomment-1752261205
All checks in CI have passed with the current modification. I am going to
spend some time to see if it's possible to extract some common logic on the
file format.
--
This is a
github-actions[bot] commented on PR #38143:
URL: https://github.com/apache/arrow/pull/38143#issuecomment-1752257957
:warning: GitHub issue #38142 **has been automatically assigned in GitHub**
to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the mes
paleolimbot opened a new pull request, #38143:
URL: https://github.com/apache/arrow/pull/38143
### Rationale for this change
The NEWS file needs updating for 14.0.0.
### What changes are included in this PR?
The NEWS file is updated with commits since 13.0.0.
#
paleolimbot commented on PR #38080:
URL: https://github.com/apache/arrow/pull/38080#issuecomment-1752243689
@assignUser is this fix worth merging? I do need this or something like it
to debug the Windows issues we've been seeing. An alternative would be to go
straight for `LIBARROW_BINARY_U
dannygoldstein commented on issue #38139:
URL: https://github.com/apache/arrow/issues/38139#issuecomment-1752243332
This appears to be fixed in pyarrow 13
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
paleolimbot commented on code in PR #38002:
URL: https://github.com/apache/arrow/pull/38002#discussion_r1349814104
##
r/R/csv.R:
##
@@ -279,6 +280,31 @@ read_csv_arrow <- function(file,
eval.parent(mc)
}
+#' @rdname read_delim_arrow
+#' @export
+read_csv2_arrow <- function
github-actions[bot] commented on PR #38140:
URL: https://github.com/apache/arrow/pull/38140#issuecomment-1752233825
:warning: GitHub issue #38138 **has been automatically assigned in GitHub**
to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the mes
paleolimbot opened a new pull request, #38140:
URL: https://github.com/apache/arrow/pull/38140
### Rationale for this change
testthat now requires the curl package for `skip_if_offline()`. Previously
tests were skipped; how the tests fail (although the message is somewhat
bizarre).
paleolimbot commented on PR #38089:
URL: https://github.com/apache/arrow/pull/38089#issuecomment-1752225986
@assignUser could you give this a review? I don't believe any of these
failures are new as a result of these changes.
--
This is an automated message from the Apache Git Service.
To
github-actions[bot] commented on PR #38136:
URL: https://github.com/apache/arrow/pull/38136#issuecomment-1752225504
Revision: 465b5af4fbc51c24e5d70334fafc41debbed8b6d
Submitted crossbow builds: [ursacomputing/crossbow @
actions-ecf7a4c44e](https://github.com/ursacomputing/crossbow/bra
conbench-apache-arrow[bot] commented on PR #38073:
URL: https://github.com/apache/arrow/pull/38073#issuecomment-1752224485
After merging your PR, Conbench analyzed the 4 benchmarking runs that have
been run so far on merge-commit 0b9f81771b30c5ebdd215b28eb41889efa2d76ed.
There were no
paleolimbot commented on PR #38136:
URL: https://github.com/apache/arrow/pull/38136#issuecomment-1752224422
@github-actions crossbow submit test-r-rstudio-r-base-4.1-opensuse153
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
conbench-apache-arrow[bot] commented on PR #38129:
URL: https://github.com/apache/arrow/pull/38129#issuecomment-1752200979
After merging your PR, Conbench analyzed the 6 benchmarking runs that have
been run so far on merge-commit 60916fe658672bfc8330eaa488d960ae4bca1451.
There were no
orgadish commented on issue #38031:
URL: https://github.com/apache/arrow/issues/38031#issuecomment-1752197296
@thisisnic I don't know if this was updated in a recent Arrow version, but
it looks like what I want works now!
Below is a reprex for it. `read_csv(col_select = ...)` actually
sarutak opened a new pull request, #7773:
URL: https://github.com/apache/arrow-datafusion/pull/7773
## Rationale for this change
In `datafusion/core/tests/sql/mod.rs`, `#[cfg(feature = "avro")]` is applied
to `pub mod create_drop`, but it is not related to Avro.
I guess this is a lefto
kou merged PR #38073:
URL: https://github.com/apache/arrow/pull/38073
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.or
kou commented on PR #38073:
URL: https://github.com/apache/arrow/pull/38073#issuecomment-1752168206
Passed. :-)
I'll merge this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
EXPEbdodla commented on issue #37442:
URL: https://github.com/apache/arrow/issues/37442#issuecomment-1752162949
Thanks @zeroshade . I'm able to run locally on Mac with mallocator which was
failing to build with CGO Allocator. Are there any performance benchmarks
between CGOAllocator and Mal
kou merged PR #38129:
URL: https://github.com/apache/arrow/pull/38129
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.or
github-actions[bot] commented on PR #38132:
URL: https://github.com/apache/arrow/pull/38132#issuecomment-1752160303
Revision: 859ecc9639336ce4a62797258e02ec81c668067a
Submitted crossbow builds: [ursacomputing/crossbow @
actions-97d56254dd](https://github.com/ursacomputing/crossbow/bra
kou commented on PR #38132:
URL: https://github.com/apache/arrow/pull/38132#issuecomment-1752159855
@github-actions crossbow submit java-jars
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
kou commented on code in PR #38136:
URL: https://github.com/apache/arrow/pull/38136#discussion_r1349773787
##
cpp/src/arrow/dataset/file_parquet.cc:
##
@@ -462,7 +462,9 @@ Result>
ParquetFileFormat::GetReader
std::unique_ptr arrow_reader;
RETURN_NOT_OK(parquet::arrow::Fil
MrLolthe1st commented on PR #37970:
URL: https://github.com/apache/arrow/pull/37970#issuecomment-1752149766
> Why do we need to care about `MessageReader`? This implementation
re-creates `StreamDecoderImpl` instead of reusing existing `StreamDecoderImpl`
(including `MessageReader`).
esodan commented on PR #1152:
URL: https://github.com/apache/arrow-adbc/pull/1152#issuecomment-1752144017
I would like to add an example on how to access a data from a SELECT
statement, could you guide me on how can I do that?
I have a problem: GArrow.Statement.execute() returns an ou
conbench-apache-arrow[bot] commented on PR #38097:
URL: https://github.com/apache/arrow/pull/38097#issuecomment-1752122117
After merging your PR, Conbench analyzed the 6 benchmarking runs that have
been run so far on merge-commit 839137e53078953d4dc8d0d71d9c9a04996e24df.
There was 1 b
conbench-apache-arrow[bot] commented on PR #38097:
URL: https://github.com/apache/arrow/pull/38097#issuecomment-1752120955
After merging your PR, Conbench analyzed the 6 benchmarking runs that have
been run so far on merge-commit 839137e53078953d4dc8d0d71d9c9a04996e24df.
There was 1 b
alamb commented on issue #7767:
URL:
https://github.com/apache/arrow-datafusion/issues/7767#issuecomment-1752117633
> I would like to provide users with options such as the following which
will determine the number of output files:
>
> Maximum rows per file
> Maximum
I agree
llama90 commented on issue #38074:
URL: https://github.com/apache/arrow/issues/38074#issuecomment-1752111924
It seems that the issue has been fixed.
I will clean up the code, write unit tests, and aim to submit a PR as soon
as possible. Thanks to your review, I was able to reproduce t
andygrove commented on PR #509:
URL:
https://github.com/apache/arrow-datafusion-python/pull/509#issuecomment-1752110818
@dlovell Could you upmerge to pick up the clippy fix?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
andygrove commented on PR #499:
URL:
https://github.com/apache/arrow-datafusion-python/pull/499#issuecomment-1752110564
@jiangzhx Clippy tests are failing on this and your other PRs due to a new
clippy rule in the latest Rust version. A fix has already been merged to main,
so upmerging one
alamb commented on code in PR #7743:
URL: https://github.com/apache/arrow-datafusion/pull/7743#discussion_r1349747256
##
datafusion/core/src/datasource/listing/table.rs:
##
@@ -907,17 +907,19 @@ impl TableProvider for ListingTable {
"Cannot insert into a sor
alamb merged PR #7743:
URL: https://github.com/apache/arrow-datafusion/pull/7743
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arro
alamb closed issue #7354: Allow inserts to a sorted ListingTable
URL: https://github.com/apache/arrow-datafusion/issues/7354
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
alamb commented on PR #7743:
URL:
https://github.com/apache/arrow-datafusion/pull/7743#issuecomment-1752106345
> > But now that I look at that plan, perhaps the issue is that there is
more than one file in each group, so the sort order can't be maintained 🤔
>
> Perhaps if each output
alamb commented on code in PR #7751:
URL: https://github.com/apache/arrow-datafusion/pull/7751#discussion_r1349746527
##
datafusion/physical-plan/src/sorts/sort.rs:
##
@@ -769,7 +769,7 @@ impl DisplayAs for SortExec {
write!(
alamb commented on PR #7738:
URL:
https://github.com/apache/arrow-datafusion/pull/7738#issuecomment-1752104901
Thank you @jackwener
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
alamb commented on issue #7766:
URL:
https://github.com/apache/arrow-datafusion/issues/7766#issuecomment-1752104812
Thank you @haohuaijin
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
Tangruilin commented on issue #7749:
URL:
https://github.com/apache/arrow-datafusion/issues/7749#issuecomment-1752095464
> > > when i get the result with (string), (float).etc cols. I found that
[batches_to_vec](https://github.com/apache/arrow-datafusion/blob/main/test-utils/src/lib.rs#L31)
conbench-apache-arrow[bot] commented on PR #38082:
URL: https://github.com/apache/arrow/pull/38082#issuecomment-1752052141
After merging your PR, Conbench analyzed the 5 benchmarking runs that have
been run so far on merge-commit 3697bcdd514fc5a0472dabd3928f6b4731554cda.
There were no
Tangruilin commented on issue #7749:
URL:
https://github.com/apache/arrow-datafusion/issues/7749#issuecomment-1752052104
> > when i get the result with (string), (float).etc cols. I found that
[batches_to_vec](https://github.com/apache/arrow-datafusion/blob/main/test-utils/src/lib.rs#L31)
haohuaijin commented on issue #7766:
URL:
https://github.com/apache/arrow-datafusion/issues/7766#issuecomment-1752034970
I want to do it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
alamb commented on issue #7749:
URL:
https://github.com/apache/arrow-datafusion/issues/7749#issuecomment-1752020153
> when i get the result with (string), (float).etc cols. I found that
[batches_to_vec](https://github.com/apache/arrow-datafusion/blob/main/test-utils/src/lib.rs#L31)
can onl
conbench-apache-arrow[bot] commented on PR #38085:
URL: https://github.com/apache/arrow/pull/38085#issuecomment-1752016117
After merging your PR, Conbench analyzed the 6 benchmarking runs that have
been run so far on merge-commit f525b99b0fa0c49da656b0f45c4a0689934621d5.
There was 1 b
Tangruilin opened a new pull request, #7772:
URL: https://github.com/apache/arrow-datafusion/pull/7772
## Which issue does this PR close?
Closes #7749 .
## Rationale for this change
Add fuzz test for topk
## What changes are included in this PR?
1. This PR add i32 type
ongchi commented on PR #7732:
URL:
https://github.com/apache/arrow-datafusion/pull/7732#issuecomment-1752012139
> Another thing comes to my mind if we support both syntaxes, we should prob
have some notification when new operator is introduced. It might be a common
trait that will require
berkaysynnada commented on PR #7758:
URL:
https://github.com/apache/arrow-datafusion/pull/7758#issuecomment-1752011933
I've observed the problem is in `new_zero()` function while defining the
target node for timestamps.
https://github.com/apache/arrow-datafusion/blob/3d1b23a04bdc04c
Tangruilin commented on issue #7749:
URL:
https://github.com/apache/arrow-datafusion/issues/7749#issuecomment-1752011519
@alamb maybe i can add a enum to support other type? If it is ok, i will do
it.
--
This is an automated message from the Apache Git Service.
To respond to the message,
Tangruilin commented on issue #7749:
URL:
https://github.com/apache/arrow-datafusion/issues/7749#issuecomment-1752011211
when i get the result with (string), (float).etc cols. I found that
[batches_to_vec](https://github.com/apache/arrow-datafusion/blob/main/test-utils/src/lib.rs#L31)
can
conbench-apache-arrow[bot] commented on PR #37731:
URL: https://github.com/apache/arrow/pull/37731#issuecomment-1751977073
After merging your PR, Conbench analyzed the 5 benchmarking runs that have
been run so far on merge-commit 629ecbd8fd62173b62758282ca113a331940be4f.
There was 1 b
Weijun-H opened a new pull request, #7771:
URL: https://github.com/apache/arrow-datafusion/pull/7771
## Which issue does this PR close?
Closes #7764
## Rationale for this change
## What changes are included in this PR?
## Are these changes t
niyue commented on PR #38116:
URL: https://github.com/apache/arrow/pull/38116#issuecomment-1751963794
@kou this PR is ready for review, the failing CI checks don't seem to be
related with my change. Could you please help? Thanks.
--
This is an automated message from the Apache Git Service
jackwener merged PR #7738:
URL: https://github.com/apache/arrow-datafusion/pull/7738
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@
jackwener merged PR #7768:
URL: https://github.com/apache/arrow-datafusion/pull/7768
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@
jackwener commented on code in PR #7695:
URL: https://github.com/apache/arrow-datafusion/pull/7695#discussion_r1349639806
##
datafusion/optimizer/src/eliminate_nested_union.rs:
##
@@ -0,0 +1,214 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contri
jackwener commented on code in PR #7695:
URL: https://github.com/apache/arrow-datafusion/pull/7695#discussion_r1349639782
##
datafusion/optimizer/src/eliminate_nested_union.rs:
##
@@ -0,0 +1,214 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contri
68 matches
Mail list logo
