Re: [I] Port `StringToArray` to `function-arrays` [arrow-datafusion]

2024-03-10 Thread via GitHub
jayzhan211 closed issue #9497: Port `StringToArray` to `function-arrays` URL: https://github.com/apache/arrow-datafusion/issues/9497 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

Re: [PR] Port `StringToArray` to `function-arrays` subcrate [arrow-datafusion]

2024-03-10 Thread via GitHub
jayzhan211 merged PR #9543: URL: https://github.com/apache/arrow-datafusion/pull/9543 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...

Re: [I] Move `make_array` to datafusion-functions [arrow-datafusion]

2024-03-10 Thread via GitHub
jayzhan211 closed issue #9288: Move `make_array` to datafusion-functions URL: https://github.com/apache/arrow-datafusion/issues/9288 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

Re: [PR] Implement spilling for PartialSortExec [arrow-datafusion]

2024-03-10 Thread via GitHub
mustafasrepo commented on PR #9469: URL: https://github.com/apache/arrow-datafusion/pull/9469#issuecomment-1987731498 > Does anyone have any actual queries running against real inputs that use PartialSort but also run out of memory? > > I agree it can happen in theory, but I was wond

Re: [I] [CI][Debian] Use Debian 12 because Debian 11 will reach EOL on 2024-07 [arrow]

2024-03-10 Thread via GitHub
kou commented on issue #40453: URL: https://github.com/apache/arrow/issues/40453#issuecomment-1987724020 Duplicated of #40454. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[I] Eliminate code duplication between math UDFs [arrow-datafusion]

2024-03-10 Thread via GitHub
jonahgao opened a new issue, #9552: URL: https://github.com/apache/arrow-datafusion/issues/9552 ### Is your feature request related to a problem or challenge? The codes in [acos.rs](https://github.com/apache/arrow-datafusion/blob/main/datafusion/functions/src/math/acos.rs), [asin.rs

Re: [I] [Epic] Port BuiltInFunctons to `datafusion-functions-*` crates [arrow-datafusion]

2024-03-10 Thread via GitHub
erenavsarogullari commented on issue #9285: URL: https://github.com/apache/arrow-datafusion/issues/9285#issuecomment-1987704189 `ArraySort` and `ArrayDistinct` are also being addressed by following PRs: https://github.com/apache/arrow-datafusion/pull/9551 and https://github.com/apache/arro

Re: [PR] GH-38560: [C++][Parquet] Rewrite BYTE_STREAM_SPLIT SSE optimizations using xsimd [arrow]

2024-03-10 Thread via GitHub
mapleFU commented on PR #40335: URL: https://github.com/apache/arrow/pull/40335#issuecomment-1987702743 Emmm so sad, would it caused by my memcpy among simd types? Or regression comes from other problem...? -- This is an automated message from the Apache Git Service. To respond to the mes

Re: [I] Got "LIMIT must not be negative" error as long as it is not a literal [arrow-datafusion]

2024-03-10 Thread via GitHub
SteveLauC commented on issue #9506: URL: https://github.com/apache/arrow-datafusion/issues/9506#issuecomment-1987695291 > any scalar expression Yeah, as long as it can be evaluated to a number, it should work. -- This is an automated message from the Apache Git Service. To respond

[PR] Port `ArraySort` to `function-arrays` subcrate [arrow-datafusion]

2024-03-10 Thread via GitHub
erenavsarogullari opened a new pull request, #9551: URL: https://github.com/apache/arrow-datafusion/pull/9551 ## Which issue does this PR close? Closes #9550 ## What changes are included in this PR? This PR aims to do following changes in terms of Epic https://github.com/apache/

Re: [PR] GH-40445: [C++] Fix static build on Windows [arrow]

2024-03-10 Thread via GitHub
conbench-apache-arrow[bot] commented on PR #40446: URL: https://github.com/apache/arrow/pull/40446#issuecomment-1987666060 After merging your PR, Conbench analyzed the 7 benchmarking runs that have been run so far on merge-commit f299db0215c3178c542e2ab608013d6b6f43d783. There were no

Re: [I] Port `ArraySort` to `function-arrays` subcrate [arrow-datafusion]

2024-03-10 Thread via GitHub
erenavsarogullari commented on issue #9550: URL: https://github.com/apache/arrow-datafusion/issues/9550#issuecomment-1987663730 take -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[I] Port `ArraySort` to `function-arrays` subcrate [arrow-datafusion]

2024-03-10 Thread via GitHub
erenavsarogullari opened a new issue, #9550: URL: https://github.com/apache/arrow-datafusion/issues/9550 ### Is your feature request related to a problem or challenge? ArraySort function needs to be ported to new `function-arrays` subcreate in terms of #9285. ### Describe the s

Re: [PR] GH-40441: [GLib][Docs] Use Sphinx for Apache Arrow GLib front page [arrow]

2024-03-10 Thread via GitHub
kou commented on PR #40442: URL: https://github.com/apache/arrow/pull/40442#issuecomment-1987657886 @AlenkaF @jorisvandenbossche Can we enable MyST-Parser to use Markdown in Sphinx? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

Re: [PR] MINOR: [R][Docs] Fix typo in s3_bucket example code [arrow]

2024-03-10 Thread via GitHub
conbench-apache-arrow[bot] commented on PR #40447: URL: https://github.com/apache/arrow/pull/40447#issuecomment-1987641320 After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit 8c7820a576ff5197a40ba529f838ae13f4ff4095. There were no

Re: [I] [GLib] Intoroduce auto formatter [arrow]

2024-03-10 Thread via GitHub
kou commented on issue #31545: URL: https://github.com/apache/arrow/issues/31545#issuecomment-1987632484 Issue resolved by pull request 40451 https://github.com/apache/arrow/pull/40451 -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] Support Serde for ScalarUDF in Physical Expressions [arrow-datafusion]

2024-03-10 Thread via GitHub
yyy1000 commented on PR #9436: URL: https://github.com/apache/arrow-datafusion/pull/9436#issuecomment-1987632449 I think I need some feedback on https://github.com/apache/arrow-datafusion/pull/9436#discussion_r1510246296 and https://github.com/apache/arrow-datafusion/pull/9436#discussion_r

Re: [PR] GH-31545: [GLib] Enable clang-format [arrow]

2024-03-10 Thread via GitHub
kou merged PR #40451: URL: https://github.com/apache/arrow/pull/40451 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.or

Re: [PR] GH-31545: [GLib] Enable clang-format [arrow]

2024-03-10 Thread via GitHub
kou commented on PR #40451: URL: https://github.com/apache/arrow/pull/40451#issuecomment-1987631866 +1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mai

Re: [PR] Improve get_simple README [arrow-experiments]

2024-03-10 Thread via GitHub
ianmcook merged PR #15: URL: https://github.com/apache/arrow-experiments/pull/15 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arro

[PR] Improve get_simple README [arrow-experiments]

2024-03-10 Thread via GitHub
ianmcook opened a new pull request, #15: URL: https://github.com/apache/arrow-experiments/pull/15 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscrib

[PR] Port `ArrayDistinct` to `function-arrays` subcrate [arrow-datafusion]

2024-03-10 Thread via GitHub
erenavsarogullari opened a new pull request, #9549: URL: https://github.com/apache/arrow-datafusion/pull/9549 ## Which issue does this PR close? Closes #9545. ## Rationale for this change This PR aims to do following changes in terms of Epic https://github.com/apache/arrow-dataf

Re: [I] Provide faster parquet writing outside of Datafusion query execution. [arrow-datafusion]

2024-03-10 Thread via GitHub
wiedld commented on issue #9493: URL: https://github.com/apache/arrow-datafusion/issues/9493#issuecomment-1987591839 > Thank you @wiedld -- would it be possible to create a PR with the content from https://github.com/apache/arrow-datafusion/compare/main...wiedld:arrow-datafusion:test/parqu

Re: [PR] WIP(do-not-merge): changes to enable ParquetSink poc [arrow-datafusion]

2024-03-10 Thread via GitHub
wiedld commented on code in PR #9548: URL: https://github.com/apache/arrow-datafusion/pull/9548#discussion_r1519131511 ## datafusion/execution/src/object_store.rs: ## @@ -60,6 +60,11 @@ impl ObjectStoreUrl { pub fn as_str(&self) -> &str { self.as_ref() } + +

Re: [I] [GLib] GLib Installation Failure: Errors in gtkdoc Helper Script [arrow]

2024-03-10 Thread via GitHub
llama90 commented on issue #39935: URL: https://github.com/apache/arrow/issues/39935#issuecomment-1987589010 @kou Thank you for letting me know. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

Re: [PR] GH-31545: [GLib] Enable clang-format [arrow]

2024-03-10 Thread via GitHub
github-actions[bot] commented on PR #40451: URL: https://github.com/apache/arrow/pull/40451#issuecomment-1987585176 :warning: GitHub issue #31545 **has been automatically assigned in GitHub** to PR creator. -- This is an automated message from the Apache Git Service. To respond to the mes

[PR] GH-31545: [GLib] Enable clang-format [arrow]

2024-03-10 Thread via GitHub
kou opened a new pull request, #40451: URL: https://github.com/apache/arrow/pull/40451 ### Rationale for this change This will help new contributors. ### What changes are included in this PR? Create `c_glib/.clang-format` based on the current style. But there are many ch

Re: [PR] WIP(do-not-merge): changes to enable ParquetSink poc [arrow-datafusion]

2024-03-10 Thread via GitHub
wiedld commented on PR #9548: URL: https://github.com/apache/arrow-datafusion/pull/9548#issuecomment-1987582397 Note: this code was used for a POC, where we added a single commit after the latest release commit (that we were using at the time). This code will not be merged, and is not inte

[PR] WIP(do-not-merge): changes to enable ParquetSink poc [arrow-datafusion]

2024-03-10 Thread via GitHub
wiedld opened a new pull request, #9548: URL: https://github.com/apache/arrow-datafusion/pull/9548 **POC for Discussion only: DO NOT MERGE.** ## Which issue does this PR close? For discussion of https://github.com/apache/arrow-datafusion/issues/9493. ## Rationale for

Re: [PR] GH-39386: [C++] Add floordiv compute kernel [arrow]

2024-03-10 Thread via GitHub
WillAyd commented on code in PR #40450: URL: https://github.com/apache/arrow/pull/40450#discussion_r1519090991 ## cpp/src/arrow/compute/kernels/base_arithmetic_internal.h: ## @@ -464,6 +465,74 @@ struct FloatingDivideChecked { // TODO: Add decimal }; +struct FloorDiv { +

Re: [I] [Python] unexpected URL encoded path (white spaces) when uploading to S3 [arrow]

2024-03-10 Thread via GitHub
sahitya-pavurala commented on issue #34905: URL: https://github.com/apache/arrow/issues/34905#issuecomment-1987544684 take -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

Re: [I] [Python] Better pytest parametrization for different compression codecs [arrow]

2024-03-10 Thread via GitHub
sahitya-pavurala commented on issue #29053: URL: https://github.com/apache/arrow/issues/29053#issuecomment-1987544183 take -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

Re: [I] Efficiency Problem: Parallelization and vectorization [arrow-datafusion]

2024-03-10 Thread via GitHub
Lordworms commented on issue #9547: URL: https://github.com/apache/arrow-datafusion/issues/9547#issuecomment-1987543076 My current plan for this is to generate a vectorization instruction coverage in CI/CD to track the usage of SIMD instructions. Also I think tokio may got some bugs for th

Re: [PR] GH-39386: [C++] Add floordiv compute kernel [arrow]

2024-03-10 Thread via GitHub
github-actions[bot] commented on PR #40450: URL: https://github.com/apache/arrow/pull/40450#issuecomment-1987540988 :warning: GitHub issue #39386 **has been automatically assigned in GitHub** to PR creator. -- This is an automated message from the Apache Git Service. To respond to the mes

[PR] GH-39386: [C++] Add floordiv compute kernel [arrow]

2024-03-10 Thread via GitHub
WillAyd opened a new pull request, #40450: URL: https://github.com/apache/arrow/pull/40450 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-ma

Re: [I] Efficiency Problem: Parallelization and vectorization [arrow-datafusion]

2024-03-10 Thread via GitHub
yyy1000 commented on issue #9547: URL: https://github.com/apache/arrow-datafusion/issues/9547#issuecomment-1987539627 probably related: #5942 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [I] Efficiency Problem: Parallelization and vectorization [arrow-datafusion]

2024-03-10 Thread via GitHub
Lordworms commented on issue #9547: URL: https://github.com/apache/arrow-datafusion/issues/9547#issuecomment-1987539227 @alamb I am kinda stuck here, could you please provide some clues about this one? Thanks -- This is an automated message from the Apache Git Service. To respond to the

Re: [I] Replace `GetFieldAccessExpr::NamedStructField` with `ScalarFunction::Struct` [arrow-datafusion]

2024-03-10 Thread via GitHub
yyy1000 commented on issue #9532: URL: https://github.com/apache/arrow-datafusion/issues/9532#issuecomment-1987537560 I port Struct function in https://github.com/apache/arrow-datafusion/pull/9546 I think after that I can take this issue. :) -- This is an automated message from the Ap

[I] Efficiency Problem: Parallelization and vectorization [arrow-datafusion]

2024-03-10 Thread via GitHub
Lordworms opened a new issue, #9547: URL: https://github.com/apache/arrow-datafusion/issues/9547 ### Is your feature request related to a problem or challenge? I was doing a course project on efficiency comparison. And I try on using VTune on TPC-H benchmark to compare the efficiency

Re: [I] [Python] unexpected URL encoded path (white spaces) when uploading to S3 [arrow]

2024-03-10 Thread via GitHub
sahitya-pavurala commented on issue #34905: URL: https://github.com/apache/arrow/issues/34905#issuecomment-1987534793 Can I be assigned to solve for this issue? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

Re: [PR] feat: track memory consumers for GreedyMemoryPoolState [arrow-datafusion]

2024-03-10 Thread via GitHub
yjshen commented on PR #9015: URL: https://github.com/apache/arrow-datafusion/pull/9015#issuecomment-1987532523 > Seems like assuming each consumer to have a unique name is not correct. Introduce an ID field to the memory consumer, track memory usage with consumer ID, and do ID -> Na

Re: [I] Update ClickBench benchmarks with DataFusion 36 [arrow-datafusion]

2024-03-10 Thread via GitHub
Ted-Jiang commented on issue #9404: URL: https://github.com/apache/arrow-datafusion/issues/9404#issuecomment-1987530880 @alamb Sorry for the late response. >@Ted-Jiang is there some way to test via configuration setting if caching the per-file metadata would help these queries? Th

Re: [PR] Better document parquet pushdown [arrow-rs]

2024-03-10 Thread via GitHub
tustvold merged PR #5491: URL: https://github.com/apache/arrow-rs/pull/5491 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apa

Re: [PR] GH-40448: [CI][Dev] Run pre-commit [arrow]

2024-03-10 Thread via GitHub
github-actions[bot] commented on PR #40449: URL: https://github.com/apache/arrow/pull/40449#issuecomment-1987521313 :warning: GitHub issue #40448 **has been automatically assigned in GitHub** to PR creator. -- This is an automated message from the Apache Git Service. To respond to the mes

[PR] GH-40448: [CI][Dev] Run pre-commit [arrow]

2024-03-10 Thread via GitHub
kou opened a new pull request, #40449: URL: https://github.com/apache/arrow/pull/40449 ### Rationale for this change We have pre-commit configuration but it's not used in CI. ### What changes are included in this PR? Run pre-commit in CI. ### Are these changes test

Re: [I] LocalStack Tests Flaky in CI [arrow-rs]

2024-03-10 Thread via GitHub
tustvold commented on issue #5283: URL: https://github.com/apache/arrow-rs/issues/5283#issuecomment-1987520546 Fantastic news, I'll probably wait until `3.3` as the regular CI failures appear to have abated for now, but will pre-empt this and use a image sha should they return -- This is

Re: [PR] Port tan, tanh to datafusion-functions [arrow-datafusion]

2024-03-10 Thread via GitHub
jonahgao commented on code in PR #9535: URL: https://github.com/apache/arrow-datafusion/pull/9535#discussion_r1519076790 ## datafusion/functions/src/math/tanh.rs: ## @@ -0,0 +1,110 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license

Re: [PR] Port tan, tanh to datafusion-functions [arrow-datafusion]

2024-03-10 Thread via GitHub
jonahgao commented on code in PR #9535: URL: https://github.com/apache/arrow-datafusion/pull/9535#discussion_r1519076597 ## datafusion/functions/src/math/tan.rs: ## @@ -0,0 +1,110 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license a

Re: [PR] Add DataType::ListView and DataType::LargeListView [arrow-rs]

2024-03-10 Thread via GitHub
tustvold commented on code in PR #5493: URL: https://github.com/apache/arrow-rs/pull/5493#discussion_r1519076201 ## arrow-data/src/data.rs: ## @@ -119,12 +119,22 @@ pub(crate) fn new_buffers(data_type: &DataType, capacity: usize) -> [MutableBuff buffer.push(0i32);

Re: [PR] Add DataType::ListView and DataType::LargeListView [arrow-rs]

2024-03-10 Thread via GitHub
tustvold commented on code in PR #5493: URL: https://github.com/apache/arrow-rs/pull/5493#discussion_r1519076201 ## arrow-data/src/data.rs: ## @@ -119,12 +119,22 @@ pub(crate) fn new_buffers(data_type: &DataType, capacity: usize) -> [MutableBuff buffer.push(0i32);

Re: [PR] Remove unused import detected by nightly rust [arrow-rs]

2024-03-10 Thread via GitHub
tustvold commented on PR #5477: URL: https://github.com/apache/arrow-rs/pull/5477#issuecomment-1987516905 Thank you -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

Re: [PR] Remove unused import detected by nightly rust [arrow-rs]

2024-03-10 Thread via GitHub
tustvold merged PR #5477: URL: https://github.com/apache/arrow-rs/pull/5477 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apa

Re: [I] Unused import in nightly rust [arrow-rs]

2024-03-10 Thread via GitHub
tustvold closed issue #5476: Unused import in nightly rust URL: https://github.com/apache/arrow-rs/issues/5476 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e

Re: [PR] Port Struct to datafusion-functions [arrow-datafusion]

2024-03-10 Thread via GitHub
yyy1000 commented on code in PR #9546: URL: https://github.com/apache/arrow-datafusion/pull/9546#discussion_r1519072896 ## datafusion/sql/src/expr/mod.rs: ## @@ -583,8 +586,10 @@ impl<'a, S: ContextProvider> SqlToRel<'a, S> { self.sql_expr_to_logical_expr(value,

Re: [PR] GH-38560: [C++][Parquet] Rewrite BYTE_STREAM_SPLIT SSE optimizations using xsimd [arrow]

2024-03-10 Thread via GitHub
cyb70289 commented on PR #40335: URL: https://github.com/apache/arrow/pull/40335#issuecomment-1987514574 Did a quick profiling. For gcc, looks Neon code doesn't save total instructions. Normalize instructions by iteration gives similar result for both the scalar and neon benchmark. `ASE_

[PR] Port Struct to datafusion-functions [arrow-datafusion]

2024-03-10 Thread via GitHub
yyy1000 opened a new pull request, #9546: URL: https://github.com/apache/arrow-datafusion/pull/9546 ## Which issue does this PR close? Related #9285 . ## Rationale for this change ## What changes are included in this PR? ## Are these changes tested?

Re: [I] Got "LIMIT must not be negative" error as long as it is not a literal [arrow-datafusion]

2024-03-10 Thread via GitHub
jonahgao commented on issue #9506: URL: https://github.com/apache/arrow-datafusion/issues/9506#issuecomment-1987512263 I think ideally it should support any scalar expression. In PostgreSQL, even functions and scalar subqueries are allowed. ```sh psql=> select * from t limit (select

Re: [PR] GH-38560: [C++][Parquet] Rewrite BYTE_STREAM_SPLIT SSE optimizations using xsimd [arrow]

2024-03-10 Thread via GitHub
cyb70289 commented on PR #40335: URL: https://github.com/apache/arrow/pull/40335#issuecomment-1987511710 Tested on Neoverse-N1. For clang, I see performance improvement from both encoder and decode. But for gcc, there's some drop from the encoder. **- clang-16, improvement from both e

Re: [PR] fix: Comet native operator can be executed after ReusedExchange [arrow-datafusion-comet]

2024-03-10 Thread via GitHub
codecov-commenter commented on PR #187: URL: https://github.com/apache/arrow-datafusion-comet/pull/187#issuecomment-1987510051 ## [Codecov](https://app.codecov.io/gh/apache/arrow-datafusion-comet/pull/187?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr

Re: [PR] GH-40376: [Python] Update for NumPy 2.0 ABI change in PyArray_Descr->elsize [arrow]

2024-03-10 Thread via GitHub
kou commented on PR #40418: URL: https://github.com/apache/arrow/pull/40418#issuecomment-1987495204 It seems that wheel-manylinux failures and wheel-windows failures are related to this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] Minor: Fix document Interval syntax [arrow-datafusion]

2024-03-10 Thread via GitHub
yyy1000 commented on code in PR #9542: URL: https://github.com/apache/arrow-datafusion/pull/9542#discussion_r1519059686 ## docs/source/user-guide/sql/data_types.md: ## @@ -30,11 +30,11 @@ the `arrow_typeof` function. For example: ```sql select arrow_typeof(interval '1 month'

Re: [PR] Remove unused import detected by nightly rust [arrow-rs]

2024-03-10 Thread via GitHub
XiangpengHao commented on code in PR #5477: URL: https://github.com/apache/arrow-rs/pull/5477#discussion_r1519057599 ## parquet/src/compression.rs: ## @@ -441,8 +437,6 @@ mod lz4_codec { } } } -#[cfg(any(feature = "lz4", test))] -pub use lz4_codec::*; Review Comm

Re: [PR] Use HTTP/1.1 and implement chunked transfer encoding in simple Python server example [arrow-experiments]

2024-03-10 Thread via GitHub
ianmcook merged PR #12: URL: https://github.com/apache/arrow-experiments/pull/12 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arro

Re: [PR] GH-40394: [C++] Add support for mold [arrow]

2024-03-10 Thread via GitHub
kou commented on PR #40397: URL: https://github.com/apache/arrow/pull/40397#issuecomment-1987491083 I'll merge this tomorrow if nobody objects this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

Re: [PR] Show how to disable chunked transfer encoding in Go and Java server examples [arrow-experiments]

2024-03-10 Thread via GitHub
ianmcook merged PR #13: URL: https://github.com/apache/arrow-experiments/pull/13 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arro

Re: [PR] Add simple C GLib client example [arrow-experiments]

2024-03-10 Thread via GitHub
ianmcook merged PR #14: URL: https://github.com/apache/arrow-experiments/pull/14 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arro

Re: [I] [Python] python/benchmarks/parquet.py has flake8 failures [arrow]

2024-03-10 Thread via GitHub
kou commented on issue #40439: URL: https://github.com/apache/arrow/issues/40439#issuecomment-1987489862 Issue resolved by pull request 40440 https://github.com/apache/arrow/pull/40440 -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] GH-40439: [Python] Fix flake8 failures in python/benchmarks/parquet.py [arrow]

2024-03-10 Thread via GitHub
kou merged PR #40440: URL: https://github.com/apache/arrow/pull/40440 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.or

Re: [PR] GH-40439: [Python] Fix flake8 failures in python/benchmarks/parquet.py [arrow]

2024-03-10 Thread via GitHub
kou commented on PR #40440: URL: https://github.com/apache/arrow/pull/40440#issuecomment-1987488537 +1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mai

Re: [I] [Python] python/examples/minimal_build/Dockerfile.* have hadolint warnings [arrow]

2024-03-10 Thread via GitHub
kou commented on issue #40443: URL: https://github.com/apache/arrow/issues/40443#issuecomment-1987487919 Issue resolved by pull request 40444 https://github.com/apache/arrow/pull/40444 -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] GH-40443: [Python] Suppress python/examples/minimal_build/Dockerfile.* warnings [arrow]

2024-03-10 Thread via GitHub
kou merged PR #40444: URL: https://github.com/apache/arrow/pull/40444 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.or

Re: [PR] GH-40443: [Python] Suppress python/examples/minimal_build/Dockerfile.* warnings [arrow]

2024-03-10 Thread via GitHub
kou commented on PR #40444: URL: https://github.com/apache/arrow/pull/40444#issuecomment-1987487628 +1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mai

Re: [PR] fix: Try to convert a static list into a set in rust [arrow-datafusion-comet]

2024-03-10 Thread via GitHub
advancedxy commented on PR #184: URL: https://github.com/apache/arrow-datafusion-comet/pull/184#issuecomment-1987486432 cc @viirya @sunchao -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

Re: [PR] Remove unused import detected by nightly rust [arrow-rs]

2024-03-10 Thread via GitHub
tustvold commented on code in PR #5477: URL: https://github.com/apache/arrow-rs/pull/5477#discussion_r1519054153 ## parquet/src/compression.rs: ## @@ -441,8 +437,6 @@ mod lz4_codec { } } } -#[cfg(any(feature = "lz4", test))] -pub use lz4_codec::*; Review Comment:

Re: [PR] Add simple C GLib client example [arrow-experiments]

2024-03-10 Thread via GitHub
kou commented on PR #14: URL: https://github.com/apache/arrow-experiments/pull/14#issuecomment-1987483103 OK! Can we merge this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

[I] Comet native operator cannot be executed after ReusedExchange [arrow-datafusion-comet]

2024-03-10 Thread via GitHub
viirya opened a new issue, #188: URL: https://github.com/apache/arrow-datafusion-comet/issues/188 ### Describe the bug Currently, if there are Comet operators after `ReusedExchange`, Comet will throw exception: ``` org.apache.comet.CometRuntimeException: No input for Comet

[PR] fix: Comet native operator can be executed after ReusedExchange [arrow-datafusion-comet]

2024-03-10 Thread via GitHub
viirya opened a new pull request, #187: URL: https://github.com/apache/arrow-datafusion-comet/pull/187 ## Which issue does this PR close? Closes #. ## Rationale for this change ## What changes are included in this PR? ## How are these change

Re: [PR] Add simple C GLib client example [arrow-experiments]

2024-03-10 Thread via GitHub
ianmcook commented on PR #14: URL: https://github.com/apache/arrow-experiments/pull/14#issuecomment-1987474397 > Thanks for testing. I've added a missing `g_object_unref(table)` that is included in your example. Thanks! > BTW, should we add write code like you added to the exa

Re: [PR] Remove unused import detected by nightly rust [arrow-rs]

2024-03-10 Thread via GitHub
XiangpengHao commented on code in PR #5477: URL: https://github.com/apache/arrow-rs/pull/5477#discussion_r1519045105 ## parquet/src/compression.rs: ## @@ -441,8 +437,6 @@ mod lz4_codec { } } } -#[cfg(any(feature = "lz4", test))] -pub use lz4_codec::*; Review Comm

Re: [PR] Remove unused import detected by nightly rust [arrow-rs]

2024-03-10 Thread via GitHub
XiangpengHao commented on code in PR #5477: URL: https://github.com/apache/arrow-rs/pull/5477#discussion_r1519045105 ## parquet/src/compression.rs: ## @@ -441,8 +437,6 @@ mod lz4_codec { } } } -#[cfg(any(feature = "lz4", test))] -pub use lz4_codec::*; Review Comm

Re: [PR] fix: CometExecRule should handle ShuffleQueryStage and ReusedExchange [arrow-datafusion-comet]

2024-03-10 Thread via GitHub
viirya commented on code in PR #186: URL: https://github.com/apache/arrow-datafusion-comet/pull/186#discussion_r1519043640 ## spark/src/main/scala/org/apache/comet/CometSparkSessionExtensions.scala: ## @@ -378,6 +382,27 @@ class CometSparkSessionExtensions case Non

Re: [PR] Port StringToArray to function-arrays [arrow-datafusion]

2024-03-10 Thread via GitHub
erenavsarogullari commented on code in PR #9543: URL: https://github.com/apache/arrow-datafusion/pull/9543#discussion_r1519041732 ## datafusion/core/tests/dataframe/dataframe_functions.rs: ## @@ -870,3 +870,22 @@ async fn test_fn_array_to_string() -> Result<()> { Ok(())

Re: [PR] Port StringToArray to function-arrays [arrow-datafusion]

2024-03-10 Thread via GitHub
erenavsarogullari commented on code in PR #9543: URL: https://github.com/apache/arrow-datafusion/pull/9543#discussion_r1519041732 ## datafusion/core/tests/dataframe/dataframe_functions.rs: ## @@ -870,3 +870,22 @@ async fn test_fn_array_to_string() -> Result<()> { Ok(())

Re: [PR] GH-40077: [CI] Use GitHub hosted M1 macOS runner [arrow]

2024-03-10 Thread via GitHub
kou commented on PR #40437: URL: https://github.com/apache/arrow/pull/40437#issuecomment-1987455008 > I suppose the "install packages" step in the arm64 wheel builds will get faster once vcpkg results are cached? Yes. The previous arm64 template doesn't use NuGet based cache but I uni

Re: [I] [C++] Windows static build for java-jars failed [arrow]

2024-03-10 Thread via GitHub
kou commented on issue #40445: URL: https://github.com/apache/arrow/issues/40445#issuecomment-1987452992 Issue resolved by pull request 40446 https://github.com/apache/arrow/pull/40446 -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] GH-40445: [C++] Fix static build on Windows [arrow]

2024-03-10 Thread via GitHub
kou merged PR #40446: URL: https://github.com/apache/arrow/pull/40446 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.or

Re: [PR] fix: CometExecRule should handle ShuffleQueryStage and ReusedExchange [arrow-datafusion-comet]

2024-03-10 Thread via GitHub
snmvaughan commented on code in PR #186: URL: https://github.com/apache/arrow-datafusion-comet/pull/186#discussion_r1519036311 ## spark/src/main/scala/org/apache/comet/CometSparkSessionExtensions.scala: ## @@ -378,6 +382,27 @@ class CometSparkSessionExtensions case

Re: [PR] GH-40445: [C++] Fix static build on Windows [arrow]

2024-03-10 Thread via GitHub
kou commented on PR #40446: URL: https://github.com/apache/arrow/pull/40446#issuecomment-1987452497 +1 https://github.com/ursacomputing/crossbow/actions/runs/8222805723/job/22484732454 The error has gone. -- This is an automated message from the Apache Git Service. To respond to

Re: [I] Unable to access builder on List type column with List type of field. [arrow-rs]

2024-03-10 Thread via GitHub
istvan-fodor commented on issue #5494: URL: https://github.com/apache/arrow-rs/issues/5494#issuecomment-1987449478 @tustvold @alamb I was able to get this to work with the following code. Took the Box and downcasted it. ```rust use arrow::{ array::{ArrayBuilder, StructBuilde

Re: [PR] Minor: Fix document Interval syntax [arrow-datafusion]

2024-03-10 Thread via GitHub
jayzhan211 commented on code in PR #9542: URL: https://github.com/apache/arrow-datafusion/pull/9542#discussion_r1519031038 ## docs/source/user-guide/sql/data_types.md: ## @@ -30,11 +30,11 @@ the `arrow_typeof` function. For example: ```sql select arrow_typeof(interval '1 mon

Re: [I] Port `ArrayDistinct` to `function-arrays` subcrate [arrow-datafusion]

2024-03-10 Thread via GitHub
erenavsarogullari commented on issue #9545: URL: https://github.com/apache/arrow-datafusion/issues/9545#issuecomment-1987439966 take -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[I] Port `ArrayDistinct` to `function-arrays` subcrate [arrow-datafusion]

2024-03-10 Thread via GitHub
erenavsarogullari opened a new issue, #9545: URL: https://github.com/apache/arrow-datafusion/issues/9545 ### Is your feature request related to a problem or challenge? ArrayDistinct function needs to be ported to new `function-arrays` subcreate in terms of #9285. ### Describe t

Re: [PR] Port StringToArray to function-arrays [arrow-datafusion]

2024-03-10 Thread via GitHub
jayzhan211 commented on PR #9543: URL: https://github.com/apache/arrow-datafusion/pull/9543#issuecomment-1987436239 You can follow the `How to format .md document` section in https://arrow.apache.org/datafusion/contributor-guide/index.html#developer-s-guide to solve the formating issue -

Re: [PR] build: Run Spark SQL tests for 3.4 [arrow-datafusion-comet]

2024-03-10 Thread via GitHub
viirya commented on code in PR #166: URL: https://github.com/apache/arrow-datafusion-comet/pull/166#discussion_r1519025545 ## dev/diffs/3.4.2.diff: ## @@ -0,0 +1,1306 @@ +diff --git a/pom.xml b/pom.xml +index fab98342498..f2156d790d1 100644 +--- a/pom.xml b/pom.xml +@@ -14

Re: [PR] Port StringToArray to function-arrays [arrow-datafusion]

2024-03-10 Thread via GitHub
jayzhan211 commented on code in PR #9543: URL: https://github.com/apache/arrow-datafusion/pull/9543#discussion_r1519025426 ## docs/source/user-guide/sql/scalar_functions.md: ## @@ -3113,6 +3113,7 @@ _Alias of [make_array](#make_array)._ ### `string_to_array` Splits a string

Re: [PR] Port StringToArray to function-arrays [arrow-datafusion]

2024-03-10 Thread via GitHub
jayzhan211 commented on code in PR #9543: URL: https://github.com/apache/arrow-datafusion/pull/9543#discussion_r1519025106 ## datafusion/core/tests/dataframe/dataframe_functions.rs: ## @@ -870,3 +870,22 @@ async fn test_fn_array_to_string() -> Result<()> { Ok(()) } + +#[

Re: [PR] MINOR: [R][Docs] Fix typo in s3_bucket example code [arrow]

2024-03-10 Thread via GitHub
kou merged PR #40447: URL: https://github.com/apache/arrow/pull/40447 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.or

Re: [PR] build: Run Spark SQL tests for 3.4 [arrow-datafusion-comet]

2024-03-10 Thread via GitHub
viirya commented on code in PR #166: URL: https://github.com/apache/arrow-datafusion-comet/pull/166#discussion_r1519024001 ## .github/workflows/spark_sql_test.yml: ## @@ -0,0 +1,217 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license

Re: [PR] GH-40252: [C++] Make span SFINAE standards-conforming to enable compilation with nvcc [arrow]

2024-03-10 Thread via GitHub
vyasr commented on code in PR #40253: URL: https://github.com/apache/arrow/pull/40253#discussion_r1519023528 ## cpp/src/arrow/util/span.h: ## @@ -25,6 +25,18 @@ namespace arrow::util { +template +class span; + +template +struct ConstructibleFromDataAndSize : std::false_ty

[I] Non deterministic result for window function [arrow-datafusion]

2024-03-10 Thread via GitHub
jayzhan211 opened a new issue, #9544: URL: https://github.com/apache/arrow-datafusion/issues/9544 ### Is your feature request related to a problem or challenge? This query failed sometimes. https://github.com/apache/arrow-datafusion/actions/runs/895671/job/22483743010 https

  1   2   3   >