wiedld commented on code in PR #9685:
URL: https://github.com/apache/arrow-datafusion/pull/9685#discussion_r1531573732
##
datafusion/optimizer/src/common_subexpr_eliminate.rs:
##
@@ -571,66 +580,73 @@ enum VisitRecord {
/// `usize` is the monotone increasing series number a
wiedld commented on code in PR #9685:
URL: https://github.com/apache/arrow-datafusion/pull/9685#discussion_r1531573732
##
datafusion/optimizer/src/common_subexpr_eliminate.rs:
##
@@ -571,66 +580,73 @@ enum VisitRecord {
/// `usize` is the monotone increasing series number a
wiedld commented on code in PR #9685:
URL: https://github.com/apache/arrow-datafusion/pull/9685#discussion_r1531581836
##
datafusion/optimizer/src/common_subexpr_eliminate.rs:
##
@@ -42,6 +41,15 @@ use datafusion_expr::{col, Expr, ExprSchemable};
/// - DataType of this expressi
conbench-apache-arrow[bot] commented on PR #40651:
URL: https://github.com/apache/arrow/pull/40651#issuecomment-2008812199
After merging your PR, Conbench analyzed the 7 benchmarking runs that have
been run so far on merge-commit 921863f7bfb38da88a277a6352a2b535d1e7a4b1.
There were no
github-actions[bot] commented on PR #40685:
URL: https://github.com/apache/arrow/pull/40685#issuecomment-2008783511
Thanks for opening a pull request!
If this is not a [minor
PR](https://github.com/apache/arrow/blob/main/CONTRIBUTING.md#Minor-Fixes).
Could you open an issue f
vibhatha opened a new pull request, #40685:
URL: https://github.com/apache/arrow/pull/40685
### Rationale for this change
Adding documentation for debugging JNI-based Java modules.
### What changes are included in this PR?
Documentation update for developer docs for
wiedld commented on code in PR #9685:
URL: https://github.com/apache/arrow-datafusion/pull/9685#discussion_r1531575684
##
datafusion/optimizer/src/common_subexpr_eliminate.rs:
##
@@ -571,66 +580,73 @@ enum VisitRecord {
/// `usize` is the monotone increasing series number a
codecov-commenter commented on PR #215:
URL:
https://github.com/apache/arrow-datafusion-comet/pull/215#issuecomment-2008773210
##
[Codecov](https://app.codecov.io/gh/apache/arrow-datafusion-comet/pull/215?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comme
wiedld commented on code in PR #9685:
URL: https://github.com/apache/arrow-datafusion/pull/9685#discussion_r1531573732
##
datafusion/optimizer/src/common_subexpr_eliminate.rs:
##
@@ -571,66 +580,73 @@ enum VisitRecord {
/// `usize` is the monotone increasing series number a
wiedld commented on code in PR #9685:
URL: https://github.com/apache/arrow-datafusion/pull/9685#discussion_r1531573732
##
datafusion/optimizer/src/common_subexpr_eliminate.rs:
##
@@ -571,66 +580,73 @@ enum VisitRecord {
/// `usize` is the monotone increasing series number a
wiedld commented on code in PR #9685:
URL: https://github.com/apache/arrow-datafusion/pull/9685#discussion_r1531567569
##
datafusion/optimizer/src/common_subexpr_eliminate.rs:
##
@@ -719,23 +741,10 @@ impl TreeNodeRewriter for CommonSubexprRewriter<'_> {
wiedld commented on code in PR #9685:
URL: https://github.com/apache/arrow-datafusion/pull/9685#discussion_r1531566365
##
datafusion/optimizer/src/common_subexpr_eliminate.rs:
##
@@ -719,23 +741,10 @@ impl TreeNodeRewriter for CommonSubexprRewriter<'_> {
Tangruilin commented on PR #9541:
URL:
https://github.com/apache/arrow-datafusion/pull/9541#issuecomment-2008738902
> Hi @Tangruilin -- I wonder how this PR is going?
I need to slove the conflicts, then the PR can be reviewed
This will be finished today
--
This is an automat
erenavsarogullari commented on issue #9705:
URL:
https://github.com/apache/arrow-datafusion/issues/9705#issuecomment-2008724200
take
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
erenavsarogullari opened a new issue, #9705:
URL: https://github.com/apache/arrow-datafusion/issues/9705
### Is your feature request related to a problem or challenge?
This issue aims refactoring by addressing following requirements:
`functions-array` subcreate is introduced in term
wgtmac commented on PR #40609:
URL: https://github.com/apache/arrow/pull/40609#issuecomment-2008718921
Failure in [AMD64 Ubuntu 20.04 R 4.3 Force-Tests
true](https://github.com/apache/arrow/actions/runs/8353163894/job/22867379973#logs)
is also unrelated.
```
══ Failed tests
═
tustvold closed pull request #5529: Fix local file copy when source not found
(#5503)
URL: https://github.com/apache/arrow-rs/pull/5529
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
tustvold commented on PR #5529:
URL: https://github.com/apache/arrow-rs/pull/5529#issuecomment-2008706999
Closed by #5528
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
tustvold closed issue #5503: Local object store copy/rename with nonexistent
`from` file loops forever instead of erroring
URL: https://github.com/apache/arrow-rs/issues/5503
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
tustvold merged PR #5528:
URL: https://github.com/apache/arrow-rs/pull/5528
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apa
wgtmac commented on code in PR #40647:
URL: https://github.com/apache/arrow/pull/40647#discussion_r1531536368
##
cpp/src/arrow/memory_pool.h:
##
@@ -35,44 +36,62 @@ namespace internal {
///
// Helper tracking
github-actions[bot] commented on PR #40514:
URL: https://github.com/apache/arrow/pull/40514#issuecomment-2008694762
Revision: ce1e39644e6ab970c3b321bf85eefa073f7e3482
Submitted crossbow builds: [ursacomputing/crossbow @
actions-ace79921cd](https://github.com/ursacomputing/crossbow/bra
vibhatha commented on PR #40514:
URL: https://github.com/apache/arrow/pull/40514#issuecomment-2008693145
@github-actions crossbow submit -g java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
wgtmac commented on PR #40609:
URL: https://github.com/apache/arrow/pull/40609#issuecomment-2008685211
> Revision:
[1a2634b](https://github.com/apache/arrow/commit/1a2634b37723074f2b1cbb0765666981fb997575)
>
> Submitted crossbow builds: [ursacomputing/crossbow @
actions-2e59d7101d](h
mapleFU commented on PR #40647:
URL: https://github.com/apache/arrow/pull/40647#issuecomment-2008683602
Still not understanding that. I think `xadd` is enough, is `lock xadd`
neccessary? See cases above:
1.
https://github.com/apache/kudu/blob/647726ad6b2aab0c6a6d34e16e027debd8a827eb/
jayzhan211 commented on issue #9637:
URL:
https://github.com/apache/arrow-datafusion/issues/9637#issuecomment-2008680102
I analyze the `sql_planner` again and find that `exprlist_to_fields` and
`calc_func_dependencies_for_project` are the two most time spending func, so I
think #9595 might
AlenkaF merged PR #40679:
URL: https://github.com/apache/arrow/pull/40679
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apach
viirya commented on PR #194:
URL:
https://github.com/apache/arrow-datafusion-comet/pull/194#issuecomment-2008670350
Merged. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
viirya merged PR #194:
URL: https://github.com/apache/arrow-datafusion-comet/pull/194
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...
viirya closed issue #193: Support HashJoin operator
URL: https://github.com/apache/arrow-datafusion-comet/issues/193
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscr
erenavsarogullari opened a new pull request, #9704:
URL: https://github.com/apache/arrow-datafusion/pull/9704
## Which issue does this PR close?
Closes #9660.
## What changes are included in this PR?
This PR aims to address following refactorings:
1- Extracts `array_to_string`
dimbtp commented on PR #5528:
URL: https://github.com/apache/arrow-rs/pull/5528#issuecomment-2008663526
It makes sense and thank you for explanation.Ready for another review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
amoeba commented on PR #40610:
URL: https://github.com/apache/arrow/pull/40610#issuecomment-2008638430
Sure! And thanks :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
amoeba commented on code in PR #40022:
URL: https://github.com/apache/arrow/pull/40022#discussion_r1531493577
##
.pre-commit-config.yaml:
##
@@ -36,6 +36,12 @@ repos:
- dockerfile
entry: --entrypoint /bin/hadolint hadolint/hadolint:latest -
exclude: ^
amoeba commented on PR #40022:
URL: https://github.com/apache/arrow/pull/40022#issuecomment-2008636238
Sorry for not doing that before asking for another review @kou. Description
updated. Feedback from the last 24hours has all been addressed as well.
--
This is an automated message from t
av8or1 commented on issue #18014:
URL: https://github.com/apache/arrow/issues/18014#issuecomment-2008634222
@felipecrv OK thank you. Work has been busy. Just now looking at this
again. It appears that @kou has completed the URI parsing business (#40028).
Thus I will prepare on my end to
vibhatha commented on PR #40520:
URL: https://github.com/apache/arrow/pull/40520#issuecomment-2008625780
```bash
nm --version
GNU nm (GNU Binutils for Ubuntu) 2.38
Copyright (C) 2022 Free Software Foundation, Inc.
This program is free software; you may redistribute it under the te
vibhatha commented on PR #40520:
URL: https://github.com/apache/arrow/pull/40520#issuecomment-2008625394
> You can check `w`/`W` symbol type to detect weak symbols.
>
> See also: https://man7.org/linux/man-pages/man1/nm.1.html
>
> (`--no-week` was typo... `--no-weak` is correct.
amoeba commented on code in PR #40022:
URL: https://github.com/apache/arrow/pull/40022#discussion_r1531484072
##
docs/requirements.txt:
##
@@ -10,5 +10,6 @@ pydata-sphinx-theme~=0.14
sphinx-autobuild
sphinx-design
sphinx-copybutton
+sphinx-lint
Review Comment:
We don't ne
amoeba commented on code in PR #40022:
URL: https://github.com/apache/arrow/pull/40022#discussion_r1531483974
##
ci/conda_env_sphinx.txt:
##
@@ -26,6 +26,7 @@ pydata-sphinx-theme=0.14
sphinx-autobuild
sphinx-design
sphinx-copybutton
+sphinx-lint
Review Comment:
I agree. R
amoeba commented on code in PR #40022:
URL: https://github.com/apache/arrow/pull/40022#discussion_r1531482932
##
docs/source/cpp/tutorials/basic_arrow.rst:
##
@@ -141,7 +141,7 @@ Building int16 Arrays
An :class:`ArrayBuilder` has its type specified at the time of declaration.
amoeba commented on code in PR #40022:
URL: https://github.com/apache/arrow/pull/40022#discussion_r1531482765
##
docs/source/cpp/tutorials/basic_arrow.rst:
##
@@ -141,7 +141,7 @@ Building int16 Arrays
An :class:`ArrayBuilder` has its type specified at the time of declaration.
kou commented on PR #40520:
URL: https://github.com/apache/arrow/pull/40520#issuecomment-2008622295
You can check `w`/`W` symbol type to detect weak symbols.
See also: https://man7.org/linux/man-pages/man1/nm.1.html
(`--no-week` was typo... `--no-weak` is correct...)
--
This
amoeba commented on PR #40610:
URL: https://github.com/apache/arrow/pull/40610#issuecomment-2008620548
http://crossbow.voltrondata.com/pr_docs/40610/r/index.html looks good to me.
@kou do you agree? I tested locally too.
--
This is an automated message from the Apache Git Service.
To resp
kou commented on issue #40633:
URL: https://github.com/apache/arrow/issues/40633#issuecomment-2008618938
Could you try installing the `tzdata-legacy` package?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo
paleolimbot commented on issue #40648:
URL: https://github.com/apache/arrow/issues/40648#issuecomment-2008617788
> Does pyarrow.array ever return a ChunkedArray?
```python
import pyarrow as pa
type(pa.array(["a" * 2 ** 20 for _ in range(2**10)]))
#> pyarrow.lib.StringArray
github-actions[bot] commented on PR #40514:
URL: https://github.com/apache/arrow/pull/40514#issuecomment-2008615950
Revision: f5d023a4278b5efec44a88f4d6cea4fcaa724e8f
Submitted crossbow builds: [ursacomputing/crossbow @
actions-16125c3386](https://github.com/ursacomputing/crossbow/bra
vibhatha commented on code in PR #40514:
URL: https://github.com/apache/arrow/pull/40514#discussion_r1531476994
##
dev/tasks/verify-rc/github.linux.amd64.docker.yml:
##
@@ -41,6 +41,7 @@ jobs:
-e VERIFY_RC="{{ rc|default("") }}" \
-e TEST_DEFAULT=0 \
vibhatha commented on PR #40514:
URL: https://github.com/apache/arrow/pull/40514#issuecomment-2008614453
@github-actions crossbow submit -g java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
kou commented on PR #1599:
URL: https://github.com/apache/arrow-adbc/pull/1599#issuecomment-2008613845
> Hmm so from the backtrace_symbols manpage the default output is something
like `./prog(myfunc3+0x5c) [0x80487f0]`. But we can't get the `myfunc3+0x5c` in
the first place because our symb
davlee1972 commented on issue #38750:
URL: https://github.com/apache/arrow/issues/38750#issuecomment-2008610497
I added a bunch here with a DNF function.. “is” and “is not” operators
support is None, is True, is False, is not None, is not True, etc..
https://github.com/apache/arrow/is
vibhatha commented on PR #40520:
URL: https://github.com/apache/arrow/pull/40520#issuecomment-2008609680
Though this is interesting:
https://www.ibm.com/docs/en/aix/7.2?topic=n-nm-command#nm__row-d3e46469
--
This is an automated message from the Apache Git Service.
To respond to the m
vibhatha commented on PR #40520:
URL: https://github.com/apache/arrow/pull/40520#issuecomment-2008605302
> It seems that they are defined as week symbols. So we can ignore them. (It
seems that `nm` has `--no-week` option.)
>
> ```
> ZSTD_trace_compress_begin
> ZSTD_trace_compres
kou commented on issue #40674:
URL: https://github.com/apache/arrow/issues/40674#issuecomment-2008604754
Hmm. It seems that 64-bit integer type provided by GLib (`gint64`) and C++
(`int64_t`) became incompatible...
I'll add explicit casts...
--
This is an automated message from the Apa
kou commented on PR #40520:
URL: https://github.com/apache/arrow/pull/40520#issuecomment-2008597221
It seems that they are defined as week symbols. So we can ignore them. (It
seems that `nm` has `--no-week` option.)
```text
ZSTD_trace_compress_begin
ZSTD_trace_compress_end
ZS
vibhatha commented on PR #40520:
URL: https://github.com/apache/arrow/pull/40520#issuecomment-2008594404
> _ITM_RU1
I agree. In local tests, I don't get these as missing libs though.
```bash
nm -D --format=just-symbols /lib/x86_64-linux-gnu/libstdc++.so.6 | grep _ITM
kou commented on code in PR #40609:
URL: https://github.com/apache/arrow/pull/40609#discussion_r1531464108
##
dev/tasks/python-wheels/github.windows.yml:
##
@@ -56,7 +56,7 @@ jobs:
if errorlevel 1 (
archery docker build --no-pull python-wheel-windows-vs20
github-actions[bot] commented on PR #40520:
URL: https://github.com/apache/arrow/pull/40520#issuecomment-2008591805
Revision: 6df06b2997f4bb0c2527431488af8c15fb29b84a
Submitted crossbow builds: [ursacomputing/crossbow @
actions-e0a3533424](https://github.com/ursacomputing/crossbow/bra
assignUser commented on code in PR #406:
URL: https://github.com/apache/arrow-nanoarrow/pull/406#discussion_r1531449200
##
CMakeLists.txt:
##
@@ -154,13 +154,48 @@ else()
endif()
endif()
- install(TARGETS nanoarrow DESTINATION lib)
+ install(TARGETS nanoarrow
+
kou commented on PR #40520:
URL: https://github.com/apache/arrow/pull/40520#issuecomment-2008591305
It seems that `libstdc++.so` has the following symbols:
```text
getentropy
_ITM_addUserCommitAction
_ITM_memcpyRnWt
_ITM_memcpyRtWn
_ITM_RU1
_ITM_RU8
_ZGTtdlPv
_Z
github-actions[bot] commented on PR #40609:
URL: https://github.com/apache/arrow/pull/40609#issuecomment-2008591152
Revision: 1a2634b37723074f2b1cbb0765666981fb997575
Submitted crossbow builds: [ursacomputing/crossbow @
actions-2e59d7101d](https://github.com/ursacomputing/crossbow/bra
vibhatha commented on PR #40520:
URL: https://github.com/apache/arrow/pull/40520#issuecomment-2008590622
@github-actions crossbow submit java-jars
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
wgtmac commented on PR #40609:
URL: https://github.com/apache/arrow/pull/40609#issuecomment-2008589805
@github-actions crossbow submit wheel-windows*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
kou commented on PR #40520:
URL: https://github.com/apache/arrow/pull/40520#issuecomment-2008589151
You can just submit the `java-jars` job: `@github-actions crossbow submit
java-jars`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
kylebarron commented on issue #40648:
URL: https://github.com/apache/arrow/issues/40648#issuecomment-2008587961
> for me this is like `pyarrow.array()` returning either a `ChunkedArray` or
an `Array`: it just doesn't know until it sees the input what type it needs to
unambiguously represent
wgtmac commented on code in PR #40609:
URL: https://github.com/apache/arrow/pull/40609#discussion_r1531458847
##
dev/tasks/python-wheels/github.windows.yml:
##
@@ -56,7 +56,7 @@ jobs:
if errorlevel 1 (
archery docker build --no-pull python-wheel-windows-v
github-actions[bot] commented on PR #40491:
URL: https://github.com/apache/arrow/pull/40491#issuecomment-2008586846
Revision: b3e2ad2b3de30ae0cbcd4c2d6cf6c5f31e99783b
Submitted crossbow builds: [ursacomputing/crossbow @
actions-75fa8e9099](https://github.com/ursacomputing/crossbow/bra
vibhatha commented on PR #40491:
URL: https://github.com/apache/arrow/pull/40491#issuecomment-2008585573
@github-actions crossbow submit -g java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
github-actions[bot] commented on PR #40683:
URL: https://github.com/apache/arrow/pull/40683#issuecomment-2008584798
Revision: 129c7ea5f27fae5d42e0dab16ab28af6e75d6cb7
Submitted crossbow builds: [ursacomputing/crossbow @
actions-e920eb11b8](https://github.com/ursacomputing/crossbow/bra
kou commented on code in PR #40609:
URL: https://github.com/apache/arrow/pull/40609#discussion_r1531456412
##
dev/tasks/python-wheels/github.windows.yml:
##
@@ -56,7 +56,7 @@ jobs:
if errorlevel 1 (
archery docker build --no-pull python-wheel-windows-vs20
kylebarron commented on issue #40648:
URL: https://github.com/apache/arrow/issues/40648#issuecomment-2008583634
Being able to infer the input structure also significantly helps static
typing. For example, I have type hints that I'm writing for geoarrow-rust that
[include](https://github.com
vibhatha commented on PR #40683:
URL: https://github.com/apache/arrow/pull/40683#issuecomment-2008583496
@github-actions crossbow submit -g java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
vibhatha opened a new pull request, #40683:
URL: https://github.com/apache/arrow/pull/40683
### What changes are included in this PR?
Removing static imports of UTF_8. This has been identified as a minor
enhancement as documented here: https://github.com/apache/arrow/issues/39752
and
kou commented on PR #40650:
URL: https://github.com/apache/arrow/pull/40650#issuecomment-2008578509
@jduo Thanks for taking a look at this. Hmm... It seems that we need to look
into this to fix this...
--
This is an automated message from the Apache Git Service.
To respond to the message,
mapleFU commented on code in PR #40647:
URL: https://github.com/apache/arrow/pull/40647#discussion_r1531452789
##
cpp/src/arrow/memory_pool.h:
##
@@ -35,44 +36,62 @@ namespace internal {
///
// Helper tracking
mapleFU commented on PR #40647:
URL: https://github.com/apache/arrow/pull/40647#issuecomment-2008577611
Which benchmark should I run? I'd like to testing on my M1 Pro
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
kou commented on PR #40650:
URL: https://github.com/apache/arrow/pull/40650#issuecomment-2008577490
> is there a way to locally test this using docker/archery to reproduce if
possible?
You can use `archery docker run -e TEST_DEFAULT=0 TEST_JAVA=1
almalinux-verify-rc`.
--
This is a
kou commented on code in PR #40514:
URL: https://github.com/apache/arrow/pull/40514#discussion_r1531451993
##
dev/tasks/verify-rc/github.linux.amd64.docker.yml:
##
@@ -41,6 +41,7 @@ jobs:
-e VERIFY_RC="{{ rc|default("") }}" \
-e TEST_DEFAULT=0 \
tustvold closed issue #5527: Inconsistency between documentation and code
URL: https://github.com/apache/arrow-rs/issues/5527
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
vibhatha commented on issue #39752:
URL: https://github.com/apache/arrow/issues/39752#issuecomment-2008576432
> I will continue to work on these improvements following up reviews in
#39529
I have missed this unfortunately. Creating a smaller PR to fix this.
--
This is an automated
kou commented on issue #40668:
URL: https://github.com/apache/arrow/issues/40668#issuecomment-2008573695
Issue resolved by pull request 40669
https://github.com/apache/arrow/pull/40669
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
kou merged PR #40669:
URL: https://github.com/apache/arrow/pull/40669
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.or
kou commented on PR #40669:
URL: https://github.com/apache/arrow/pull/40669#issuecomment-2008573484
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mai
paleolimbot commented on code in PR #404:
URL: https://github.com/apache/arrow-nanoarrow/pull/404#discussion_r1531439477
##
src/nanoarrow/nanoarrow.hpp:
##
@@ -548,6 +558,366 @@ class VectorArrayStream {
/// @}
+struct Nothing {};
+constexpr Nothing NA{};
+
+template
+clas
vibhatha commented on issue #40192:
URL: https://github.com/apache/arrow/issues/40192#issuecomment-2008572853
This issue has been resolved: https://github.com/apache/arrow/pull/40662
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Gi
assignUser commented on code in PR #406:
URL: https://github.com/apache/arrow-nanoarrow/pull/406#discussion_r1531445501
##
examples/build_tests/CMakeLists.txt:
##
@@ -0,0 +1,50 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreem
assignUser commented on code in PR #406:
URL: https://github.com/apache/arrow-nanoarrow/pull/406#discussion_r1531445501
##
examples/build_tests/CMakeLists.txt:
##
@@ -0,0 +1,50 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreem
my-vegetable-has-exploded commented on issue #8393:
URL:
https://github.com/apache/arrow-datafusion/issues/8393#issuecomment-2008567024
> So, if i'm not mistaken, this issue is mostly about covering NLJoin in
[join_selection.rs](https://github.com/apache/arrow-datafusion/blob/abb0c1f62bf622
felipecrv commented on code in PR #40647:
URL: https://github.com/apache/arrow/pull/40647#discussion_r1531444973
##
cpp/src/arrow/memory_pool.h:
##
@@ -36,43 +37,58 @@ namespace internal {
// Helper tracking memory statistics
class MemoryPoolStats {
- public:
- MemoryPoolSt
github-actions[bot] commented on PR #40514:
URL: https://github.com/apache/arrow/pull/40514#issuecomment-2008563471
Revision: fb1ecfe568ffd2fb92868bf69374f8ca4092d23d
Submitted crossbow builds: [ursacomputing/crossbow @
actions-3025e0a31d](https://github.com/ursacomputing/crossbow/bra
github-actions[bot] commented on PR #40520:
URL: https://github.com/apache/arrow/pull/40520#issuecomment-2008561750
Revision: f426c9c0daedc8069800a698152306f2b65819fa
Submitted crossbow builds: [ursacomputing/crossbow @
actions-7ddbdef22e](https://github.com/ursacomputing/crossbow/bra
vibhatha commented on code in PR #40514:
URL: https://github.com/apache/arrow/pull/40514#discussion_r1531441941
##
java/dataset/pom.xml:
##
@@ -150,7 +150,7 @@
commons-io
commons-io
- 2.15.1
+ 2.7
Review Comment:
done. a
vibhatha commented on PR #40514:
URL: https://github.com/apache/arrow/pull/40514#issuecomment-2008561990
@github-actions crossbow submit -g java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
felipecrv commented on PR #40647:
URL: https://github.com/apache/arrow/pull/40647#issuecomment-2008561783
I pushed some re-ordering of loads and stores that I believe can work better
on CPUs with higher latency on the memory system [1]. Note that my code updates
`max_memory_` correctly (I r
vibhatha commented on code in PR #40514:
URL: https://github.com/apache/arrow/pull/40514#discussion_r1531441264
##
java/dataset/pom.xml:
##
@@ -150,7 +150,7 @@
commons-io
commons-io
- 2.15.1
+ 2.7
Review Comment:
ah righ
thisisnic merged PR #40651:
URL: https://github.com/apache/arrow/pull/40651
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apa
vibhatha commented on PR #40520:
URL: https://github.com/apache/arrow/pull/40520#issuecomment-2008560273
@github-actions crossbow submit -g java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
ianmcook commented on code in PR #40514:
URL: https://github.com/apache/arrow/pull/40514#discussion_r1531437433
##
java/dataset/pom.xml:
##
@@ -150,7 +150,7 @@
commons-io
commons-io
- 2.15.1
+ 2.7
Review Comment:
Is it n
erratic-pattern commented on PR #40311:
URL: https://github.com/apache/arrow/pull/40311#issuecomment-2008553558
I must have forgotten to commit the protobuf generated code in this branch.
I've run `go generate` locally on [the format
PR](https://github.com/apache/arrow/pull/40243) and commi
assignUser commented on issue #40632:
URL: https://github.com/apache/arrow/issues/40632#issuecomment-2008553215
This looks like arrow installed via brew is found and then there is a mixup
of the headers.
Please try installing again and set the following envvars before you do:
`FORCE_BUND
1 - 100 of 589 matches
Mail list logo
