Re: [PR] GH-41287: [Java] ListViewVector Implementation [arrow]

2024-05-09 Thread via GitHub
lidavidm commented on code in PR #41285: URL: https://github.com/apache/arrow/pull/41285#discussion_r1596337631 ## java/vector/src/main/java/org/apache/arrow/vector/complex/ListViewVector.java: ## @@ -0,0 +1,913 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under o

Re: [PR] GH-41609: [Java] Initialize non empty offset buffer for variable-size layout before exporting [arrow]

2024-05-09 Thread via GitHub
viirya commented on PR #41610: URL: https://github.com/apache/arrow/pull/41610#issuecomment-2103965074 Let me open an issue at arrow-rs and see if it makes more sense to fix it there. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] GH-41609: [Java] Initialize non empty offset buffer for variable-size layout before exporting [arrow]

2024-05-09 Thread via GitHub
viirya commented on PR #41610: URL: https://github.com/apache/arrow/pull/41610#issuecomment-2103964293 Hmm, I think I know why the tests are not failed in Java Arrow. This is how Java Arrow imports an Utf8 array: ``` try (ArrowBuf offsets = importOffsets(type, VarCharVector.OFFSET

Re: [PR] GH-41287: [Java] ListViewVector Implementation [arrow]

2024-05-09 Thread via GitHub
vibhatha commented on code in PR #41285: URL: https://github.com/apache/arrow/pull/41285#discussion_r1596319927 ## java/vector/src/main/java/org/apache/arrow/vector/complex/ListViewVector.java: ## @@ -0,0 +1,913 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under o

Re: [PR] GH-41287: [Java] ListViewVector Implementation [arrow]

2024-05-09 Thread via GitHub
lidavidm commented on code in PR #41285: URL: https://github.com/apache/arrow/pull/41285#discussion_r1596294611 ## java/vector/src/main/java/org/apache/arrow/vector/complex/BaseRepeatedValueViewVector.java: ## @@ -0,0 +1,406 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] GH-41590: [Java] Improve BaseRepeatedValueVector function on isEmpty and isNull operations [arrow]

2024-05-09 Thread via GitHub
conbench-apache-arrow[bot] commented on PR #41601: URL: https://github.com/apache/arrow/pull/41601#issuecomment-2103936011 After merging your PR, Conbench analyzed the 0 benchmarking runs that have been run so far on merge-commit f8d3b10b4b89b47f6e7a594b95c82e2ff161f1a5. None of the s

Re: [PR] Test to repro [arrow]

2024-05-09 Thread via GitHub
zanmato1984 closed pull request #41614: Test to repro URL: https://github.com/apache/arrow/pull/41614 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gi

Re: [PR] Test to repro [arrow]

2024-05-09 Thread via GitHub
zanmato1984 commented on PR #41614: URL: https://github.com/apache/arrow/pull/41614#issuecomment-2103919614 Sorry, filed in the wrong repo. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

Re: [PR] Test to repro [arrow]

2024-05-09 Thread via GitHub
github-actions[bot] commented on PR #41614: URL: https://github.com/apache/arrow/pull/41614#issuecomment-2103918636 Thanks for opening a pull request! If this is not a [minor PR](https://github.com/apache/arrow/blob/main/CONTRIBUTING.md#Minor-Fixes). Could you open an issue f

[PR] Test to repro [arrow]

2024-05-09 Thread via GitHub
zanmato1984 opened a new pull request, #41614: URL: https://github.com/apache/arrow/pull/41614 ### Rationale for this change ### What changes are included in this PR? ### Are these changes tested? ### Are there any user-facing changes?

Re: [I] [Java] Improve `BaseRepeatedValueVector` function on `isEmpty` and `isNull` operations [arrow]

2024-05-09 Thread via GitHub
lidavidm commented on issue #41590: URL: https://github.com/apache/arrow/issues/41590#issuecomment-2103909305 Issue resolved by pull request 41601 https://github.com/apache/arrow/pull/41601 -- This is an automated message from the Apache Git Service. To respond to the message, please lo

Re: [PR] GH-41590: [Java] Improve BaseRepeatedValueVector function on isEmpty and isNull operations [arrow]

2024-05-09 Thread via GitHub
lidavidm merged PR #41601: URL: https://github.com/apache/arrow/pull/41601 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apac

Re: [I] [C++][Python] Sporadic asof join test failure [arrow]

2024-05-09 Thread via GitHub
zanmato1984 commented on issue #40675: URL: https://github.com/apache/arrow/issues/40675#issuecomment-2103879680 This is causing wrong result so I'm adding critical label. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

Re: [I] [C++][Python] Sporadic asof_join failures in PyArrow [arrow]

2024-05-09 Thread via GitHub
zanmato1984 commented on issue #41149: URL: https://github.com/apache/arrow/issues/41149#issuecomment-2103878463 This is causing wrong result so I'm adding critical label. My first label added as a collaborator, please correct me if it's not proper :) -- This is an automated messag

Re: [I] [Java] Implement C Data Interface for StringView [arrow]

2024-05-09 Thread via GitHub
vibhatha commented on issue #40942: URL: https://github.com/apache/arrow/issues/40942#issuecomment-2103818773 That sounds like a plan @urvishdesai I will update here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

Re: [I] [Java] Implement C Data Interface for StringView [arrow]

2024-05-09 Thread via GitHub
urvishdesai commented on issue #40942: URL: https://github.com/apache/arrow/issues/40942#issuecomment-2103812345 @vibhatha Thanks a lot! I think you could work on this faster but I can help with the reviews. Let me know if it will take longer or more work. If so, I can help out! -- This

Re: [I] [Java] Implement C Data Interface for StringView [arrow]

2024-05-09 Thread via GitHub
vibhatha commented on issue #40942: URL: https://github.com/apache/arrow/issues/40942#issuecomment-2103807495 @urvishdesai I started looking into the implementation details. It requires some other helper components. I am going to start working on those components. Once I complete that I wil

Re: [PR] GH-38692: [C#] Implement ICollection on scalar arrays [arrow]

2024-05-09 Thread via GitHub
CurtHagenlocher commented on code in PR #41539: URL: https://github.com/apache/arrow/pull/41539#discussion_r1596200190 ## csharp/src/Apache.Arrow/Arrays/BinaryArray.cs: ## @@ -380,5 +380,40 @@ public ReadOnlySpan GetBytes(int index, out bool isNull) } IEnume

Re: [PR] GH-40944: [Java] Implement TypeEqualsVisitor for StringView [arrow]

2024-05-09 Thread via GitHub
lidavidm commented on PR #41606: URL: https://github.com/apache/arrow/pull/41606#issuecomment-2103774893 This is for type equality... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] WIP: GH-41134: [GLib] Support building arrow-glib with MSVC [arrow]

2024-05-09 Thread via GitHub
kou commented on code in PR #41599: URL: https://github.com/apache/arrow/pull/41599#discussion_r1596198031 ## c_glib/arrow-glib/array-builder.h: ## @@ -22,70 +22,97 @@ #include #include #include +#include G_BEGIN_DECLS #define GARROW_TYPE_ARRAY_BUILDER (garrow_array

Re: [PR] GH-40944: [Java] Implement TypeEqualsVisitor for StringView [arrow]

2024-05-09 Thread via GitHub
vibhatha commented on PR #41606: URL: https://github.com/apache/arrow/pull/41606#issuecomment-2103773164 @lidavidm should we also include a test for `string.length > 12`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

Re: [PR] GH-39858: [C++][Device] Add Copy/View slice functions to MemoryManager [arrow]

2024-05-09 Thread via GitHub
felipecrv commented on code in PR #41477: URL: https://github.com/apache/arrow/pull/41477#discussion_r1596160781 ## cpp/src/arrow/c/bridge.cc: ## @@ -1876,16 +1876,14 @@ struct ArrayImporter { return ImportBuffer(buffer_id, buffer_size); } -// we only need the

Re: [PR] WIP: GH-41134: [GLib] Support building arrow-glib with MSVC [arrow]

2024-05-09 Thread via GitHub
kou commented on code in PR #41599: URL: https://github.com/apache/arrow/pull/41599#discussion_r1596196810 ## c_glib/arrow-glib/array-builder.cpp: ## @@ -231,8 +231,14 @@ garrow_array_builder_append_values(GArrowArrayBuilder *builder, if (n_remains > 0) { ++n_loops;

Re: [PR] WIP: GH-41134: [GLib] Support building arrow-glib with MSVC [arrow]

2024-05-09 Thread via GitHub
adamreeve commented on code in PR #41599: URL: https://github.com/apache/arrow/pull/41599#discussion_r1596194136 ## c_glib/arrow-glib/array-builder.h: ## @@ -22,70 +22,97 @@ #include #include #include +#include G_BEGIN_DECLS #define GARROW_TYPE_ARRAY_BUILDER (garrow

Re: [PR] WIP: GH-41134: [GLib] Support building arrow-glib with MSVC [arrow]

2024-05-09 Thread via GitHub
adamreeve commented on code in PR #41599: URL: https://github.com/apache/arrow/pull/41599#discussion_r1596190266 ## ci/scripts/c_glib_build.sh: ## @@ -35,8 +36,16 @@ export CXXFLAGS="-DARROW_NO_DEPRECATED_API" mkdir -p ${build_dir} +if [ "${BUILD_C_GLIB_WITH_VCPKG}" == "ON"

Re: [PR] WIP: GH-41134: [GLib] Support building arrow-glib with MSVC [arrow]

2024-05-09 Thread via GitHub
adamreeve commented on code in PR #41599: URL: https://github.com/apache/arrow/pull/41599#discussion_r1596189468 ## c_glib/arrow-glib/array-builder.cpp: ## @@ -231,8 +231,14 @@ garrow_array_builder_append_values(GArrowArrayBuilder *builder, if (n_remains > 0) { ++n_loop

Re: [PR] WIP: GH-41134: [GLib] Support building arrow-glib with MSVC [arrow]

2024-05-09 Thread via GitHub
adamreeve commented on code in PR #41599: URL: https://github.com/apache/arrow/pull/41599#discussion_r1596188448 ## .github/workflows/ruby.yml: ## @@ -305,3 +305,96 @@ jobs: $Env:MAKE = "ridk exec make" $ErrorActionPreference = "Continue" rake -f

Re: [PR] WIP: GH-41134: [GLib] Support building arrow-glib with MSVC [arrow]

2024-05-09 Thread via GitHub
adamreeve commented on code in PR #41599: URL: https://github.com/apache/arrow/pull/41599#discussion_r1596186641 ## c_glib/arrow-glib/visibility.h: ## @@ -0,0 +1,56 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements.

Re: [PR] WIP: GH-41134: [GLib] Support building arrow-glib with MSVC [arrow]

2024-05-09 Thread via GitHub
kou commented on code in PR #41599: URL: https://github.com/apache/arrow/pull/41599#discussion_r1596150100 ## c_glib/arrow-glib/visibility.h: ## @@ -0,0 +1,56 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See t

Re: [PR] GH-41609: [Java] Initialize non empty offset buffer for variable-size layout before exporting [arrow]

2024-05-09 Thread via GitHub
viirya commented on PR #41610: URL: https://github.com/apache/arrow/pull/41610#issuecomment-2103732519 Thank you @vibhatha -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] GH-41609: [Java] Initialize non empty offset buffer for variable-size layout before exporting [arrow]

2024-05-09 Thread via GitHub
vibhatha commented on PR #41610: URL: https://github.com/apache/arrow/pull/41610#issuecomment-2103731271 Thanks for explaining @viirya . If you need help please let me know. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] GH-40944: [Java] Implement TypeEqualsVisitor for StringView [arrow]

2024-05-09 Thread via GitHub
vibhatha commented on PR #41606: URL: https://github.com/apache/arrow/pull/41606#issuecomment-2103729300 @lidavidm could you please help to run the workflows? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

Re: [PR] GH-40944: [Java] Implement TypeEqualsVisitor for StringView [arrow]

2024-05-09 Thread via GitHub
vibhatha commented on PR #41606: URL: https://github.com/apache/arrow/pull/41606#issuecomment-2103728831 @tlm365 thanks for working on this PR. I will take a look today. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] GH-41609: [Java] Initialize non empty offset buffer for variable-size layout before exporting [arrow]

2024-05-09 Thread via GitHub
viirya commented on PR #41610: URL: https://github.com/apache/arrow/pull/41610#issuecomment-2103720979 @vibhatha I have some fix locally but I am unable to run the C module tests locally on a Mac. I am trying to write these tests that are supposed to fail in CI to verify that. Once t

Re: [PR] feat(csharp): Initial changes for ADBC 1.1 in C# implementation [arrow-adbc]

2024-05-09 Thread via GitHub
CurtHagenlocher merged PR #1821: URL: https://github.com/apache/arrow-adbc/pull/1821 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@

Re: [PR] GH-41609: [Java] Initialize non empty offset buffer for variable-size layout before exporting [arrow]

2024-05-09 Thread via GitHub
vibhatha commented on PR #41610: URL: https://github.com/apache/arrow/pull/41610#issuecomment-2103710811 @viirya just to make sure I understand the change here. Are we introducing the required change in this PR itself right? And these test cases supposed to fail without that fix? -

Re: [PR] GH-41529: [C++][Compute] Remove redundant logic for ArrayData as ExecResults in ExecScalarCaseWhen [arrow]

2024-05-09 Thread via GitHub
conbench-apache-arrow[bot] commented on PR #41380: URL: https://github.com/apache/arrow/pull/41380#issuecomment-2103706997 After merging your PR, Conbench analyzed the 0 benchmarking runs that have been run so far on merge-commit 5255adc5139d6094a7b3b04f273f3ef11d49ec38. None of the s

Re: [I] [C++][Compute] Redundant logic for ArrayData as ExecResults in ExecScalarCaseWhen [arrow]

2024-05-09 Thread via GitHub
felipecrv commented on issue #41529: URL: https://github.com/apache/arrow/issues/41529#issuecomment-2103686257 Issue resolved by pull request 41380 https://github.com/apache/arrow/pull/41380 -- This is an automated message from the Apache Git Service. To respond to the message, please l

Re: [PR] GH-41529: [C++][Compute] Remove redundant logic for ArrayData as ExecResults in ExecScalarCaseWhen [arrow]

2024-05-09 Thread via GitHub
felipecrv merged PR #41380: URL: https://github.com/apache/arrow/pull/41380 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apa

Re: [I] [C++][Gandiva] Test failures in Gandiva DateTimeTestProjector test (gandiva-projector-test) [arrow]

2024-05-09 Thread via GitHub
amoeba commented on issue #41605: URL: https://github.com/apache/arrow/issues/41605#issuecomment-2103669918 That makes sense. I think this has type of issue has come up before but I'm not finding anything. It doesn't seem like any of these tests are specifically to test summer time so I thi

Re: [I] [Format] Should there be a copy of adbc.h in the Arrow repository [arrow]

2024-05-09 Thread via GitHub
lidavidm commented on issue #41607: URL: https://github.com/apache/arrow/issues/41607#issuecomment-2103669214 I'd rather remove the copy here since it's just going to get out of sync -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

Re: [I] [Java] Implement C Data Interface for StringView [arrow]

2024-05-09 Thread via GitHub
vibhatha commented on issue #40942: URL: https://github.com/apache/arrow/issues/40942#issuecomment-2103667747 @urvishdesai I will be picking up this task earlier next week. But if you're interested in working, please go ahead I can help out with reviews. -- This is an automated m

Re: [PR] GH-41590: [Java] Improve BaseRepeatedValueVector function on isEmpty and isNull operations [arrow]

2024-05-09 Thread via GitHub
vibhatha commented on code in PR #41601: URL: https://github.com/apache/arrow/pull/41601#discussion_r1596136078 ## java/vector/src/main/java/org/apache/arrow/vector/complex/BaseRepeatedValueVector.java: ## @@ -355,16 +355,12 @@ public int getInnerValueCountAt(int index) {

Re: [I] [Java] Implement C Data Interface for StringView [arrow]

2024-05-09 Thread via GitHub
vibhatha commented on issue #40942: URL: https://github.com/apache/arrow/issues/40942#issuecomment-2103664815 @urvishdesai yes, this one is planned to be done sooner. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

Re: [PR] GH-41478: [C++] Clean up more redundant move warnings [arrow]

2024-05-09 Thread via GitHub
github-actions[bot] commented on PR #41487: URL: https://github.com/apache/arrow/pull/41487#issuecomment-2103662659 Revision: 35addce8c4495be9eb068badac6c67a6280f4966 Submitted crossbow builds: [ursacomputing/crossbow @ actions-1322e4442f](https://github.com/ursacomputing/crossbow/bra

Re: [PR] GH-41478: [C++] Clean up more redundant move warnings [arrow]

2024-05-09 Thread via GitHub
kou commented on PR #41487: URL: https://github.com/apache/arrow/pull/41487#issuecomment-2103661008 @github-actions crossbow submit -g cpp -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

Re: [I] [Format] Should there be a copy of adbc.h in the Arrow repository [arrow]

2024-05-09 Thread via GitHub
kou commented on issue #41607: URL: https://github.com/apache/arrow/issues/41607#issuecomment-2103660128 @lidavidm What do you think about this? BTW, we should backport #38953 to apache/arrow-adbc. -- This is an automated message from the Apache Git Service. To respond to the messag

Re: [I] [C++][Gandiva] Test failures in Gandiva DateTimeTestProjector test (gandiva-projector-test) [arrow]

2024-05-09 Thread via GitHub
kou commented on issue #41605: URL: https://github.com/apache/arrow/issues/41605#issuecomment-2103637549 It seems that it's related to summer time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] feat(csharp/src/Drivers/Apache): add implementation for AdbcStatement.SetOption on Spark driver [arrow-adbc]

2024-05-09 Thread via GitHub
birschick-bq commented on code in PR #1849: URL: https://github.com/apache/arrow-adbc/pull/1849#discussion_r1596113152 ## csharp/src/Drivers/Apache/Hive2/HiveServer2Statement.cs: ## @@ -123,9 +138,23 @@ protected async ValueTask GetSchemaAsync() return SchemaParser.

Re: [PR] feat(csharp/src/Drivers/Apache): add implementation for AdbcStatement.SetOption on Spark driver [arrow-adbc]

2024-05-09 Thread via GitHub
birschick-bq commented on code in PR #1849: URL: https://github.com/apache/arrow-adbc/pull/1849#discussion_r1596112643 ## csharp/src/Drivers/Apache/Hive2/HiveServer2Statement.cs: ## @@ -123,9 +138,23 @@ protected async ValueTask GetSchemaAsync() return SchemaParser.

Re: [PR] feat(csharp/src/Drivers/Apache): add implementation for AdbcStatement.SetOption on Spark driver [arrow-adbc]

2024-05-09 Thread via GitHub
birschick-bq commented on code in PR #1849: URL: https://github.com/apache/arrow-adbc/pull/1849#discussion_r1596112643 ## csharp/src/Drivers/Apache/Hive2/HiveServer2Statement.cs: ## @@ -123,9 +138,23 @@ protected async ValueTask GetSchemaAsync() return SchemaParser.

[PR] feat(csharp/src/Drivers/Apache): add implementation for AdbcStatement.SetOption on Spark driver [arrow-adbc]

2024-05-09 Thread via GitHub
birschick-bq opened a new pull request, #1849: URL: https://github.com/apache/arrow-adbc/pull/1849 Implement AdbcStatement.SetOption on Spark driver * `"adbc.statement.polltime_milliseconds"` -> sets the poll time to check for results to execute a statement. * `"adbc.statement.batch_si

Re: [I] [Java] Implement C Data Interface for StringView [arrow]

2024-05-09 Thread via GitHub
urvishdesai commented on issue #40942: URL: https://github.com/apache/arrow/issues/40942#issuecomment-2103617642 Hi, @vibhatha I have been following this PR. Is this task on C ABI support being worked upon currently? -- This is an automated message from the Apache Git Service. To respond

Re: [PR] GH-41262: [Java][FlightSQL] Implement stateless prepared statements [arrow]

2024-05-09 Thread via GitHub
stevelorddremio commented on PR #41237: URL: https://github.com/apache/arrow/pull/41237#issuecomment-2103611469 Thank you @mateuszrzeszutek. I have merged your changes to my PR. That looks to successfully run. On Wed, May 8, 2024 at 9:48 AM Mateusz Rzeszutek ***@***.***> wrote:

Re: [I] go/adbc/driver/snowflake+flightsql: Memory access violation when both are used in Python [arrow-adbc]

2024-05-09 Thread via GitHub
lidavidm commented on issue #1841: URL: https://github.com/apache/arrow-adbc/issues/1841#issuecomment-2103611932 ``` runtime.throw({0x18223ac23?, 0x1c061a0?}) /Users/runner/hostedtoolcache/go/1.21.8/x64/src/runtime/panic.go:1077 +0x5c fp=0x1c00069be88 sp=0x1c00069be58 pc=0x180

Re: [PR] GH-41590: [Java] Improve BaseRepeatedValueVector function on isEmpty and isNull operations [arrow]

2024-05-09 Thread via GitHub
lidavidm commented on code in PR #41601: URL: https://github.com/apache/arrow/pull/41601#discussion_r1596098246 ## java/vector/src/main/java/org/apache/arrow/vector/complex/BaseRepeatedValueVector.java: ## @@ -355,16 +355,12 @@ public int getInnerValueCountAt(int index) {

[PR] GH-41611: [Docs][CI] Enable more sphinx-lint rules for documentation [arrow]

2024-05-09 Thread via GitHub
amoeba opened a new pull request, #41612: URL: https://github.com/apache/arrow/pull/41612 ### Rationale for this change https://github.com/apache/arrow/issues/41611 ### What changes are included in this PR? - Update to pre-commit config - Associated fix docs ###

Re: [I] [Docs][CI] Enable more sphinx-lint rules for documentation [arrow]

2024-05-09 Thread via GitHub
amoeba commented on issue #41611: URL: https://github.com/apache/arrow/issues/41611#issuecomment-2103592192 The current docs violates just six of the 22 sphinx-lint rules. Of these, most are useful and catch real issues. For each, I've noted which I think we should and shouldn't enable:

Re: [PR] GH-39990: [Docs][CI] Add sphinx-lint for docs linting [arrow]

2024-05-09 Thread via GitHub
amoeba commented on PR #40022: URL: https://github.com/apache/arrow/pull/40022#issuecomment-2103578791 Good reminder, thanks @jorisvandenbossche. I think quite a few would be good to add. I've filed https://github.com/apache/arrow/issues/41611 for that work. -- This is an automated messag

Re: [PR] GH-41478: [C++] Clean up more redundant move warnings [arrow]

2024-05-09 Thread via GitHub
github-actions[bot] commented on PR #41487: URL: https://github.com/apache/arrow/pull/41487#issuecomment-2103567631 ``` Only contributors can submit requests to this bot. Please ask someone from the community for help with getting the first commit in. The Archery job run can be found a

Re: [PR] GH-41478: [C++] Clean up more redundant move warnings [arrow]

2024-05-09 Thread via GitHub
WillAyd commented on PR #41487: URL: https://github.com/apache/arrow/pull/41487#issuecomment-2103567169 @github-actions crossbow submit -g cpp -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] GH-41609: [Java] Initialize non empty offset buffer for variable-size layout before exporting [arrow]

2024-05-09 Thread via GitHub
viirya commented on PR #41610: URL: https://github.com/apache/arrow/pull/41610#issuecomment-2103481591 Marked it as a draft and will make it ready for review once I submit the fix. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[PR] GH-41609: [Java] Initialize non empty offset buffer for variable-size layout before exporting [arrow]

2024-05-09 Thread via GitHub
viirya opened a new pull request, #41610: URL: https://github.com/apache/arrow/pull/41610 ### Rationale for this change This is a follow up of https://github.com/apache/arrow/issues/40038. In https://github.com/apache/arrow/issues/40038, we fixed null offset buffer iss

Re: [I] A model for I/O utilization? [arrow-adbc]

2024-05-09 Thread via GitHub
CurtHagenlocher commented on issue #1848: URL: https://github.com/apache/arrow-adbc/issues/1848#issuecomment-2103470898 I guess in addition to setting the current catalog and schema, the other obvious candidate for a standard option that immediately changes server state would be autocommit.

[PR] fix: parse string to decimal when scale is 0 [arrow-rs]

2024-05-09 Thread via GitHub
yjshen opened a new pull request, #5740: URL: https://github.com/apache/arrow-rs/pull/5740 # Which issue does this PR close? Closes #5739. # Rationale for this change Unable to parse scientific notation string when the scale is 0. ```rust parse_deci

[I] Unable to parse scientific notation string to decimal when scale is 0 [arrow-rs]

2024-05-09 Thread via GitHub
yjshen opened a new issue, #5739: URL: https://github.com/apache/arrow-rs/issues/5739 **To Reproduce** ```rust fn main() -> Result<()> { parse_decimal::("1.234e16", 20, 0).unwrap(); Ok(()) } ``` **Expected behavior** Parse the string successfull

Re: [PR] feat(csharp): Initial changes for ADBC 1.1 in C# implementation [arrow-adbc]

2024-05-09 Thread via GitHub
CurtHagenlocher commented on PR #1821: URL: https://github.com/apache/arrow-adbc/pull/1821#issuecomment-2103424427 If we want to pass all the initial options in at once when we construct something, then they kind of have to be represented as "object". Post construction, it might be justifie

Re: [PR] feat(csharp): Initial changes for ADBC 1.1 in C# implementation [arrow-adbc]

2024-05-09 Thread via GitHub
davidhcoe commented on PR #1821: URL: https://github.com/apache/arrow-adbc/pull/1821#issuecomment-2103408709 Overall, this is a good step toward a 1.1 implementation. I am not sure how we got the BulkIngest method in AdbcConnection, since the spec doesn't define that, but Java has it too, s

Re: [I] A model for I/O utilization? [arrow-adbc]

2024-05-09 Thread via GitHub
zeroshade commented on issue #1848: URL: https://github.com/apache/arrow-adbc/issues/1848#issuecomment-2103404654 > But I don't know that we should make a strong statement about the behavior of something like `AdbcConnectionSetOption(ADBC_CONNECTION_OPTION_CURRENT_CATALOG, "catalogName")';

[PR] feat(r): Add experimental `nanoarrow_vctr` to wrap a list of arrays [arrow-nanoarrow]

2024-05-09 Thread via GitHub
paleolimbot opened a new pull request, #461: URL: https://github.com/apache/arrow-nanoarrow/pull/461 Work in progress! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] GH-41179: [Docs] Documentation for Dissociated IPC Protocol [arrow]

2024-05-09 Thread via GitHub
conbench-apache-arrow[bot] commented on PR #41180: URL: https://github.com/apache/arrow/pull/41180#issuecomment-2103331658 After merging your PR, Conbench analyzed the 0 benchmarking runs that have been run so far on merge-commit 1c62df5255ced89171d5b846dc82f5a10d519f4a. None of the s

Re: [PR] GH-39645: [Python] Fix read_table for encrypted parquet [arrow]

2024-05-09 Thread via GitHub
conbench-apache-arrow[bot] commented on PR #39438: URL: https://github.com/apache/arrow/pull/39438#issuecomment-2103302645 After merging your PR, Conbench analyzed the 0 benchmarking runs that have been run so far on merge-commit bd444106af494b3d4c6cce0af88f6ce2a6a327eb. None of the s

Re: [PR] GH-41179: [Docs] Documentation for Dissociated IPC Protocol [arrow]

2024-05-09 Thread via GitHub
zeroshade merged PR #41180: URL: https://github.com/apache/arrow/pull/41180 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apa

Re: [PR] GH-39645: [Python] Fix read_table for encrypted parquet [arrow]

2024-05-09 Thread via GitHub
rok merged PR #39438: URL: https://github.com/apache/arrow/pull/39438 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.or

Re: [PR] GH-40944: [Java] Implement TypeEqualsVisitor for StringView [arrow]

2024-05-09 Thread via GitHub
github-actions[bot] commented on PR #41606: URL: https://github.com/apache/arrow/pull/41606#issuecomment-2103246831 :warning: GitHub issue #40944 **has been automatically assigned in GitHub** to PR creator. -- This is an automated message from the Apache Git Service. To respond to the mes

[PR] GH-40944: [Java] Implement TypeEqualsVisitor for StringView [arrow]

2024-05-09 Thread via GitHub
tlm365 opened a new pull request, #41606: URL: https://github.com/apache/arrow/pull/41606 ### Rationale for this change Resolves #40944 . ### What changes are included in this PR? ### Are these changes tested? Yes. ### Are there any user-faci

Re: [PR] feat(rust): add the driver manager [arrow-adbc]

2024-05-09 Thread via GitHub
alexandreyc commented on PR #1803: URL: https://github.com/apache/arrow-adbc/pull/1803#issuecomment-2103235975 > CI LGTM, though, maybe we should think about refactoring things at some point (since not all the jobs in native-unix/native-windows need to run for Rust-only changes). Though, it

Re: [PR] GH-41502: [Python] Fix reading column index with decimal values [arrow]

2024-05-09 Thread via GitHub
jrversteegh commented on PR #41503: URL: https://github.com/apache/arrow/pull/41503#issuecomment-2103127207 @AlenkaF @jorisvandenbossche I've added a test and restored the decimal index from strings. This looks like a bit of a kludge. I think it's because both numpy and pandas don't unders

Re: [PR] GH-41590: [Java] Improve BaseRepeatedValueVector function on isEmpty and isNull operations [arrow]

2024-05-09 Thread via GitHub
github-actions[bot] commented on PR #41601: URL: https://github.com/apache/arrow/pull/41601#issuecomment-2103062816 :warning: GitHub issue #41590 **has been automatically assigned in GitHub** to PR creator. -- This is an automated message from the Apache Git Service. To respond to the mes

Re: [I] proposal: Make AsyncArrowWriter accepts AsyncFileWriter trait instead [arrow-rs]

2024-05-09 Thread via GitHub
Xuanwo commented on issue #5738: URL: https://github.com/apache/arrow-rs/issues/5738#issuecomment-2103057623 > I think this would be a very nice addition, and would tie in well with the new object_store vectored write APIs such as https://docs.rs/object_store/latest/object_store/struct.Writ

Re: [I] csharp/src/Drivers/Apache: data types should be returned as-is instead of being converted [arrow-adbc]

2024-05-09 Thread via GitHub
CurtHagenlocher commented on issue #1727: URL: https://github.com/apache/arrow-adbc/issues/1727#issuecomment-2103006499 I think what would need to happen to make this work is not to return until we've read the first Arrow batch and to take the schema from that instead of the Thrift-based me

Re: [I] csharp/src/Drivers/Apache: data types should be returned as-is instead of being converted [arrow-adbc]

2024-05-09 Thread via GitHub
birschick-bq commented on issue #1727: URL: https://github.com/apache/arrow-adbc/issues/1727#issuecomment-2102990754 @CurtHagenlocher - So initially, this option was set. Unfortunately, the server did not return enough metadata for us to reconstruct the data structure to dereference the buf

Re: [PR] Document planned release cadence for arrow/parquet/etc [arrow-rs]

2024-05-09 Thread via GitHub
tustvold commented on code in PR #5737: URL: https://github.com/apache/arrow-rs/pull/5737#discussion_r1595676959 ## README.md: ## @@ -34,7 +34,33 @@ This repo contains the following main components: The current development version the API documentation in this repo can be fo

Re: [PR] Document planned release cadence for arrow/parquet/etc [arrow-rs]

2024-05-09 Thread via GitHub
tustvold commented on PR #5737: URL: https://github.com/apache/arrow-rs/pull/5737#issuecomment-2102982661 > Do we have a plan to object_store? I'm guessing a breaking change to object_store could also affect parquet? Nothing formal, but a natural implication of this would be that if w

Re: [I] [C#] Tests fail on MacOS arm64 with a stack overflow [arrow]

2024-05-09 Thread via GitHub
CurtHagenlocher commented on issue #41397: URL: https://github.com/apache/arrow/issues/41397#issuecomment-2102979570 I'm still seeing this both in PR builds and locally so I'm reopening. See #41603 for a recent PR build that exhibits this problem. -- This is an automated message from the

Re: [I] proposal: Make AsyncArrowWriter accepts AsyncFileWriter trait instead [arrow-rs]

2024-05-09 Thread via GitHub
tustvold commented on issue #5738: URL: https://github.com/apache/arrow-rs/issues/5738#issuecomment-2102979602 I think this would be a very nice addition, and would tie in well with the new object_store vectored write APIs such as https://docs.rs/object_store/latest/object_store/struct.Writ

[PR] GH-41602: [C#] Eliminate compiler warnings [arrow]

2024-05-09 Thread via GitHub
CurtHagenlocher opened a new pull request, #41603: URL: https://github.com/apache/arrow/pull/41603 ### What changes are included in this PR? Annotations required to eliminate compiler warnings during build. ### Are these changes tested? The existing test suite covers all

Re: [PR] GH-41190: [C++] support for single threaded joins [arrow]

2024-05-09 Thread via GitHub
joemarshall commented on PR #41125: URL: https://github.com/apache/arrow/pull/41125#issuecomment-2102888582 And did the same in sorted merge. There are some weird errors in python asof join on some platforms (e.g. mac ), which seem to happen in the main build also. I don't think I bro

Re: [I] go/adbc/driver/snowflake+flightsql: Memory access violation when both are used in Python [arrow-adbc]

2024-05-09 Thread via GitHub
cocoa-xu commented on issue #1841: URL: https://github.com/apache/arrow-adbc/issues/1841#issuecomment-2102881122 > @cocoa-xu this will also affect BigQuery...it seems both C++ and Go have packaging issues here... So I tried the following code on my x86_64 macOS and it will have the sa

[I] proposal: Make AsyncArrowWriter accepts AsyncFileWriter trait instead [arrow-rs]

2024-05-09 Thread via GitHub
Xuanwo opened a new issue, #5738: URL: https://github.com/apache/arrow-rs/issues/5738 This proposal intends to make `AsyncArrowWriter` accepts a new trait called `AsyncFileWriter` instead like what we do for `ParquetRecordBatchStream`. `AsyncArrowWriter` accepts `AsyncWrite` currently

Re: [I] Add `gc`garbage collector support for `StringViewArray` and `BinaryViewArray` [arrow-rs]

2024-05-09 Thread via GitHub
alamb commented on issue #5513: URL: https://github.com/apache/arrow-rs/issues/5513#issuecomment-2102825827 Another potential idea came up in discord today which was to also implement some way of "interning" strings (aka track which strings have been seen before and remove duplicates)

Re: [I] Stateless prepared statements wrap `DoPutPreparedStatementResult` with `Any` which is differs from Go implementation [arrow-rs]

2024-05-09 Thread via GitHub
alamb commented on issue #5731: URL: https://github.com/apache/arrow-rs/issues/5731#issuecomment-2102820255 I think we should follow the Go implementation as they are likely to have a better understanding of what is correct in protobuf Any clients can wrap the ticket in Any if they wa

Re: [PR] GH-39645: [Python] Fix read_table for encrypted parquet [arrow]

2024-05-09 Thread via GitHub
rok commented on code in PR #39438: URL: https://github.com/apache/arrow/pull/39438#discussion_r1595561059 ## python/pyarrow/_dataset_parquet.pyx: ## @@ -715,6 +714,9 @@ cdef class ParquetFragmentScanOptions(FragmentScanOptions): decryption_config : pyarrow.dataset.ParquetD

Re: [I] Stateless prepared statements wrap `DoPutPreparedStatementResult` with `Any` which is differs from Go implementation [arrow-rs]

2024-05-09 Thread via GitHub
alamb commented on issue #5731: URL: https://github.com/apache/arrow-rs/issues/5731#issuecomment-2102818715 cc @erratic-pattern -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

Re: [PR] GH-39645: [Python] Fix read_table for encrypted parquet [arrow]

2024-05-09 Thread via GitHub
rok commented on code in PR #39438: URL: https://github.com/apache/arrow/pull/39438#discussion_r1595554926 ## python/pyarrow/_dataset_parquet.pyx: ## @@ -715,6 +714,9 @@ cdef class ParquetFragmentScanOptions(FragmentScanOptions): decryption_config : pyarrow.dataset.ParquetD

Re: [I] go/adbc/driver/snowflake+flightsql: Memory access violation when both are used in Python [arrow-adbc]

2024-05-09 Thread via GitHub
cocoa-xu commented on issue #1841: URL: https://github.com/apache/arrow-adbc/issues/1841#issuecomment-2102807656 > @cocoa-xu this will also affect BigQuery...it seems both C++ and Go have packaging issues here... It appears to be so... I have an x86_64 macOS so please let me kn

Re: [I] go/adbc/driver/snowflake+flightsql: Memory access violation when both are used in Python [arrow-adbc]

2024-05-09 Thread via GitHub
paleolimbot commented on issue #1841: URL: https://github.com/apache/arrow-adbc/issues/1841#issuecomment-2102795356 Sure! The non-lldbd backtrace from the R snippet above is: ``` fatal error: unexpected signal during runtime execution [signal SIGSEGV: segmentation

Re: [PR] Document planned release cadence for arrow/parquet/etc [arrow-rs]

2024-05-09 Thread via GitHub
Xuanwo commented on PR #5737: URL: https://github.com/apache/arrow-rs/pull/5737#issuecomment-2102788926 Do we have a plan to object_store? I'm guessing a breaking change to `object_store` could also affect parquet? -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] GH-39645: [Python] Fix read_table for encrypted parquet [arrow]

2024-05-09 Thread via GitHub
wgtmac commented on code in PR #39438: URL: https://github.com/apache/arrow/pull/39438#discussion_r1595533630 ## python/pyarrow/_dataset_parquet.pyx: ## @@ -715,6 +714,9 @@ cdef class ParquetFragmentScanOptions(FragmentScanOptions): decryption_config : pyarrow.dataset.Parqu

Re: [I] go/adbc/driver/snowflake+flightsql: Memory access violation when both are used in Python [arrow-adbc]

2024-05-09 Thread via GitHub
lidavidm commented on issue #1841: URL: https://github.com/apache/arrow-adbc/issues/1841#issuecomment-2102764177 I wonder, are you able to get a backtrace from lldb? Under rosetta it appears the Go runtime fails to initialize entirely (it appears to get stuck holding a lock) so I wasn't abl

  1   2   >