Re: [PR] MINOR: [Java] Bump org.apache.maven.plugins:maven-dependency-plugin from 3.1.2 to 3.6.1 (manual update) [arrow]

2024-06-03 Thread via GitHub
vibhatha commented on PR #40149: URL: https://github.com/apache/arrow/pull/40149#issuecomment-2146700383 Closing this PR in favor of a waiting for a suitable plugin version update. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

Re: [PR] MINOR: [Java] Bump org.apache.maven.plugins:maven-dependency-plugin from 3.1.2 to 3.6.1 (manual update) [arrow]

2024-06-03 Thread via GitHub
vibhatha closed pull request #40149: MINOR: [Java] Bump org.apache.maven.plugins:maven-dependency-plugin from 3.1.2 to 3.6.1 (manual update) URL: https://github.com/apache/arrow/pull/40149 -- This is an automated message from the Apache Git Service. To respond to the message, please log on t

Re: [PR] MINOR: [Java] Bump org.apache.maven.plugins:maven-dependency-plugin from 3.1.2 to 3.6.1 (manual update) [arrow]

2024-06-03 Thread via GitHub
vibhatha commented on code in PR #40149: URL: https://github.com/apache/arrow/pull/40149#discussion_r1625412137 ## java/tools/pom.xml: ## @@ -57,10 +57,12 @@ com.fasterxml.jackson.core jackson-core + test Review Comment: Sure. I will close this one.

Re: [PR] MINOR: [Java] Bump org.apache.maven.plugins:maven-dependency-plugin from 3.1.2 to 3.6.1 (manual update) [arrow]

2024-06-03 Thread via GitHub
lidavidm commented on code in PR #40149: URL: https://github.com/apache/arrow/pull/40149#discussion_r1625410970 ## java/tools/pom.xml: ## @@ -57,10 +57,12 @@ com.fasterxml.jackson.core jackson-core + test Review Comment: We can just ignore this versi

Re: [PR] s3 region: Enable buckets that contain periods in their name for fetc… [arrow-rs]

2024-06-03 Thread via GitHub
garyhuntddn commented on PR #5747: URL: https://github.com/apache/arrow-rs/pull/5747#issuecomment-2146677677 Just a thought - I note you’ve included a trailing / in the revised endpoint url. If I’m reading [sdk/aws-smithy-runtime/src/client/endpoint.rs](https://github.com/awslabs/aws

Re: [PR] GH-40819: [Java] Adding Spotless to Algorithm module [arrow]

2024-06-03 Thread via GitHub
github-actions[bot] commented on PR #41825: URL: https://github.com/apache/arrow/pull/41825#issuecomment-2146669232 Revision: 64dc87d121eb175db2a0882886edfb203b51a760 Submitted crossbow builds: [ursacomputing/crossbow @ actions-447b788d04](https://github.com/ursacomputing/crossbow/bra

Re: [PR] GH-40819: [Java] Adding Spotless to Algorithm module [arrow]

2024-06-03 Thread via GitHub
vibhatha commented on PR #41825: URL: https://github.com/apache/arrow/pull/41825#issuecomment-214366 @github-actions crossbow submit -g java -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

Re: [PR] MINOR: [Java] Bump org.apache.maven.plugins:maven-dependency-plugin from 3.1.2 to 3.6.1 (manual update) [arrow]

2024-06-03 Thread via GitHub
vibhatha commented on code in PR #40149: URL: https://github.com/apache/arrow/pull/40149#discussion_r1625383156 ## java/tools/pom.xml: ## @@ -57,10 +57,12 @@ com.fasterxml.jackson.core jackson-core + test Review Comment: Similar issue mentioned here:

Re: [PR] MINOR: [Java] Bump org.apache.maven.plugins:maven-dependency-plugin from 3.1.2 to 3.6.1 (manual update) [arrow]

2024-06-03 Thread via GitHub
vibhatha commented on code in PR #40149: URL: https://github.com/apache/arrow/pull/40149#discussion_r1625367621 ## java/tools/pom.xml: ## @@ -57,10 +57,12 @@ com.fasterxml.jackson.core jackson-core + test Review Comment: At least for this module they

Re: [PR] GH-41608: [C++][Python] Extends the add_key_value to parquet::arrow and PyArrow [arrow]

2024-06-03 Thread via GitHub
mapleFU commented on PR #41633: URL: https://github.com/apache/arrow/pull/41633#issuecomment-2146634851 @AlenkaF @jorisvandenbossche @pitrou Would you mind take a look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

Re: [PR] MINOR: [JS] Bump @typescript-eslint/parser from 7.11.0 to 7.12.0 in /js [arrow]

2024-06-03 Thread via GitHub
kou merged PR #41949: URL: https://github.com/apache/arrow/pull/41949 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.or

Re: [PR] MINOR: [JS] Bump @types/node from 20.13.0 to 20.14.1 in /js [arrow]

2024-06-03 Thread via GitHub
kou merged PR #41948: URL: https://github.com/apache/arrow/pull/41948 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.or

Re: [PR] GH-41867: [Java] Parallel to build JNI C++ code [arrow]

2024-06-03 Thread via GitHub
vibhatha commented on PR #41868: URL: https://github.com/apache/arrow/pull/41868#issuecomment-2146615093 > Sorry that should be [`CMAKE_BUILD_PARALLEL_LEVEL`](https://cmake.org/cmake/help/latest/envvar/CMAKE_BUILD_PARALLEL_LEVEL.html) I haven't actually checked this. @jinchengchenghh

Re: [PR] GH-41923: [C++] Maybe fix ExecuteScalar with chunked_array [arrow]

2024-06-03 Thread via GitHub
mapleFU commented on PR #41925: URL: https://github.com/apache/arrow/pull/41925#issuecomment-2146606801 cc @felipecrv @bkietz The problem is desc in the issue here, would you mind take a look https://github.com/apache/arrow/issues/41923 -- This is an automated message from the Apache Git

Re: [PR] GH-41608: [C++][Python] Extends the add_key_value to parquet::arrow and PyArrow [arrow]

2024-06-03 Thread via GitHub
mapleFU commented on code in PR #41633: URL: https://github.com/apache/arrow/pull/41633#discussion_r1625337628 ## cpp/src/parquet/type_fwd.h: ## @@ -78,9 +78,7 @@ class ReaderProperties; class ArrowReaderProperties; class WriterProperties; -class WriterPropertiesBuilder; Re

Re: [PR] GH-41719: [C++][Parquet] Cannot read encrypted parquet datasets via _metadata file [arrow]

2024-06-03 Thread via GitHub
ggershinsky commented on PR #41821: URL: https://github.com/apache/arrow/pull/41821#issuecomment-2146591031 > Perhaps I am wrong, but I assumed that metadata collector collected metadata that was already encrypted, and the issue mostly stems from the fact that when we write out metadata fil

Re: [I] [Python][Docs] `RecordBatch.from_pydict()` and `RecordBatch.from_pylist()` example code references `pa.Table` instead of `pa.RecordBatch` [arrow]

2024-06-03 Thread via GitHub
AlenkaF commented on issue #41907: URL: https://github.com/apache/arrow/issues/41907#issuecomment-2146585215 We use Sphinx but I do not think Sphinx conditionals will work for code docstrings. -- This is an automated message from the Apache Git Service. To respond to the message, please l

Re: [PR] GH-41719: [C++][Parquet] Cannot read encrypted parquet datasets via _metadata file [arrow]

2024-06-03 Thread via GitHub
ggershinsky commented on PR #41821: URL: https://github.com/apache/arrow/pull/41821#issuecomment-2146577953 > > ~ a billion crypto operations (meaning a billion parquet pages) > > Out of curiosity, what is the underlying cause? The AES GCM math - when an attacker has 2^32 blocks

Re: [PR] GH-40964: [CI][Archery] Archery linking should also check for undefined symbols Linux [arrow]

2024-06-03 Thread via GitHub
vibhatha commented on PR #40520: URL: https://github.com/apache/arrow/pull/40520#issuecomment-2146558195 @pitrou I updated the PR, but I have one question and noted [here](https://github.com/apache/arrow/pull/40520#discussion_r1625252984) -- This is an automated message from the Apache Gi

Re: [PR] MINOR: [Java] Bump org.apache.maven.plugins:maven-gpg-plugin from 3.2.2 to 3.2.4 in /java [arrow]

2024-06-03 Thread via GitHub
conbench-apache-arrow[bot] commented on PR #41939: URL: https://github.com/apache/arrow/pull/41939#issuecomment-2146536392 After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit 9b59157a443dcfd7bf6f7db53a1cad02ff04645f. There were no

Re: [PR] GH-41902: [Java] Variadic Buffer Counts Incorrect [arrow]

2024-06-03 Thread via GitHub
vibhatha commented on code in PR #41930: URL: https://github.com/apache/arrow/pull/41930#discussion_r1625306169 ## java/c/src/main/java/org/apache/arrow/c/StructVectorLoader.java: ## @@ -54,7 +55,12 @@ public class StructVectorLoader { /** * Construct with a schema. -

Re: [PR] GH-39649: [Java][CI] Fix or suppress spurious errorprone warnings stage 2 [arrow]

2024-06-03 Thread via GitHub
lidavidm commented on code in PR #39777: URL: https://github.com/apache/arrow/pull/39777#discussion_r1625301489 ## docs/source/developers/java/development.rst: ## @@ -137,3 +137,14 @@ This applies the style to all pom.xml files under the current directory or from .. _conbench:

Re: [PR] GH-41902: [Java] Variadic Buffer Counts Incorrect [arrow]

2024-06-03 Thread via GitHub
vibhatha commented on code in PR #41930: URL: https://github.com/apache/arrow/pull/41930#discussion_r1625281196 ## java/c/src/main/java/org/apache/arrow/c/StructVectorLoader.java: ## @@ -54,7 +55,12 @@ public class StructVectorLoader { /** * Construct with a schema. -

Re: [PR] GH-41902: [Java] Variadic Buffer Counts Incorrect [arrow]

2024-06-03 Thread via GitHub
lidavidm commented on code in PR #41930: URL: https://github.com/apache/arrow/pull/41930#discussion_r1625275968 ## java/c/src/main/java/org/apache/arrow/c/StructVectorLoader.java: ## @@ -54,7 +55,12 @@ public class StructVectorLoader { /** * Construct with a schema. -

Re: [PR] GH-41902: [Java] Variadic Buffer Counts Incorrect [arrow]

2024-06-03 Thread via GitHub
lidavidm commented on code in PR #41930: URL: https://github.com/apache/arrow/pull/41930#discussion_r1625276849 ## java/c/src/main/java/org/apache/arrow/c/StructVectorLoader.java: ## @@ -54,7 +55,12 @@ public class StructVectorLoader { /** * Construct with a schema. -

Re: [PR] MINOR: [Go] Bump github.com/hamba/avro/v2 from 2.22.0 to 2.22.1 in /go [arrow]

2024-06-03 Thread via GitHub
conbench-apache-arrow[bot] commented on PR #41937: URL: https://github.com/apache/arrow/pull/41937#issuecomment-2146487978 After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 2b1593d78f915b1d5e12a83ba759ed95124dd300. There were no

Re: [PR] GH-39649: [Java][CI] Fix or suppress spurious errorprone warnings stage 2 [arrow]

2024-06-03 Thread via GitHub
vibhatha commented on code in PR #39777: URL: https://github.com/apache/arrow/pull/39777#discussion_r1625272182 ## java/memory/memory-core/src/main/java/org/apache/arrow/memory/util/HistoricalLog.java: ## @@ -80,14 +85,15 @@ public HistoricalLog(final int limit, final String id

Re: [PR] GH-41301: [C++] Extract the kernel loops used for PrimitiveTakeExec and generalize to any fixed-width type [arrow]

2024-06-03 Thread via GitHub
felipecrv commented on code in PR #41373: URL: https://github.com/apache/arrow/pull/41373#discussion_r1625269304 ## cpp/src/arrow/util/gather_internal.h: ## @@ -0,0 +1,287 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreement

Re: [PR] MINOR: [CI][Java] Update develocity access key environment variable [arrow]

2024-06-03 Thread via GitHub
assignUser commented on PR #41880: URL: https://github.com/apache/arrow/pull/41880#issuecomment-2146476070 What ever it was it seems to be back up :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] GH-39649: [Java][CI] Fix or suppress spurious errorprone warnings stage 2 [arrow]

2024-06-03 Thread via GitHub
vibhatha commented on code in PR #39777: URL: https://github.com/apache/arrow/pull/39777#discussion_r1625263847 ## java/memory/memory-core/pom.xml: ## Review Comment: Reported here: https://github.com/apache/arrow/issues/41951 I am going to suppress the warning but a

Re: [I] [Format] Passing column statistics through Arrow C data interface [arrow]

2024-06-03 Thread via GitHub
kou commented on issue #38837: URL: https://github.com/apache/arrow/issues/38837#issuecomment-2146457071 If per-batch statistics are needed, the separated API approach (schema for statistics is only defined) is better than using `ArrowSchema`/`ArrowArray`/`ArrowArrayStream`. With the sep

Re: [PR] GH-40964: [CI][Archery] Archery linking should also check for undefined symbols Linux [arrow]

2024-06-03 Thread via GitHub
vibhatha commented on code in PR #40520: URL: https://github.com/apache/arrow/pull/40520#discussion_r1625255057 ## dev/archery/archery/linking.py: ## @@ -61,9 +63,84 @@ def list_dependency_names(self): names.append(name) return names +def _remove_weak

Re: [PR] GH-40964: [CI][Archery] Archery linking should also check for undefined symbols Linux [arrow]

2024-06-03 Thread via GitHub
vibhatha commented on code in PR #40520: URL: https://github.com/apache/arrow/pull/40520#discussion_r1625252984 ## dev/archery/archery/linking.py: ## @@ -61,9 +63,84 @@ def list_dependency_names(self): names.append(name) return names +def _remove_weak

Re: [I] [Swift] Add interface ArrowArrayHolderBuilder [arrow]

2024-06-03 Thread via GitHub
kou commented on issue #41945: URL: https://github.com/apache/arrow/issues/41945#issuecomment-2146446008 Issue resolved by pull request 41946 https://github.com/apache/arrow/pull/41946 -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] GH-41945: [Swift] Add interface ArrowArrayHolderBuilder [arrow]

2024-06-03 Thread via GitHub
kou merged PR #41946: URL: https://github.com/apache/arrow/pull/41946 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.or

Re: [I] format: granularity for constraints in AdbcConnectionGetObjects [arrow-adbc]

2024-06-03 Thread via GitHub
lidavidm commented on issue #1508: URL: https://github.com/apache/arrow-adbc/issues/1508#issuecomment-2146437865 Ah, I think what we're missing is the equivalent of https://docs.oracle.com/en/java/javase/11/docs/api/java.sql/java/sql/DatabaseMetaData.html#getSearchStringEscape() There

Re: [PR] GH-40964: [CI][Archery] Archery linking should also check for undefined symbols Linux [arrow]

2024-06-03 Thread via GitHub
vibhatha commented on code in PR #40520: URL: https://github.com/apache/arrow/pull/40520#discussion_r1625237901 ## dev/archery/archery/linking.py: ## @@ -61,9 +63,84 @@ def list_dependency_names(self): names.append(name) return names +def _remove_weak

Re: [PR] GH-40964: [CI][Archery] Archery linking should also check for undefined symbols Linux [arrow]

2024-06-03 Thread via GitHub
vibhatha commented on code in PR #40520: URL: https://github.com/apache/arrow/pull/40520#discussion_r1625237720 ## dev/archery/archery/linking.py: ## @@ -61,9 +63,84 @@ def list_dependency_names(self): names.append(name) return names +def _remove_weak

Re: [PR] MINOR: [JS] Bump @typescript-eslint/eslint-plugin from 7.8.0 to 7.11.0 in /js [arrow]

2024-06-03 Thread via GitHub
dependabot[bot] closed pull request #41914: MINOR: [JS] Bump @typescript-eslint/eslint-plugin from 7.8.0 to 7.11.0 in /js URL: https://github.com/apache/arrow/pull/41914 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] MINOR: [JS] Bump @typescript-eslint/eslint-plugin from 7.8.0 to 7.11.0 in /js [arrow]

2024-06-03 Thread via GitHub
dependabot[bot] commented on PR #41914: URL: https://github.com/apache/arrow/pull/41914#issuecomment-2146427436 Superseded by #41950. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[PR] MINOR: [JS] Bump @typescript-eslint/eslint-plugin from 7.11.0 to 7.12.0 in /js [arrow]

2024-06-03 Thread via GitHub
dependabot[bot] opened a new pull request, #41950: URL: https://github.com/apache/arrow/pull/41950 Bumps [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin) from 7.11.0 to 7.12.0. Release notes Sourced from ht

Re: [PR] MINOR: [JS] Bump @typescript-eslint/parser from 7.8.0 to 7.11.0 in /js [arrow]

2024-06-03 Thread via GitHub
dependabot[bot] closed pull request #41913: MINOR: [JS] Bump @typescript-eslint/parser from 7.8.0 to 7.11.0 in /js URL: https://github.com/apache/arrow/pull/41913 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

Re: [PR] MINOR: [JS] Bump @types/node from 20.12.8 to 20.13.0 in /js [arrow]

2024-06-03 Thread via GitHub
dependabot[bot] closed pull request #41912: MINOR: [JS] Bump @types/node from 20.12.8 to 20.13.0 in /js URL: https://github.com/apache/arrow/pull/41912 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

Re: [PR] MINOR: [JS] Bump @typescript-eslint/parser from 7.8.0 to 7.11.0 in /js [arrow]

2024-06-03 Thread via GitHub
dependabot[bot] commented on PR #41913: URL: https://github.com/apache/arrow/pull/41913#issuecomment-2146427302 Superseded by #41949. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] MINOR: [JS] Bump @types/node from 20.12.8 to 20.13.0 in /js [arrow]

2024-06-03 Thread via GitHub
dependabot[bot] commented on PR #41912: URL: https://github.com/apache/arrow/pull/41912#issuecomment-2146427300 Superseded by #41948. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[PR] MINOR: [JS] Bump @typescript-eslint/parser from 7.11.0 to 7.12.0 in /js [arrow]

2024-06-03 Thread via GitHub
dependabot[bot] opened a new pull request, #41949: URL: https://github.com/apache/arrow/pull/41949 Bumps [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser) from 7.11.0 to 7.12.0. Release notes Sourced from https://github.c

[PR] MINOR: [JS] Bump @types/node from 20.13.0 to 20.14.1 in /js [arrow]

2024-06-03 Thread via GitHub
dependabot[bot] opened a new pull request, #41948: URL: https://github.com/apache/arrow/pull/41948 Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 20.13.0 to 20.14.1. Commits See full diff in https://github.com/DefinitelyTyped/

Re: [PR] MINOR: [JS] Bump rollup from 4.17.2 to 4.18.0 in /js [arrow]

2024-06-03 Thread via GitHub
dependabot[bot] commented on PR #41918: URL: https://github.com/apache/arrow/pull/41918#issuecomment-2146426684 Looks like rollup is up-to-date now, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] MINOR: [JS] Bump @swc/core from 1.4.17 to 1.5.24 in /js [arrow]

2024-06-03 Thread via GitHub
dependabot[bot] closed pull request #41917: MINOR: [JS] Bump @swc/core from 1.4.17 to 1.5.24 in /js URL: https://github.com/apache/arrow/pull/41917 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

Re: [PR] MINOR: [JS] Bump @swc/core from 1.4.17 to 1.5.24 in /js [arrow]

2024-06-03 Thread via GitHub
dependabot[bot] commented on PR #41917: URL: https://github.com/apache/arrow/pull/41917#issuecomment-2146426609 Looks like @swc/core is up-to-date now, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

Re: [PR] MINOR: [JS] Bump ts-jest from 29.1.2 to 29.1.4 in /js [arrow]

2024-06-03 Thread via GitHub
dependabot[bot] closed pull request #41911: MINOR: [JS] Bump ts-jest from 29.1.2 to 29.1.4 in /js URL: https://github.com/apache/arrow/pull/41911 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] MINOR: [JS] Bump ts-jest from 29.1.2 to 29.1.4 in /js [arrow]

2024-06-03 Thread via GitHub
dependabot[bot] commented on PR #41911: URL: https://github.com/apache/arrow/pull/41911#issuecomment-2146426568 Looks like ts-jest is up-to-date now, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] MINOR: [JS] Bump jest-silent-reporter from 0.5.0 to 0.6.0 in /js [arrow]

2024-06-03 Thread via GitHub
dependabot[bot] commented on PR #41915: URL: https://github.com/apache/arrow/pull/41915#issuecomment-2146426754 Looks like jest-silent-reporter is up-to-date now, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the message, please lo

Re: [PR] MINOR: [JS] Bump jest-silent-reporter from 0.5.0 to 0.6.0 in /js [arrow]

2024-06-03 Thread via GitHub
dependabot[bot] closed pull request #41915: MINOR: [JS] Bump jest-silent-reporter from 0.5.0 to 0.6.0 in /js URL: https://github.com/apache/arrow/pull/41915 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] MINOR: [JS] Bump rollup from 4.17.2 to 4.18.0 in /js [arrow]

2024-06-03 Thread via GitHub
dependabot[bot] closed pull request #41918: MINOR: [JS] Bump rollup from 4.17.2 to 4.18.0 in /js URL: https://github.com/apache/arrow/pull/41918 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

Re: [PR] GH-41905: [JS] Update dependencies [arrow]

2024-06-03 Thread via GitHub
domoritz merged PR #41906: URL: https://github.com/apache/arrow/pull/41906 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apac

Re: [I] [ARM v8] Exception thrown when JAVA calls libgandiva_jni.so on ARM (but successfully on x86 platform) [arrow]

2024-06-03 Thread via GitHub
kou commented on issue #41935: URL: https://github.com/apache/arrow/issues/41935#issuecomment-2146423860 #39695 may be related. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

Re: [PR] GH-41902: [Java] Variadic Buffer Counts Incorrect [arrow]

2024-06-03 Thread via GitHub
vibhatha commented on code in PR #41930: URL: https://github.com/apache/arrow/pull/41930#discussion_r1625216404 ## java/c/src/main/java/org/apache/arrow/c/StructVectorLoader.java: ## @@ -111,7 +117,7 @@ private void loadBuffers(FieldVector vector, Field field, Iterator buf

Re: [PR] feat(python) : Added support to create timestamp/date32/date64 Array from iterable [arrow-nanoarrow]

2024-06-03 Thread via GitHub
paleolimbot commented on PR #502: URL: https://github.com/apache/arrow-nanoarrow/pull/502#issuecomment-2146379504 Did you know about `pre-commit run --all-files`? (It should take care of the style checks for you) -- This is an automated message from the Apache Git Service. To respond to t

Re: [PR] feat(python) : Added support to create timestamp/date32/date64 Array from iterable [arrow-nanoarrow]

2024-06-03 Thread via GitHub
aosingh commented on PR #502: URL: https://github.com/apache/arrow-nanoarrow/pull/502#issuecomment-2146375261 There are a few style guide check failures and 1 unit test failed. I am checking this. -- This is an automated message from the Apache Git Service. To respond to the message, ple

Re: [PR] GH-41902: [Java] Variadic Buffer Counts Incorrect [arrow]

2024-06-03 Thread via GitHub
vibhatha commented on code in PR #41930: URL: https://github.com/apache/arrow/pull/41930#discussion_r1625183754 ## java/c/src/main/java/org/apache/arrow/c/StructVectorLoader.java: ## @@ -54,7 +55,12 @@ public class StructVectorLoader { /** * Construct with a schema. -

Re: [PR] GH-41397: [C#] Downgrade macOS test runner to avoid infrastructure bug [arrow]

2024-06-03 Thread via GitHub
conbench-apache-arrow[bot] commented on PR #41934: URL: https://github.com/apache/arrow/pull/41934#issuecomment-2146326232 After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 7f0c4070dd723b2f7e1967d7f7f2cccf6fb256b7. There were no

Re: [PR] feat: Standalone Python installer using Meson [arrow-nanoarrow]

2024-06-03 Thread via GitHub
WillAyd commented on PR #505: URL: https://github.com/apache/arrow-nanoarrow/pull/505#issuecomment-2146308751 In this PR the bootstrap file actually gets decoupled from CMake and has nothing to do with Meson - the only thing Meson does is provide it a command line argument so it knows where

Re: [PR] feat(python) : Added support to create timestamp/date32/date64 Array from iterable [arrow-nanoarrow]

2024-06-03 Thread via GitHub
aosingh commented on code in PR #502: URL: https://github.com/apache/arrow-nanoarrow/pull/502#discussion_r1625164883 ## python/tests/test_c_array.py: ## @@ -514,3 +516,36 @@ def test_c_array_from_buffers_validation(): validation_level=validation_level, )

Re: [PR] MINOR: [Java] Bump com.google.guava:guava-bom from 33.0.0-jre to 33.2.1-jre in /java [arrow]

2024-06-03 Thread via GitHub
kou merged PR #41943: URL: https://github.com/apache/arrow/pull/41943 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.or

Re: [PR] feat: Standalone Python installer using Meson [arrow-nanoarrow]

2024-06-03 Thread via GitHub
paleolimbot commented on PR #505: URL: https://github.com/apache/arrow-nanoarrow/pull/505#issuecomment-2146298783 For what it's worth, I'd like to move the "bundle" logic from CMake to Python at some point (at which point `bootstrap.py` work work without CMake or Meson)...is the issue that

Re: [PR] MINOR: [Java] Bump org.apache.maven.plugins:maven-install-plugin from 3.1.1 to 3.1.2 in /java [arrow]

2024-06-03 Thread via GitHub
kou merged PR #41941: URL: https://github.com/apache/arrow/pull/41941 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.or

Re: [PR] MINOR: [Java] Bump dep.slf4j.version from 2.0.12 to 2.0.13 in /java [arrow]

2024-06-03 Thread via GitHub
kou merged PR #41940: URL: https://github.com/apache/arrow/pull/41940 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.or

Re: [PR] MINOR: [Java] Bump org.apache.maven.plugins:maven-gpg-plugin from 3.2.2 to 3.2.4 in /java [arrow]

2024-06-03 Thread via GitHub
kou merged PR #41939: URL: https://github.com/apache/arrow/pull/41939 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.or

Re: [PR] MINOR: [Go] Bump github.com/hamba/avro/v2 from 2.22.0 to 2.22.1 in /go [arrow]

2024-06-03 Thread via GitHub
kou merged PR #41937: URL: https://github.com/apache/arrow/pull/41937 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.or

Re: [PR] GH-39649: [Java][CI] Fix or suppress spurious errorprone warnings stage 2 [arrow]

2024-06-03 Thread via GitHub
vibhatha commented on code in PR #39777: URL: https://github.com/apache/arrow/pull/39777#discussion_r1625158956 ## java/memory/memory-core/pom.xml: ## Review Comment: Sure let me do that. -- This is an automated message from the Apache Git Service. To respond to the me

Re: [PR] feat(python) : Added support to create timestamp/date32/date64 Array from iterable [arrow-nanoarrow]

2024-06-03 Thread via GitHub
paleolimbot commented on PR #502: URL: https://github.com/apache/arrow-nanoarrow/pull/502#issuecomment-2146293792 Thanks for the additional changes! I was out-of-office today but will take a look tomorrow morning 🙂 -- This is an automated message from the Apache Git Service. To respond t

Re: [PR] feat(python) : Added support to create timestamp/date32/date64 Array from iterable [arrow-nanoarrow]

2024-06-03 Thread via GitHub
paleolimbot commented on code in PR #502: URL: https://github.com/apache/arrow-nanoarrow/pull/502#discussion_r1625158089 ## python/tests/test_c_array.py: ## @@ -514,3 +516,36 @@ def test_c_array_from_buffers_validation(): validation_level=validation_level,

Re: [PR] feat(python) : Added support to create timestamp/date32/date64 Array from iterable [arrow-nanoarrow]

2024-06-03 Thread via GitHub
paleolimbot commented on code in PR #502: URL: https://github.com/apache/arrow-nanoarrow/pull/502#discussion_r1625157773 ## python/src/nanoarrow/_lib.pyx: ## @@ -1069,6 +1069,12 @@ cdef class CSchemaView: NANOARROW_TYPE_SPARSE_UNION ) +_buffer_protocol_suppor

Re: [I] [Python] Keeping cursors alive when using cursor.fetch_record_batch() [arrow-adbc]

2024-06-03 Thread via GitHub
davlee1972 commented on issue #1893: URL: https://github.com/apache/arrow-adbc/issues/1893#issuecomment-2146291707 I created a temporary hack pyarrow.RecordBatchReader and pyarrow.dataset.Scanner to fix this.. Here's the error example: Attempt to read from a stream that has already b

Re: [PR] GH-41684: [C++][Python] Add optional null_bitmap to MapArray::FromArrays [arrow]

2024-06-03 Thread via GitHub
felipecrv commented on code in PR #41757: URL: https://github.com/apache/arrow/pull/41757#discussion_r1625137177 ## cpp/src/arrow/array/array_nested.cc: ## @@ -807,7 +807,7 @@ MapArray::MapArray(const std::shared_ptr& type, int64_t length, Result> MapArray::FromArraysInternal(

Re: [PR] feat(python) : Added support to create timestamp/date32/date64 Array from iterable [arrow-nanoarrow]

2024-06-03 Thread via GitHub
aosingh commented on PR #502: URL: https://github.com/apache/arrow-nanoarrow/pull/502#issuecomment-2146240354 @paleolimbot Could you please help with the GitHub CI workflow ? I wanted to verify the latest changes and unit tests. Thanks. -- This is an automated message from the A

Re: [PR] chore(csharp): bump Google.Cloud.BigQuery.V2 from 3.9.0 to 3.10.0 in /csharp [arrow-adbc]

2024-06-03 Thread via GitHub
CurtHagenlocher merged PR #1902: URL: https://github.com/apache/arrow-adbc/pull/1902 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@

Re: [PR] GH-41902: [Java] Variadic Buffer Counts Incorrect [arrow]

2024-06-03 Thread via GitHub
vibhatha commented on code in PR #41930: URL: https://github.com/apache/arrow/pull/41930#discussion_r1625123769 ## java/c/src/main/java/org/apache/arrow/c/StructVectorLoader.java: ## @@ -111,7 +117,7 @@ private void loadBuffers(FieldVector vector, Field field, Iterator buf

Re: [PR] GH-41902: [Java] Variadic Buffer Counts Incorrect [arrow]

2024-06-03 Thread via GitHub
vibhatha commented on code in PR #41930: URL: https://github.com/apache/arrow/pull/41930#discussion_r1625123247 ## java/c/src/main/java/org/apache/arrow/c/StructVectorLoader.java: ## @@ -54,7 +55,12 @@ public class StructVectorLoader { /** * Construct with a schema. -

Re: [PR] chore(csharp): bump DuckDB.NET.Bindings.Full from 0.10.3 to 1.0.0 in /csharp [arrow-adbc]

2024-06-03 Thread via GitHub
CurtHagenlocher merged PR #1901: URL: https://github.com/apache/arrow-adbc/pull/1901 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@

Re: [PR] GH-41493: [C++] Add a new S3option to check existence before CreateDir [arrow]

2024-06-03 Thread via GitHub
HaochengLIU commented on code in PR #41822: URL: https://github.com/apache/arrow/pull/41822#discussion_r1625107284 ## cpp/src/arrow/filesystem/s3fs.cc: ## @@ -2871,6 +2872,12 @@ Status S3FileSystem::CreateDir(const std::string& s, bool recursive) { for (const auto& part :

Re: [PR] GH-41493: [C++] Add a new S3option to check existence before CreateDir [arrow]

2024-06-03 Thread via GitHub
HaochengLIU commented on code in PR #41822: URL: https://github.com/apache/arrow/pull/41822#discussion_r1625105717 ## cpp/src/arrow/filesystem/s3fs_test.cc: ## @@ -939,6 +943,31 @@ TEST_F(TestS3FS, CreateDir) { // Extraneous slashes ASSERT_RAISES(Invalid, fs_->CreateDir("b

Re: [PR] GH-41493: [C++] Add a new S3option to check existence before CreateDir [arrow]

2024-06-03 Thread via GitHub
HaochengLIU commented on code in PR #41822: URL: https://github.com/apache/arrow/pull/41822#discussion_r1625105223 ## cpp/src/arrow/filesystem/s3fs_test.cc: ## @@ -922,9 +922,13 @@ TEST_F(TestS3FS, CreateDir) { // New "directory" AssertFileInfo(fs_.get(), "bucket/newdir"

Re: [PR] GH-41493: [C++] Add a new S3option to check existence before CreateDir [arrow]

2024-06-03 Thread via GitHub
HaochengLIU commented on code in PR #41822: URL: https://github.com/apache/arrow/pull/41822#discussion_r1625104098 ## cpp/src/arrow/filesystem/s3fs.cc: ## @@ -2859,17 +2859,41 @@ Status S3FileSystem::CreateDir(const std::string& s, bool recursive) { return impl_->CreateBuc

Re: [I] [Python][FlightRPC] Segmentation Fault when invoking authenticate concurrently over a same FlightClient [arrow]

2024-06-03 Thread via GitHub
jcferretti commented on issue #38565: URL: https://github.com/apache/arrow/issues/38565#issuecomment-2146196632 > There is likely no need for locking, just making SetToken take a shared_ptr instead of a raw pointer may be enough, see linked issue. Actually that's wrong, there is no gu

Re: [PR] feat: Meson Support for ADBC [arrow-adbc]

2024-06-03 Thread via GitHub
WillAyd commented on code in PR #1904: URL: https://github.com/apache/arrow-adbc/pull/1904#discussion_r1625083196 ## c/meson.build: ## Review Comment: Left some TODOs in this file on things that were tripping me up. I don't know enough about Go to make that work, though th

[PR] feat: Meson Support for ADBC [arrow-adbc]

2024-06-03 Thread via GitHub
WillAyd opened a new pull request, #1904: URL: https://github.com/apache/arrow-adbc/pull/1904 This worked pretty well in nanoarrow so figured worth trying in ADBC. In the long run arrow-adbc would make for a nice addition to the Meson WrapDB - it would be an easy way to install the source f

[PR] feat(go/adbc/driver): add support for ClickHouse [arrow-adbc]

2024-06-03 Thread via GitHub
cocoa-xu opened a new pull request, #1903: URL: https://github.com/apache/arrow-adbc/pull/1903 Hi this PR is a preliminary Go implementation for ClickHouse. I'll leave this PR as a draft until most data types are supported and have some tests for it. The screenshot below shows its current s

[PR] chore(csharp): bump Google.Cloud.BigQuery.V2 from 3.9.0 to 3.10.0 in /csharp [arrow-adbc]

2024-06-03 Thread via GitHub
dependabot[bot] opened a new pull request, #1902: URL: https://github.com/apache/arrow-adbc/pull/1902 Bumps [Google.Cloud.BigQuery.V2](https://github.com/googleapis/google-cloud-dotnet) from 3.9.0 to 3.10.0. Commits https://github.com/googleapis/google-cloud-dotnet/commit/544e

[PR] chore(csharp): bump DuckDB.NET.Bindings.Full from 0.10.3 to 1.0.0 in /csharp [arrow-adbc]

2024-06-03 Thread via GitHub
dependabot[bot] opened a new pull request, #1901: URL: https://github.com/apache/arrow-adbc/pull/1901 Bumps [DuckDB.NET.Bindings.Full](https://github.com/Giorgi/DuckDB.NET) from 0.10.3 to 1.0.0. Commits https://github.com/Giorgi/DuckDB.NET/commit/9fce699036663d46f0296414a896725

Re: [PR] GH-41902: [Java] Variadic Buffer Counts Incorrect [arrow]

2024-06-03 Thread via GitHub
lidavidm commented on code in PR #41930: URL: https://github.com/apache/arrow/pull/41930#discussion_r1625023631 ## java/c/src/main/java/org/apache/arrow/c/StructVectorLoader.java: ## @@ -54,7 +55,12 @@ public class StructVectorLoader { /** * Construct with a schema. -

[PR] chore(go/adbc): bump github.com/snowflakedb/gosnowflake from 1.10.0 to 1.10.1 in /go/adbc [arrow-adbc]

2024-06-03 Thread via GitHub
dependabot[bot] opened a new pull request, #1900: URL: https://github.com/apache/arrow-adbc/pull/1900 Bumps [github.com/snowflakedb/gosnowflake](https://github.com/snowflakedb/gosnowflake) from 1.10.0 to 1.10.1. Release notes Sourced from https://github.com/snowflakedb/gosnowflake

Re: [PR] refactor!: More idiomatic meson usage [arrow-nanoarrow]

2024-06-03 Thread via GitHub
paleolimbot merged PR #504: URL: https://github.com/apache/arrow-nanoarrow/pull/504 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@a

Re: [PR] MINOR: [Java] Bump com.google.guava:guava-bom from 33.0.0-jre to 33.2.1-jre in /java [arrow]

2024-06-03 Thread via GitHub
github-actions[bot] commented on PR #41943: URL: https://github.com/apache/arrow/pull/41943#issuecomment-2146057739 Revision: 8633322a9af16853769675e244a8bd8cc7605b3a Submitted crossbow builds: [ursacomputing/crossbow @ actions-42d3f90af6](https://github.com/ursacomputing/crossbow/bra

Re: [PR] MINOR: [Java] Bump org.apache.maven.plugins:maven-install-plugin from 3.1.1 to 3.1.2 in /java [arrow]

2024-06-03 Thread via GitHub
github-actions[bot] commented on PR #41941: URL: https://github.com/apache/arrow/pull/41941#issuecomment-2146056031 Revision: 8e7fd783bdcdf67720b267aa0dbf1b50e727cdff Submitted crossbow builds: [ursacomputing/crossbow @ actions-9a5d00e40c](https://github.com/ursacomputing/crossbow/bra

Re: [PR] MINOR: [Java] Bump org.apache.maven.plugins:maven-gpg-plugin from 3.2.2 to 3.2.4 in /java [arrow]

2024-06-03 Thread via GitHub
github-actions[bot] commented on PR #41939: URL: https://github.com/apache/arrow/pull/41939#issuecomment-2146054761 Revision: 41e7e9069a312be8f7e5aa95b039e8e3a1773661 Submitted crossbow builds: [ursacomputing/crossbow @ actions-93d0df530c](https://github.com/ursacomputing/crossbow/bra

Re: [PR] MINOR: [Java] Bump dep.slf4j.version from 2.0.12 to 2.0.13 in /java [arrow]

2024-06-03 Thread via GitHub
github-actions[bot] commented on PR #41940: URL: https://github.com/apache/arrow/pull/41940#issuecomment-2146055487 Revision: 9810a736936eb3086fca3d9bbb1238564a530cba Submitted crossbow builds: [ursacomputing/crossbow @ actions-e4615a0b40](https://github.com/ursacomputing/crossbow/bra

Re: [PR] MINOR: [Java] Bump com.google.guava:guava-bom from 33.0.0-jre to 33.2.1-jre in /java [arrow]

2024-06-03 Thread via GitHub
kou commented on PR #41943: URL: https://github.com/apache/arrow/pull/41943#issuecomment-2146053946 @github-actions crossbow submit -g java -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[PR] chore(java): bump com.uber.nullaway:nullaway from 0.10.26 to 0.11.0 in /java [arrow-adbc]

2024-06-03 Thread via GitHub
dependabot[bot] opened a new pull request, #1898: URL: https://github.com/apache/arrow-adbc/pull/1898 Bumps [com.uber.nullaway:nullaway](https://github.com/uber/NullAway) from 0.10.26 to 0.11.0. Release notes Sourced from https://github.com/uber/NullAway/releases";>com.uber.nullawa

  1   2   3   >