ttencate commented on issue #6111:
URL: https://github.com/apache/arrow-rs/issues/6111#issuecomment-2252077696
I understand, just thought I'd mention it (and I failed to find the
duplicate). Thank you the impressively quick response!
--
This is an automated message from the Apache Git Ser
anjakefala commented on issue #6048:
URL: https://github.com/apache/arrow-rs/issues/6048#issuecomment-2252026272
@etseidl I am not! I would love it if you picked it up. =)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
zanmato1984 commented on PR #43415:
URL: https://github.com/apache/arrow/pull/43415#issuecomment-2251983949
Looping in @felipecrv as well. Would you help to take a look? Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
conbench-apache-arrow[bot] commented on PR #43335:
URL: https://github.com/apache/arrow/pull/43335#issuecomment-2251983143
After merging your PR, Conbench analyzed the 4 benchmarking runs that have
been run so far on merge-commit 85684fe4af1e35233f3ac921ed45b95202cda562.
There were no
handstuyennn commented on PR #43117:
URL: https://github.com/apache/arrow/pull/43117#issuecomment-2251982913
> @handstuyennn could you look into the last remaining test so we can merge
this?
I will handle it this weekend
--
This is an automated message from the Apache Git Service.
conbench-apache-arrow[bot] commented on PR #42086:
URL: https://github.com/apache/arrow/pull/42086#issuecomment-2251946011
After merging your PR, Conbench analyzed the 4 benchmarking runs that have
been run so far on merge-commit 0fbea66a4bcdec2dc6bbffd2877c143e47d1653d.
There were no
wgtmac commented on PR #43428:
URL: https://github.com/apache/arrow/pull/43428#issuecomment-2251896183
We should not write `ColumnMetaData` at the end of ColumnChunk any more:
https://github.com/apache/arrow/blob/62ee67616d793d1a1df5e8ca7807e29381adaba9/cpp/src/parquet/column_writer.cc#L670
mapleFU commented on PR #43428:
URL: https://github.com/apache/arrow/pull/43428#issuecomment-2251893943
Also cc @emkornfield @etseidl
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
github-actions[bot] commented on PR #43428:
URL: https://github.com/apache/arrow/pull/43428#issuecomment-2251893900
:warning: GitHub issue #43427 **has been automatically assigned in GitHub**
to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the mes
mapleFU opened a new pull request, #43428:
URL: https://github.com/apache/arrow/pull/43428
### Rationale for this change
See github issue
### What changes are included in this PR?
Force `ColumnChunk::file_offset` tobe 0
### Are these changes
lidavidm commented on issue #565:
URL:
https://github.com/apache/arrow-nanoarrow/issues/565#issuecomment-2251810238
FWIW, GTest has a macro called MATCHER_P that makes it much easier to define
matchers like that (instead of writing it out by hand)
--
This is an automated message from the
paleolimbot commented on issue #565:
URL:
https://github.com/apache/arrow-nanoarrow/issues/565#issuecomment-2251804839
ADBC's status matcher is here:
https://github.com/apache/arrow-adbc/blob/d6255ac0a10825f98846f112f13ffd0dc013e3f5/c/validation/adbc_validation_util.cc#L85-L145
--
JasonLi-cn commented on issue #6112:
URL: https://github.com/apache/arrow-rs/issues/6112#issuecomment-2251790369
> FWIW in general offset overflows do yield panics in arrow-rs, the
additional plumbing for error handling what is almost always an unrecoverable
error has been hard to justify,
vibhatha commented on code in PR #43077:
URL: https://github.com/apache/arrow/pull/43077#discussion_r1692365190
##
java/vector/src/main/java/org/apache/arrow/vector/compare/VectorVisitor.java:
##
@@ -60,4 +61,6 @@ public interface VectorVisitor {
OUT visit(NullVector left, IN
lidavidm commented on code in PR #43077:
URL: https://github.com/apache/arrow/pull/43077#discussion_r1692363746
##
java/vector/src/main/java/org/apache/arrow/vector/compare/VectorVisitor.java:
##
@@ -60,4 +61,6 @@ public interface VectorVisitor {
OUT visit(NullVector left, IN
vibhatha commented on code in PR #43053:
URL: https://github.com/apache/arrow/pull/43053#discussion_r1692360196
##
java/c/src/test/java/org/apache/arrow/c/RoundtripTest.java:
##
@@ -951,6 +952,86 @@ public void testImportReleasedArray() {
}
}
+ @Test
Review Comment:
vibhatha commented on code in PR #43077:
URL: https://github.com/apache/arrow/pull/43077#discussion_r1692357593
##
java/vector/src/main/java/org/apache/arrow/vector/compare/VectorVisitor.java:
##
@@ -60,4 +61,6 @@ public interface VectorVisitor {
OUT visit(NullVector left, IN
zeroshade commented on issue #2040:
URL: https://github.com/apache/arrow-adbc/issues/2040#issuecomment-2251758093
There's a few ways we could do so, though if this is being implemented via
Python threads it'll be a bit difficult to track down which stack is the
problematic one. Though we co
lidavidm commented on code in PR #43077:
URL: https://github.com/apache/arrow/pull/43077#discussion_r1692344436
##
java/vector/src/main/java/org/apache/arrow/vector/compare/VectorVisitor.java:
##
@@ -60,4 +61,6 @@ public interface VectorVisitor {
OUT visit(NullVector left, IN
lidavidm commented on code in PR #43077:
URL: https://github.com/apache/arrow/pull/43077#discussion_r1692344245
##
java/vector/src/main/codegen/templates/PromotableWriter.java:
##
@@ -526,4 +589,35 @@ public int getValueCapacity() {
public void close() throws Exception {
lidavidm commented on issue #2040:
URL: https://github.com/apache/arrow-adbc/issues/2040#issuecomment-2251734618
Or if there's any way to get Go to dump stack without killing the process?
(Maybe that's another debug feature we should consider - optionally binding to
SIGUSR or something)
-
lidavidm commented on issue #2040:
URL: https://github.com/apache/arrow-adbc/issues/2040#issuecomment-2251732691
@zeroshade or @joellubi any ideas here what could've happened?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub a
conbench-apache-arrow[bot] commented on PR #43292:
URL: https://github.com/apache/arrow/pull/43292#issuecomment-2251653272
After merging your PR, Conbench analyzed the 4 benchmarking runs that have
been run so far on merge-commit 1f67c1a16a426d27a52d9aa31fc1b39602bad161.
There were no
conbench-apache-arrow[bot] commented on PR #43263:
URL: https://github.com/apache/arrow/pull/43263#issuecomment-2251646270
After merging your PR, Conbench analyzed the 4 benchmarking runs that have
been run so far on merge-commit bde199a0b4f59952e2ab88a1e83ed2fa1e34b746.
There were no
conbench-apache-arrow[bot] commented on PR #43366:
URL: https://github.com/apache/arrow/pull/43366#issuecomment-2251640336
After merging your PR, Conbench analyzed the 4 benchmarking runs that have
been run so far on merge-commit ad4d490f926c9d36ba0d679aa142a94db12fb647.
There were no
github-actions[bot] commented on PR #43385:
URL: https://github.com/apache/arrow/pull/43385#issuecomment-2251601793
Revision: 10c59a8af2be9979ef0e77944809db4c46a162ae
Submitted crossbow builds: [ursacomputing/crossbow @
actions-96d6d76c00](https://github.com/ursacomputing/crossbow/bra
vibhatha commented on PR #43385:
URL: https://github.com/apache/arrow/pull/43385#issuecomment-2251597909
@github-actions crossbow submit -g java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
JasonLi-cn commented on issue #6112:
URL: https://github.com/apache/arrow-rs/issues/6112#issuecomment-2251577977
> The bug you describe certainly can happen if there are large numbers of
distinct large strings in a multi-column group 🤔
Yes, this problem was first discovered in the cas
vibhatha commented on PR #43310:
URL: https://github.com/apache/arrow/pull/43310#issuecomment-2251576558
@danepitkin I filed this issue: https://github.com/apache/arrow/issues/43378
I think it is the same happening here. I saw a few CIs failing in multiple
PRs for the same reason.
--
aiguofer commented on issue #2040:
URL: https://github.com/apache/arrow-adbc/issues/2040#issuecomment-2251572970
Unfortunately it's not reproducible, we noticed it after-the-fact when users
reported queries hanging. I only saw this happen with 4 queries, all around the
same time, 3 on the s
vibhatha commented on PR #43264:
URL: https://github.com/apache/arrow/pull/43264#issuecomment-2251571505
@danepitkin there is a protobuf related issue in
https://github.com/apache/arrow/actions/runs/10100575453/job/27932234113?pr=43264#step:7:4064
--
This is an automated message from the
github-actions[bot] commented on PR #43385:
URL: https://github.com/apache/arrow/pull/43385#issuecomment-2251568776
Revision: 85c12449ff16a77795c84ad5ee337a5f604951f2
Submitted crossbow builds: [ursacomputing/crossbow @
actions-6f3ab99e36](https://github.com/ursacomputing/crossbow/bra
vibhatha commented on PR #43385:
URL: https://github.com/apache/arrow/pull/43385#issuecomment-2251566501
@github-actions crossbow submit java-jars
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
lidavidm commented on issue #2040:
URL: https://github.com/apache/arrow-adbc/issues/2040#issuecomment-2251553639
hmm. 30 minutes is rather concerning. Would it be possible to get a
thread dump (e.g. with gdb) if you notice that happening?
There is a log level env var that can be
assignUser commented on issue #43418:
URL: https://github.com/apache/arrow/issues/43418#issuecomment-2251550884
Issue resolved by pull request 43419
https://github.com/apache/arrow/pull/43419
--
This is an automated message from the Apache Git Service.
To respond to the message, please
assignUser merged PR #43419:
URL: https://github.com/apache/arrow/pull/43419
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.ap
adamreeve commented on code in PR #43413:
URL: https://github.com/apache/arrow/pull/43413#discussion_r1692255996
##
cpp/src/parquet/encryption/encryption_internal.cc:
##
@@ -758,9 +795,14 @@ void QuickUpdatePageAad(int32_t new_page_ordinal,
std::string* AAD) {
std::memcpy(AA
etseidl commented on PR #6105:
URL: https://github.com/apache/arrow-rs/pull/6105#issuecomment-2251464912
Merge went ok...once #6126 merges I'll rebase this on master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
alamb commented on PR #6105:
URL: https://github.com/apache/arrow-rs/pull/6105#issuecomment-2251462463
Update for anyone following along:
https://github.com/apache/arrow-rs/pull/6126 is the merge of the dev branch to
main
--
This is an automated message from the Apache Git Service.
T
alamb commented on issue #6097:
URL: https://github.com/apache/arrow-rs/issues/6097#issuecomment-2251455585
I could also commission some more monodraw diagrams 😆
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
conbench-apache-arrow[bot] commented on PR #43381:
URL: https://github.com/apache/arrow/pull/43381#issuecomment-2251455207
After merging your PR, Conbench analyzed the 4 benchmarking runs that have
been run so far on merge-commit fc075ad736964897d2ad1320bfb2303b84251f1c.
There were no
alamb commented on issue #6099:
URL: https://github.com/apache/arrow-rs/issues/6099#issuecomment-2251453023
> Actually I think the buffering change can be done without a breaking
change?
I am not sure -- but since our next release will have breaking changes in it
anyways, I think it
alamb commented on PR #6074:
URL: https://github.com/apache/arrow-rs/pull/6074#issuecomment-2251451191
> Is it possible to have this fix applied to the 0.9.x line?
The patch should apply cleanly.
I made a branch https://github.com/apache/arrow-rs/tree/object_store_0.9-dev
alamb commented on code in PR #6126:
URL: https://github.com/apache/arrow-rs/pull/6126#discussion_r1692160127
##
parquet/src/column/writer/mod.rs:
##
@@ -282,20 +297,8 @@ impl<'a, E: ColumnValueEncoder> GenericColumnWriter<'a, E>
{
num_buffered_rows: 0,
etseidl commented on code in PR #6126:
URL: https://github.com/apache/arrow-rs/pull/6126#discussion_r1692157167
##
parquet/src/column/writer/mod.rs:
##
@@ -282,20 +297,8 @@ impl<'a, E: ColumnValueEncoder> GenericColumnWriter<'a, E>
{
num_buffered_rows: 0,
etseidl commented on PR #6126:
URL: https://github.com/apache/arrow-rs/pull/6126#issuecomment-2251429811
merge oopsie 😮
```diff
diff --git a/parquet/src/column/writer/mod.rs
b/parquet/src/column/writer/mod.rs
index 643f34fbdd0..2c0c957d87d 100644
--- a/parquet/src/column/wri
etseidl commented on PR #6105:
URL: https://github.com/apache/arrow-rs/pull/6105#issuecomment-2251400644
> The only thing I could think that we might want to explore is using a rust
struct rather than a `Option` so it could be easier to use / document.
I'll make a PR to explore what that lo
alamb opened a new pull request, #6126:
URL: https://github.com/apache/arrow-rs/pull/6126
# Which issue does this PR close?
# Rationale for this change
Now that we hare released 52.2.0
https://github.com/apache/arrow-rs/issues/5688 we can introduce breaking API
changes to mai
conbench-apache-arrow[bot] commented on PR #43411:
URL: https://github.com/apache/arrow/pull/43411#issuecomment-2251394572
After merging your PR, Conbench analyzed the 4 benchmarking runs that have
been run so far on merge-commit e2d4dbfa43ea570c1d3234776f4ea44170f1792f.
There were no
alamb commented on PR #6105:
URL: https://github.com/apache/arrow-rs/pull/6105#issuecomment-2251391164
The clippy failure is likely due to the new rust version which was released
today. I fixed it on main. Also since we have made a 52.2.0 release candidate I
think we can move `53.0.0` devel
alamb commented on issue #6104:
URL: https://github.com/apache/arrow-rs/issues/6104#issuecomment-2251380447
Thanks for trying 🙏
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comme
ParkMyCar closed issue #6104: Implement `Into>` for `ArrayData`
URL: https://github.com/apache/arrow-rs/issues/6104
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscri
ParkMyCar commented on issue #6104:
URL: https://github.com/apache/arrow-rs/issues/6104#issuecomment-2251378574
Darn, yeah orphan rules and crate layout currently prevent it.
```
// approach 1
//
// In the `arrow-data` crate, this doesn't work because `arrow-array`
depends o
ParkMyCar commented on issue #6104:
URL: https://github.com/apache/arrow-rs/issues/6104#issuecomment-2251360086
> > Perfect, `make_array` is what I was looking for! Do you think it would
still be worthwhile to implement `Into> for ArrayData`? If not,
feel free to close out this issue!
>
etseidl commented on issue #6048:
URL: https://github.com/apache/arrow-rs/issues/6048#issuecomment-2251352794
@anjakefala are you working on this? If not I have some free cycles to
devote to this.
--
This is an automated message from the Apache Git Service.
To respond to the message, plea
alamb opened a new pull request, #6125:
URL: https://github.com/apache/arrow-rs/pull/6125
# Which issue does this PR close?
Related to https://github.com/apache/arrow-rs/issues/6016
# Rationale for this change
Update the calendar with the anticipated release schedule so
paleolimbot commented on issue #566:
URL:
https://github.com/apache/arrow-nanoarrow/issues/566#issuecomment-2251332256
We could certainly replicate Arrow C++'s syntax here, although I am hesitant
to add scope to nanoarrow or make it seem like we are trying to replace
anything about Arrow C
alamb closed issue #6119: Clippy in `object_store` crate after upgrade to Rust
1.80
URL: https://github.com/apache/arrow-rs/issues/6119
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
alamb merged PR #6120:
URL: https://github.com/apache/arrow-rs/pull/6120
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache
danepitkin commented on PR #43310:
URL: https://github.com/apache/arrow/pull/43310#issuecomment-2251317256
@github-actions crossbow submit test-debian-12-docs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo
github-actions[bot] commented on PR #43310:
URL: https://github.com/apache/arrow/pull/43310#issuecomment-2251320590
Revision: 6edff42f370cd0bb58b4b0242ebeb9a605a2df52
Submitted crossbow builds: [ursacomputing/crossbow @
actions-169aaeb47e](https://github.com/ursacomputing/crossbow/bra
danepitkin commented on PR #43397:
URL: https://github.com/apache/arrow/pull/43397#issuecomment-2251302340
> I thought Protobuf generated code depended on this at some point but
apparently not anymore.
Turns out this line omits the annotation that protobuf was adding:
https://github.
bkietz commented on issue #566:
URL:
https://github.com/apache/arrow-nanoarrow/issues/566#issuecomment-2251288094
This should include a schema equality utility too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
U
danepitkin commented on PR #43264:
URL: https://github.com/apache/arrow/pull/43264#issuecomment-2251286437
@dependabot rebase
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
bkietz opened a new issue, #566:
URL: https://github.com/apache/arrow-nanoarrow/issues/566
Arrow C++ includes factories for constructing schemas, types, fields, and
metadata which allow construction of even deeply nested structures to be
expressive:
```c++
schema({
field("som
kou commented on issue #43169:
URL: https://github.com/apache/arrow/issues/43169#issuecomment-2251282385
Issue resolved by pull request 43335
https://github.com/apache/arrow/pull/43335
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
kou merged PR #43335:
URL: https://github.com/apache/arrow/pull/43335
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.or
danepitkin commented on PR #43264:
URL: https://github.com/apache/arrow/pull/43264#issuecomment-2251276600
Looks like CI is broken though..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
paleolimbot commented on issue #565:
URL:
https://github.com/apache/arrow-nanoarrow/issues/565#issuecomment-2251273106
Thanks for opening! It has been suggested before that we have an
`EXPECT_OK()` in a review but I haven't had the time to investigate. I've never
really minded `EXPECT_EQ(.
danepitkin merged PR #42086:
URL: https://github.com/apache/arrow/pull/42086
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.ap
danepitkin commented on issue #42085:
URL: https://github.com/apache/arrow/issues/42085#issuecomment-2251270958
Issue resolved by pull request 42086
https://github.com/apache/arrow/pull/42086
--
This is an automated message from the Apache Git Service.
To respond to the message, please
alamb commented on code in PR #6123:
URL: https://github.com/apache/arrow-rs/pull/6123#discussion_r1692021127
##
object_store/Cargo.toml:
##
@@ -24,7 +24,7 @@ readme = "README.md"
description = "A generic object store interface for uniformly interacting with
AWS S3, Google Clo
alamb commented on code in PR #6120:
URL: https://github.com/apache/arrow-rs/pull/6120#discussion_r1692020740
##
object_store/Cargo.toml:
##
@@ -24,7 +24,7 @@ readme = "README.md"
description = "A generic object store interface for uniformly interacting with
AWS S3, Google Clo
djanderson opened a new issue, #6124:
URL: https://github.com/apache/arrow-rs/issues/6124
**Is your feature request related to a problem or challenge? Please describe
what you are trying to do.**
I have a Flight server that I'm working to cut over to Flight SQL. The bulk
ingest (
alamb commented on PR #6120:
URL: https://github.com/apache/arrow-rs/pull/6120#issuecomment-2251249468
Actually, upon more thought, I think keeping the MSRV update separate would
be better. I opened a PR do that here
https://github.com/apache/arrow-rs/pull/6123 and I will change this PR to
alamb opened a new pull request, #6123:
URL: https://github.com/apache/arrow-rs/pull/6123
(draft as it buidls on https://github.com/apache/arrow-rs/pull/6120)
# Which issue does this PR close?
Closes https://github.com/apache/arrow-rs/issues/6122
# Rationale for this chan
alamb opened a new issue, #6122:
URL: https://github.com/apache/arrow-rs/issues/6122
**Is your feature request related to a problem or challenge? Please describe
what you are trying to do.**
It appears we are using something that requires Rust 1.64:
https://github.com/apache/arrow-rs
alamb opened a new issue, #6121:
URL: https://github.com/apache/arrow-rs/issues/6121
**Is your feature request related to a problem or challenge? Please describe
what you are trying to do.**
Following on from https://github.com/apache/arrow-rs/issues/6022
There are several breaking
alamb commented on code in PR #6120:
URL: https://github.com/apache/arrow-rs/pull/6120#discussion_r1692007462
##
object_store/Cargo.toml:
##
@@ -24,7 +24,7 @@ readme = "README.md"
description = "A generic object store interface for uniformly interacting with
AWS S3, Google Clo
github-actions[bot] commented on PR #43424:
URL: https://github.com/apache/arrow/pull/43424#issuecomment-2251218909
Revision: f178b8b59974d4ecc329af324d597eac0404ba78
Submitted crossbow builds: [ursacomputing/crossbow @
actions-e3e81ab5a0](https://github.com/ursacomputing/crossbow/bra
WillAyd commented on issue #565:
URL:
https://github.com/apache/arrow-nanoarrow/issues/565#issuecomment-2251223086
I definitely support this initiative - improving these error messages would
be immensely helpful
I am no expert in GTest so open to whatever you think is best. I believe
github-actions[bot] commented on PR #43424:
URL: https://github.com/apache/arrow/pull/43424#issuecomment-2251218338
:warning: GitHub issue #43425 **has been automatically assigned in GitHub**
to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the mes
alamb commented on PR #6071:
URL: https://github.com/apache/arrow-rs/pull/6071#issuecomment-2251218333
FYI @Jefffrey and @tustvold -- I'll plan to merge this tomorrow unless
there are any concerns or anyone would like more time to reivew
--
This is an automated message from the Apache G
danepitkin commented on PR #43424:
URL: https://github.com/apache/arrow/pull/43424#issuecomment-2251214638
@github-actions crossbow submit -g java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
alamb opened a new issue, #6119:
URL: https://github.com/apache/arrow-rs/issues/6119
**Describe the bug**
Similarly to https://github.com/apache/arrow-rs/issues/6114
CI is failing on the object store crate most likely due to the new rust
release today adding more stringent clippy
samuelcolvin opened a new pull request, #6118:
URL: https://github.com/apache/arrow-rs/pull/6118
# Which issue does this PR close?
Related to (but not closing) #6107.
# Rationale for this change
Lots of context in #6107, this makes `LIKE` and `ILIKE` queries which are
s
alamb commented on PR #6096:
URL: https://github.com/apache/arrow-rs/pull/6096#issuecomment-2251197883
Marking as draft so it is clear this PR isn't waiting on feedback anymore
(at least I don't think it is). Please mark it as ready for review when it is
ready for another look
--
This is
alamb commented on PR #6071:
URL: https://github.com/apache/arrow-rs/pull/6071#issuecomment-2251199363
I took the liberty of merging up from main to pick up
https://github.com/apache/arrow-rs/pull/6116
--
This is an automated message from the Apache Git Service.
To respond to the message
alamb commented on code in PR #6116:
URL: https://github.com/apache/arrow-rs/pull/6116#discussion_r1691974467
##
arrow-array/Cargo.toml:
##
@@ -52,6 +52,7 @@ hashbrown = { version = "0.14.2", default-features = false }
[features]
ffi = ["arrow-schema/ffi", "arrow-data/ffi"]
alamb merged PR #6116:
URL: https://github.com/apache/arrow-rs/pull/6116
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache
alamb commented on PR #6116:
URL: https://github.com/apache/arrow-rs/pull/6116#issuecomment-2251177225
Thank you @Dandandan 🙏 Very nice to have a fast review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
alamb closed issue #6114: Clippy fails on main after upgrade to rust 1.80
URL: https://github.com/apache/arrow-rs/issues/6114
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
bkietz commented on issue #565:
URL:
https://github.com/apache/arrow-nanoarrow/issues/565#issuecomment-2251169758
@paleolimbot @WillAyd
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
joellubi commented on code in PR #43234:
URL: https://github.com/apache/arrow/pull/43234#discussion_r1691969034
##
docs/source/format/CanonicalExtensions.rst:
##
@@ -283,6 +283,28 @@ UUID
A specific UUID version is not required or guaranteed. This extension
represents
U
bkietz opened a new issue, #565:
URL: https://github.com/apache/arrow-nanoarrow/issues/565
Many functions in nanoarrow accept an `ArrowError*` which receives a message
describing the error; frequently more informative than the `ArrowErrorCode`.
Although there are tests asserting error messa
Xuanwo commented on code in PR #6116:
URL: https://github.com/apache/arrow-rs/pull/6116#discussion_r1691937215
##
arrow-array/Cargo.toml:
##
@@ -52,6 +52,7 @@ hashbrown = { version = "0.14.2", default-features = false }
[features]
ffi = ["arrow-schema/ffi", "arrow-data/ffi"]
alamb commented on code in PR #6071:
URL: https://github.com/apache/arrow-rs/pull/6071#discussion_r1691896946
##
arrow-arith/src/temporal.rs:
##
@@ -387,6 +400,88 @@ impl ExtractDatePartExt for
PrimitiveArray {
}
}
+impl ExtractDatePartExt for PrimitiveArray {
+fn d
alamb commented on code in PR #6116:
URL: https://github.com/apache/arrow-rs/pull/6116#discussion_r1691893285
##
arrow-array/Cargo.toml:
##
@@ -52,6 +52,7 @@ hashbrown = { version = "0.14.2", default-features = false }
[features]
ffi = ["arrow-schema/ffi", "arrow-data/ffi"]
github-actions[bot] commented on PR #43424:
URL: https://github.com/apache/arrow/pull/43424#issuecomment-2251059529
Thanks for opening a pull request!
If this is not a [minor
PR](https://github.com/apache/arrow/blob/main/CONTRIBUTING.md#Minor-Fixes).
Could you open an issue f
danepitkin opened a new pull request, #43424:
URL: https://github.com/apache/arrow/pull/43424
1 - 100 of 229 matches
Mail list logo
