Re: [PR] GH-44096: [C++] Don't use Boost.Process with Emscripten [arrow]

2024-09-13 Thread via GitHub
conbench-apache-arrow[bot] commented on PR #44097: URL: https://github.com/apache/arrow/pull/44097#issuecomment-2350870617 After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 62060ab55be2dc811e5abf0c5aba9834d3056ee1. There were no

Re: [PR] GH-44098: [C++] Add home made _mm256_set_m128i for compilers who are missing it [arrow]

2024-09-13 Thread via GitHub
github-actions[bot] commented on PR #44116: URL: https://github.com/apache/arrow/pull/44116#issuecomment-2350834026 :warning: GitHub issue #44098 **has been automatically assigned in GitHub** to PR creator. -- This is an automated message from the Apache Git Service. To respond to the mes

Re: [PR] GH-40098: [C++] Add home made _mm256_set_m128i for compilers who are missing it [arrow]

2024-09-13 Thread via GitHub
zanmato1984 commented on PR #44116: URL: https://github.com/apache/arrow/pull/44116#issuecomment-2350828903 Also cc @pitrou . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] GH-40098: [C++] Add home made _mm256_set_m128i for compilers who are missing it [arrow]

2024-09-13 Thread via GitHub
zanmato1984 commented on code in PR #44116: URL: https://github.com/apache/arrow/pull/44116#discussion_r1759663811 ## cpp/src/arrow/util/simd.h: ## @@ -27,18 +27,25 @@ #else // gcc/clang (possibly others) -# if defined(ARROW_HAVE_BMI2) +# if defined(ARROW_HAVE_BMI2) || def

Re: [PR] GH-40098: [C++] Add home made _mm256_set_m128i for compilers who are missing it [arrow]

2024-09-13 Thread via GitHub
zanmato1984 commented on code in PR #44116: URL: https://github.com/apache/arrow/pull/44116#discussion_r1759663811 ## cpp/src/arrow/util/simd.h: ## @@ -27,18 +27,25 @@ #else // gcc/clang (possibly others) -# if defined(ARROW_HAVE_BMI2) +# if defined(ARROW_HAVE_BMI2) || def

Re: [PR] GH-40098: [C++] Add home made _mm256_set_m128i for compilers who are missing it [arrow]

2024-09-13 Thread via GitHub
github-actions[bot] commented on PR #44116: URL: https://github.com/apache/arrow/pull/44116#issuecomment-2350827626 Revision: 91340508d93a962b490ee782c6a36736cb54dec3 Submitted crossbow builds: [ursacomputing/crossbow @ actions-0fe409cd3d](https://github.com/ursacomputing/crossbow/bra

Re: [PR] GH-40098: [C++] Add home made _mm256_set_m128i for compilers who are missing it [arrow]

2024-09-13 Thread via GitHub
zanmato1984 commented on PR #44116: URL: https://github.com/apache/arrow/pull/44116#issuecomment-2350827032 @github-actions crossbow submit test-r-rstudio-r-base-4.1-opensuse155 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] GH-40098: [C++] Add home made _mm256_set_m128i for compilers who are missing it [arrow]

2024-09-13 Thread via GitHub
zanmato1984 commented on PR #44116: URL: https://github.com/apache/arrow/pull/44116#issuecomment-2350826964 cc @kou @assignUser @jonkeane -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

Re: [I] [C++][Compute] `_mm256_set_m128i()` is unavailable on OpenSUSE 15.1 (GCC 7.5) [arrow]

2024-09-13 Thread via GitHub
zanmato1984 commented on issue #44098: URL: https://github.com/apache/arrow/issues/44098#issuecomment-2350826868 I filed PR #44116 to workaround it anyway. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[PR] GH-40098: [C++] Add home made _mm256_set_m128i for compilers who are missing it [arrow]

2024-09-13 Thread via GitHub
zanmato1984 opened a new pull request, #44116: URL: https://github.com/apache/arrow/pull/44116 ### Rationale for this change AVX2 intrinsic _mm256_set_m128i is missing in GCC versions <8.0 - this is a GCC bug discussed in [1], causing certain CI build failed. ##

Re: [PR] GH-40098: [C++] Add home made _mm256_set_m128i for compilers who are missing it [arrow]

2024-09-13 Thread via GitHub
github-actions[bot] commented on PR #44116: URL: https://github.com/apache/arrow/pull/44116#issuecomment-2350826493 :warning: GitHub issue #40098 **has been automatically assigned in GitHub** to PR creator. -- This is an automated message from the Apache Git Service. To respond to the mes

Re: [PR] feat(python): Implement bindings to IPC writer [arrow-nanoarrow]

2024-09-13 Thread via GitHub
paleolimbot merged PR #586: URL: https://github.com/apache/arrow-nanoarrow/pull/586 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@a

Re: [I] object_store: Conditional put and rename_if_not_exist on S3 [arrow-rs]

2024-09-13 Thread via GitHub
fhilgers commented on issue #6285: URL: https://github.com/apache/arrow-rs/issues/6285#issuecomment-2350804999 After playing around a bit, I found out that this can be worked around just by using multipart copy: 1. Initiate Multipart Upload 2. Upload Part Copy 3. Supply `if-none

Re: [PR] GH-44088: [Java] Fix copyFrom in BaseVariableWidthViewVector [arrow]

2024-09-13 Thread via GitHub
vibhatha commented on PR #44078: URL: https://github.com/apache/arrow/pull/44078#issuecomment-2350800505 On it @lidavidm -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] GH-44088: [Java] Fix copyFrom in BaseVariableWidthViewVector [arrow]

2024-09-13 Thread via GitHub
lidavidm commented on PR #44078: URL: https://github.com/apache/arrow/pull/44078#issuecomment-2350785869 CC @vibhatha -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] MINOR: [Java] Bump com.gradle:develocity-maven-extension from 1.21.6 to 1.22.1 in /java [arrow]

2024-09-13 Thread via GitHub
lidavidm merged PR #44108: URL: https://github.com/apache/arrow/pull/44108 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apac

Re: [PR] GH-20981: [Flight][Integration] Generic gRPC Test Runner and Server [arrow]

2024-09-13 Thread via GitHub
lidavidm commented on code in PR #44115: URL: https://github.com/apache/arrow/pull/44115#discussion_r1759641256 ## dev/flight-integration/flight/Flight.pb.go: ## Review Comment: I thought we included the stubs in arrow-go? ## dev/flight-integration/cases/auth:bas

Re: [PR] GH-44055: [Java] Finalize ErrorProne Warnings to be considered as Errors [arrow]

2024-09-13 Thread via GitHub
lidavidm commented on code in PR #44056: URL: https://github.com/apache/arrow/pull/44056#discussion_r1759631841 ## java/gandiva/src/main/java/org/apache/arrow/gandiva/evaluator/FunctionSignature.java: ## @@ -73,7 +75,8 @@ public boolean equals(Object signature) { @Override

Re: [PR] GH-44055: [Java] Finalize ErrorProne Warnings to be considered as Errors [arrow]

2024-09-13 Thread via GitHub
vibhatha commented on code in PR #44056: URL: https://github.com/apache/arrow/pull/44056#discussion_r1759635983 ## java/flight/flight-core/src/main/java/org/apache/arrow/flight/SetSessionOptionsResult.java: ## @@ -45,12 +45,14 @@ static ErrorValue fromProtocol(Flight.SetSession

Re: [PR] GH-44055: [Java] Finalize ErrorProne Warnings to be considered as Errors [arrow]

2024-09-13 Thread via GitHub
lidavidm commented on code in PR #44056: URL: https://github.com/apache/arrow/pull/44056#discussion_r1759631455 ## java/flight/flight-core/src/main/java/org/apache/arrow/flight/SetSessionOptionsResult.java: ## @@ -45,12 +45,14 @@ static ErrorValue fromProtocol(Flight.SetSession

Re: [I] [Python] read_row_group fails with Nested data conversions not implemented for chunked array outputs [arrow]

2024-09-13 Thread via GitHub
yuxi-liu-wired commented on issue #21526: URL: https://github.com/apache/arrow/issues/21526#issuecomment-2350741670 > In case someone wants to load a pandas dataframe I want to share my workaround. > > For me installing `fastparquet` and specifying the `eninge='fastparquet'` argument

Re: [I] [Go][Format][FlightRPC] Update go_package in Flight.proto and FlightSql.proto [arrow]

2024-09-13 Thread via GitHub
kou commented on issue #44034: URL: https://github.com/apache/arrow/issues/44034#issuecomment-2350741311 Issue resolved by pull request 44035 https://github.com/apache/arrow/pull/44035 -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] GH-44034: [Go][Format][FlightRPC] Update go_package in Flight.proto and FlightSql.proto [arrow]

2024-09-13 Thread via GitHub
kou merged PR #44035: URL: https://github.com/apache/arrow/pull/44035 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.or

Re: [PR] http/python: Add simple HTTP GET example with FastAPI and Uvicorn [arrow-experiments]

2024-09-13 Thread via GitHub
felipecrv commented on code in PR #37: URL: https://github.com/apache/arrow-experiments/pull/37#discussion_r1759616392 ## http/get_simple/python/server/fastapi_uvicorn/server.py: ## @@ -0,0 +1,86 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contrib

Re: [PR] Improve performance of set_bits by avoiding to set individual bits [arrow-rs]

2024-09-13 Thread via GitHub
kazuyukitanimura commented on code in PR #6288: URL: https://github.com/apache/arrow-rs/pull/6288#discussion_r1759566843 ## arrow-buffer/src/util/bit_mask.rs: ## @@ -185,4 +277,40 @@ mod tests { assert_eq!(destination, expected_data); assert_eq!(result, expecte

Re: [I] [C++][Compute] `_mm256_set_m128i()` is unavailable on OpenSUSE 15.1 (GCC 7.5) [arrow]

2024-09-13 Thread via GitHub
assignUser commented on issue #44098: URL: https://github.com/apache/arrow/issues/44098#issuecomment-2350657640 Though I am not sure if the opensuse job is really important, it's not an official flavour and tbh I don't think there is a huge R demographic on it... @jonkeane what do you think

Re: [PR] Implement set_bits fuzz test [arrow-rs]

2024-09-13 Thread via GitHub
alamb commented on code in PR #6394: URL: https://github.com/apache/arrow-rs/pull/6394#discussion_r1759595494 ## arrow-buffer/src/util/bit_mask.rs: ## @@ -64,125 +64,235 @@ pub fn set_bits( #[cfg(test)] mod tests { use super::*; +use crate::bit_util::unset_bit; +u

Re: [PR] Implement set_bits fuzz test [arrow-rs]

2024-09-13 Thread via GitHub
alamb commented on code in PR #6394: URL: https://github.com/apache/arrow-rs/pull/6394#discussion_r1759595386 ## arrow-buffer/src/util/bit_mask.rs: ## @@ -64,125 +64,235 @@ pub fn set_bits( #[cfg(test)] mod tests { use super::*; +use crate::bit_util::unset_bit; +u

Re: [PR] Improve performance of set_bits by avoiding to set individual bits [arrow-rs]

2024-09-13 Thread via GitHub
alamb commented on code in PR #6288: URL: https://github.com/apache/arrow-rs/pull/6288#discussion_r1759593847 ## arrow-buffer/src/util/bit_mask.rs: ## @@ -185,4 +277,40 @@ mod tests { assert_eq!(destination, expected_data); assert_eq!(result, expected_null_coun

Re: [PR] GH-107: Add test CI for arm Runners [arrow-go]

2024-09-13 Thread via GitHub
kou commented on PR #123: URL: https://github.com/apache/arrow-go/pull/123#issuecomment-2350607454 Ah, we should have check `${GITHUB_REPOSITORY_OWNER}` like https://github.com/apache/arrow/blob/62060ab55be2dc811e5abf0c5aba9834d3056ee1/.github/workflows/go.yml#L77-L93 to prevent running the

Re: [PR] Improve performance of set_bits by avoiding to set individual bits [arrow-rs]

2024-09-13 Thread via GitHub
kazuyukitanimura commented on PR #6288: URL: https://github.com/apache/arrow-rs/pull/6288#issuecomment-2350605785 > Thank you @kazuyukitanimura -- I believe this code is correct, but I think it needs some more testing for me to be super confident it in, especially given its profuse use of `

Re: [PR] Implement set_bits fuzz test [arrow-rs]

2024-09-13 Thread via GitHub
alamb commented on code in PR #6394: URL: https://github.com/apache/arrow-rs/pull/6394#discussion_r1759590955 ## arrow-buffer/src/util/bit_mask.rs: ## @@ -64,125 +64,235 @@ pub fn set_bits( #[cfg(test)] mod tests { use super::*; +use crate::bit_util::unset_bit; +u

Re: [PR] Implement set_bits fuzz test [arrow-rs]

2024-09-13 Thread via GitHub
alamb commented on code in PR #6394: URL: https://github.com/apache/arrow-rs/pull/6394#discussion_r1759590695 ## arrow-buffer/src/util/bit_mask.rs: ## @@ -64,125 +64,235 @@ pub fn set_bits( #[cfg(test)] mod tests { use super::*; +use crate::bit_util::unset_bit; +u

Re: [I] [C++] Can't build `arrow::util::Process` with Emscripten [arrow]

2024-09-13 Thread via GitHub
kou commented on issue #44096: URL: https://github.com/apache/arrow/issues/44096#issuecomment-2350597918 Issue resolved by pull request 44097 https://github.com/apache/arrow/pull/44097 -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[PR] Implement set_bits fuzz test [arrow-rs]

2024-09-13 Thread via GitHub
alamb opened a new pull request, #6394: URL: https://github.com/apache/arrow-rs/pull/6394 # Which issue does this PR close? Part of https://github.com/apache/arrow-rs/pull/6288 # Rationale for this change The code in https://github.com/apache/arrow-rs/pull/6288 is tricky

Re: [PR] GH-44096: [C++] Don't use Boost.Process with Emscripten [arrow]

2024-09-13 Thread via GitHub
kou merged PR #44097: URL: https://github.com/apache/arrow/pull/44097 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.or

Re: [PR] Example for Python HTTP Post Arrow client and server [arrow-experiments]

2024-09-13 Thread via GitHub
ianmcook closed pull request #27: Example for Python HTTP Post Arrow client and server URL: https://github.com/apache/arrow-experiments/pull/27 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

Re: [PR] http/python: Add simple HTTP GET example with FastAPI and Uvicorn [arrow-experiments]

2024-09-13 Thread via GitHub
ianmcook commented on code in PR #37: URL: https://github.com/apache/arrow-experiments/pull/37#discussion_r175950 ## http/get_simple/python/server/fastapi_uvicorn/server.py: ## @@ -0,0 +1,86 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contribu

Re: [PR] Example for Python HTTP Post Arrow client and server [arrow-experiments]

2024-09-13 Thread via GitHub
ianmcook commented on PR #27: URL: https://github.com/apache/arrow-experiments/pull/27#issuecomment-2350503906 I moved the FastAPI + Uvicorn server piece of this to #37 (with some small changes). -- This is an automated message from the Apache Git Service. To respond to the message, pleas

[PR] http/python: Add simple HTTP GET example with FastAPI and Uvicorn [arrow-experiments]

2024-09-13 Thread via GitHub
ianmcook opened a new pull request, #37: URL: https://github.com/apache/arrow-experiments/pull/37 Closes https://github.com/apache/arrow/issues/40869. Supercedes #27 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] feat: Implement read support for String/Binary View types [arrow-nanoarrow]

2024-09-13 Thread via GitHub
WillAyd commented on code in PR #596: URL: https://github.com/apache/arrow-nanoarrow/pull/596#discussion_r1759567403 ## src/nanoarrow/common/array.c: ## @@ -148,12 +156,17 @@ ArrowErrorCode ArrowArrayInitFromType(struct ArrowArray* array, ArrowBitmapInit(&private_data->bitma

Re: [PR] Improve performance of set_bits by avoiding to set individual bits [arrow-rs]

2024-09-13 Thread via GitHub
kazuyukitanimura commented on code in PR #6288: URL: https://github.com/apache/arrow-rs/pull/6288#discussion_r1759566843 ## arrow-buffer/src/util/bit_mask.rs: ## @@ -185,4 +277,40 @@ mod tests { assert_eq!(destination, expected_data); assert_eq!(result, expecte

Re: [PR] GH-43589: [Python] add bindings for additional Buffer class non-CPU methods [arrow]

2024-09-13 Thread via GitHub
github-actions[bot] commented on PR #43590: URL: https://github.com/apache/arrow/pull/43590#issuecomment-2350454623 Revision: 2e1090558d5d399b060a7051eb9d05caa2174821 Submitted crossbow builds: [ursacomputing/crossbow @ actions-6f97bc8a50](https://github.com/ursacomputing/crossbow/bra

Re: [PR] GH-43589: [Python] add bindings for additional Buffer class non-CPU methods [arrow]

2024-09-13 Thread via GitHub
anjakefala commented on PR #43590: URL: https://github.com/apache/arrow/pull/43590#issuecomment-2350445820 @github-actions crossbow submit test-cuda-python -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] GH-43589: [Python] add bindings for additional Buffer class non-CPU methods [arrow]

2024-09-13 Thread via GitHub
anjakefala commented on PR #43590: URL: https://github.com/apache/arrow/pull/43590#issuecomment-2350445100 @danepitkin We decided to move those to a separate PR! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] Improve performance of set_bits by avoiding to set individual bits [arrow-rs]

2024-09-13 Thread via GitHub
alamb commented on code in PR #6288: URL: https://github.com/apache/arrow-rs/pull/6288#discussion_r1759540314 ## arrow-buffer/src/util/bit_mask.rs: ## @@ -185,4 +277,40 @@ mod tests { assert_eq!(destination, expected_data); assert_eq!(result, expected_null_coun

Re: [PR] Added PartialOrd for FixedSizeListArray (and struct members) [arrow-rs]

2024-09-13 Thread via GitHub
ngli-me closed pull request #6393: Added PartialOrd for FixedSizeListArray (and struct members) URL: https://github.com/apache/arrow-rs/pull/6393 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Added PartialOrd for FixedSizeListArray (and struct members) [arrow-rs]

2024-09-13 Thread via GitHub
ngli-me commented on PR #6393: URL: https://github.com/apache/arrow-rs/pull/6393#issuecomment-2350293406 Ah, I didn't even realize that existed, that's my bad. Sorry I'm newer to these projects, just been poking around. In that case, yeah this is not needed, I'll close it out. Thanks! --

Re: [PR] Improve performance of set_bits by avoiding to set individual bits [arrow-rs]

2024-09-13 Thread via GitHub
kazuyukitanimura commented on code in PR #6288: URL: https://github.com/apache/arrow-rs/pull/6288#discussion_r1759537901 ## arrow-buffer/src/util/bit_mask.rs: ## @@ -30,35 +29,128 @@ pub fn set_bits( offset_read: usize, len: usize, ) -> usize { +assert!(offset_wri

Re: [I] [Dev][Archery][Integration] Reduce needless test matrix [arrow]

2024-09-13 Thread via GitHub
kou commented on issue #44062: URL: https://github.com/apache/arrow/issues/44062#issuecomment-2350266865 Yes. The following change is needed with the current #44099 implementation: ```diff diff --git a/.github/workflows/integration.yml b/.github/workflows/integration.yml index 4

Re: [PR] [Parquet] Recover from panic in file reader [arrow-go]

2024-09-13 Thread via GitHub
kou commented on PR #124: URL: https://github.com/apache/arrow-go/pull/124#issuecomment-2350250134 FYI: We can use `Co-authored-by` trailer for this case. See also: https://docs.github.com/en/pull-requests/committing-changes-to-your-project/creating-and-editing-commits/creating-a-commit-with

Re: [PR] [Parquet] Recover from panic in file reader [arrow-go]

2024-09-13 Thread via GitHub
kou commented on PR #124: URL: https://github.com/apache/arrow-go/pull/124#issuecomment-2350242160 Fixes apache/arrow#43605. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [I] [Go][Parquet] Panic while reading corrupted parquet file [arrow]

2024-09-13 Thread via GitHub
kou commented on issue #43605: URL: https://github.com/apache/arrow/issues/43605#issuecomment-2350243597 Fixed by apache/arrow-go#124. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Added PartialOrd for FixedSizeListArray (and struct members) [arrow-rs]

2024-09-13 Thread via GitHub
tustvold commented on PR #6393: URL: https://github.com/apache/arrow-rs/pull/6393#issuecomment-2350240572 This won't derive an implementation if PartialOrd that has any real meaning, for example nulls won't behave in a sensible manner. I think datafusion should instead use the logic a

Re: [PR] GH-21: Add release CI [arrow-go]

2024-09-13 Thread via GitHub
kou commented on code in PR #122: URL: https://github.com/apache/arrow-go/pull/122#discussion_r1759525985 ## dev/release/verify_rc.sh: ## @@ -0,0 +1,227 @@ +#!/usr/bin/env bash +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreem

Re: [PR] MINOR: [Java] Bump com.gradle:develocity-maven-extension from 1.21.6 to 1.22.1 in /java [arrow]

2024-09-13 Thread via GitHub
github-actions[bot] commented on PR #44108: URL: https://github.com/apache/arrow/pull/44108#issuecomment-2350199879 Revision: ab71532be347d0819b7531cd190a2601bbce96c8 Submitted crossbow builds: [ursacomputing/crossbow @ actions-25c9f7c7b5](https://github.com/ursacomputing/crossbow/bra

Re: [PR] MINOR: [C#] Bump Google.Protobuf from 3.28.0 to 3.28.1 in /csharp [arrow]

2024-09-13 Thread via GitHub
conbench-apache-arrow[bot] commented on PR #44110: URL: https://github.com/apache/arrow/pull/44110#issuecomment-2350194332 After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit aab17c330190e90b5aebde243bec500e6a1e8eda. There were no

Re: [PR] MINOR: [Java] Bump com.gradle:develocity-maven-extension from 1.21.6 to 1.22.1 in /java [arrow]

2024-09-13 Thread via GitHub
danepitkin commented on PR #44108: URL: https://github.com/apache/arrow/pull/44108#issuecomment-2350190474 @github-actions crossbow submit java-jars -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

Re: [I] [C++][Compute] `_mm256_set_m128i()` is unavailable on OpenSUSE 15.1 (GCC 7.5) [arrow]

2024-09-13 Thread via GitHub
kou commented on issue #44098: URL: https://github.com/apache/arrow/issues/44098#issuecomment-2350169135 OK. @zanmato1984 Could you try a workaround for the platform? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] Clear string-tracking hash table when ByteView deduplication is enabled [arrow-rs]

2024-09-13 Thread via GitHub
alamb commented on PR #6385: URL: https://github.com/apache/arrow-rs/pull/6385#issuecomment-2350144731 > ℹ️ This is my first PR to the Arrow repository as well as to any Apache repository. Welcome and thank you -- This is an automated message from the Apache Git Service. To respo

Re: [PR] Clear string-tracking hash table when ByteView deduplication is enabled [arrow-rs]

2024-09-13 Thread via GitHub
alamb commented on code in PR #6385: URL: https://github.com/apache/arrow-rs/pull/6385#discussion_r1759504804 ## arrow-array/src/builder/generic_bytes_view_builder.rs: ## @@ -590,6 +593,20 @@ mod tests { assert_eq!(array.views().get(1), array.views().get(5)); } +

Re: [PR] Clear string-tracking hash table when ByteView deduplication is enabled [arrow-rs]

2024-09-13 Thread via GitHub
alamb merged PR #6385: URL: https://github.com/apache/arrow-rs/pull/6385 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache

Re: [I] StringViewBuilder with deduplication does not clear observed values [arrow-rs]

2024-09-13 Thread via GitHub
alamb closed issue #6384: StringViewBuilder with deduplication does not clear observed values URL: https://github.com/apache/arrow-rs/issues/6384 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [I] Add Flight JDBC Connection String example [arrow-flight-sql-postgresql]

2024-09-13 Thread via GitHub
kou commented on issue #190: URL: https://github.com/apache/arrow-flight-sql-postgresql/issues/190#issuecomment-2350138705 Right. It's a server side configuration. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

Re: [I] [Dev][Archery][Integration] Reduce needless test matrix [arrow]

2024-09-13 Thread via GitHub
alamb commented on issue #44062: URL: https://github.com/apache/arrow/issues/44062#issuecomment-2350133490 > In apache/arror-rs, the following patterns are redundant because they should be done in apache/arrow: Can you give me some hint about how to reduce the test matrix in arrow-rs

Re: [I] Interval parsing interprets `5 day hour` wrongly [arrow-rs]

2024-09-13 Thread via GitHub
alamb commented on issue #6390: URL: https://github.com/apache/arrow-rs/issues/6390#issuecomment-2350102349 I think `5 day hour` is a pretty uncommon usecase . Thank you for filing this -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] MINOR: [CI] Use new boost feedstock [arrow]

2024-09-13 Thread via GitHub
kou commented on code in PR #44113: URL: https://github.com/apache/arrow/pull/44113#discussion_r1759453688 ## ci/conda_env_cpp.txt: ## @@ -22,7 +22,7 @@ azure-storage-blobs-cpp>=12.10.0 azure-storage-common-cpp>=12.5.0 azure-storage-files-datalake-cpp>=12.9.0 benchmark>=1.6.0

Re: [PR] feat: Implement read support for String/Binary View types [arrow-nanoarrow]

2024-09-13 Thread via GitHub
paleolimbot commented on code in PR #596: URL: https://github.com/apache/arrow-nanoarrow/pull/596#discussion_r1759427744 ## src/nanoarrow/common/array.c: ## @@ -449,14 +462,33 @@ static ArrowErrorCode ArrowArrayFinalizeBuffers(struct ArrowArray* array) { NANOARROW_RETURN_N

Re: [PR] GH-20981: [Flight][Integration] Generic gRPC Flight Integration Server and Runner [arrow]

2024-09-13 Thread via GitHub
github-actions[bot] commented on PR #44115: URL: https://github.com/apache/arrow/pull/44115#issuecomment-2350084152 :warning: GitHub issue #20981 **has been automatically assigned in GitHub** to PR creator. -- This is an automated message from the Apache Git Service. To respond to the mes

[PR] GH-20981: [Flight][Integration] Generic gRPC Flight Integration Server and Runner [arrow]

2024-09-13 Thread via GitHub
joellubi opened a new pull request, #44115: URL: https://github.com/apache/arrow/pull/44115 ### Rationale for this change ### What changes are included in this PR? ### Are these changes tested? ### Are there any user-facing changes?

[PR] Added PartialOrd for FixedSizeListArray [arrow-rs]

2024-09-13 Thread via GitHub
ngli-me opened a new pull request, #6393: URL: https://github.com/apache/arrow-rs/pull/6393 # Which issue does this PR close? Related https://github.com/apache/datafusion/issues/8932. # Rationale for this change Allows upstream users of FixedSizeListArray

Re: [PR] GH-43872: [Go][CI] Disable Dependabot for Go [arrow]

2024-09-13 Thread via GitHub
conbench-apache-arrow[bot] commented on PR #44102: URL: https://github.com/apache/arrow/pull/44102#issuecomment-2350021779 After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 5c82b9dfe027d34274b31f7fb068344730d078cc. There were no

Re: [I] [R] Add Rocky and opensuse to the allowlist for libarrow binaries [arrow]

2024-09-13 Thread via GitHub
nealrichardson commented on issue #44114: URL: https://github.com/apache/arrow/issues/44114#issuecomment-2349830647 Yep, seems safe to just do. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [I] adbc_ingest is working better, but still has some COPY INTO issues after adbc 1.2 release [arrow-adbc]

2024-09-13 Thread via GitHub
davlee1972 commented on issue #2128: URL: https://github.com/apache/arrow-adbc/issues/2128#issuecomment-2349813437 I ran multiple tests and setting ingest copy into concurrency to "0" worked across all tests.. The problem looks like COPY INTO completions are not being tracked and when

Re: [I] Request to support Run-End Encoded Layout in Java C Data interface [arrow]

2024-09-13 Thread via GitHub
danepitkin commented on issue #44065: URL: https://github.com/apache/arrow/issues/44065#issuecomment-2349810250 RunEndEncoded Vectors are not yet implemented in Arrow Java. There's a PR in progress to add it: https://github.com/apache/arrow/pull/43888 -- This is an automated message from

Re: [PR] MINOR: [Java] Bump com.google.api.grpc:proto-google-common-protos from 2.43.0 to 2.44.0 in /java [arrow]

2024-09-13 Thread via GitHub
danepitkin merged PR #44104: URL: https://github.com/apache/arrow/pull/44104 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.ap

Re: [I] `compute::binary_mut` returns `Err(PrimitiveArray)` only with certain arrays [arrow-rs]

2024-09-13 Thread via GitHub
viirya commented on issue #6374: URL: https://github.com/apache/arrow-rs/issues/6374#issuecomment-2349788859 Looking into this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

Re: [PR] GH-21: Add release CI [arrow-go]

2024-09-13 Thread via GitHub
zeroshade commented on code in PR #122: URL: https://github.com/apache/arrow-go/pull/122#discussion_r1759293506 ## dev/release/verify_rc.sh: ## @@ -0,0 +1,227 @@ +#!/usr/bin/env bash +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license

Re: [PR] [Parquet] Recover from panic in file reader [arrow-go]

2024-09-13 Thread via GitHub
zeroshade merged PR #124: URL: https://github.com/apache/arrow-go/pull/124 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apac

Re: [PR] GH-44055: [Java] Finalize ErrorProne Warnings to be considered as Errors [arrow]

2024-09-13 Thread via GitHub
danepitkin commented on code in PR #44056: URL: https://github.com/apache/arrow/pull/44056#discussion_r1759072522 ## java/gandiva/src/main/java/org/apache/arrow/gandiva/evaluator/Filter.java: ## @@ -42,7 +42,10 @@ public class Filter { private final JniWrapper wrapper; p

Re: [I] [R] How to pass Arrow objects like Table between C++ and R? [arrow]

2024-09-13 Thread via GitHub
ajinkya-k commented on issue #43675: URL: https://github.com/apache/arrow/issues/43675#issuecomment-2349765150 Thanks! I will give it a try -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

Re: [PR] GH-44085: [CI][R] Update Ubuntu version for R force test [arrow]

2024-09-13 Thread via GitHub
jonkeane commented on code in PR #44087: URL: https://github.com/apache/arrow/pull/44087#discussion_r175923 ## ci/docker/linux-apt-r.dockerfile: ## @@ -81,25 +82,23 @@ RUN cat /arrow/ci/etc/rprofile >> $(R RHOME)/etc/Rprofile.site # Also ensure parallel compilation of C/C+

Re: [PR] GH-43809: [Docs] Update extension type examples to not use UUID [arrow]

2024-09-13 Thread via GitHub
ianmcook commented on PR #43849: URL: https://github.com/apache/arrow/pull/43849#issuecomment-2349702544 > Hi @ianmcook i did do the sync and also setup archery locally to see if I could do some debugging separate from the long GA flow. I’ve resolved one issue (the missing “unregister” call

Re: [PR] GH-43809: [Docs] Update extension type examples to not use UUID [arrow]

2024-09-13 Thread via GitHub
ianmcook commented on code in PR #43849: URL: https://github.com/apache/arrow/pull/43849#discussion_r1759254758 ## python/pyarrow/types.pxi: ## @@ -1618,59 +1618,79 @@ cdef class ExtensionType(BaseExtensionType): Examples -Define a UuidType extension typ

Re: [PR] GH-43809: [Docs] Update extension type examples to not use UUID [arrow]

2024-09-13 Thread via GitHub
ianmcook commented on code in PR #43849: URL: https://github.com/apache/arrow/pull/43849#discussion_r1759254758 ## python/pyarrow/types.pxi: ## @@ -1618,59 +1618,79 @@ cdef class ExtensionType(BaseExtensionType): Examples -Define a UuidType extension typ

Re: [PR] GH-43605: [Go][Parquet] Recover from panic in file reader [arrow]

2024-09-13 Thread via GitHub
zeroshade closed pull request #43607: GH-43605: [Go][Parquet] Recover from panic in file reader URL: https://github.com/apache/arrow/pull/43607 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

Re: [PR] GH-43605: [Go][Parquet] Recover from panic in file reader [arrow]

2024-09-13 Thread via GitHub
zeroshade commented on PR #43607: URL: https://github.com/apache/arrow/pull/43607#issuecomment-2349654115 Closing this to move it to https://github.com/apache/arrow-go/pull/124 for the new Arrow Go repo. -- This is an automated message from the Apache Git Service. To respond to the messag

[PR] [Parquet] Recover from panic in file reader [arrow-go]

2024-09-13 Thread via GitHub
zeroshade opened a new pull request, #124: URL: https://github.com/apache/arrow-go/pull/124 see https://github.com/apache/arrow/pull/43607 original author: @don4get -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

Re: [PR] GH-43809: [Docs] Update extension type examples to not use UUID [arrow]

2024-09-13 Thread via GitHub
ianmcook commented on code in PR #43849: URL: https://github.com/apache/arrow/pull/43849#discussion_r1759254758 ## python/pyarrow/types.pxi: ## @@ -1618,59 +1618,79 @@ cdef class ExtensionType(BaseExtensionType): Examples -Define a UuidType extension typ

Re: [PR] fix: Stop losing precision and scale when casting decimal to dictionary [arrow-rs]

2024-09-13 Thread via GitHub
viirya commented on code in PR #6383: URL: https://github.com/apache/arrow-rs/pull/6383#discussion_r1759200026 ## arrow-cast/src/cast/dictionary.rs: ## @@ -203,10 +203,36 @@ pub(crate) fn cast_to_dictionary( UInt32 => pack_numeric_to_dictionary::(array, dict_value_type

Re: [PR] fix: Stop losing precision and scale when casting decimal to dictionary [arrow-rs]

2024-09-13 Thread via GitHub
viirya commented on code in PR #6383: URL: https://github.com/apache/arrow-rs/pull/6383#discussion_r1759200026 ## arrow-cast/src/cast/dictionary.rs: ## @@ -203,10 +203,36 @@ pub(crate) fn cast_to_dictionary( UInt32 => pack_numeric_to_dictionary::(array, dict_value_type

Re: [PR] fix: Stop losing precision and scale when casting decimal to dictionary [arrow-rs]

2024-09-13 Thread via GitHub
viirya commented on code in PR #6383: URL: https://github.com/apache/arrow-rs/pull/6383#discussion_r1759200026 ## arrow-cast/src/cast/dictionary.rs: ## @@ -203,10 +203,36 @@ pub(crate) fn cast_to_dictionary( UInt32 => pack_numeric_to_dictionary::(array, dict_value_type

Re: [PR] stop panic in `MetadataLoader` on invalid data [arrow-rs]

2024-09-13 Thread via GitHub
etseidl commented on code in PR #6367: URL: https://github.com/apache/arrow-rs/pull/6367#discussion_r1759190210 ## parquet/src/arrow/async_reader/metadata.rs: ## @@ -57,6 +57,12 @@ impl MetadataLoader { return Err(ParquetError::EOF(format!( "file si

Re: [I] object_store: Retry on connection duration timeouts? [arrow-rs]

2024-09-13 Thread via GitHub
itsjunetime commented on issue #6287: URL: https://github.com/apache/arrow-rs/issues/6287#issuecomment-2349389670 take -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] MINOR: [CI] Use new boost feedstock [arrow]

2024-09-13 Thread via GitHub
ursabot commented on PR #44113: URL: https://github.com/apache/arrow/pull/44113#issuecomment-2349377280 Benchmark runs are scheduled for commit 13657ab5217b6f246c439d7a440a6b086914fb1b. Watch https://buildkite.com/apache-arrow and https://conbench.ursa.dev for updates. A comment will be po

Re: [PR] MINOR: [CI] Use new boost feedstock [arrow]

2024-09-13 Thread via GitHub
austin3dickey commented on PR #44113: URL: https://github.com/apache/arrow/pull/44113#issuecomment-2349376644 @ursabot please benchmark -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

Re: [PR] MINOR: [CI] Use new boost feedstock [arrow]

2024-09-13 Thread via GitHub
github-actions[bot] commented on PR #44113: URL: https://github.com/apache/arrow/pull/44113#issuecomment-2349366440 Revision: 13657ab5217b6f246c439d7a440a6b086914fb1b Submitted crossbow builds: [ursacomputing/crossbow @ actions-75f24b835b](https://github.com/ursacomputing/crossbow/bra

Re: [PR] MINOR: [CI] Use new boost feedstock [arrow]

2024-09-13 Thread via GitHub
github-actions[bot] commented on PR #44113: URL: https://github.com/apache/arrow/pull/44113#issuecomment-2349332499 Revision: c43668d6e87c234bfc365d6eb6b7738189557e5f Submitted crossbow builds: [ursacomputing/crossbow @ actions-84fa4890ac](https://github.com/ursacomputing/crossbow/bra

Re: [PR] MINOR: [CI] Use new boost feedstock [arrow]

2024-09-13 Thread via GitHub
assignUser commented on PR #44113: URL: https://github.com/apache/arrow/pull/44113#issuecomment-2349328423 @github-actions crossbow submit -g conda -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[PR] MINOR: [CI] Use new boost feedstock [arrow]

2024-09-13 Thread via GitHub
assignUser opened a new pull request, #44113: URL: https://github.com/apache/arrow/pull/44113 ### Rationale for this change The boost-cpp feedstock was archived. ### What changes are included in this PR? Switch to the new package name `libboost-devel`. ### Are these ch

  1   2   >