Re: [PR] [C++][Acero] Fix BackpressureConcurrentQueue::Pop() when empty [arrow]

2025-02-04 Thread via GitHub
mapleFU commented on code in PR #45421: URL: https://github.com/apache/arrow/pull/45421#discussion_r1942372346 ## cpp/src/arrow/acero/concurrent_queue_internal.h: ## @@ -35,8 +35,7 @@ class ConcurrentQueue { // T Pop() { std::unique_lock lock(mutex_); -cond_.wait(

Re: [PR] [C++][Acero] Fix BackpressureConcurrentQueue::Pop() when empty [arrow]

2025-02-04 Thread via GitHub
gitmodimo commented on code in PR #45421: URL: https://github.com/apache/arrow/pull/45421#discussion_r1942369015 ## cpp/src/arrow/acero/concurrent_queue_internal.h: ## @@ -35,8 +35,7 @@ class ConcurrentQueue { // T Pop() { std::unique_lock lock(mutex_); -cond_.wai

Re: [I] [Release] 18.2.0 [arrow-java]

2025-02-04 Thread via GitHub
kou commented on issue #574: URL: https://github.com/apache/arrow-java/issues/574#issuecomment-2635842172 I'll create RC2 tomorrow. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] CI: add benchmark workflow and script [arrow-go]

2025-02-04 Thread via GitHub
singh1203 commented on PR #250: URL: https://github.com/apache/arrow-go/pull/250#issuecomment-2635809993 Hi @kou Maybe we could do another runner's round. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

Re: [I] [Release] .env preparation description is missing in dev/release/README.md [arrow-java]

2025-02-04 Thread via GitHub
kou commented on issue #587: URL: https://github.com/apache/arrow-java/issues/587#issuecomment-2635838722 Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubsc

[PR] GH-588: [Release] Increase wait interval in `dev/release/release_rc.sh` [arrow-java]

2025-02-04 Thread via GitHub
kou opened a new pull request, #589: URL: https://github.com/apache/arrow-java/pull/589 Fixes GH-588. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail

Re: [I] [Release] 18.2.0 [arrow-java]

2025-02-04 Thread via GitHub
kou commented on issue #574: URL: https://github.com/apache/arrow-java/issues/574#issuecomment-2635830474 Hmm... It reached a secondary rate limit again... https://github.com/apache/arrow-java/actions/runs/13151205894/job/36700236201#step:3:17 ```text HTTP 403: You ha

Re: [I] [Release] .env preparation description is missing in dev/release/README.md [arrow-java]

2025-02-04 Thread via GitHub
jbonofre commented on issue #587: URL: https://github.com/apache/arrow-java/issues/587#issuecomment-2635822953 Yup, good point. Let me propose a PR about that if it works for you 😄 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

Re: [I] Use `ubuntu-24.04-arm` instead of self-hosted arm runner in CI [arrow-go]

2025-02-04 Thread via GitHub
kou commented on issue #267: URL: https://github.com/apache/arrow-go/issues/267#issuecomment-2635812268 Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscri

Re: [I] Use `ubuntu-24.04-arm` instead of self-hosted arm runner in CI [arrow-go]

2025-02-04 Thread via GitHub
singh1203 commented on issue #267: URL: https://github.com/apache/arrow-go/issues/267#issuecomment-2635806594 Hey @kou I would be happy to assist here; kindly assign -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] GH-579: Add and fix LICENSE.txt and NOTICE.txt in the distributed artifacts [arrow-java]

2025-02-04 Thread via GitHub
kou commented on PR #578: URL: https://github.com/apache/arrow-java/pull/578#issuecomment-2635768950 Thanks! I'll create cut an RC. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] GH-45362: [C++] Fix identity cast for time scalar [arrow]

2025-02-04 Thread via GitHub
mapleFU commented on code in PR #45370: URL: https://github.com/apache/arrow/pull/45370#discussion_r1942275704 ## cpp/src/arrow/scalar_test.cc: ## @@ -156,6 +157,45 @@ TEST(TestBooleanScalar, Cast) { } } +TEST(TestScalar, IndentityCast) { + random::RandomArrayGenerator ge

Re: [PR] GH-45362: [C++] Fix identity cast for time scalar [arrow]

2025-02-04 Thread via GitHub
mapleFU commented on code in PR #45370: URL: https://github.com/apache/arrow/pull/45370#discussion_r1942275285 ## cpp/src/arrow/scalar_test.cc: ## @@ -866,6 +866,9 @@ TEST(TestTimeScalars, Basics) { ASSERT_TRUE(first->Equals(*MakeScalar(ty, 5).ValueOrDie())); ASSERT_TR

Re: [PR] GH-579: Add and fix LICENSE.txt and NOTICE.txt in the distributed artifacts [arrow-java]

2025-02-04 Thread via GitHub
jbonofre commented on PR #578: URL: https://github.com/apache/arrow-java/pull/578#issuecomment-2635744222 @lidavidm @kou thanks for the review and merge. I'm doing a quick new run but I think we are good for the release. -- This is an automated message from the Apache Git Service. To res

Re: [PR] GH-579: Add and fix LICENSE.txt and NOTICE.txt in the distributed artifacts [arrow-java]

2025-02-04 Thread via GitHub
lidavidm merged PR #578: URL: https://github.com/apache/arrow-java/pull/578 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apa

Re: [PR] GH-579: Add and fix LICENSE.txt and NOTICE.txt in the distributed artifacts [arrow-java]

2025-02-04 Thread via GitHub
jbonofre commented on PR #578: URL: https://github.com/apache/arrow-java/pull/578#issuecomment-2635736474 > @jbonofre Can we merge this? Yes, we are good 👍 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] fix: first none in `ListArray` panics in `cast_with_options` [arrow-rs]

2025-02-04 Thread via GitHub
irenjj commented on code in PR #7065: URL: https://github.com/apache/arrow-rs/pull/7065#discussion_r1942246993 ## arrow-cast/src/cast/list.rs: ## @@ -88,11 +88,16 @@ where let mut mutable = MutableArrayData::new(vec![&values], nullable, cap); // The end position in val

Re: [PR] GH-45295: [Python][CI] Use tzdata package to get tzinfo database when testing Windows wheels [arrow]

2025-02-04 Thread via GitHub
amoeba commented on PR #45425: URL: https://github.com/apache/arrow/pull/45425#issuecomment-2635688308 Thanks for getting the jobs running, I'll check on them tomorrow. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

Re: [PR] GH-45295: [Python][CI] Use tzdata package to get tzinfo database when testing Windows wheels [arrow]

2025-02-04 Thread via GitHub
amoeba commented on code in PR #45425: URL: https://github.com/apache/arrow/pull/45425#discussion_r1942223874 ## ci/scripts/python_wheel_windows_test.bat: ## @@ -58,11 +58,14 @@ py -0p @REM Validate wheel contents %PYTHON_CMD% C:\arrow\ci\scripts\python_wheel_validate_contents

Re: [PR] GH-45295: [Python][CI] Use tzdata package to get tzinfo database when testing Windows wheels [arrow]

2025-02-04 Thread via GitHub
github-actions[bot] commented on PR #45425: URL: https://github.com/apache/arrow/pull/45425#issuecomment-2635664530 Revision: 29467e206d85e5101743a8783ef9fc5b8e210781 Submitted crossbow builds: [ursacomputing/crossbow @ actions-435df0c2a2](https://github.com/ursacomputing/crossbow/bra

Re: [PR] GH-45295: [Python][CI] Use tzdata package to get tzinfo database when testing Windows wheels [arrow]

2025-02-04 Thread via GitHub
amoeba commented on code in PR #45425: URL: https://github.com/apache/arrow/pull/45425#discussion_r1942221651 ## ci/scripts/python_wheel_windows_test.bat: ## @@ -58,11 +58,14 @@ py -0p @REM Validate wheel contents %PYTHON_CMD% C:\arrow\ci\scripts\python_wheel_validate_contents

Re: [PR] GH-45295: [Python][CI] Use tzdata package to get tzinfo database when testing Windows wheels [arrow]

2025-02-04 Thread via GitHub
kou commented on PR #45425: URL: https://github.com/apache/arrow/pull/45425#issuecomment-2635662397 @github-actions crossbow submit wheel-windows-* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] GH-45295: [Python][CI] Use tzdata package to get tzinfo database when testing Windows wheels [arrow]

2025-02-04 Thread via GitHub
github-actions[bot] commented on PR #45425: URL: https://github.com/apache/arrow/pull/45425#issuecomment-2635655973 ``` Unable to match any tasks for `wheel-windows-cp39-amd64` The Archery job run can be found at: https://github.com/apache/arrow/actions/runs/13149993032 ``` -- Th

Re: [PR] GH-45295: [Python][CI] Use tzdata package to get tzinfo database when testing Windows wheels [arrow]

2025-02-04 Thread via GitHub
kou commented on PR #45425: URL: https://github.com/apache/arrow/pull/45425#issuecomment-2635654747 @github-actions crossbow submit wheel-windows-cp39-amd64 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] GH-45295: [Python][CI] Use tzdata package to get tzinfo database when testing Windows wheels [arrow]

2025-02-04 Thread via GitHub
kou commented on code in PR #45425: URL: https://github.com/apache/arrow/pull/45425#discussion_r1942215856 ## ci/scripts/python_wheel_windows_test.bat: ## @@ -58,11 +58,14 @@ py -0p @REM Validate wheel contents %PYTHON_CMD% C:\arrow\ci\scripts\python_wheel_validate_contents.py

Re: [PR] GH-45295: [Python][CI] Use tzdata package to get tzinfo database when testing Windows wheels [arrow]

2025-02-04 Thread via GitHub
kou commented on code in PR #45425: URL: https://github.com/apache/arrow/pull/45425#discussion_r1942215482 ## ci/scripts/python_wheel_windows_test.bat: ## @@ -58,11 +58,14 @@ py -0p @REM Validate wheel contents %PYTHON_CMD% C:\arrow\ci\scripts\python_wheel_validate_contents.py

Re: [PR] GH-45295: [Python][CI] Use tzdata package to get tzinfo database when testing Windows wheels [arrow]

2025-02-04 Thread via GitHub
kou commented on code in PR #45425: URL: https://github.com/apache/arrow/pull/45425#discussion_r1942213246 ## ci/scripts/python_wheel_windows_test.bat: ## @@ -58,11 +58,14 @@ py -0p @REM Validate wheel contents %PYTHON_CMD% C:\arrow\ci\scripts\python_wheel_validate_contents.py

Re: [PR] GH-45295: [Python][CI] Use tzdata package to get tzinfo database when testing Windows wheels [arrow]

2025-02-04 Thread via GitHub
amoeba commented on PR #45425: URL: https://github.com/apache/arrow/pull/45425#issuecomment-2635637641 @kou is there a way to test this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

Re: [PR] GH-45295: [Python][CI] Use tzdata package to get tzinfo database when testing Windows wheels [arrow]

2025-02-04 Thread via GitHub
amoeba commented on code in PR #45425: URL: https://github.com/apache/arrow/pull/45425#discussion_r1942203941 ## ci/scripts/python_wheel_windows_test.bat: ## @@ -58,11 +58,14 @@ py -0p @REM Validate wheel contents %PYTHON_CMD% C:\arrow\ci\scripts\python_wheel_validate_contents

Re: [PR] GH-45295: [Python][CI] Use tzdata package to get tzinfo database when testing Windows wheels [arrow]

2025-02-04 Thread via GitHub
amoeba commented on code in PR #45425: URL: https://github.com/apache/arrow/pull/45425#discussion_r1942205440 ## ci/scripts/python_wheel_windows_test.bat: ## @@ -58,11 +58,14 @@ py -0p @REM Validate wheel contents %PYTHON_CMD% C:\arrow\ci\scripts\python_wheel_validate_contents

Re: [PR] GH-45295: [Python][CI] Use tzdata package to get tzinfo database when testing Windows wheels [arrow]

2025-02-04 Thread via GitHub
amoeba commented on code in PR #45425: URL: https://github.com/apache/arrow/pull/45425#discussion_r1942203941 ## ci/scripts/python_wheel_windows_test.bat: ## @@ -58,11 +58,14 @@ py -0p @REM Validate wheel contents %PYTHON_CMD% C:\arrow\ci\scripts\python_wheel_validate_contents

Re: [I] [Python][CI] test_download_tzdata_on_windows fails on Windows wheels due to CERTIFICATE_VERIFY_FAILED [arrow]

2025-02-04 Thread via GitHub
amoeba commented on issue #45295: URL: https://github.com/apache/arrow/issues/45295#issuecomment-2635632790 After reopening this and putting up a PR, I realize the issue here is only related but not the same as what's being fixed in https://github.com/apache/arrow/pull/45425. Should I open

Re: [PR] GH-45295: [Python][CI] Use tzdata package to get tzinfo database when testing Windows wheels [arrow]

2025-02-04 Thread via GitHub
github-actions[bot] commented on PR #45425: URL: https://github.com/apache/arrow/pull/45425#issuecomment-2635627294 ``` Unable to match any tasks for `wheel-windows-cp39-amd64` The Archery job run can be found at: https://github.com/apache/arrow/actions/runs/13149682761 ``` -- Th

Re: [PR] GH-45295: [Python][CI] Use tzdata package to get tzinfo database when testing Windows wheels [arrow]

2025-02-04 Thread via GitHub
amoeba commented on PR #45425: URL: https://github.com/apache/arrow/pull/45425#issuecomment-2635626316 @github-actions crossbow submit wheel-windows-cp39-amd64 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

Re: [PR] WIP: [Release] Verify release-19.0.1-rc0 [arrow]

2025-02-04 Thread via GitHub
amoeba commented on PR #45420: URL: https://github.com/apache/arrow/pull/45420#issuecomment-2635624315 PR over at https://github.com/apache/arrow/pull/45425. I didn't test the whole script since it needs to be tested as part of CI. -- This is an automated message from the Apache Git Servi

[PR] GH-45295: [Python][CI] Use tzdata package to get tzinfo database when testing Windows wheels [arrow]

2025-02-04 Thread via GitHub
amoeba opened a new pull request, #45425: URL: https://github.com/apache/arrow/pull/45425 ### Rationale for this change The current version of this script pulls the tzinfo database from a URL that's not stable. Instead of finding another stable URL or hosting a version ourselves, @ko

Re: [PR] GH-45295: [Python][CI] Use tzdata package to get tzinfo database when testing Windows wheels [arrow]

2025-02-04 Thread via GitHub
github-actions[bot] commented on PR #45425: URL: https://github.com/apache/arrow/pull/45425#issuecomment-2635623554 :warning: GitHub issue #45295 **has been automatically assigned in GitHub** to PR creator. -- This is an automated message from the Apache Git Service. To respond to the mes

Re: [PR] WIP: [Release] Verify release-19.0.1-rc0 [arrow]

2025-02-04 Thread via GitHub
amoeba commented on PR #45420: URL: https://github.com/apache/arrow/pull/45420#issuecomment-2635606090 Will do that in a sec once I figure out the .bat script part. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

Re: [PR] WIP: [Release] Verify release-19.0.1-rc0 [arrow]

2025-02-04 Thread via GitHub
kou commented on PR #45420: URL: https://github.com/apache/arrow/pull/45420#issuecomment-2635604083 Wow! Could you open a PR that uses https://pypi.org/project/tzdata/ ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] WIP: [Release] Verify release-19.0.1-rc0 [arrow]

2025-02-04 Thread via GitHub
amoeba commented on PR #45420: URL: https://github.com/apache/arrow/pull/45420#issuecomment-2635598251 That seems like it could work, ```sh ❯ python -c "import os; from importlib import resources; print(os.path.join(resources.files('tzdata'), 'zoneinfo'));" C:\Users\Bryce\Temp\t

Re: [I] [GLib] Add `garrow_table_validate()` [arrow]

2025-02-04 Thread via GitHub
kou commented on issue #44761: URL: https://github.com/apache/arrow/issues/44761#issuecomment-2635597600 Issue resolved by pull request 45414 https://github.com/apache/arrow/pull/45414 -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] GH-44761: [GLib] Add garrow_table_validate() [arrow]

2025-02-04 Thread via GitHub
kou merged PR #45414: URL: https://github.com/apache/arrow/pull/45414 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.or

Re: [PR] GH-45423: [C++] Don't require Boost library with ARROW_TESTING=ON/ARROW_BUILD_SHARED=OFF [arrow]

2025-02-04 Thread via GitHub
wgtmac commented on code in PR #45424: URL: https://github.com/apache/arrow/pull/45424#discussion_r1942182890 ## cpp/cmake_modules/ThirdpartyToolchain.cmake: ## @@ -1256,14 +1256,19 @@ endif() # - Gandiva has a compile-time (header-only) dependency on Boost, not runtime. # - T

Re: [PR] WIP: [Release] Verify release-19.0.1-rc0 [arrow]

2025-02-04 Thread via GitHub
kou commented on PR #45420: URL: https://github.com/apache/arrow/pull/45420#issuecomment-2635586226 Hmm... I think that we don't want to update tzdata periodically... We may be able to use https://pypi.org/project/tzdata/ . -- This is an automated message from the Apache Git Service

Re: [PR] [C++][Acero] Fix BackpressureConcurrentQueue::Pop() when empty [arrow]

2025-02-04 Thread via GitHub
mapleFU commented on code in PR #45421: URL: https://github.com/apache/arrow/pull/45421#discussion_r1942176129 ## cpp/src/arrow/acero/concurrent_queue_internal.h: ## @@ -35,8 +35,7 @@ class ConcurrentQueue { // T Pop() { std::unique_lock lock(mutex_); -cond_.wait(

Re: [PR] WIP: [Release] Verify release-19.0.1-rc0 [arrow]

2025-02-04 Thread via GitHub
amoeba commented on PR #45420: URL: https://github.com/apache/arrow/pull/45420#issuecomment-2635583424 Thanks @kou. Does it make sense for us to host a copy ourselves? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

Re: [PR] GH-45423: [C++] Don't require Boost library with ARROW_TESTING=ON/ARROW_BUILD_SHARED=OFF [arrow]

2025-02-04 Thread via GitHub
kou commented on code in PR #45424: URL: https://github.com/apache/arrow/pull/45424#discussion_r1942166829 ## cpp/cmake_modules/ThirdpartyToolchain.cmake: ## @@ -1256,14 +1256,19 @@ endif() # - Gandiva has a compile-time (header-only) dependency on Boost, not runtime. # - Test

Re: [PR] GH-579: Add and fix LICENSE.txt and NOTICE.txt in the distributed artifacts [arrow-java]

2025-02-04 Thread via GitHub
kou commented on PR #578: URL: https://github.com/apache/arrow-java/pull/578#issuecomment-2635569182 @jbonofre Can we merge this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

Re: [PR] GH-45423: [C++] Don't require Boost library with ARROW_TESTING=ON/ARROW_BUILD_SHARED=OFF [arrow]

2025-02-04 Thread via GitHub
kou commented on code in PR #45424: URL: https://github.com/apache/arrow/pull/45424#discussion_r1942165470 ## cpp/cmake_modules/ThirdpartyToolchain.cmake: ## @@ -1256,14 +1256,19 @@ endif() # - Gandiva has a compile-time (header-only) dependency on Boost, not runtime. # - Test

Re: [PR] GH-45423: [C++] Don't require Boost library with ARROW_TESTING=ON/ARROW_BUILD_SHARED=OFF [arrow]

2025-02-04 Thread via GitHub
kou commented on code in PR #45424: URL: https://github.com/apache/arrow/pull/45424#discussion_r1942163931 ## cpp/cmake_modules/ThirdpartyToolchain.cmake: ## @@ -1256,14 +1256,19 @@ endif() # - Gandiva has a compile-time (header-only) dependency on Boost, not runtime. # - Test

Re: [PR] GH-44345: [C++][Parquet] Fully support arrow decimal32/64 in Parquet [arrow]

2025-02-04 Thread via GitHub
curioustien commented on PR #45351: URL: https://github.com/apache/arrow/pull/45351#issuecomment-2635560851 Quick update: Finding a good way to convert these decimal types and getting all the test passes take longer than I thought. Probably need a few more days -- This is an automated

Re: [PR] GH-45423: [C++] Don't require Boost library with ARROW_TESTING=ON/ARROW_BUILD_SHARED=OFF [arrow]

2025-02-04 Thread via GitHub
wgtmac commented on code in PR #45424: URL: https://github.com/apache/arrow/pull/45424#discussion_r1942156943 ## cpp/cmake_modules/ThirdpartyToolchain.cmake: ## @@ -1256,14 +1256,19 @@ endif() # - Gandiva has a compile-time (header-only) dependency on Boost, not runtime. # - T

Re: [I] Parsing a string column containing JSON values into a typed array [arrow-rs]

2025-02-04 Thread via GitHub
bionicles commented on issue #6522: URL: https://github.com/apache/arrow-rs/issues/6522#issuecomment-2635541751 well, you know how it is, a day or two of struggle writing new code saves 15-30 minutes reading the instructions i'm a major noob with arrow internals, and didn't know all t

[PR] Support converting large dates (i.e. +10999-12-31) from string to Date32 [arrow-rs]

2025-02-04 Thread via GitHub
phillipleblanc opened a new pull request, #7076: URL: https://github.com/apache/arrow-rs/pull/7076 # Which issue does this PR close? Closes #7073 # Rationale for this change Support for casting large dates from string to Date32. # What changes are included in this

Re: [PR] GH-45371: [C++] Fix data race in `SimpleRecordBatch::columns` [arrow]

2025-02-04 Thread via GitHub
colin-r-schultz commented on code in PR #45372: URL: https://github.com/apache/arrow/pull/45372#discussion_r1942123751 ## cpp/src/arrow/record_batch_test.cc: ## @@ -393,6 +399,27 @@ TEST_F(TestRecordBatch, RemoveColumnEmpty) { AssertBatchesEqual(*added, *batch1); } +TEST_F

Re: [PR] WIP: [Release] Verify release-19.0.1-rc0 [arrow]

2025-02-04 Thread via GitHub
kou commented on PR #45420: URL: https://github.com/apache/arrow/pull/45420#issuecomment-2635486651 It seems that https://cygwin.osuosl.org/noarch/release/tzdata/tzdata-2024a-1.tar.xz removed. https://github.com/apache/arrow/blob/1567be0d74c5ee90c3d989f6fcefb32c402a736c/ci/scripts/py

[PR] GH-45423: [C++] Don't require Boost library with ARROW_TESTING=ON/ARROW_BUILD_SHARED=OFF [arrow]

2025-02-04 Thread via GitHub
kou opened a new pull request, #45424: URL: https://github.com/apache/arrow/pull/45424 ### Rationale for this change We can use `libarrow_testing.a` without `boost::filesystem` when `arrow::util::Process` isn't used. ### What changes are included in this PR? `ARROW_TESTI

Re: [PR] GH-45423: [C++] Don't require Boost library with ARROW_TESTING=ON/ARROW_BUILD_SHARED=OFF [arrow]

2025-02-04 Thread via GitHub
github-actions[bot] commented on PR #45424: URL: https://github.com/apache/arrow/pull/45424#issuecomment-2635479694 Revision: 06a70af5b883ab11fd95a14f50ff0ad11351fd91 Submitted crossbow builds: [ursacomputing/crossbow @ actions-a3bc80b5c0](https://github.com/ursacomputing/crossbow/bra

Re: [PR] GH-45423: [C++] Don't require Boost library with ARROW_TESTING=ON/ARROW_BUILD_SHARED=OFF [arrow]

2025-02-04 Thread via GitHub
github-actions[bot] commented on PR #45424: URL: https://github.com/apache/arrow/pull/45424#issuecomment-2635477709 :warning: GitHub issue #45423 **has been automatically assigned in GitHub** to PR creator. -- This is an automated message from the Apache Git Service. To respond to the mes

Re: [PR] GH-45423: [C++] Don't require Boost library with ARROW_TESTING=ON/ARROW_BUILD_SHARED=OFF [arrow]

2025-02-04 Thread via GitHub
kou commented on PR #45424: URL: https://github.com/apache/arrow/pull/45424#issuecomment-2635477533 @github-actions crossbow submit test-build-cpp-fuzz -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

Re: [PR] Support converting large dates (i.e. +10999-12-31) from string to Date32 [arrow-rs]

2025-02-04 Thread via GitHub
phillipleblanc closed pull request #7076: Support converting large dates (i.e. +10999-12-31) from string to Date32 URL: https://github.com/apache/arrow-rs/pull/7076 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] GH-45396: [C++] Use Boost with ARROW_FUZZING [arrow]

2025-02-04 Thread via GitHub
kou commented on PR #45397: URL: https://github.com/apache/arrow/pull/45397#issuecomment-2635466674 Oh, sorry. I'll fix it. #45423 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

Re: [PR] GH-26648: [C++] Optimize union equality comparison [arrow]

2025-02-04 Thread via GitHub
conbench-apache-arrow[bot] commented on PR #45384: URL: https://github.com/apache/arrow/pull/45384#issuecomment-2635464268 After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 1567be0d74c5ee90c3d989f6fcefb32c402a736c. There were 8

Re: [I] [Python][Packaging] Revisit Windows wheel Docker setup [arrow]

2025-02-04 Thread via GitHub
amoeba commented on issue #45156: URL: https://github.com/apache/arrow/issues/45156#issuecomment-2635424955 Installing a Win10/11 SDK fixes the warning at startup, `--add Microsoft.VisualStudio.Component.Windows11SDK`. -- This is an automated message from the Apache Git Service. To respon

Re: [I] [Python][Packaging] Revisit Windows wheel Docker setup [arrow]

2025-02-04 Thread via GitHub
amoeba commented on issue #45156: URL: https://github.com/apache/arrow/issues/45156#issuecomment-2635366819 I'm looking at this today and have made some progress. My image so far is only 7.57GB whereas the existing wheel image is 26.8GB which is a nice savings. So far I have, ```dock

Re: [PR] WIP: [Release] Verify release-19.0.1-rc0 [arrow]

2025-02-04 Thread via GitHub
github-actions[bot] commented on PR #45420: URL: https://github.com/apache/arrow/pull/45420#issuecomment-2635356097 Revision: 36e0d50f4c7b51eb4e4147facb6f99da7049609d Submitted crossbow builds: [ursacomputing/crossbow @ actions-42cab651f2](https://github.com/ursacomputing/crossbow/bra

Re: [PR] WIP: [Release] Verify release-19.0.1-rc0 [arrow]

2025-02-04 Thread via GitHub
amoeba commented on PR #45420: URL: https://github.com/apache/arrow/pull/45420#issuecomment-2635349801 @github-actions crossbow submit wheel-windows-cp39-amd64 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

Re: [PR] WIP: [Release] Verify release-19.0.1-rc0 [arrow]

2025-02-04 Thread via GitHub
amoeba commented on PR #45420: URL: https://github.com/apache/arrow/pull/45420#issuecomment-2635349416 I had hoped to reproduce the issue but wasn't able to. I built the image locally, ```sh $ $env:DOCKER_BUILDKIT = 0 archery docker build --no-pull python-wheel-windows-vs2019

Re: [I] Allow Parquet reader to read incorrectly written (negative) uint8, uint16 values for compatibility [arrow-rs]

2025-02-04 Thread via GitHub
etseidl commented on issue #7040: URL: https://github.com/apache/arrow-rs/issues/7040#issuecomment-2635178656 Now I'm conflicted. On the one hand, sentiment in the Parquet community seems to be heading towards returning an error for data that is malformed as in this issue. On the other, I'v

Re: [I] [R] perl operators in regular expressions [arrow]

2025-02-04 Thread via GitHub
WillAyd commented on issue #40220: URL: https://github.com/apache/arrow/issues/40220#issuecomment-2635181965 FWIW there is a large discussion of this upstream in re2. It doesn't appear likely that this will be implemented: https://github.com/google/re2/issues/156 -- This is an auto

Re: [I] [C++] Optimize union equality comparison [arrow]

2025-02-04 Thread via GitHub
pitrou commented on issue #26648: URL: https://github.com/apache/arrow/issues/26648#issuecomment-2635129385 > happy to! just so I am understanding right: per benchmarking, the throughput is for `ArrayRangeEqualsSparseUnion` comparisons is about 2x more efficient? Yes, roughly.

Re: [I] Incorrect IPC schema encoding for multiple dictionaries [arrow-rs]

2025-02-04 Thread via GitHub
XiangpengHao commented on issue #7058: URL: https://github.com/apache/arrow-rs/issues/7058#issuecomment-2635110750 For anyone following along, I think the bug is from flatbuffer, and the workaround is to turnoff the verifier on receiving the data. The data seems to be correct, just the veri

Re: [I] Supporting object store FFI [arrow-rs]

2025-02-04 Thread via GitHub
lisasgoh commented on issue #7075: URL: https://github.com/apache/arrow-rs/issues/7075#issuecomment-2635059503 The use case here would be that unlike Datafusion that has a `register_object_store` method that allows for custom implementations for object stores, Polars doesn't (https://github

Re: [I] Feather chunksize doesn't round-trip [arrow]

2025-02-04 Thread via GitHub
alippai commented on issue #45422: URL: https://github.com/apache/arrow/issues/45422#issuecomment-2635035677 Is this the equivalent? ```python BATCH_SIZE = 1024*1024 if len(t.to_batches) > 1: t = t.combine_chunks() with pa.OSFile('test3.feather', 'wb') as sink: wit

Re: [PR] fix(cpp): Ensure Meson build compiles Arrow tests [arrow-nanoarrow]

2025-02-04 Thread via GitHub
WillAyd merged PR #711: URL: https://github.com/apache/arrow-nanoarrow/pull/711 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow

Re: [I] Supporting object store FFI [arrow-rs]

2025-02-04 Thread via GitHub
kylebarron commented on issue #7075: URL: https://github.com/apache/arrow-rs/issues/7075#issuecomment-2634984317 It sounds like the OP here is interested in a custom implementation of `ObjectStore` to serve something other than AWS/GCP/Azure. That's a bit different than what I've been

Re: [I] Supporting object store FFI [arrow-rs]

2025-02-04 Thread via GitHub
tustvold commented on issue #7075: URL: https://github.com/apache/arrow-rs/issues/7075#issuecomment-2634952585 Tagging @kylebarron. I think there are a couple of questions here: * Is the major use-case python interop * Does a python focused abstraction have more utliity than

Re: [I] Add Attributes API Exposing Broader Set of Object Metadata [arrow-rs]

2025-02-04 Thread via GitHub
tustvold closed issue #5334: Add Attributes API Exposing Broader Set of Object Metadata URL: https://github.com/apache/arrow-rs/issues/5334 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

Re: [I] Add Attributes API Exposing Broader Set of Object Metadata [arrow-rs]

2025-02-04 Thread via GitHub
tustvold commented on issue #5334: URL: https://github.com/apache/arrow-rs/issues/5334#issuecomment-2634934529 Closed by https://github.com/apache/arrow-rs/pull/5650 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [I] Parsing a string column containing JSON values into a typed array [arrow-rs]

2025-02-04 Thread via GitHub
scovich commented on issue #6522: URL: https://github.com/apache/arrow-rs/issues/6522#issuecomment-2634918695 > I prototyped this last month for polars, could share, it's a lot This seems a bit surprising, given that the feature request is to define new `num_buffered_rows` and `has_pa

Re: [I] Parsing a string column containing JSON values into a typed array [arrow-rs]

2025-02-04 Thread via GitHub
scovich commented on issue #6522: URL: https://github.com/apache/arrow-rs/issues/6522#issuecomment-2634910042 Perhaps the real concern is about the "bonus" request? > It would be even nicer if the `parse_json` method could just become part of either arrow-json or arrow-compute, if parsing

Re: [I] Add Attributes API Exposing Broader Set of Object Metadata [arrow-rs]

2025-02-04 Thread via GitHub
kylebarron commented on issue #5334: URL: https://github.com/apache/arrow-rs/issues/5334#issuecomment-2634894456 Am I correct that this issue can be closed now that there's https://docs.rs/object_store/latest/object_store/struct.Attributes.html? -- This is an automated message from the Ap

Re: [PR] fix: issue introduced in #6833 - less than equal check for scale in decimal conversion [arrow-rs]

2025-02-04 Thread via GitHub
himadripal commented on code in PR #7070: URL: https://github.com/apache/arrow-rs/pull/7070#discussion_r1941766675 ## arrow-cast/src/cast/decimal.rs: ## @@ -167,7 +167,7 @@ where let array: PrimitiveArray = if input_scale == output_scale && input_precision <= outpu

Re: [I] [C++] Optimize union equality comparison [arrow]

2025-02-04 Thread via GitHub
mcshawn10 commented on issue #26648: URL: https://github.com/apache/arrow/issues/26648#issuecomment-2634831643 > Thank you for your contribution [@mcshawn10](https://github.com/mcshawn10) ! happy to! just so I am understanding right: per benchmarking, the throughput is for `ArrayRang

Re: [I] `UnionListWriter#startList` points the inner writer at the wrong position [arrow-java]

2025-02-04 Thread via GitHub
nbauernfeind commented on issue #585: URL: https://github.com/apache/arrow-java/issues/585#issuecomment-2634733299 Nevermind. While using the returned value from `startNewValue` is more appropriate, when you start a new value the end offset is initialized to the start offset. While a little

Re: [PR] fix: issue introduced in #6833 - less than equal check for scale in decimal conversion [arrow-rs]

2025-02-04 Thread via GitHub
viirya commented on code in PR #7070: URL: https://github.com/apache/arrow-rs/pull/7070#discussion_r1941683724 ## arrow-cast/src/cast/decimal.rs: ## @@ -167,7 +167,7 @@ where let array: PrimitiveArray = if input_scale == output_scale && input_precision <= output_pr

[PR] fix(cpp): Ensure Meson build compiles Arrow tests [arrow-nanoarrow]

2025-02-04 Thread via GitHub
WillAyd opened a new pull request, #711: URL: https://github.com/apache/arrow-nanoarrow/pull/711 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe

Re: [I] `UnionListWriter#startList` points the inner writer at the wrong position [arrow-java]

2025-02-04 Thread via GitHub
nbauernfeind commented on issue #585: URL: https://github.com/apache/arrow-java/issues/585#issuecomment-2634698746 Possibly this is the cause of #296. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[I] Supporting object store FFI [arrow-rs]

2025-02-04 Thread via GitHub
lisasgoh opened a new issue, #7075: URL: https://github.com/apache/arrow-rs/issues/7075 **Is your feature request related to a problem or challenge? Please describe what you are trying to do.** The use case here would be to be able to dynamically load libraries with custom object sto

Re: [I] [C++] Optimize union equality comparison [arrow]

2025-02-04 Thread via GitHub
pitrou commented on issue #26648: URL: https://github.com/apache/arrow/issues/26648#issuecomment-2634657867 Thank you for your contribution @mcshawn10 ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [I] [C++] Optimize union equality comparison [arrow]

2025-02-04 Thread via GitHub
pitrou commented on issue #26648: URL: https://github.com/apache/arrow/issues/26648#issuecomment-2634656884 Issue resolved by pull request 45384 https://github.com/apache/arrow/pull/45384 -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] GH-26648: [C++] Optimize union equality comparison [arrow]

2025-02-04 Thread via GitHub
pitrou merged PR #45384: URL: https://github.com/apache/arrow/pull/45384 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache

Re: [I] Support casting strings to Date32 that contain large dates [arrow-rs]

2025-02-04 Thread via GitHub
phillipleblanc commented on issue #7073: URL: https://github.com/apache/arrow-rs/issues/7073#issuecomment-2634612370 take -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[PR] Support converting large dates (i.e. +10999-12-31) from string to Date32 [arrow-rs]

2025-02-04 Thread via GitHub
phillipleblanc opened a new pull request, #7074: URL: https://github.com/apache/arrow-rs/pull/7074 # Which issue does this PR close? Closes #7073 # Rationale for this change Support for casting large dates from string to Date32. # What changes are included in this

[I] Support casting strings to Date32 that contain large dates [arrow-rs]

2025-02-04 Thread via GitHub
phillipleblanc opened a new issue, #7073: URL: https://github.com/apache/arrow-rs/issues/7073 **Describe the bug** Attempting to convert a string which contains a valid large date in the ISO format (i.e. `+10999-12-31`) will result in the following error: `CastError("Cannot cast st

Re: [PR] GH-26648: [C++] Optimize union equality comparison [arrow]

2025-02-04 Thread via GitHub
pitrou commented on PR #45384: URL: https://github.com/apache/arrow/pull/45384#issuecomment-2634533257 It turns out that we didn't have any proper tests for sparse union comparison, so I added one. -- This is an automated message from the Apache Git Service. To respond to the message, ple

Re: [PR] GH-26648: [C++] Optimize union equality comparison [arrow]

2025-02-04 Thread via GitHub
mcshawn10 commented on code in PR #45384: URL: https://github.com/apache/arrow/pull/45384#discussion_r1941491449 ## cpp/src/arrow/compare.cc: ## @@ -381,23 +381,49 @@ class RangeDataEqualsImpl { const int8_t* right_codes = right_.GetValues(1); // Unions don't have a

Re: [I] [JS] Implement IPC RecordBatch body buffer compression from ARROW-300 [arrow]

2025-02-04 Thread via GitHub
mapsensedev commented on issue #24833: URL: https://github.com/apache/arrow/issues/24833#issuecomment-2634406031 Any update on the timelines for JS implementation to support buffer compression -- This is an automated message from the Apache Git Service. To respond to the message, please l

Re: [PR] GH-45371: [C++] Fix data race in `SimpleRecordBatch::columns` [arrow]

2025-02-04 Thread via GitHub
pitrou commented on code in PR #45372: URL: https://github.com/apache/arrow/pull/45372#discussion_r1941468163 ## cpp/src/arrow/record_batch.cc: ## @@ -102,8 +103,10 @@ class SimpleRecordBatch : public RecordBatch { std::shared_ptr column(int i) const override { std::shar

Re: [PR] WIP: [Release] Verify release-19.0.1-rc0 [arrow]

2025-02-04 Thread via GitHub
amoeba commented on PR #45420: URL: https://github.com/apache/arrow/pull/45420#issuecomment-2634390020 My first thought after some searching around was that IANA may have changed how they issues their TLS cert (which is still possible) and that we just need a newer version of the certifi pa

  1   2   >