Re: [PR] GH-46111: [C++][CI] Fix boost 1.88 on MinGW [arrow]

2025-04-12 Thread via GitHub
kou commented on PR #46113: URL: https://github.com/apache/arrow/pull/46113#issuecomment-2799830893 Related issue: https://github.com/boostorg/process/issues/480 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] Add benchmark for parquet reader with row_filter and project settings [arrow-rs]

2025-04-12 Thread via GitHub
zhuqi-lucas commented on PR #7401: URL: https://github.com/apache/arrow-rs/pull/7401#issuecomment-2799825990 Benchmark Result compare after the fix: ```rust group better_decode

Re: [PR] GH-46092: [C++] Add filesystem option to Meson [arrow]

2025-04-12 Thread via GitHub
kou commented on code in PR #46101: URL: https://github.com/apache/arrow/pull/46101#discussion_r2041037993 ## cpp/src/arrow/filesystem/meson.build: ## @@ -0,0 +1,87 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See t

Re: [PR] GH-46092: [C++] Add filesystem option to Meson [arrow]

2025-04-12 Thread via GitHub
kou commented on code in PR #46101: URL: https://github.com/apache/arrow/pull/46101#discussion_r2041035955 ## cpp/meson.options: ## @@ -29,6 +36,20 @@ option( value: false, ) +option( +'filesystem', +type: 'boolean', +description: 'Build the Arrow Filesystem

Re: [I] Parquet decoder / decoded page Cache [arrow-rs]

2025-04-12 Thread via GitHub
zhuqi-lucas commented on issue #7363: URL: https://github.com/apache/arrow-rs/issues/7363#issuecomment-2799780788 > Thank you [@alamb](https://github.com/alamb) , i already changed the benchmark testing to trigger cache logic, and the testing works well for main branch, but the testing seem

[PR] Skip page should also support skip dict page [arrow-rs]

2025-04-12 Thread via GitHub
zhuqi-lucas opened a new pull request, #7409: URL: https://github.com/apache/arrow-rs/pull/7409 # Which issue does this PR close? Closes part of [#7363](https://github.com/apache/arrow-rs/issues/7363) # Rationale for this change We hit the bug during

Re: [PR] GH-46123: [C++] Undefined behavior in `compare_internal.cc` and `light_array_internal.cc` [arrow]

2025-04-12 Thread via GitHub
github-actions[bot] commented on PR #46124: URL: https://github.com/apache/arrow/pull/46124#issuecomment-2799358646 Revision: d65c77d543179c3a7b1efb91fa72e9fa304570e2 Submitted crossbow builds: [ursacomputing/crossbow @ actions-a97753c416](https://github.com/ursacomputing/crossbow/bra

Re: [PR] GH-46123: [C++] Undefined behavior in `compare_internal.cc` and `light_array_internal.cc` [arrow]

2025-04-12 Thread via GitHub
jonkeane commented on PR #46124: URL: https://github.com/apache/arrow/pull/46124#issuecomment-2799349750 @github-actions crossbow submit test-r-clang-ubsan -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [I] PostgreSQL `dbapi.connect` ignores `conn_kwargs` and `db_kwargs` [arrow-adbc]

2025-04-12 Thread via GitHub
fwojciec commented on issue #2696: URL: https://github.com/apache/arrow-adbc/issues/2696#issuecomment-2799277176 Hi @lidavidm - I made a PR, but run into some problems. Looks like there is currently only one option that could be theoretically set using `conn_kwargs` - specifically `adbc.con

[PR] fix(python/driver/postgresql): handle kwargs in dbapi connect [arrow-adbc]

2025-04-12 Thread via GitHub
fwojciec opened a new pull request, #2700: URL: https://github.com/apache/arrow-adbc/pull/2700 Closes #2696 But I've encountered some issues when writing a test for the change: - there are currently no supported `db_kwargs` beyond `driver` and `uri` - which are set explicitly

Re: [I] [R] Address CRAN check failures for 19.0.1.1 [arrow]

2025-04-12 Thread via GitHub
amoeba commented on issue #46125: URL: https://github.com/apache/arrow/issues/46125#issuecomment-2798958811 Thanks @jonkeane. I'll close this issue and keep an eye on https://github.com/apache/arrow/issues/46123 so we can start prepping a new CRAN submission. -- This is an automated mess

Re: [I] [C++] Undefined behavior in `compare_internal.cc` and `light_array_internal.cc` [arrow]

2025-04-12 Thread via GitHub
jonkeane commented on issue #46123: URL: https://github.com/apache/arrow/issues/46123#issuecomment-2798958080 I've been trying to trigger the failures seen on CRAN's machine with our linux sanitizers, but haven't been able to yet. It might be unique to using Apple's clang sanitizer tools (w

Re: [I] [R] Address CRAN check failures for 19.0.1.1 [arrow]

2025-04-12 Thread via GitHub
jonkeane commented on issue #46125: URL: https://github.com/apache/arrow/issues/46125#issuecomment-2798955924 I got an email this morning and I created #46123 to deal with it. TL;DR there's [a new M1-based sanitization check](https://www.stats.ox.ac.uk/pub/bdr/M1-SAN/README.txt) — it's not

Re: [I] [R][Docs] Improve documentation of `col_types` [arrow]

2025-04-12 Thread via GitHub
emstruong commented on issue #38903: URL: https://github.com/apache/arrow/issues/38903#issuecomment-2798952574 Hi, the documentation fix here would be a great help. Is this something that anyone wants to take on? -- This is an automated message from the Apache Git Service. To respond to t

Re: [PR] feat: support list with ListOpts which contains the offset, max_keys,… [arrow-rs-object-store]

2025-04-12 Thread via GitHub
tustvold commented on code in PR #324: URL: https://github.com/apache/arrow-rs-object-store/pull/324#discussion_r2040708806 ## src/client/list.rs: ## @@ -33,6 +32,8 @@ pub(crate) trait ListClient: Send + Sync + 'static { delimiter: bool, token: Option<&str>,

Re: [PR] feat: support list with ListOpts which contains the offset, max_keys,… [arrow-rs-object-store]

2025-04-12 Thread via GitHub
tustvold commented on code in PR #324: URL: https://github.com/apache/arrow-rs-object-store/pull/324#discussion_r2040703373 ## src/aws/builder.rs: ## @@ -891,6 +893,12 @@ impl AmazonS3Builder { self } +/// Set the max keys per list request. It's almost used

Re: [PR] Check for additional IO errors that should be retried [arrow-rs-object-store]

2025-04-12 Thread via GitHub
tustvold commented on code in PR #319: URL: https://github.com/apache/arrow-rs-object-store/pull/319#discussion_r2040702666 ## src/client/connection.rs: ## @@ -108,12 +108,15 @@ impl HttpError { } else if e.is_timeout() { kind = HttpErrorKi

Re: [PR] feat: make some helpers/utils public [arrow-rs-object-store]

2025-04-12 Thread via GitHub
tustvold commented on code in PR #316: URL: https://github.com/apache/arrow-rs-object-store/pull/316#discussion_r2040702270 ## src/util.rs: ## @@ -208,7 +208,8 @@ pub enum GetRange { } #[derive(Debug, thiserror::Error)] -pub(crate) enum InvalidGetRange { +#[expect(missing_c

Re: [I] Allow attributes in local filesystem (or impove the error msg) [arrow-rs-object-store]

2025-04-12 Thread via GitHub
tustvold commented on issue #331: URL: https://github.com/apache/arrow-rs-object-store/issues/331#issuecomment-2798884167 I agree the error could/should be improved. Adding support for attributes would likely be a more complex undertaking, but might be able to use xattr on Unix syste

Re: [I] Query on usage of experimental package ring [arrow-rs-object-store]

2025-04-12 Thread via GitHub
tustvold commented on issue #310: URL: https://github.com/apache/arrow-rs-object-store/issues/310#issuecomment-2798886583 Closing as the question has been answered -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

Re: [I] [Object Store] Make the service account used when interacting with the metadata url more flexible [arrow-rs-object-store]

2025-04-12 Thread via GitHub
tustvold closed issue #265: [Object Store] Make the service account used when interacting with the metadata url more flexible URL: https://github.com/apache/arrow-rs-object-store/issues/265 -- This is an automated message from the Apache Git Service. To respond to the message, please log on t

Re: [I] Query on usage of experimental package ring [arrow-rs-object-store]

2025-04-12 Thread via GitHub
tustvold closed issue #310: Query on usage of experimental package ring URL: https://github.com/apache/arrow-rs-object-store/issues/310 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [I] Parquet decoder / decoded page Cache [arrow-rs]

2025-04-12 Thread via GitHub
alamb commented on issue #7363: URL: https://github.com/apache/arrow-rs/issues/7363#issuecomment-2798880453 > > Those are very nice figures and summarize the common filter patterns I can think of! [@alamb](https://github.com/alamb) > > As a side note, not directly related to this issue, b

Re: [PR] [ObjectStore] Add SpawnService for running requests on different tokio runtime/`Handle` [arrow-rs]

2025-04-12 Thread via GitHub
ion-elgreco commented on PR #7253: URL: https://github.com/apache/arrow-rs/pull/7253#issuecomment-2798881313 @alamb sure! I'll take a jab at this tomorrow :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

Re: [PR] [ObjectStore] Add SpawnService for running requests on different tokio runtime/`Handle` [arrow-rs]

2025-04-12 Thread via GitHub
alamb commented on PR #7253: URL: https://github.com/apache/arrow-rs/pull/7253#issuecomment-2798879532 > Is this PR going to be reopened in the new repo? :) I am looking quite forward to this ^^ I suspect @tustvold doesn't have the bandwidth? If you are willing to open a new PR I ca

Re: [PR] GH-46123: [C++] Undefined behavior in `compare_internal.cc` and `light_array_internal.cc` [arrow]

2025-04-12 Thread via GitHub
github-actions[bot] commented on PR #46124: URL: https://github.com/apache/arrow/pull/46124#issuecomment-2798876923 Revision: f509ff3490e2047c05604d22176d5147e16c7ae3 Submitted crossbow builds: [ursacomputing/crossbow @ actions-080d457e3d](https://github.com/ursacomputing/crossbow/bra

Re: [PR] GH-46123: [C++] Undefined behavior in `compare_internal.cc` and `light_array_internal.cc` [arrow]

2025-04-12 Thread via GitHub
jonkeane commented on PR #46124: URL: https://github.com/apache/arrow/pull/46124#issuecomment-2798876075 @github-actions crossbow submit test-r-clang-ubsan -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[I] Allow attributes in local filesystem (or impove the error msg) [arrow-rs-object-store]

2025-04-12 Thread via GitHub
Owez opened a new issue, #331: URL: https://github.com/apache/arrow-rs-object-store/issues/331 I was writing a multipart upload and it seemed to work fine, but I got an odd error of an operation isn't implemented. I had to clone the repo and search through the trait impls to find out that `

Re: [PR] Add support for file row numbers in Parquet readers [arrow-rs]

2025-04-12 Thread via GitHub
jkylling commented on PR #7307: URL: https://github.com/apache/arrow-rs/pull/7307#issuecomment-2798867336 Thank you for the update, and totally understand other responsibilities are taking up your time. I'll keep on being patient, and maybe do some minor improvements to this PR (use a small

Re: [PR] GH-46123: [C++] Undefined behavior in `compare_internal.cc` and `light_array_internal.cc` [arrow]

2025-04-12 Thread via GitHub
github-actions[bot] commented on PR #46124: URL: https://github.com/apache/arrow/pull/46124#issuecomment-2798858056 Revision: c654b0096e8229785695d0fff57414ac21d790aa Submitted crossbow builds: [ursacomputing/crossbow @ actions-be6350e4a3](https://github.com/ursacomputing/crossbow/bra

Re: [PR] GH-46123: [C++] Undefined behavior in `compare_internal.cc` and `light_array_internal.cc` [arrow]

2025-04-12 Thread via GitHub
jonkeane commented on PR #46124: URL: https://github.com/apache/arrow/pull/46124#issuecomment-2798857289 @github-actions crossbow submit test-r-clang-ubsan -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] feat(go/adbc/driver/flightsql): Add OAuth Support to Flight Client [arrow-adbc]

2025-04-12 Thread via GitHub
davidhcoe commented on PR #2651: URL: https://github.com/apache/arrow-adbc/pull/2651#issuecomment-2798841821 > > Just to add to this (and this could be a follow-on PR) - what happens if https://github.com/apache/arrow-adbc/blob/a187ead78afebe85c75b466a06ad6e01ae4ac8c6/go/adbc/driver/flightsq

Re: [PR] feat(go/adbc/driver/flightsql): Add OAuth Support to Flight Client [arrow-adbc]

2025-04-12 Thread via GitHub
davidhcoe commented on PR #2651: URL: https://github.com/apache/arrow-adbc/pull/2651#issuecomment-2798840447 > Just to add to this (and this could be a follow-on PR) - what happens if https://github.com/apache/arrow-adbc/blob/a187ead78afebe85c75b466a06ad6e01ae4ac8c6/go/adbc/driver/flightsql/

Re: [PR] feat(go/adbc/driver/flightsql): Add OAuth Support to Flight Client [arrow-adbc]

2025-04-12 Thread via GitHub
davidhcoe commented on PR #2651: URL: https://github.com/apache/arrow-adbc/pull/2651#issuecomment-2798837604 Just to add to this (and this could be a follow-on PR) - what happens if https://github.com/apache/arrow-adbc/blob/a187ead78afebe85c75b466a06ad6e01ae4ac8c6/go/adbc/driver/flightsql/fl

Re: [PR] feat: impl display for `DataType::List` [arrow-rs]

2025-04-12 Thread via GitHub
irenjj commented on code in PR #7051: URL: https://github.com/apache/arrow-rs/pull/7051#discussion_r2040660087 ## arrow-schema/src/datatype.rs: ## @@ -458,7 +458,25 @@ pub enum UnionMode { impl fmt::Display for DataType { fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Res

Re: [PR] GH-46123: [C++] Undefined behavior in `compare_internal.cc` and `light_array_internal.cc` [arrow]

2025-04-12 Thread via GitHub
github-actions[bot] commented on PR #46124: URL: https://github.com/apache/arrow/pull/46124#issuecomment-2798836002 Revision: 562a9320bd0cb9acb53a203562eb0d032f8e4328 Submitted crossbow builds: [ursacomputing/crossbow @ actions-1f2ba4f158](https://github.com/ursacomputing/crossbow/bra

Re: [PR] GH-46123: [C++] Undefined behavior in `compare_internal.cc` and `light_array_internal.cc` [arrow]

2025-04-12 Thread via GitHub
github-actions[bot] commented on PR #46124: URL: https://github.com/apache/arrow/pull/46124#issuecomment-2798835352 :warning: GitHub issue #46123 **has been automatically assigned in GitHub** to PR creator. -- This is an automated message from the Apache Git Service. To respond to the mes

Re: [PR] GH-46123: [C++] Undefined behavior in `compare_internal.cc` and `light_array_internal.cc` [arrow]

2025-04-12 Thread via GitHub
jonkeane commented on PR #46124: URL: https://github.com/apache/arrow/pull/46124#issuecomment-2798835326 @github-actions crossbow submit test-r-clang-sanitizer -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[PR] GH-46123: [C++] Undefined behavior in `compare_internal.cc` and `light_array_internal.cc` [arrow]

2025-04-12 Thread via GitHub
jonkeane opened a new pull request, #46124: URL: https://github.com/apache/arrow/pull/46124 ### Rationale for this change Removing undefined behaviors ### What changes are included in this PR? So far, attempting to test this. ### Are these changes tested? Ho

Re: [PR] [ObjectStore] Add SpawnService for running requests on different tokio runtime/`Handle` [arrow-rs]

2025-04-12 Thread via GitHub
ion-elgreco commented on PR #7253: URL: https://github.com/apache/arrow-rs/pull/7253#issuecomment-2798802633 Is this PR going to be reopened in the new repo? :) I am looking quite forward to this ^^ -- This is an automated message from the Apache Git Service. To respond to the message, pl

Re: [PR] Add benchmark for parquet reader with row_filter and project settings [arrow-rs]

2025-04-12 Thread via GitHub
zhuqi-lucas commented on PR #7401: URL: https://github.com/apache/arrow-rs/pull/7401#issuecomment-2798797706 I created a fix, it seems can fix the problem: https://github.com/zhuqi-lucas/arrow-rs/commit/d0ab2fe851babe158452104e823f8b57f8b3df01 -- This is an automated messag

Re: [I] [JS] Unable to parse fetch stream [arrow]

2025-04-12 Thread via GitHub
antspy commented on issue #46073: URL: https://github.com/apache/arrow/issues/46073#issuecomment-2798727699 Hi, This seems to work fine, thank you very much for debugging!! I would not have been able to do this myself :) > Ideally Arrow JS would support it Is t

Re: [PR] GH-45991: [C++] Bump bundled nlohmann_json to v3.12.0 [arrow]

2025-04-12 Thread via GitHub
conbench-apache-arrow[bot] commented on PR #46112: URL: https://github.com/apache/arrow/pull/46112#issuecomment-2798774637 After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 48fb347e5de59e86f3ad0e8b50d3779bd14ff080. There were no

Re: [PR] Add benchmark for parquet reader with row_filter and project settings [arrow-rs]

2025-04-12 Thread via GitHub
zhuqi-lucas commented on PR #7401: URL: https://github.com/apache/arrow-rs/pull/7401#issuecomment-2798744870 I found the deadlock happen in the following code for page cache branch: 1. When we call has_next: ```rust while total_records_read < max_records && self.has_next()? {

Re: [I] [JS] Unable to parse fetch stream [arrow]

2025-04-12 Thread via GitHub
amoeba commented on issue #46073: URL: https://github.com/apache/arrow/issues/46073#issuecomment-2798740177 I've opened https://github.com/apache/arrow/issues/46120 to track it. Thanks for filing an issue and for reporting back. I'll mark this closed. -- This is an automated message