Re: [PR] Avro codec enhancements [arrow-rs]

2025-04-20 Thread via GitHub
klion26 commented on PR #6965: URL: https://github.com/apache/arrow-rs/pull/6965#issuecomment-2817717843 @nathaniel-elastiflow thanks for the fix, it works for me now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

Re: [PR] GH-43807: [C++][Python] Add UUID extension type conversion support to/from Parquet [arrow]

2025-04-20 Thread via GitHub
paleolimbot commented on PR #45866: URL: https://github.com/apache/arrow/pull/45866#issuecomment-2817608196 Thanks! I'll merge tomorrow if there are no objections! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [I] Provide non blocking getFlightInfo [arrow-java]

2025-04-20 Thread via GitHub
tanejagagan commented on issue #719: URL: https://github.com/apache/arrow-java/issues/719#issuecomment-2817593369 I did look at those classes including FlightService as well as FlightBindingService but could not come up with approach without doing to much refactoring to my code base. We hav

Re: [PR] GH-698: Improve and fix Avro read consumers [arrow-java]

2025-04-20 Thread via GitHub
lidavidm commented on PR #718: URL: https://github.com/apache/arrow-java/pull/718#issuecomment-2817591251 Looks like there are some lint errors to be fixed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [I] rust: Let the returned RecordBatchReader outlive & parameters [arrow-adbc]

2025-04-20 Thread via GitHub
felipecrv commented on issue #2694: URL: https://github.com/apache/arrow-adbc/issues/2694#issuecomment-2817564705 > I think Stream is a good interface for interop. ADBC will keep returning instances of the very simple `RecordBatchReader` trait and we should be able to write a function

Re: [I] rust: Let the returned RecordBatchReader outlive & parameters [arrow-adbc]

2025-04-20 Thread via GitHub
yutannihilation commented on issue #2694: URL: https://github.com/apache/arrow-adbc/issues/2694#issuecomment-2817555757 Thanks for your replies! > if that's what the caller (like you!) actually wanted. I'm not yet sure if this is what an ordinary user wants to do, but probably

Re: [PR] GH-45908: [C++][Docs] Expose basic {Array,...}FromJSON helpers as public APIs [arrow]

2025-04-20 Thread via GitHub
amoeba commented on PR #46180: URL: https://github.com/apache/arrow/pull/46180#issuecomment-2817554228 Docs previews: - User guide: http://crossbow.voltrondata.com/pr_docs/46180/cpp/arrays.html#fromjson-helpers - API docs: http://crossbow.voltrondata.com/pr_docs/46180/cpp/api/array.ht

Re: [PR] GH-45908: [C++][Docs] Expose basic {Array,...}FromJSON helpers as public APIs [arrow]

2025-04-20 Thread via GitHub
github-actions[bot] commented on PR #46180: URL: https://github.com/apache/arrow/pull/46180#issuecomment-2817517928 Revision: cf808f9f3524df96d5385cbd557c8f353e1fed5b Submitted crossbow builds: [ursacomputing/crossbow @ actions-7a9d15701e](https://github.com/ursacomputing/crossbow/bra

[PR] Mp/fix 128 byte value limit on get [arrow-adbc]

2025-04-20 Thread via GitHub
VersusFacit opened a new pull request, #2716: URL: https://github.com/apache/arrow-adbc/pull/2716 ## Problem So we need to accommodate fields higher than 128 bytes in some cases. The Go Library is proven to support arbitrary lengths but this Rust layer artificially constrains values. Thi

Re: [PR] Mp/fix 128 byte value limit on get [arrow-adbc]

2025-04-20 Thread via GitHub
VersusFacit closed pull request #2716: Mp/fix 128 byte value limit on get URL: https://github.com/apache/arrow-adbc/pull/2716 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] GH-45908: [C++] Expose basic {Array,...}FromJSON helpers as public APIs [arrow]

2025-04-20 Thread via GitHub
amoeba commented on PR #46180: URL: https://github.com/apache/arrow/pull/46180#issuecomment-2817516113 @github-actions crossbow submit preview-docs -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [I] [C++] Expose `{Array,...}FromJSON` as public APIs [arrow]

2025-04-20 Thread via GitHub
amoeba commented on issue #45908: URL: https://github.com/apache/arrow/issues/45908#issuecomment-2817514232 I created [#46180](https://github.com/apache/arrow/pull/46180) to move just the helpers in json_simple to make it as easy to review as possible. -- This is an automated message from

Re: [I] [C++] Fix ASAN issue in the arrow-dataset-dataset-writer-test [arrow]

2025-04-20 Thread via GitHub
amoeba commented on issue #45235: URL: https://github.com/apache/arrow/issues/45235#issuecomment-2817499917 I saw this today in CI for https://github.com/apache/arrow/pull/46180 and was also able to reproduce it locally (debian sid, amd64) _once_ but not after repeated calls. -- This is

Re: [I] [C++][Packaging] Remove pin for grpc-cpp in conda_env_cpp.txt [arrow]

2025-04-20 Thread via GitHub
kou commented on issue #46137: URL: https://github.com/apache/arrow/issues/46137#issuecomment-2817462371 https://github.com/conda-forge/grpc-cpp-feedstock/commit/27238606a533a0cecb3d1b909c30c83891348d8b It seems that `grpc-cpp` is a deprecated package. Could you use `libgrpc` instead of

Re: [PR] GH-698: Improve and fix Avro read consumers [arrow-java]

2025-04-20 Thread via GitHub
lidavidm commented on code in PR #718: URL: https://github.com/apache/arrow-java/pull/718#discussion_r2051858753 ## adapter/avro/src/main/java/org/apache/arrow/adapter/avro/AvroToArrowUtils.java: ## @@ -277,11 +333,17 @@ private static Consumer createConsumer( break;

Re: [I] rust: Every ADBC operation acquires a lock on the driver preventing parallel statement execution [arrow-adbc]

2025-04-20 Thread via GitHub
felipecrv commented on issue #2715: URL: https://github.com/apache/arrow-adbc/issues/2715#issuecomment-2817445199 So I figured. I’m working on a fix. On Sun, 20 Apr 2025 at 22:14 David Li ***@***.***> wrote: > Hmm, the driver should be a static table of values so there should be

Re: [I] rust: Every ADBC operation acquires a lock on the driver preventing parallel statement execution [arrow-adbc]

2025-04-20 Thread via GitHub
lidavidm commented on issue #2715: URL: https://github.com/apache/arrow-adbc/issues/2715#issuecomment-2817443865 Hmm, the driver should be a static table of values so there should be no reason to lock it. -- This is an automated message from the Apache Git Service. To respond to the messa

Re: [PR] feat(rust)!: use GATs for return types in `Connection` and `Statement` traits [arrow-adbc]

2025-04-20 Thread via GitHub
lidavidm commented on PR #2713: URL: https://github.com/apache/arrow-adbc/pull/2713#issuecomment-2817442161 `Box` sounds like the pragmatic choice to me here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

Re: [I] rust: Let the returned RecordBatchReader outlive & parameters [arrow-adbc]

2025-04-20 Thread via GitHub
felipecrv commented on issue #2694: URL: https://github.com/apache/arrow-adbc/issues/2694#issuecomment-2817314409 I think it should be possible to implement a `SendableRecordBatchReader` after the changes I'm asking for here. -- This is an automated message from the Apache Git Service. To

Re: [I] rust: Let the returned RecordBatchReader outlive & parameters [arrow-adbc]

2025-04-20 Thread via GitHub
paleolimbot commented on issue #2694: URL: https://github.com/apache/arrow-adbc/issues/2694#issuecomment-2817312665 > is it possible to return a Stream like DataFusion does? The ADBC spec itself returns RecordBatchReaders, although I am sure the Rust API could allow for a driver to im

Re: [I] Support Utf8View for avro [arrow-rs]

2025-04-20 Thread via GitHub
kumarlokesh commented on issue #7262: URL: https://github.com/apache/arrow-rs/issues/7262#issuecomment-2817305101 take -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [I] pyarrow.compute.field("x").isin(0.0) incorrectly filters out all rows when they all match [arrow]

2025-04-20 Thread via GitHub
ypsah commented on issue #46183: URL: https://github.com/apache/arrow/issues/46183#issuecomment-2817232884 While the bug appears to have existed for numerous versions and its impact must have been limited until now, [apache/iceberg-python](https://github.com/apache/iceberg-python)'s particu

Re: [PR] add DataType::test_string [arrow-rs]

2025-04-20 Thread via GitHub
berkaysynnada commented on code in PR #7429: URL: https://github.com/apache/arrow-rs/pull/7429#discussion_r2051712839 ## arrow-schema/src/datatype.rs: ## @@ -596,6 +596,13 @@ impl DataType { matches!(self, Null) } +/// Returns true if this type is signed inte

Re: [I] rust: Let the returned RecordBatchReader outlive & parameters [arrow-adbc]

2025-04-20 Thread via GitHub
yutannihilation commented on issue #2694: URL: https://github.com/apache/arrow-adbc/issues/2694#issuecomment-2817139277 Not sure if this is a related topic or not, but, is it possible to return a `Stream` like DataFusion does? https://docs.rs/datafusion/latest/datafusion/#streaming-ex

Re: [I] [C++][Packaging] Remove pin for grpc-cpp in conda_env_cpp.txt [arrow]

2025-04-20 Thread via GitHub
yyossy5 commented on issue #46137: URL: https://github.com/apache/arrow/issues/46137#issuecomment-2817130043 Looking at the link https://conda.anaconda.org/conda-forge/osx-arm64/, it appears that the available version of grpc-cpp for osx-arm64 is only up to 1.51.1. -- This is an automate

Re: [I] [C++][Packaging] Remove pin for grpc-cpp in conda_env_cpp.txt [arrow]

2025-04-20 Thread via GitHub
yyossy5 commented on issue #46137: URL: https://github.com/apache/arrow/issues/46137#issuecomment-2817123569 It seems that if we can use grpc-cpp 1.71.0, we should be able to use a newer version of libprotobuf as well, and the build process looks promising. ```bash $ conda sear

Re: [I] [C++][Packaging] Remove pin for grpc-cpp in conda_env_cpp.txt [arrow]

2025-04-20 Thread via GitHub
yyossy5 commented on issue #46137: URL: https://github.com/apache/arrow/issues/46137#issuecomment-2817119297 According to https://github.com/conda-forge/grpc-cpp-feedstock, it seems that version 1.71.0 of grpc-cpp is available from conda-forge. However, in my environment, the latest versi

Re: [I] [C++][Packaging] Remove pin for grpc-cpp in conda_env_cpp.txt [arrow]

2025-04-20 Thread via GitHub
yyossy5 commented on issue #46137: URL: https://github.com/apache/arrow/issues/46137#issuecomment-2817113951 I removed the pin for grpc-cpp, created the conda environment, and built C++ Arrow, but I'm still encountering the same error. ```bash $ conda create -n pyarrow-dev-test-no-