etiennebacher commented on code in PR #46667:
URL: https://github.com/apache/arrow/pull/46667#discussion_r2125804357
##
r/tests/testthat/test-dplyr-funcs-conditional.R:
##
@@ -491,3 +491,20 @@ test_that("coalesce()", {
class = "validation_error"
)
})
+
+test_that("exter
pitrou commented on PR #46686:
URL: https://github.com/apache/arrow/pull/46686#issuecomment-2938798863
That's fine with me. @kszucs Any comments?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
kou commented on PR #21:
URL: https://github.com/apache/arrow-swift/pull/21#issuecomment-2938756783
https://github.com/kou/arrow-swift/actions/runs/15435171137/job/43440064721
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
kou commented on PR #21:
URL: https://github.com/apache/arrow-swift/pull/21#issuecomment-2938754188
Oh, sorry. I missed it.
I increased timeout to 15min from 10min.
> Maybe it's only the first time?
Yes. We need to build SwiftLint that is written by Swift.
--
This is a
lidavidm commented on code in PR #726:
URL: https://github.com/apache/arrow-java/pull/726#discussion_r2125746756
##
vector/src/test/java/org/apache/arrow/vector/complex/impl/UuidReaderImpl.java:
##
@@ -0,0 +1,51 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under o
github-actions[bot] commented on PR #46703:
URL: https://github.com/apache/arrow/pull/46703#issuecomment-2938744322
:warning: GitHub issue #46702 **has been automatically assigned in GitHub**
to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the mes
kou opened a new pull request, #46703:
URL: https://github.com/apache/arrow/pull/46703
### Rationale for this change
We moved `js/` in apache/arrow to apache/arrow-js.
### What changes are included in this PR?
Remove `js/` in apache/arrow.
### Are these changes tes
lidavidm commented on PR #2904:
URL: https://github.com/apache/arrow-adbc/pull/2904#issuecomment-2938732666
Added another test in Python, just to confirm that we don't need to reset
the timezone before a bulk COPY (interestingly enough).
--
This is an automated message from the Apache Git
EnricoMi commented on PR #46626:
URL: https://github.com/apache/arrow/pull/46626#issuecomment-2938727314
@pitrou what do you think about 9c8874402c45f0a43432b2207f81a97cecbe6334? It
is essential that `AssertSecurelyCleared` really catches leaked secrets, so I
added tests for that. Capturing
EnricoMi commented on code in PR #46626:
URL: https://github.com/apache/arrow/pull/46626#discussion_r2125736245
##
cpp/src/arrow/util/secure_string.cc:
##
@@ -0,0 +1,169 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.
kou commented on issue #12570:
URL: https://github.com/apache/arrow/issues/12570#issuecomment-2938686823
If this still doesn't work, please open a new issue on
https://github.com/apache/arrow-java not apache/arrow.
--
This is an automated message from the Apache Git Service.
To respond to
github-actions[bot] commented on PR #46700:
URL: https://github.com/apache/arrow/pull/46700#issuecomment-2938684434
Revision: f195bb7c2ea5eaecfe4d7835031157d9fb6f35b9
Submitted crossbow builds: [ursacomputing/crossbow @
actions-6927c6452c](https://github.com/ursacomputing/crossbow/bra
kou commented on PR #46700:
URL: https://github.com/apache/arrow/pull/46700#issuecomment-2938678231
@github-actions crossbow submit -g cpp
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
raulcd commented on issue #46608:
URL: https://github.com/apache/arrow/issues/46608#issuecomment-2938666238
This has been solved by:
- https://github.com/apache/arrow/pull/46618
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitH
kou opened a new pull request, #22:
URL: https://github.com/apache/arrow-swift/pull/22
## What's Changed
Enabled Dependabots for:
* GitHub Actions
* Swift packages
* Go packages
Closes #4.
--
This is an automated message from the Apache Git Service.
To respon
raulcd commented on issue #46611:
URL: https://github.com/apache/arrow/issues/46611#issuecomment-2938664894
Issue resolved by pull request 46618
https://github.com/apache/arrow/pull/46618
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
raulcd merged PR #46618:
URL: https://github.com/apache/arrow/pull/46618
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache
kou commented on PR #21:
URL: https://github.com/apache/arrow-swift/pull/21#issuecomment-2938649710
@abandy Could you take a look at this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
raulcd merged PR #19:
URL: https://github.com/apache/arrow-swift/pull/19
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache
raulcd merged PR #18:
URL: https://github.com/apache/arrow-swift/pull/18
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache
kou opened a new pull request, #21:
URL: https://github.com/apache/arrow-swift/pull/21
This upgrades SwiftLint to the latest version (0.59.1) from 0.53.0. So some
format fixes are included.
Closes #20.
--
This is an automated message from the Apache Git Service.
To respond to the m
conbench-apache-arrow[bot] commented on PR #46566:
URL: https://github.com/apache/arrow/pull/46566#issuecomment-2938633491
After merging your PR, Conbench analyzed the 4 benchmarking runs that have
been run so far on merge-commit 94e3b3e98fe75a7498f2ee6edaeb006146d5cbe3.
There were 73
EnricoMi commented on code in PR #46626:
URL: https://github.com/apache/arrow/pull/46626#discussion_r2125624811
##
cpp/src/arrow/util/secure_string.cc:
##
@@ -0,0 +1,169 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.
kou commented on PR #137:
URL: https://github.com/apache/arrow-js/pull/137#issuecomment-2938364599
I tried this workflow on my fork:
* RC workflow: https://github.com/kou/arrow-js/actions/runs/15431752994
* RC GitHub Release: https://github.com/kou/arrow-js/releases/tag/v20.0.0-rc2
*
kou opened a new pull request, #137:
URL: https://github.com/apache/arrow-js/pull/137
## What's Changed
This is based on the release scripts used by apache/arrow-java:
https://github.com/apache/arrow-java/tree/main/dev/release
Here is the release workflow:
1. Bump vers
eitsupi commented on code in PR #46667:
URL: https://github.com/apache/arrow/pull/46667#discussion_r2125538650
##
r/tests/testthat/test-dplyr-funcs-conditional.R:
##
@@ -491,3 +491,20 @@ test_that("coalesce()", {
class = "validation_error"
)
})
+
+test_that("external ob
amoeba commented on code in PR #46696:
URL: https://github.com/apache/arrow/pull/46696#discussion_r2125110742
##
cpp/src/arrow/json/from_string.h:
##
@@ -68,52 +68,45 @@ Result> ArrayFromJSONString(const
std::shared_ptr chunked_array;
-/// ChunkedArrayFromJSONString(
-/// int
conbench-apache-arrow[bot] commented on PR #46672:
URL: https://github.com/apache/arrow/pull/46672#issuecomment-2938217356
After merging your PR, Conbench analyzed the 4 benchmarking runs that have
been run so far on merge-commit acbad2942be80e9a76b888f99fe3b9ebdc4f2941.
There were 65
zeroshade commented on code in PR #2918:
URL: https://github.com/apache/arrow-adbc/pull/2918#discussion_r2125311308
##
c/driver_manager/adbc_driver_manager.cc:
##
@@ -15,26 +15,41 @@
// specific language governing permissions and limitations
// under the License.
-#include "
zeroshade commented on code in PR #2918:
URL: https://github.com/apache/arrow-adbc/pull/2918#discussion_r2125291615
##
c/driver_manager/adbc_driver_manager.cc:
##
@@ -632,6 +985,36 @@ static const char kDefaultEntrypoint[] = "AdbcDriverInit";
// Other helpers (intentionally n
zeroshade commented on code in PR #2918:
URL: https://github.com/apache/arrow-adbc/pull/2918#discussion_r2125307103
##
c/driver_manager/adbc_driver_manager.cc:
##
@@ -632,6 +985,36 @@ static const char kDefaultEntrypoint[] = "AdbcDriverInit";
// Other helpers (intentionally n
lidavidm commented on code in PR #2918:
URL: https://github.com/apache/arrow-adbc/pull/2918#discussion_r2125340006
##
c/driver_manager/adbc_driver_manager.cc:
##
@@ -632,6 +985,36 @@ static const char kDefaultEntrypoint[] = "AdbcDriverInit";
// Other helpers (intentionally no
github-actions[bot] commented on PR #46700:
URL: https://github.com/apache/arrow/pull/46700#issuecomment-2938154880
:warning: GitHub issue #46699 **has been automatically assigned in GitHub**
to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the mes
hiroyuki-sato opened a new pull request, #46700:
URL: https://github.com/apache/arrow/pull/46700
### Rationale for this change
`ci/scripts/cpp_test.sh` violates two shellcheck rules.
* SC2071: `< is for string comparisons. Use -lt instead.`
* SC2086: `Double quote to prevent
zeroshade commented on code in PR #2918:
URL: https://github.com/apache/arrow-adbc/pull/2918#discussion_r2125349412
##
c/driver_manager/adbc_driver_manager.cc:
##
@@ -632,6 +985,36 @@ static const char kDefaultEntrypoint[] = "AdbcDriverInit";
// Other helpers (intentionally n
zeroshade commented on code in PR #2918:
URL: https://github.com/apache/arrow-adbc/pull/2918#discussion_r2125346323
##
c/driver_manager/adbc_driver_manager.cc:
##
@@ -632,6 +985,36 @@ static const char kDefaultEntrypoint[] = "AdbcDriverInit";
// Other helpers (intentionally n
lidavidm commented on code in PR #2918:
URL: https://github.com/apache/arrow-adbc/pull/2918#discussion_r2125342460
##
c/driver_manager/adbc_driver_manager.cc:
##
@@ -632,6 +985,36 @@ static const char kDefaultEntrypoint[] = "AdbcDriverInit";
// Other helpers (intentionally no
hiroyuki-sato commented on issue #46690:
URL: https://github.com/apache/arrow/issues/46690#issuecomment-2937981018
Thank you for your comment. I'll close when this issue resolve.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
zeroshade commented on code in PR #2918:
URL: https://github.com/apache/arrow-adbc/pull/2918#discussion_r2125339275
##
c/driver_manager/adbc_driver_manager.cc:
##
@@ -632,6 +985,36 @@ static const char kDefaultEntrypoint[] = "AdbcDriverInit";
// Other helpers (intentionally n
lidavidm commented on code in PR #2918:
URL: https://github.com/apache/arrow-adbc/pull/2918#discussion_r2125335756
##
c/driver_manager/adbc_driver_manager.cc:
##
@@ -632,6 +985,36 @@ static const char kDefaultEntrypoint[] = "AdbcDriverInit";
// Other helpers (intentionally no
zeroshade commented on code in PR #2918:
URL: https://github.com/apache/arrow-adbc/pull/2918#discussion_r2125317901
##
c/driver_manager/adbc_driver_manager.cc:
##
@@ -15,26 +15,41 @@
// specific language governing permissions and limitations
// under the License.
-#include "
zeroshade commented on code in PR #2918:
URL: https://github.com/apache/arrow-adbc/pull/2918#discussion_r2125283660
##
c/driver_manager/adbc_driver_manager.cc:
##
@@ -15,26 +15,41 @@
// specific language governing permissions and limitations
// under the License.
-#include "
kou opened a new pull request, #19:
URL: https://github.com/apache/arrow-swift/pull/19
Closes #7.
This is based on
https://github.com/apache/arrow-js/blob/main/.github/pull_request_template.md .
--
This is an automated message from the Apache Git Service.
To respond to the message,
zeroshade commented on code in PR #2918:
URL: https://github.com/apache/arrow-adbc/pull/2918#discussion_r2125321117
##
c/driver_manager/adbc_driver_manager.cc:
##
@@ -632,6 +985,36 @@ static const char kDefaultEntrypoint[] = "AdbcDriverInit";
// Other helpers (intentionally n
kou opened a new pull request, #18:
URL: https://github.com/apache/arrow-swift/pull/18
Closes #2
We can use plain LICENSE.txt and NOTICE.txt because we don't have any
bundled dependencies and we don't provide binary artifacts.
--
This is an automated message from the Apache Git Ser
lidavidm commented on code in PR #2918:
URL: https://github.com/apache/arrow-adbc/pull/2918#discussion_r2125316437
##
c/driver_manager/adbc_driver_manager.cc:
##
@@ -632,6 +985,36 @@ static const char kDefaultEntrypoint[] = "AdbcDriverInit";
// Other helpers (intentionally no
lidavidm commented on code in PR #2918:
URL: https://github.com/apache/arrow-adbc/pull/2918#discussion_r2125314627
##
c/driver_manager/adbc_driver_manager.cc:
##
@@ -15,26 +15,41 @@
// specific language governing permissions and limitations
// under the License.
-#include "a
lidavidm commented on PR #2858:
URL: https://github.com/apache/arrow-adbc/pull/2858#issuecomment-2938074760
I have another concern in that we seem to be installing gmock/gtest, but
that should be unrelated to this PR
```
-- Install configuration: "Release"
-- I
lidavidm commented on code in PR #2858:
URL: https://github.com/apache/arrow-adbc/pull/2858#discussion_r2125308614
##
c/cmake_modules/GoUtils.cmake:
##
@@ -180,36 +201,79 @@ function(add_go_lib GO_MOD_DIR GO_LIBNAME)
list(APPEND GO_ENV_VARS "GOARCH=arm64")
endif()
lidavidm commented on code in PR #2918:
URL: https://github.com/apache/arrow-adbc/pull/2918#discussion_r2125300589
##
c/driver_manager/adbc_driver_manager.cc:
##
@@ -15,26 +15,41 @@
// specific language governing permissions and limitations
// under the License.
-#include "a
lidavidm commented on code in PR #2918:
URL: https://github.com/apache/arrow-adbc/pull/2918#discussion_r2125299712
##
c/driver_manager/adbc_driver_manager.cc:
##
@@ -632,6 +985,36 @@ static const char kDefaultEntrypoint[] = "AdbcDriverInit";
// Other helpers (intentionally no
lidavidm commented on code in PR #760:
URL: https://github.com/apache/arrow-java/pull/760#discussion_r2125296888
##
c/src/test/java/org/apache/arrow/c/ExceptionTest.java:
##
@@ -0,0 +1,184 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contribu
zeroshade commented on code in PR #2918:
URL: https://github.com/apache/arrow-adbc/pull/2918#discussion_r2125263567
##
c/include/arrow-adbc/adbc_driver_manager.h:
##
@@ -31,6 +31,16 @@ extern "C" {
#ifndef ADBC_DRIVER_MANAGER_H
#define ADBC_DRIVER_MANAGER_H
+enum LoadOptions
lidavidm commented on code in PR #2918:
URL: https://github.com/apache/arrow-adbc/pull/2918#discussion_r2125262141
##
c/driver_manager/adbc_driver_manager_test.cc:
##
@@ -28,6 +30,7 @@
#include "validation/adbc_validation_util.h"
std::string AdbcDriverManagerDefaultEntrypoin
zeroshade commented on code in PR #2918:
URL: https://github.com/apache/arrow-adbc/pull/2918#discussion_r2125294489
##
c/driver_manager/adbc_driver_manager.cc:
##
@@ -15,26 +15,41 @@
// specific language governing permissions and limitations
// under the License.
-#include "
lidavidm commented on code in PR #2918:
URL: https://github.com/apache/arrow-adbc/pull/2918#discussion_r2125287741
##
c/driver_manager/adbc_driver_manager.cc:
##
@@ -15,26 +15,41 @@
// specific language governing permissions and limitations
// under the License.
-#include "a
wgtmac commented on code in PR #46678:
URL: https://github.com/apache/arrow/pull/46678#discussion_r2125263312
##
cpp/src/parquet/properties.h:
##
@@ -1051,6 +1053,18 @@ class PARQUET_EXPORT ArrowReaderProperties {
/// Return the Arrow binary type to read BYTE_ARRAY columns as
amoeba commented on PR #46696:
URL: https://github.com/apache/arrow/pull/46696#issuecomment-2938044400
I think the gdb.cc errors are fixed in
https://github.com/apache/arrow/pull/46696/commits/641839ff99f929e845d4ef117e4fa5e7d1a08aa5.
I realize we can't use those helpers and that it's fine
adamreeve commented on code in PR #7600:
URL: https://github.com/apache/arrow-rs/pull/7600#discussion_r2125257704
##
parquet/src/file/metadata/writer.rs:
##
@@ -635,11 +636,17 @@ impl MetadataObjectWriter {
}
}
-fn get_footer_encryption_algorithm(&self) -> Op
zeroshade commented on code in PR #2918:
URL: https://github.com/apache/arrow-adbc/pull/2918#discussion_r2125262511
##
c/driver_manager/CMakeLists.txt:
##
@@ -15,6 +15,7 @@
# specific language governing permissions and limitations
# under the License.
+include(FetchContent)
lidavidm commented on code in PR #2918:
URL: https://github.com/apache/arrow-adbc/pull/2918#discussion_r2125251334
##
c/vendor/toml++/toml.hpp:
##
Review Comment:
We need to update LICENSE/NOTICE and .gitattributes
##
c/include/arrow-adbc/adbc_driver_manager.h:
#
wgtmac commented on PR #46692:
URL: https://github.com/apache/arrow/pull/46692#issuecomment-2937992689
I agree with @pitrou that these functions might be repeatedly called so
their performance is critical. If we have good benchmark result to demonstrate
an acceptable or negligible performan
amoeba commented on PR #46696:
URL: https://github.com/apache/arrow/pull/46696#issuecomment-2937980860
Looks like there are some issues with gdb.cc I need to figure out. And I
think
https://github.com/apache/arrow/blob/main/python/pyarrow/src/arrow/python/gdb.cc#L64
might be a latent bug.
birschick-bq commented on PR #2825:
URL: https://github.com/apache/arrow-adbc/pull/2825#issuecomment-2937738692
> Note that
[snowflakedb/gosnowflake@d092186](https://github.com/snowflakedb/gosnowflake/commit/d0921865822ada6dbbcc1a673a8810d436b9eb5e)
(which is in 1.14.1 that I just merged) a
zeroshade commented on PR #2805:
URL: https://github.com/apache/arrow-adbc/pull/2805#issuecomment-2937966683
I haven't had the time lately, but I'll try building with a lower glibc this
week so you can test it out @davlee1972
--
This is an automated message from the Apache Git Service.
T
rok opened a new pull request, #7600:
URL: https://github.com/apache/arrow-rs/pull/7600
# Which issue does this PR close?
Closes #7599.
# Rationale for this change
Written plaintext footer file will not include
`footer_signing_key_metadata`, see proposed test for reprodu
kou commented on PR #46530:
URL: https://github.com/apache/arrow/pull/46530#issuecomment-2937936418
Could you add a document how to use this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
rok opened a new issue, #7599:
URL: https://github.com/apache/arrow-rs/issues/7599
**Describe the bug**
When writing plaintext footer `footer_signing_key_metadata` is not included.
Additionally footer encryption algorithm is written in even in case of
plaintext footer.
**To Reprod
amoeba commented on code in PR #46696:
URL: https://github.com/apache/arrow/pull/46696#discussion_r2125217990
##
cpp/src/arrow/json/from_string.cc:
##
@@ -1052,28 +1047,27 @@ Status ScalarFromJSONString(const
std::shared_ptr& type,
RETURN_NOT_OK(converter->AppendValue(json_d
kou commented on code in PR #46422:
URL: https://github.com/apache/arrow/pull/46422#discussion_r2125208514
##
cpp/src/arrow/array/statistics_test.cc:
##
@@ -96,6 +99,69 @@ TEST(ArrayStatisticsTest, TestEquality) {
ASSERT_NE(statistics1, statistics2);
statistics2.is_max_exa
kou commented on code in PR #46422:
URL: https://github.com/apache/arrow/pull/46422#discussion_r2125211501
##
cpp/src/arrow/array/statistics_test.cc:
##
@@ -15,9 +15,12 @@
// specific language governing permissions and limitations
// under the License.
+#include
+
#include
kou commented on code in PR #46422:
URL: https://github.com/apache/arrow/pull/46422#discussion_r2125197855
##
cpp/src/arrow/array/statistics_test.cc:
##
@@ -96,6 +99,69 @@ TEST(ArrayStatisticsTest, TestEquality) {
ASSERT_NE(statistics1, statistics2);
statistics2.is_max_exa
kou commented on code in PR #46696:
URL: https://github.com/apache/arrow/pull/46696#discussion_r2125161095
##
cpp/src/arrow/json/from_string.h:
##
@@ -68,52 +68,45 @@ Result> ArrayFromJSONString(const
std::shared_ptr chunked_array;
-/// ChunkedArrayFromJSONString(
-/// int64(
conbench-apache-arrow[bot] commented on PR #46685:
URL: https://github.com/apache/arrow/pull/46685#issuecomment-2937845647
After merging your PR, Conbench analyzed the 4 benchmarking runs that have
been run so far on merge-commit 2aaea003bbe6fe712da613fee947e0d302e03c72.
There were 73
kou commented on code in PR #46696:
URL: https://github.com/apache/arrow/pull/46696#discussion_r2125191086
##
cpp/src/arrow/json/from_string.cc:
##
@@ -1052,28 +1047,27 @@ Status ScalarFromJSONString(const
std::shared_ptr& type,
RETURN_NOT_OK(converter->AppendValue(json_doc)
amoeba commented on PR #46696:
URL: https://github.com/apache/arrow/pull/46696#issuecomment-2937876409
Rebased, all outstanding review comments addressed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
kou commented on code in PR #46696:
URL: https://github.com/apache/arrow/pull/46696#discussion_r2125159065
##
cpp/src/arrow/json/from_string.cc:
##
@@ -1003,23 +1003,22 @@ Result>
ArrayFromJSONString(const std::shared_ptr& type,
- const std::vec
kou commented on code in PR #2918:
URL: https://github.com/apache/arrow-adbc/pull/2918#discussion_r2125132489
##
c/driver_manager/adbc_driver_manager.cc:
##
@@ -114,7 +128,175 @@ struct OwnedError {
}
};
+std::filesystem::path UserConfigDir() {
+ std::filesystem::path con
amoeba commented on code in PR #46696:
URL: https://github.com/apache/arrow/pull/46696#discussion_r2125163951
##
cpp/src/arrow/json/from_string.h:
##
@@ -68,52 +68,45 @@ Result> ArrayFromJSONString(const
std::shared_ptr chunked_array;
-/// ChunkedArrayFromJSONString(
-/// int
amoeba commented on code in PR #46696:
URL: https://github.com/apache/arrow/pull/46696#discussion_r2125161908
##
cpp/src/arrow/json/from_string.h:
##
@@ -68,52 +68,45 @@ Result> ArrayFromJSONString(const
std::shared_ptr chunked_array;
-/// ChunkedArrayFromJSONString(
-/// int
amoeba commented on code in PR #46696:
URL: https://github.com/apache/arrow/pull/46696#discussion_r2125160355
##
cpp/src/arrow/json/from_string.cc:
##
@@ -1003,23 +1003,22 @@ Result>
ArrayFromJSONString(const std::shared_ptr& type,
- const std::
zeroshade commented on PR #2918:
URL: https://github.com/apache/arrow-adbc/pull/2918#issuecomment-2937715983
@paleolimbot looks like i figured it out! :smile:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo
amoeba commented on code in PR #46696:
URL: https://github.com/apache/arrow/pull/46696#discussion_r2125115586
##
cpp/src/arrow/json/from_string.h:
##
@@ -68,52 +68,45 @@ Result> ArrayFromJSONString(const
std::shared_ptr chunked_array;
-/// ChunkedArrayFromJSONString(
-/// int
amoeba commented on PR #46696:
URL: https://github.com/apache/arrow/pull/46696#issuecomment-2937720807
Thanks @kou for the quick review. I fixed what I could and left one
conversation open in
https://github.com/apache/arrow/pull/46696#discussion_r2125115586.
I'll hold off on rebasing
amoeba commented on code in PR #46696:
URL: https://github.com/apache/arrow/pull/46696#discussion_r2125110261
##
cpp/src/arrow/json/from_string.h:
##
@@ -68,52 +68,45 @@ Result> ArrayFromJSONString(const
std::shared_ptr chunked_array;
-/// ChunkedArrayFromJSONString(
-/// int
dinse commented on issue #44803:
URL: https://github.com/apache/arrow/issues/44803#issuecomment-2937694188
Hello, I ran into this problem while running pytests for a first issue.
Before finding the instructions to fetch tags from upstream, I also got the
tests to pass via
`SETU
davidhcoe commented on PR #2916:
URL: https://github.com/apache/arrow-adbc/pull/2916#issuecomment-2937674077
I run make .dll in the pkg directory.
From: Matt Topol ***@***.***>
Sent: Tuesday, June 3, 2025 2:23:05 PM
To: apache/arrow-adbc ***@**
dentiny opened a new issue, #7598:
URL: https://github.com/apache/arrow-rs/issues/7598
**Describe the bug**
I'm using [`cargo deny`](https://github.com/EmbarkStudios/cargo-deny) to
guard against my rust project dependency, as displayed below, it relies on an
unmaintained dependency `past
kou merged PR #46697:
URL: https://github.com/apache/arrow/pull/46697
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.or
kou commented on code in PR #46696:
URL: https://github.com/apache/arrow/pull/46696#discussion_r2124975825
##
cpp/src/arrow/json/from_string.cc:
##
@@ -1030,13 +1029,13 @@ Status DictArrayFromJSONString(const
std::shared_ptr& type,
ArrayFromJSONString(d
kou commented on issue #46439:
URL: https://github.com/apache/arrow/issues/46439#issuecomment-2937277117
Issue resolved by pull request 46695
https://github.com/apache/arrow/pull/46695
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
kou merged PR #46695:
URL: https://github.com/apache/arrow/pull/46695
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.or
zeroshade commented on PR #2918:
URL: https://github.com/apache/arrow-adbc/pull/2918#issuecomment-2937274180
@paleolimbot I think i'm gonna need a little help getting the R build to
recognize the vendored toml++ header, as far as I can tell looking at
`bootstrap-c.R` it should be copying it
kou commented on issue #46688:
URL: https://github.com/apache/arrow/issues/46688#issuecomment-2937259606
Issue resolved by pull request 46689
https://github.com/apache/arrow/pull/46689
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
kou merged PR #46689:
URL: https://github.com/apache/arrow/pull/46689
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.or
kou commented on issue #46690:
URL: https://github.com/apache/arrow/issues/46690#issuecomment-2937239282
https://github.com/mesonbuild/meson/issues/14440
The next Meson release will fix it.
--
This is an automated message from the Apache Git Service.
To respond to the message, pleas
alamb commented on code in PR #7513:
URL: https://github.com/apache/arrow-rs/pull/7513#discussion_r2124939075
##
arrow-array/src/builder/generic_bytes_view_builder.rs:
##
@@ -406,6 +459,122 @@ impl GenericByteViewBuilder {
};
buffer_size + in_progress + tracker
birschick-bq commented on PR #2825:
URL: https://github.com/apache/arrow-adbc/pull/2825#issuecomment-2936870672
@lidavidm
> Note that
[snowflakedb/gosnowflake@d092186](https://github.com/snowflakedb/gosnowflake/commit/d0921865822ada6dbbcc1a673a8810d436b9eb5e)
(which is in 1.14.1 that I
kou commented on issue #46673:
URL: https://github.com/apache/arrow/issues/46673#issuecomment-2937217544
Issue resolved by pull request 46682
https://github.com/apache/arrow/pull/46682
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
alamb commented on code in PR #7513:
URL: https://github.com/apache/arrow-rs/pull/7513#discussion_r2124937257
##
arrow-array/src/builder/generic_bytes_view_builder.rs:
##
@@ -406,6 +459,122 @@ impl GenericByteViewBuilder {
};
buffer_size + in_progress + tracker
1 - 100 of 278 matches
Mail list logo
