kou commented on PR #173:
URL: https://github.com/apache/arrow-js/pull/173#issuecomment-2995138423
Worked:
https://github.com/kou/arrow-js/actions/runs/15817003928/job/44577615157
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitH
raulcd commented on issue #167:
URL: https://github.com/apache/arrow-js/issues/167#issuecomment-2995106727
Given the upgrade to node and other dependencies, I think it's a good idea.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Gi
kou commented on issue #46863:
URL: https://github.com/apache/arrow/issues/46863#issuecomment-2995070415
Hmm... I don't understand why this happens... Can someone help us?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
kou opened a new pull request, #46880:
URL: https://github.com/apache/arrow/pull/46880
### Rationale for this change
#46834 required CMake 3.25 or later for an example CMake project.
### What changes are included in this PR?
Don't build the example CMake project with CMak
kou commented on issue #46846:
URL: https://github.com/apache/arrow/issues/46846#issuecomment-2994986293
Issue resolved by pull request 46847
https://github.com/apache/arrow/pull/46847
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
github-actions[bot] commented on PR #46880:
URL: https://github.com/apache/arrow/pull/46880#issuecomment-2994984489
Revision: 894f98d893c4acc58ac491a3fc7f496dd6150897
Submitted crossbow builds: [ursacomputing/crossbow @
actions-08dc997b01](https://github.com/ursacomputing/crossbow/bra
hiroyuki-sato commented on PR #46847:
URL: https://github.com/apache/arrow/pull/46847#issuecomment-2994977290
I'll appreciate if someone review this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
kou commented on issue #49:
URL: https://github.com/apache/arrow-swift/issues/49#issuecomment-2994950298
Should we release a new version after #40?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
lidavidm commented on PR #789:
URL: https://github.com/apache/arrow-java/pull/789#issuecomment-2994681666
We may just have to merge this for now though and follow up on the other CI
issues, given windows-2019 will be deprecated in a week.
Though, quite possibly the Windows/Boost issue
alamb commented on PR #7731:
URL: https://github.com/apache/arrow-rs/pull/7731#issuecomment-2994157996
🤖 `./gh_compare_arrow.sh` [Benchmark
Script](https://github.com/alamb/datafusion-benchmarking/blob/main/gh_compare_arrow.sh)
Running
Linux aal-dev 6.11.0-1015-gcp #15~24.04.1-Ubuntu SMP
kou merged PR #46874:
URL: https://github.com/apache/arrow/pull/46874
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.or
zanmato1984 commented on code in PR #46859:
URL: https://github.com/apache/arrow/pull/46859#discussion_r2160603949
##
cpp/src/arrow/compute/expression.cc:
##
@@ -1331,7 +1331,13 @@ struct Inequality {
return call->function_name == "is_valid" ? literal(true) :
literal(fal
zanmato1984 commented on code in PR #46859:
URL: https://github.com/apache/arrow/pull/46859#discussion_r2160603949
##
cpp/src/arrow/compute/expression.cc:
##
@@ -1331,7 +1331,13 @@ struct Inequality {
return call->function_name == "is_valid" ? literal(true) :
literal(fal
lidavidm commented on issue #790:
URL: https://github.com/apache/arrow-java/issues/790#issuecomment-2994676485
Can you validate this with an http2 client like cURL? I think grpc-java may
be negotiating TLS regardless
--
This is an automated message from the Apache Git Service.
To respond
lidavidm commented on code in PR #726:
URL: https://github.com/apache/arrow-java/pull/726#discussion_r2160579010
##
vector/src/test/java/org/apache/arrow/vector/complex/impl/UuidReaderImpl.java:
##
@@ -0,0 +1,51 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under o
lidavidm commented on PR #760:
URL: https://github.com/apache/arrow-java/pull/760#issuecomment-2994640852
Regardless, there are Checkstyle failures
```
Error: /build/c/src/test/java/org/apache/arrow/c/ExceptionTest.java:30:8:
Unused import: java.util.Objects. [UnusedImports]
lidavidm commented on PR #760:
URL: https://github.com/apache/arrow-java/pull/760#issuecomment-2994637005
ah right, CI is broken...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
zhuqi-lucas commented on code in PR #7731:
URL: https://github.com/apache/arrow-rs/pull/7731#discussion_r2160529686
##
arrow-ord/src/cmp.rs:
##
@@ -565,24 +565,46 @@ impl<'a, T: ByteViewType> ArrayOrd for &'a
GenericByteViewArray {
/// Item.0 is the array, Item.1 is the in
ctsk commented on PR #6427:
URL: https://github.com/apache/arrow-rs/pull/6427#issuecomment-2994418150
May I have a go at it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
kou commented on issue #22005:
URL: https://github.com/apache/arrow/issues/22005#issuecomment-2994453359
Rust was moved to arrow-rs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
alamb commented on code in PR #7731:
URL: https://github.com/apache/arrow-rs/pull/7731#discussion_r2160319037
##
arrow-ord/src/cmp.rs:
##
@@ -566,12 +566,18 @@ impl<'a, T: ByteViewType> ArrayOrd for &'a
GenericByteViewArray {
type Item = (&'a GenericByteViewArray, usize);
alamb commented on code in PR #7726:
URL: https://github.com/apache/arrow-rs/pull/7726#discussion_r2160318478
##
arrow-array/src/array/null_array.rs:
##
@@ -201,4 +204,32 @@ mod tests {
let array = NullArray::new(1024 * 1024);
assert_eq!(format!("{array:?}"), "
zhuqi-lucas commented on code in PR #7731:
URL: https://github.com/apache/arrow-rs/pull/7731#discussion_r2160330993
##
arrow-ord/src/cmp.rs:
##
@@ -566,12 +566,18 @@ impl<'a, T: ByteViewType> ArrayOrd for &'a
GenericByteViewArray {
type Item = (&'a GenericByteViewArray, us
github-actions[bot] commented on PR #46874:
URL: https://github.com/apache/arrow/pull/46874#issuecomment-2994130493
Revision: d82cf3854b115612fb59b57e0e9674da17c0eb23
Submitted crossbow builds: [ursacomputing/crossbow @
actions-bbae524876](https://github.com/ursacomputing/crossbow/bra
alamb commented on PR #7720:
URL: https://github.com/apache/arrow-rs/pull/7720#issuecomment-2994194379
I am not sure about returning an error on `append_value`
Also, while typing this it seems like `ObjectBuilder::append_value` is a
somewhat strange name -- maybe it would be better to
alamb merged PR #7726:
URL: https://github.com/apache/arrow-rs/pull/7726
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache
zhuqi-lucas commented on code in PR #7731:
URL: https://github.com/apache/arrow-rs/pull/7731#discussion_r2160529045
##
arrow-ord/src/cmp.rs:
##
@@ -565,24 +565,46 @@ impl<'a, T: ByteViewType> ArrayOrd for &'a
GenericByteViewArray {
/// Item.0 is the array, Item.1 is the in
github-actions[bot] commented on PR #46878:
URL: https://github.com/apache/arrow/pull/46878#issuecomment-2994498851
:warning: GitHub issue #45098 **has been automatically assigned in GitHub**
to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the mes
jonkeane commented on code in PR #46873:
URL: https://github.com/apache/arrow/pull/46873#discussion_r2160515139
##
r/tests/testthat/test-Array.R:
##
@@ -1397,3 +1397,9 @@ test_that("Can convert R integer/double to decimal
(ARROW-11631)", {
"Conversion to decimal from non-i
MichaelChirico opened a new pull request, #46878:
URL: https://github.com/apache/arrow/pull/46878
Closes #45098.
A number of notes:
- I basically had Gemini write this (on my free personal account). It did
95% of the work, from one prompt, then I tidied up the results and fixe
Dandandan commented on code in PR #7731:
URL: https://github.com/apache/arrow-rs/pull/7731#discussion_r2160383718
##
arrow-ord/src/cmp.rs:
##
@@ -565,24 +565,46 @@ impl<'a, T: ByteViewType> ArrayOrd for &'a
GenericByteViewArray {
/// Item.0 is the array, Item.1 is the inde
kou commented on issue #21518:
URL: https://github.com/apache/arrow/issues/21518#issuecomment-2994454484
We migrated to `${PACKAGE}Config.cmake` from `Find${PACKAGE}.cmake`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
brunal commented on issue #7736:
URL: https://github.com/apache/arrow-rs/issues/7736#issuecomment-2994314152
This is likely caused by a "cargo test": that will run the tests of all
crates in the workspace, including "pyarrow". However "pyarrow" needs specific
setup (pip install pyarrow). In
zhuqi-lucas commented on code in PR #7731:
URL: https://github.com/apache/arrow-rs/pull/7731#discussion_r2160331203
##
arrow-ord/src/cmp.rs:
##
@@ -566,12 +566,18 @@ impl<'a, T: ByteViewType> ArrayOrd for &'a
GenericByteViewArray {
type Item = (&'a GenericByteViewArray, us
alamb closed issue #7725: Do not populate nulls for `NullArray` for
`MutableArrayData`
URL: https://github.com/apache/arrow-rs/issues/7725
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specifi
kou commented on issue #23872:
URL: https://github.com/apache/arrow/issues/23872#issuecomment-2994146100
#13740 implemented validation.
#46743 may remove Crossbow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
Dandandan commented on code in PR #7731:
URL: https://github.com/apache/arrow-rs/pull/7731#discussion_r2160334767
##
arrow-ord/src/cmp.rs:
##
@@ -626,6 +645,16 @@ pub fn compare_byte_view(
) -> std::cmp::Ordering {
assert!(left_idx < left.len());
assert!(right_idx < r
conbench-apache-arrow[bot] commented on PR #46876:
URL: https://github.com/apache/arrow/pull/46876#issuecomment-2994418061
After merging your PR, Conbench analyzed the 3 benchmarking runs that have
been run so far on merge-commit 118ca35440345ebf2dfa4bf40721d8a58c9fb5b8.
There were 12
kou merged PR #46876:
URL: https://github.com/apache/arrow/pull/46876
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.or
Dandandan commented on PR #7731:
URL: https://github.com/apache/arrow-rs/pull/7731#issuecomment-2994174237
My results match the 3x / 10x improvement 🚀
```
eq StringViewArray StringViewArray inlined bytes
time: [6.5763 ms 6.6128 ms 6.6497 ms]
adriangb commented on code in PR #7737:
URL: https://github.com/apache/arrow-rs/pull/7737#discussion_r2160358275
##
arrow-arith/src/numeric.rs:
##
@@ -510,49 +510,122 @@ fn timestamp_op(
}
/// Arithmetic trait for date arrays
-///
-/// Note: these should be fallible (#4456)
jhorstmann opened a new issue, #7739:
URL: https://github.com/apache/arrow-rs/issues/7739
**Is your feature request related to a problem or challenge? Please describe
what you are trying to do.**
While looking into parquet loading performance, I noticed that the
definition levels for
Dandandan commented on code in PR #7731:
URL: https://github.com/apache/arrow-rs/pull/7731#discussion_r2160394616
##
arrow-ord/src/cmp.rs:
##
@@ -565,24 +565,46 @@ impl<'a, T: ByteViewType> ArrayOrd for &'a
GenericByteViewArray {
/// Item.0 is the array, Item.1 is the inde
friendlymatthew commented on issue #7730:
URL: https://github.com/apache/arrow-rs/issues/7730#issuecomment-2994267927
https://github.com/apache/arrow-rs/compare/main...pydantic:arrow-rs:friendlymatthew/check-duplicate-field-name?expand=1
--
This is an automated message from the Apache Git
eitsupi commented on issue #1587:
URL: https://github.com/apache/arrow-adbc/issues/1587#issuecomment-2994266387
Seems fixed by #1707
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
Weijun-H opened a new pull request, #7738:
URL: https://github.com/apache/arrow-rs/pull/7738
# Which issue does this PR close?
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases. You can
link an i
zhuqi-lucas commented on PR #7731:
URL: https://github.com/apache/arrow-rs/pull/7731#issuecomment-2994254034
The benchmark result, i run locally for latest PR:
```rust
critcmp main fast_path_view --filter "iew"
group
friendlymatthew commented on issue #7696:
URL: https://github.com/apache/arrow-rs/issues/7696#issuecomment-2994255999
take
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
zhuqi-lucas commented on PR #7731:
URL: https://github.com/apache/arrow-rs/pull/7731#issuecomment-2994245549
> Promising results! I think we need some test to show it is correct with
null characters and different lengths, I think we need to modify the
implementation a bit.
Thank
eitsupi commented on issue #2216:
URL: https://github.com/apache/arrow-adbc/issues/2216#issuecomment-2994215601
> Hmm, but there never was an 'ADBC 0.7.0'.
The title seems to be saying 0.7.0 because the test started failing with the
release of Python's adbc_driver_manager package 0.7.
adriangb commented on PR #7737:
URL: https://github.com/apache/arrow-rs/pull/7737#issuecomment-2994230624
cc @tustvold @alamb
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment
adriangb opened a new pull request, #7737:
URL: https://github.com/apache/arrow-rs/pull/7737
Fixes #4456
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-m
alamb commented on PR #7694:
URL: https://github.com/apache/arrow-rs/pull/7694#issuecomment-2994226563
I hit some error probably related to this PR when making a release candidate:
https://github.com/apache/arrow-rs/issues/7736
--
This is an automated message from the Apache Git Ser
alamb commented on issue #7736:
URL: https://github.com/apache/arrow-rs/issues/7736#issuecomment-2994226307
It fails locally with this command:
```shell
cargo test -p arrow-pyarrow --test pyarrow
```
--
This is an automated message from the Apache Git Service.
To respond to the me
alamb commented on issue #7394:
URL: https://github.com/apache/arrow-rs/issues/7394#issuecomment-2994225859
I hit a problem when testing the RC:
- https://github.com/apache/arrow-rs/issues/7736
I will investigate
--
This is an automated message from the Apache Git Service.
To res
alamb opened a new issue, #7736:
URL: https://github.com/apache/arrow-rs/issues/7736
**Describe the bug**
When verifying the release cand
```
running 2 tests
test test_to_pyarrow_byte_view ... FAILED
test test_to_pyarrow ... FAILED
failures:
test_to_pyarr
alamb merged PR #7722:
URL: https://github.com/apache/arrow-rs/pull/7722
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache
alamb commented on PR #7731:
URL: https://github.com/apache/arrow-rs/pull/7731#issuecomment-2994192858
🤖: Benchmark completed
Details
```
group
fast_path_view
lidavidm commented on issue #2739:
URL: https://github.com/apache/arrow-adbc/issues/2739#issuecomment-2994130448
Ok. It sounds like we don't need to split workspaces, at least. We can just
relax `adbc_core`'s version bound
(https://github.com/apache/arrow-adbc/issues/2524) and have `adbc_da
alamb commented on issue #7697:
URL: https://github.com/apache/arrow-rs/issues/7697#issuecomment-2994200543
> It would be better to provide two append functions: one that includes
validation and returns an error, and another without validation. 🤔
Another approach that @friendlymatthew
alamb closed issue #7712: In arrow_json, Decoder::decode can panic if it
encounters two high surrogates in a row.
URL: https://github.com/apache/arrow-rs/issues/7712
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
kou commented on issue #23158:
URL: https://github.com/apache/arrow/issues/23158#issuecomment-2994148535
#40417 removed `archery lint`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specifi
alamb commented on PR #7720:
URL: https://github.com/apache/arrow-rs/pull/7720#issuecomment-2994196744
> I got too excited and decided to add the duplicate field name check to
this PR. I'm happy to roll that commit back and merge this PR as strictly a
BTreeMap change, and then push up a fol
Dandandan commented on code in PR #7731:
URL: https://github.com/apache/arrow-rs/pull/7731#discussion_r2160332637
##
arrow-ord/src/cmp.rs:
##
@@ -626,6 +645,16 @@ pub fn compare_byte_view(
) -> std::cmp::Ordering {
assert!(left_idx < left.len());
assert!(right_idx < r
friendlymatthew commented on PR #7720:
URL: https://github.com/apache/arrow-rs/pull/7720#issuecomment-2994196078
> I am not sure about returning an error on `append_value`
>
> Also, while typing this it seems like `ObjectBuilder::append_value` is a
somewhat strange name -- maybe it wo
friendlymatthew commented on code in PR #7720:
URL: https://github.com/apache/arrow-rs/pull/7720#discussion_r2160335027
##
parquet-variant/src/builder.rs:
##
@@ -484,13 +486,33 @@ impl<'a> ObjectBuilder<'a> {
}
}
+fn check_duplicate_field_name(&self, key: &st
zhuqi-lucas commented on code in PR #7731:
URL: https://github.com/apache/arrow-rs/pull/7731#discussion_r2160334834
##
arrow-ord/src/cmp.rs:
##
@@ -626,6 +645,16 @@ pub fn compare_byte_view(
) -> std::cmp::Ordering {
assert!(left_idx < left.len());
assert!(right_idx <
alamb commented on code in PR #7720:
URL: https://github.com/apache/arrow-rs/pull/7720#discussion_r2160334082
##
parquet-variant/src/builder.rs:
##
@@ -484,13 +486,33 @@ impl<'a> ObjectBuilder<'a> {
}
}
+fn check_duplicate_field_name(&self, key: &str) -> Resu
alamb commented on code in PR #7733:
URL: https://github.com/apache/arrow-rs/pull/7733#discussion_r2160332949
##
parquet_derive/src/lib.rs:
##
@@ -50,45 +50,52 @@ mod parquet_field;
/// Example:
///
/// ```no_run
Review Comment:
Is there any way we can remove the `no_run`
alamb commented on PR #7721:
URL: https://github.com/apache/arrow-rs/pull/7721#issuecomment-2994190667
If anything this seems faster than what is on main so it has a added bonus
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
alamb merged PR #7721:
URL: https://github.com/apache/arrow-rs/pull/7721
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache
alamb commented on PR #7721:
URL: https://github.com/apache/arrow-rs/pull/7721#issuecomment-2994190714
Thanks again @nicklan and @scovich
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
alamb commented on PR #7731:
URL: https://github.com/apache/arrow-rs/pull/7731#issuecomment-2994190179
🤖 `./gh_compare_arrow.sh` [Benchmark
Script](https://github.com/alamb/datafusion-benchmarking/blob/main/gh_compare_arrow.sh)
Running
Linux aal-dev 6.11.0-1015-gcp #15~24.04.1-Ubuntu SMP
Dandandan commented on code in PR #7731:
URL: https://github.com/apache/arrow-rs/pull/7731#discussion_r2160322025
##
arrow-ord/src/cmp.rs:
##
@@ -566,12 +566,18 @@ impl<'a, T: ByteViewType> ArrayOrd for &'a
GenericByteViewArray {
type Item = (&'a GenericByteViewArray, usiz
alamb commented on PR #7731:
URL: https://github.com/apache/arrow-rs/pull/7731#issuecomment-2994160678
🤖: Benchmark completed
Details
```
group
fast_path_view
kou commented on issue #22413:
URL: https://github.com/apache/arrow/issues/22413#issuecomment-2994151030
We moved Java to apache/arrow-java.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
kou commented on issue #23447:
URL: https://github.com/apache/arrow/issues/23447#issuecomment-2994148062
#40417 removed `archery lint` because we use `pre-commit`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
kou commented on issue #23970:
URL: https://github.com/apache/arrow/issues/23970#issuecomment-2994144400
This should be implemented.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
kou commented on issue #45713:
URL: https://github.com/apache/arrow/issues/45713#issuecomment-2994132932
Issue resolved by pull request 46876
https://github.com/apache/arrow/pull/46876
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
kou commented on PR #46874:
URL: https://github.com/apache/arrow/pull/46874#issuecomment-2994129246
@github-actions crossbow submit preview-docs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
lidavidm commented on issue #2216:
URL: https://github.com/apache/arrow-adbc/issues/2216#issuecomment-2994128905
Hmm, but there never was an 'ADBC 0.7.0'.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
alamb commented on code in PR #7729:
URL: https://github.com/apache/arrow-rs/pull/7729#discussion_r2160302652
##
arrow-row/src/run.rs:
##
@@ -297,24 +262,7 @@ mod tests {
.into_iter()
.collect();
-let converter =
RowConverter::new(vec