[GitHub] [arrow] alamb commented on a change in pull request #8556: ARROW-10378: [Rust] Update take() kernel with support for LargeList.

2020-11-06 Thread GitBox
alamb commented on a change in pull request #8556: URL: https://github.com/apache/arrow/pull/8556#discussion_r518934329 ## File path: rust/arrow/src/compute/kernels/take.rs ## @@ -195,15 +217,21 @@ where let null_slice = null_buf.data_mut(); -let new_values: Vec =

[GitHub] [arrow] alamb commented on a change in pull request #8556: ARROW-10378: [Rust] Update take() kernel with support for LargeList.

2020-11-05 Thread GitBox
alamb commented on a change in pull request #8556: URL: https://github.com/apache/arrow/pull/8556#discussion_r518033636 ## File path: rust/arrow/src/compute/util.rs ## @@ -100,41 +99,55 @@ pub(super) fn compare_option_bitmap( /// Where a list array has indices `[0,2,5,10]`, ta