alamb commented on pull request #8553:
URL: https://github.com/apache/arrow/pull/8553#issuecomment-727201907
FYI @rdettai , this PR has been merged
This is an automated message from the Apache Git Service.
To respond to the m
alamb commented on pull request #8553:
URL: https://github.com/apache/arrow/pull/8553#issuecomment-727201606
The [travis
CI](https://github.com/apache/arrow/pull/8553/checks?check_run_id=1399712911)
checks (which aren't for rust specific things) seem to be stuck / not working.
I don't thi
alamb commented on pull request #8553:
URL: https://github.com/apache/arrow/pull/8553#issuecomment-727192549
Rebased
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
alamb commented on pull request #8553:
URL: https://github.com/apache/arrow/pull/8553#issuecomment-726900488
I plan to merge this tomorrow unless i hear otherwise. @jorgecarleitao /
@andygrove let me know if you have any concerns
-
alamb commented on pull request #8553:
URL: https://github.com/apache/arrow/pull/8553#issuecomment-725024351
Rebased
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
alamb commented on pull request #8553:
URL: https://github.com/apache/arrow/pull/8553#issuecomment-724935395
@jorgecarleitao -- when I ran the TPCH benchmark Q1 locally on my machine, I
found it kept all my cores busy and the memory profile was low. Thus the
improvements offered by this PR
alamb commented on pull request #8553:
URL: https://github.com/apache/arrow/pull/8553#issuecomment-723025807
Ah -- got it. 👍
This is an automated message from the Apache Git Service.
To respond to the message, please log on
alamb commented on pull request #8553:
URL: https://github.com/apache/arrow/pull/8553#issuecomment-722690860
@jorgecarleitao and @andygrove -- I did some profiling of the tpch
benchmark (SF10) locally on my laptop this afternoon. I was not able to
reproduce a slowdown on this branch
alamb commented on pull request #8553:
URL: https://github.com/apache/arrow/pull/8553#issuecomment-720409056
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
