[GitHub] [arrow] alippai edited a comment on pull request #10181: ARROW-12578: [JS] Remove Buffer in favor of TextEncoder API in NodeJS

2021-05-14 Thread GitBox
alippai edited a comment on pull request #10181: URL: https://github.com/apache/arrow/pull/10181#issuecomment-841541780 I'm closing this, as we agree that we don't want to remove the Buffer API. Additional ideas for speedup: Encode: Use TextEncoder..encodeInto() and pre-allocate

[GitHub] [arrow] alippai edited a comment on pull request #10181: ARROW-12578: [JS] Remove Buffer in favor of TextEncoder API in NodeJS

2021-05-14 Thread GitBox
alippai edited a comment on pull request #10181: URL: https://github.com/apache/arrow/pull/10181#issuecomment-841520624 During benchmarking it I realized that we already use TextEncoder and TextDecoder only. `useNativeEncoders` is always evaluated to `true` in all supported Node version