[GitHub] [arrow] bkietz commented on a change in pull request #7120: ARROW-8727: [C++] Don't require stack allocation of any object to use StringConverter, hide behind ParseValue function

2020-05-08 Thread GitBox
bkietz commented on a change in pull request #7120: URL: https://github.com/apache/arrow/pull/7120#discussion_r422353994 ## File path: cpp/src/arrow/util/value_parsing.h ## @@ -484,6 +455,14 @@ static inline bool ParseHH_MM_SS(const char* s, std::chrono::duration* } //

[GitHub] [arrow] bkietz commented on a change in pull request #7120: ARROW-8727: [C++] Don't require stack allocation of any object to use StringConverter, hide behind ParseValue function

2020-05-08 Thread GitBox
bkietz commented on a change in pull request #7120: URL: https://github.com/apache/arrow/pull/7120#discussion_r422259138 ## File path: cpp/src/arrow/util/value_parsing.cc ## @@ -43,46 +44,43 @@ struct StringToFloatConverter::Impl {