[GitHub] [arrow] bkietz commented on a change in pull request #9725: ARROW-8631: [C++][Python][Dataset] Add ReadOptions to CsvFileFormat, expose options to python

2021-03-17 Thread GitBox
bkietz commented on a change in pull request #9725: URL: https://github.com/apache/arrow/pull/9725#discussion_r596092120 ## File path: cpp/src/arrow/dataset/file_csv.h ## @@ -37,6 +37,11 @@ class ARROW_DS_EXPORT CsvFileFormat : public FileFormat { public: /// Options affec

[GitHub] [arrow] bkietz commented on a change in pull request #9725: ARROW-8631: [C++][Python][Dataset] Add ReadOptions to CsvFileFormat, expose options to python

2021-03-17 Thread GitBox
bkietz commented on a change in pull request #9725: URL: https://github.com/apache/arrow/pull/9725#discussion_r596084650 ## File path: cpp/src/arrow/dataset/dataset_internal.h ## @@ -185,5 +185,14 @@ inline bool operator==(const SubtreeImpl::Encoded& l, const SubtreeImpl::Enco

[GitHub] [arrow] bkietz commented on a change in pull request #9725: ARROW-8631: [C++][Python][Dataset] Add ReadOptions to CsvFileFormat, expose options to python

2021-03-18 Thread GitBox
bkietz commented on a change in pull request #9725: URL: https://github.com/apache/arrow/pull/9725#discussion_r597085956 ## File path: python/pyarrow/_dataset.pyx ## @@ -1363,10 +1388,21 @@ cdef class CsvFileFormat(FileFormat): cdef: CCsvFileFormat* csv_format -

[GitHub] [arrow] bkietz commented on a change in pull request #9725: ARROW-8631: [C++][Python][Dataset] Add ReadOptions to CsvFileFormat, expose options to python

2021-03-18 Thread GitBox
bkietz commented on a change in pull request #9725: URL: https://github.com/apache/arrow/pull/9725#discussion_r597084271 ## File path: cpp/src/arrow/dataset/file_csv.h ## @@ -38,6 +38,13 @@ class ARROW_DS_EXPORT CsvFileFormat : public FileFormat { public: /// Options affec