[GitHub] [arrow] emkornfield commented on a change in pull request #7973: ARROW-8493: [C++][Parquet] Start populating repeated ancestor defintion

2020-08-26 Thread GitBox
emkornfield commented on a change in pull request #7973: URL: https://github.com/apache/arrow/pull/7973#discussion_r478100513 ## File path: cpp/src/parquet/arrow/arrow_schema_test.cc ## @@ -1140,5 +1144,244 @@ TEST(TestFromParquetSchema, CorruptMetadata) { ASSERT_RAISES(IOEr

[GitHub] [arrow] emkornfield commented on a change in pull request #7973: ARROW-8493: [C++][Parquet] Start populating repeated ancestor defintion

2020-08-20 Thread GitBox
emkornfield commented on a change in pull request #7973: URL: https://github.com/apache/arrow/pull/7973#discussion_r474409559 ## File path: cpp/src/parquet/arrow/schema.cc ## @@ -410,21 +410,66 @@ ::arrow::Result> GetTypeForNode( return storage_type; } -Status NodeToSche

[GitHub] [arrow] emkornfield commented on a change in pull request #7973: ARROW-8493: [C++][Parquet] Start populating repeated ancestor defintion

2020-08-20 Thread GitBox
emkornfield commented on a change in pull request #7973: URL: https://github.com/apache/arrow/pull/7973#discussion_r474391446 ## File path: cpp/src/parquet/arrow/arrow_schema_test.cc ## @@ -1140,5 +1143,231 @@ TEST(TestFromParquetSchema, CorruptMetadata) { ASSERT_RAISES(IOEr

[GitHub] [arrow] emkornfield commented on a change in pull request #7973: ARROW-8493: [C++][Parquet] Start populating repeated ancestor defintion

2020-08-16 Thread GitBox
emkornfield commented on a change in pull request #7973: URL: https://github.com/apache/arrow/pull/7973#discussion_r471123867 ## File path: cpp/src/parquet/arrow/arrow_schema_test.cc ## @@ -1140,5 +1144,235 @@ TEST(TestFromParquetSchema, CorruptMetadata) { ASSERT_RAISES(IOEr