emkornfield commented on pull request #8589:
URL: https://github.com/apache/arrow/pull/8589#issuecomment-724611663
@chrisavl I'm done pushing. I expanded the test case to try to cover all
branches in the new slice method and reverted my previous changes. Let me know
if the new code looks
emkornfield commented on pull request #8589:
URL: https://github.com/apache/arrow/pull/8589#issuecomment-72564
I will move the slice method into parquet, expect some pushes to the branch
over the next couple of hours.
Th
emkornfield commented on pull request #8589:
URL: https://github.com/apache/arrow/pull/8589#issuecomment-722939001
Okay, I'm done pushing. @chrisavl I think the new API should make the
change for parquet_writer smaller (and probably more efficient). See unit
tests added for intended usag
emkornfield commented on pull request #8589:
URL: https://github.com/apache/arrow/pull/8589#issuecomment-722909212
NM, I'm going to take a different approach, because the one here doesn't
account for dictionaries.
This is an
emkornfield commented on pull request #8589:
URL: https://github.com/apache/arrow/pull/8589#issuecomment-722906035
just realized there are some constness issues I need to address.
This is an automated message from the Apache
emkornfield commented on pull request #8589:
URL: https://github.com/apache/arrow/pull/8589#issuecomment-722870334
@chrisavl I added a new interface that you should be able to use for
replacing the second buffer for arrow writing. I'm going to push one more
commit which will add tests. C
