[GitHub] [arrow] houqp commented on a change in pull request #7365: ARROW-9007: [Rust] Support appending array data to builders

2020-06-07 Thread GitBox
houqp commented on a change in pull request #7365: URL: https://github.com/apache/arrow/pull/7365#discussion_r436336846 ## File path: rust/arrow/src/array/builder.rs ## @@ -577,6 +632,81 @@ where self } +/// Appends data from other arrays into the builder +

[GitHub] [arrow] houqp commented on a change in pull request #7365: ARROW-9007: [Rust] Support appending array data to builders

2020-06-07 Thread GitBox
houqp commented on a change in pull request #7365: URL: https://github.com/apache/arrow/pull/7365#discussion_r436335986 ## File path: rust/arrow/src/array/builder.rs ## @@ -841,12 +1048,91 @@ impl ArrayBuilder for StringBuilder { } } +// Helper function for appending

[GitHub] [arrow] houqp commented on a change in pull request #7365: ARROW-9007: [Rust] Support appending array data to builders

2020-06-06 Thread GitBox
houqp commented on a change in pull request #7365: URL: https://github.com/apache/arrow/pull/7365#discussion_r436303006 ## File path: rust/arrow/src/array/builder.rs ## @@ -841,12 +1048,91 @@ impl ArrayBuilder for StringBuilder { } } +// Helper function for appending

[GitHub] [arrow] houqp commented on a change in pull request #7365: ARROW-9007: [Rust] Support appending array data to builders

2020-06-06 Thread GitBox
houqp commented on a change in pull request #7365: URL: https://github.com/apache/arrow/pull/7365#discussion_r436301311 ## File path: rust/arrow/src/array/builder.rs ## @@ -577,6 +632,81 @@ where self } +/// Appends data from other arrays into the builder +

[GitHub] [arrow] houqp commented on a change in pull request #7365: ARROW-9007: [Rust] Support appending array data to builders

2020-06-06 Thread GitBox
houqp commented on a change in pull request #7365: URL: https://github.com/apache/arrow/pull/7365#discussion_r436301311 ## File path: rust/arrow/src/array/builder.rs ## @@ -577,6 +632,81 @@ where self } +/// Appends data from other arrays into the builder +

[GitHub] [arrow] houqp commented on a change in pull request #7365: ARROW-9007: [Rust] Support appending array data to builders

2020-06-06 Thread GitBox
houqp commented on a change in pull request #7365: URL: https://github.com/apache/arrow/pull/7365#discussion_r436250767 ## File path: rust/arrow/src/array/builder.rs ## @@ -577,6 +620,78 @@ where self } +/// Appends data from other arrays into the builder +