[GitHub] [arrow] ianmcook commented on a change in pull request #10327: ARROW-12781: [R] Implement is.type() functions for dplyr

2021-05-30 Thread GitBox
ianmcook commented on a change in pull request #10327: URL: https://github.com/apache/arrow/pull/10327#discussion_r642087084 ## File path: r/R/type.R ## @@ -423,6 +423,24 @@ as_type <- function(type, name = "type") { type } +canonical_type_str <- function(type_str) { Rev

[GitHub] [arrow] ianmcook commented on a change in pull request #10327: ARROW-12781: [R] Implement is.type() functions for dplyr

2021-05-28 Thread GitBox
ianmcook commented on a change in pull request #10327: URL: https://github.com/apache/arrow/pull/10327#discussion_r641733353 ## File path: r/R/type.R ## @@ -423,6 +423,24 @@ as_type <- function(type, name = "type") { type } +canonical_type_str <- function(type_str) { Rev

[GitHub] [arrow] ianmcook commented on a change in pull request #10327: ARROW-12781: [R] Implement is.type() functions for dplyr

2021-05-27 Thread GitBox
ianmcook commented on a change in pull request #10327: URL: https://github.com/apache/arrow/pull/10327#discussion_r641193677 ## File path: r/R/dplyr-functions.R ## @@ -109,6 +119,55 @@ nse_funcs$as.numeric <- function(x) { Expression$create("cast", x, options = cast_options(

[GitHub] [arrow] ianmcook commented on a change in pull request #10327: ARROW-12781: [R] Implement is.type() functions for dplyr

2021-05-26 Thread GitBox
ianmcook commented on a change in pull request #10327: URL: https://github.com/apache/arrow/pull/10327#discussion_r640241809 ## File path: r/R/dplyr-functions.R ## @@ -109,6 +119,55 @@ nse_funcs$as.numeric <- function(x) { Expression$create("cast", x, options = cast_options(

[GitHub] [arrow] ianmcook commented on a change in pull request #10327: ARROW-12781: [R] Implement is.type() functions for dplyr

2021-05-26 Thread GitBox
ianmcook commented on a change in pull request #10327: URL: https://github.com/apache/arrow/pull/10327#discussion_r640241437 ## File path: r/R/type.R ## @@ -423,6 +423,24 @@ as_type <- function(type, name = "type") { type } +canonical_type_str <- function(type_str) { Rev

[GitHub] [arrow] ianmcook commented on a change in pull request #10327: ARROW-12781: [R] Implement is.type() functions for dplyr

2021-05-26 Thread GitBox
ianmcook commented on a change in pull request #10327: URL: https://github.com/apache/arrow/pull/10327#discussion_r640240623 ## File path: r/R/type.R ## @@ -423,6 +423,24 @@ as_type <- function(type, name = "type") { type } +canonical_type_str <- function(type_str) { + #

[GitHub] [arrow] ianmcook commented on a change in pull request #10327: ARROW-12781: [R] Implement is.type() functions for dplyr

2021-05-26 Thread GitBox
ianmcook commented on a change in pull request #10327: URL: https://github.com/apache/arrow/pull/10327#discussion_r640059959 ## File path: r/R/dplyr-functions.R ## @@ -58,7 +58,16 @@ nse_funcs$cast <- function(x, target_type, safe = TRUE, ...) { } nse_funcs$is <- function(

[GitHub] [arrow] ianmcook commented on a change in pull request #10327: ARROW-12781: [R] Implement is.type() functions for dplyr

2021-05-22 Thread GitBox
ianmcook commented on a change in pull request #10327: URL: https://github.com/apache/arrow/pull/10327#discussion_r637423216 ## File path: r/R/dplyr-functions.R ## @@ -109,6 +126,55 @@ nse_funcs$as.numeric <- function(x) { Expression$create("cast", x, options = cast_options(

[GitHub] [arrow] ianmcook commented on a change in pull request #10327: ARROW-12781: [R] Implement is.type() functions for dplyr

2021-05-20 Thread GitBox
ianmcook commented on a change in pull request #10327: URL: https://github.com/apache/arrow/pull/10327#discussion_r636614537 ## File path: r/R/dplyr-functions.R ## @@ -109,6 +109,39 @@ nse_funcs$as.numeric <- function(x) { Expression$create("cast", x, options = cast_options(

[GitHub] [arrow] ianmcook commented on a change in pull request #10327: ARROW-12781: [R] Implement is.type() functions for dplyr

2021-05-20 Thread GitBox
ianmcook commented on a change in pull request #10327: URL: https://github.com/apache/arrow/pull/10327#discussion_r636523993 ## File path: r/R/expression.R ## @@ -76,7 +76,15 @@ Expression <- R6Class("Expression", inherit = ArrowObject, public = list( ToString = functi

[GitHub] [arrow] ianmcook commented on a change in pull request #10327: ARROW-12781: [R] Implement is.type() functions for dplyr

2021-05-20 Thread GitBox
ianmcook commented on a change in pull request #10327: URL: https://github.com/apache/arrow/pull/10327#discussion_r636520911 ## File path: r/R/expression.R ## @@ -76,7 +76,15 @@ Expression <- R6Class("Expression", inherit = ArrowObject, public = list( ToString = functi

[GitHub] [arrow] ianmcook commented on a change in pull request #10327: ARROW-12781: [R] Implement is.type() functions for dplyr

2021-05-20 Thread GitBox
ianmcook commented on a change in pull request #10327: URL: https://github.com/apache/arrow/pull/10327#discussion_r636505859 ## File path: r/R/dplyr-functions.R ## @@ -109,6 +109,39 @@ nse_funcs$as.numeric <- function(x) { Expression$create("cast", x, options = cast_options(

[GitHub] [arrow] ianmcook commented on a change in pull request #10327: ARROW-12781: [R] Implement is.type() functions for dplyr

2021-05-14 Thread GitBox
ianmcook commented on a change in pull request #10327: URL: https://github.com/apache/arrow/pull/10327#discussion_r632797152 ## File path: r/R/expression.R ## @@ -76,7 +76,15 @@ Expression <- R6Class("Expression", inherit = ArrowObject, public = list( ToString = functi

[GitHub] [arrow] ianmcook commented on a change in pull request #10327: ARROW-12781: [R] Implement is.type() functions for dplyr

2021-05-14 Thread GitBox
ianmcook commented on a change in pull request #10327: URL: https://github.com/apache/arrow/pull/10327#discussion_r632795341 ## File path: r/R/expression.R ## @@ -76,7 +76,15 @@ Expression <- R6Class("Expression", inherit = ArrowObject, public = list( ToString = functi