[GitHub] [arrow] jorisvandenbossche commented on a change in pull request #8294: ARROW-1846: [C++][Compute] Implement "any" reduction kernel for boolean data

2020-11-13 Thread GitBox
jorisvandenbossche commented on a change in pull request #8294: URL: https://github.com/apache/arrow/pull/8294#discussion_r522942123 ## File path: cpp/src/arrow/compute/api_aggregate.cc ## @@ -41,8 +41,12 @@ Result MinMax(const Datum& value, const MinMaxOptions& options, ExecC

[GitHub] [arrow] jorisvandenbossche commented on a change in pull request #8294: ARROW-1846: [C++][Compute] Implement "any" reduction kernel for boolean data

2020-11-13 Thread GitBox
jorisvandenbossche commented on a change in pull request #8294: URL: https://github.com/apache/arrow/pull/8294#discussion_r522941736 ## File path: cpp/src/arrow/compute/api_aggregate.h ## @@ -154,7 +154,21 @@ Result MinMax(const Datum& value, const MinMaxO

[GitHub] [arrow] jorisvandenbossche commented on a change in pull request #8294: ARROW-1846: [C++][Compute] Implement "any" reduction kernel for boolean data

2020-10-14 Thread GitBox
jorisvandenbossche commented on a change in pull request #8294: URL: https://github.com/apache/arrow/pull/8294#discussion_r504462669 ## File path: cpp/src/arrow/compute/api_aggregate.h ## @@ -142,6 +142,20 @@ Result MinMax(const Datum& value, const MinMaxO

[GitHub] [arrow] jorisvandenbossche commented on a change in pull request #8294: ARROW-1846: [C++][Compute] Implement "any" reduction kernel for boolean data

2020-10-13 Thread GitBox
jorisvandenbossche commented on a change in pull request #8294: URL: https://github.com/apache/arrow/pull/8294#discussion_r504419732 ## File path: cpp/src/arrow/compute/api_aggregate.h ## @@ -142,6 +142,20 @@ Result MinMax(const Datum& value, const MinMaxO

[GitHub] [arrow] jorisvandenbossche commented on a change in pull request #8294: ARROW-1846: [C++][Compute] Implement "any" reduction kernel for boolean data

2020-10-13 Thread GitBox
jorisvandenbossche commented on a change in pull request #8294: URL: https://github.com/apache/arrow/pull/8294#discussion_r504113404 ## File path: cpp/src/arrow/compute/api_aggregate.h ## @@ -142,6 +142,20 @@ Result MinMax(const Datum& value, const MinMaxO

[GitHub] [arrow] jorisvandenbossche commented on a change in pull request #8294: ARROW-1846: [C++][Compute] Implement "any" reduction kernel for boolean data

2020-10-13 Thread GitBox
jorisvandenbossche commented on a change in pull request #8294: URL: https://github.com/apache/arrow/pull/8294#discussion_r503927482 ## File path: cpp/src/arrow/compute/api_aggregate.h ## @@ -142,6 +142,20 @@ Result MinMax(const Datum& value, const MinMaxO

[GitHub] [arrow] jorisvandenbossche commented on a change in pull request #8294: ARROW-1846: [C++][Compute] Implement "any" reduction kernel for boolean data

2020-10-13 Thread GitBox
jorisvandenbossche commented on a change in pull request #8294: URL: https://github.com/apache/arrow/pull/8294#discussion_r503927482 ## File path: cpp/src/arrow/compute/api_aggregate.h ## @@ -142,6 +142,20 @@ Result MinMax(const Datum& value, const MinMaxO