[GitHub] [arrow] jorisvandenbossche commented on pull request #8894: ARROW-10322: [C++][Dataset] Minimize Expression

2021-01-07 Thread GitBox
jorisvandenbossche commented on pull request #8894: URL: https://github.com/apache/arrow/pull/8894#issuecomment-756223249 The `ProjectOptions` also still need to be exposed in Python -> opened https://issues.apache.org/jira/browse/ARROW-11166 --

[GitHub] [arrow] jorisvandenbossche commented on pull request #8894: ARROW-10322: [C++][Dataset] Minimize Expression

2021-01-07 Thread GitBox
jorisvandenbossche commented on pull request #8894: URL: https://github.com/apache/arrow/pull/8894#issuecomment-756222590 > > [@pitrou] I'm also curious why it's called "project". It sounds rather imprecise, though it may be the conventional term for this operation?) > > [@bkietz] "pr

[GitHub] [arrow] jorisvandenbossche commented on pull request #8894: ARROW-10322: [C++][Dataset] Minimize Expression

2021-01-06 Thread GitBox
jorisvandenbossche commented on pull request #8894: URL: https://github.com/apache/arrow/pull/8894#issuecomment-755427844 (I reviewed the minimal python changes, which look good, and looked at part of the C++ dataset changes, but no need to wait on further review from my side) ---

[GitHub] [arrow] jorisvandenbossche commented on pull request #8894: ARROW-10322: [C++][Dataset] Minimize Expression

2021-01-05 Thread GitBox
jorisvandenbossche commented on pull request #8894: URL: https://github.com/apache/arrow/pull/8894#issuecomment-754888067 (the failing test-conda-python-3.7-pandas-latest is the same serialization test failure as mentioned above) ---

[GitHub] [arrow] jorisvandenbossche commented on pull request #8894: ARROW-10322: [C++][Dataset] Minimize Expression

2021-01-05 Thread GitBox
jorisvandenbossche commented on pull request #8894: URL: https://github.com/apache/arrow/pull/8894#issuecomment-754857132 The python failure looks legit: ``` test_expression_serialization _ def test_expression_serializat

[GitHub] [arrow] jorisvandenbossche commented on pull request #8894: ARROW-10322: [C++][Dataset] Minimize Expression

2021-01-05 Thread GitBox
jorisvandenbossche commented on pull request #8894: URL: https://github.com/apache/arrow/pull/8894#issuecomment-754855874 Ah, the bot doesn't work at the moment I suppose. I ran the dask/parquet tests locally, and they are passing. I also ran my tax-dataset dask notebook with some q