[GitHub] [arrow] kou commented on pull request #33803: GH-33787: [C++] arrow/cpp/src/arrow/util/cpu_info.cc: the -Werror triggers an error: statement has no effect [-Werror=unused-value]

2023-01-22 Thread via GitHub
kou commented on PR #33803: URL: https://github.com/apache/arrow/pull/33803#issuecomment-1399607221 I close this in favor of #33828. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[GitHub] [arrow] kou commented on pull request #33803: GH-33787: [C++] arrow/cpp/src/arrow/util/cpu_info.cc: the -Werror triggers an error: statement has no effect [-Werror=unused-value]

2023-01-20 Thread via GitHub
kou commented on PR #33803: URL: https://github.com/apache/arrow/pull/33803#issuecomment-1399152264 How about this? ```diff diff --git a/cpp/src/arrow/util/cpu_info.cc b/cpp/src/arrow/util/cpu_info.cc index 3ba8db216..08b7b8b21 100644 --- a/cpp/src/arrow/util/cpu_info.cc ++