[GitHub] [arrow] kou commented on pull request #7430: ARROW-9126: [C++] Fix building trimmed Boost bundle on Windows

2020-06-16 Thread GitBox
kou commented on pull request #7430: URL: https://github.com/apache/arrow/pull/7430#issuecomment-645084134 > Done. Thanks! Now, I'm a member of https://bintray.com/ursalabs . (Please ignore my meaningless join request...) > We could I guess, though I don't think I have

[GitHub] [arrow] kou commented on pull request #7430: ARROW-9126: [C++] Fix building trimmed Boost bundle on Windows

2020-06-16 Thread GitBox
kou commented on pull request #7430: URL: https://github.com/apache/arrow/pull/7430#issuecomment-645015432 OK. Could you update the bundle and then re-run the build? And could you add me ( https://bintray.com/kou ) to https://bintray.com/ursalabs 's members? I may want to upload

[GitHub] [arrow] kou commented on pull request #7430: ARROW-9126: [C++] Fix building trimmed Boost bundle on Windows

2020-06-15 Thread GitBox
kou commented on pull request #7430: URL: https://github.com/apache/arrow/pull/7430#issuecomment-644468001 Failed. Do we need to re-generate our Boost archive? This is an automated message from the Apache Git Service. To

[GitHub] [arrow] kou commented on pull request #7430: ARROW-9126: [C++] Fix building trimmed Boost bundle on Windows

2020-06-15 Thread GitBox
kou commented on pull request #7430: URL: https://github.com/apache/arrow/pull/7430#issuecomment-644450282 OK. Let's try it in this pull request. If it doesn't increase build time much, we can change the current job. This

[GitHub] [arrow] kou commented on pull request #7430: ARROW-9126: [C++] Fix building trimmed Boost bundle on Windows

2020-06-15 Thread GitBox
kou commented on pull request #7430: URL: https://github.com/apache/arrow/pull/7430#issuecomment-644412255 It will work but it may increase CI time for "C++ / AMD64 Windows 2019 C++". Increasing CI time may not be acceptable.

[GitHub] [arrow] kou commented on pull request #7430: ARROW-9126: [C++] Fix building trimmed Boost bundle on Windows

2020-06-15 Thread GitBox
kou commented on pull request #7430: URL: https://github.com/apache/arrow/pull/7430#issuecomment-644397052 > Since the builds have been green, we must not have any CI jobs that test building with bundled boost and thrift on MSVC. Should we add one (nightly perhaps)? @kou thoughts?