[GitHub] [arrow] kou commented on pull request #8243: ARROW-10068: [C++] Add bundled external project for aws-sdk-cpp

2020-09-23 Thread GitBox
kou commented on pull request #8243: URL: https://github.com/apache/arrow/pull/8243#issuecomment-697989129 Ah, wheel... This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [arrow] kou commented on pull request #8243: ARROW-10068: [C++] Add bundled external project for aws-sdk-cpp

2020-09-22 Thread GitBox
kou commented on pull request #8243: URL: https://github.com/apache/arrow/pull/8243#issuecomment-697151804 Right. It seems that we need to specify `-DBUILD_SHARED_LIBS=off`. This is an automated message from the Ap

[GitHub] [arrow] kou commented on pull request #8243: ARROW-10068: [C++] Add bundled external project for aws-sdk-cpp

2020-09-22 Thread GitBox
kou commented on pull request #8243: URL: https://github.com/apache/arrow/pull/8243#issuecomment-697040532 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[GitHub] [arrow] kou commented on pull request #8243: ARROW-10068: [C++] Add bundled external project for aws-sdk-cpp

2020-09-22 Thread GitBox
kou commented on pull request #8243: URL: https://github.com/apache/arrow/pull/8243#issuecomment-697049024 Ah, we can use `$` https://cmake.org/cmake/help/latest/manual/cmake-generator-expressions.7.html#escaped-characters instead of `LIST_SEPARATOR` like TileDB does: https://github.com/T

[GitHub] [arrow] kou commented on pull request #8243: ARROW-10068: [C++] Add bundled external project for aws-sdk-cpp

2020-09-22 Thread GitBox
kou commented on pull request #8243: URL: https://github.com/apache/arrow/pull/8243#issuecomment-697047650 It's not a strong opinion but I'm negative we bundle OpenSSL. OpenSSL is a security related product. I'm not sure we can release a new version ASAP when bundled OpenSSL has a vulner

[GitHub] [arrow] kou commented on pull request #8243: ARROW-10068: [C++] Add bundled external project for aws-sdk-cpp

2020-09-22 Thread GitBox
kou commented on pull request #8243: URL: https://github.com/apache/arrow/pull/8243#issuecomment-697040532 For the ubuntu R jobs, the following patch will fix them: ```diff diff --git a/cpp/cmake_modules/ThirdpartyToolchain.cmake b/cpp/cmake_modules/ThirdpartyToolchain.cmake in