[GitHub] [arrow] lidavidm commented on pull request #10356: ARROW-12715: [C++][Python] Add SQL LIKE match kernel

2021-05-20 Thread GitBox
lidavidm commented on pull request #10356: URL: https://github.com/apache/arrow/pull/10356#issuecomment-845185507 Merged, thanks for the review! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [arrow] lidavidm commented on pull request #10356: ARROW-12715: [C++][Python] Add SQL LIKE match kernel

2021-05-20 Thread GitBox
lidavidm commented on pull request #10356: URL: https://github.com/apache/arrow/pull/10356#issuecomment-845138005 I filed ARROW-12835. I think this PR should be otherwise good-to-go then, unless we need to also add R bindings. -- This is an automated message from the Apache Git Service.

[GitHub] [arrow] lidavidm commented on pull request #10356: ARROW-12715: [C++][Python] Add SQL LIKE match kernel

2021-05-20 Thread GitBox
lidavidm commented on pull request #10356: URL: https://github.com/apache/arrow/pull/10356#issuecomment-845101882 We could add it to `MatchSubstringOptions`, if we plan to support for all kernels, and leave it unimplemented for now in the non-regex case (it's pretty easy to support in any

[GitHub] [arrow] lidavidm commented on pull request #10356: ARROW-12715: [C++][Python] Add SQL LIKE match kernel

2021-05-19 Thread GitBox
lidavidm commented on pull request #10356: URL: https://github.com/apache/arrow/pull/10356#issuecomment-844542476 No, but in that case we'd just not dispatch to that path. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[GitHub] [arrow] lidavidm commented on pull request #10356: ARROW-12715: [C++][Python] Add SQL LIKE match kernel

2021-05-19 Thread GitBox
lidavidm commented on pull request #10356: URL: https://github.com/apache/arrow/pull/10356#issuecomment-844540228 We could easily add a flag to toggle insensitivity in RE2 as well. (Would be better than allocating a new string and potentially dealing with Unicode.) -- This is an automate