[GitHub] [arrow] liyafan82 commented on pull request #7326: ARROW-9010: [Java] Framework and interface changes for RecordBatch IPC buffer compression

2020-08-24 Thread GitBox
liyafan82 commented on pull request #7326: URL: https://github.com/apache/arrow/pull/7326#issuecomment-679458247 > > The conda integration test is failing, because the default no compression option is not supported by the specification. Maybe we need to start a discussion in the ML. >

[GitHub] [arrow] liyafan82 commented on pull request #7326: ARROW-9010: [Java] Framework and interface changes for RecordBatch IPC buffer compression

2020-08-16 Thread GitBox
liyafan82 commented on pull request #7326: URL: https://github.com/apache/arrow/pull/7326#issuecomment-674618715 > > The conda integration test is failing, because the default no compression option is not supported by the specification. Maybe we need to start a discussion in the ML. >

[GitHub] [arrow] liyafan82 commented on pull request #7326: ARROW-9010: [Java] Framework and interface changes for RecordBatch IPC buffer compression

2020-08-12 Thread GitBox
liyafan82 commented on pull request #7326: URL: https://github.com/apache/arrow/pull/7326#issuecomment-673213128 The conda integration test is failing, because the default no compression option is not supported by the specification. Maybe we need to start a discussion in the ML. ---

[GitHub] [arrow] liyafan82 commented on pull request #7326: ARROW-9010: [Java] Framework and interface changes for RecordBatch IPC buffer compression

2020-08-05 Thread GitBox
liyafan82 commented on pull request #7326: URL: https://github.com/apache/arrow/pull/7326#issuecomment-669111978 > At the very least I think this needs more comments as to why it appears that manual serializion of flatbuffer data is being used. > > It would also be nice to avoid intr

[GitHub] [arrow] liyafan82 commented on pull request #7326: ARROW-9010: [Java] Framework and interface changes for RecordBatch IPC buffer compression

2020-06-15 Thread GitBox
liyafan82 commented on pull request #7326: URL: https://github.com/apache/arrow/pull/7326#issuecomment-644563536 > Hi, I have a question... probably not related to what this PR focus on. > What if the compressor / decompressor for the codec will have JNI call for compression / decomperss

[GitHub] [arrow] liyafan82 commented on pull request #7326: ARROW-9010: [Java] Framework and interface changes for RecordBatch IPC buffer compression

2020-06-09 Thread GitBox
liyafan82 commented on pull request #7326: URL: https://github.com/apache/arrow/pull/7326#issuecomment-640584596 Thanks a lot for your good comments. Please see my reply in line. > Looks good, few minor comments. It would be good to see this in a test (if that is reasonable/possible