[GitHub] [arrow] maartenbreddels commented on pull request #7593: ARROW-9160: [C++] Implement contains for exact matches

2020-07-02 Thread GitBox
maartenbreddels commented on pull request #7593: URL: https://github.com/apache/arrow/pull/7593#issuecomment-653047332 String is a subclass of binary right? So I expect binary_contains_exact to work on strings right? This is

[GitHub] [arrow] maartenbreddels commented on pull request #7593: ARROW-9160: [C++] Implement contains for exact matches

2020-07-01 Thread GitBox
maartenbreddels commented on pull request #7593: URL: https://github.com/apache/arrow/pull/7593#issuecomment-652263794 While at the difficult topic of naming, is there a conversion (agreed or emerging) for naming the functors/ArrayKernelExec implementations? I see in `scalar_string.cc` we

[GitHub] [arrow] maartenbreddels commented on pull request #7593: ARROW-9160: [C++] Implement contains for exact matches

2020-07-01 Thread GitBox
maartenbreddels commented on pull request #7593: URL: https://github.com/apache/arrow/pull/7593#issuecomment-652254096 I like the prefixing by `string`. I'm a big fan of ordering 'words' in snake or camel casing for good tab completion and alphabetic ordering, so I agree with @wesm 's prop