[GitHub] [arrow] nealrichardson commented on a change in pull request #7318: ARROW-8917: [C++] Formalize "metafunction" concept. Add Take and Filter metafunctions, port R and Python bindings

2020-06-06 Thread GitBox
nealrichardson commented on a change in pull request #7318: URL: https://github.com/apache/arrow/pull/7318#discussion_r436304103 ## File path: r/R/chunked-array.R ## @@ -75,23 +75,15 @@ ChunkedArray <- R6Class("ChunkedArray", inherit = ArrowObject, if (is.integer(i)) {

[GitHub] [arrow] nealrichardson commented on a change in pull request #7318: ARROW-8917: [C++] Formalize "metafunction" concept. Add Take and Filter metafunctions, port R and Python bindings

2020-06-02 Thread GitBox
nealrichardson commented on a change in pull request #7318: URL: https://github.com/apache/arrow/pull/7318#discussion_r434285021 ## File path: r/R/table.R ## @@ -146,21 +146,15 @@ Table <- R6Class("Table", inherit = ArrowObject, if (is.integer(i)) { i <- Array$c

[GitHub] [arrow] nealrichardson commented on a change in pull request #7318: ARROW-8917: [C++] Formalize "metafunction" concept. Add Take and Filter metafunctions, port R and Python bindings

2020-06-02 Thread GitBox
nealrichardson commented on a change in pull request #7318: URL: https://github.com/apache/arrow/pull/7318#discussion_r434284600 ## File path: r/R/record-batch.R ## @@ -121,14 +121,13 @@ RecordBatch <- R6Class("RecordBatch", inherit = ArrowObject, assert_is(i, "Array")

[GitHub] [arrow] nealrichardson commented on a change in pull request #7318: ARROW-8917: [C++] Formalize "metafunction" concept. Add Take and Filter metafunctions, port R and Python bindings

2020-06-02 Thread GitBox
nealrichardson commented on a change in pull request #7318: URL: https://github.com/apache/arrow/pull/7318#discussion_r434284526 ## File path: r/R/chunked-array.R ## @@ -75,23 +75,15 @@ ChunkedArray <- R6Class("ChunkedArray", inherit = ArrowObject, if (is.integer(i)) {