[GitHub] [arrow] nealrichardson commented on pull request #9615: ARROW-3316: [R] Multi-threaded conversion from R data.frame to Arrow table / record batch

2021-06-02 Thread GitBox
nealrichardson commented on pull request #9615: URL: https://github.com/apache/arrow/pull/9615#issuecomment-853293852 Thanks @westonpace, I'll merge now and make a followup -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [arrow] nealrichardson commented on pull request #9615: ARROW-3316: [R] Multi-threaded conversion from R data.frame to Arrow table / record batch

2021-05-25 Thread GitBox
nealrichardson commented on pull request #9615: URL: https://github.com/apache/arrow/pull/9615#issuecomment-848297121 @romainfrancois @westonpace @jonkeane Is this ready to merge? (The rtools35 error is spurious) -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [arrow] nealrichardson commented on pull request #9615: ARROW-3316: [R] Multi-threaded conversion from R data.frame to Arrow table / record batch

2021-05-14 Thread GitBox
nealrichardson commented on pull request #9615: URL: https://github.com/apache/arrow/pull/9615#issuecomment-841545022 I think this needs rebase, and then that should expose the other place where `Table__from_dots` is called that needs `options_use_threads()` passed to it (which is the fail

[GitHub] [arrow] nealrichardson commented on pull request #9615: ARROW-3316: [R] Multi-threaded conversion from R data.frame to Arrow table / record batch

2021-05-12 Thread GitBox
nealrichardson commented on pull request #9615: URL: https://github.com/apache/arrow/pull/9615#issuecomment-840145156 I wonder if the logic for "parallelize what you can, then do the rest in serial" isn't working right. Maybe the natural datasets all have at least one column (string, most

[GitHub] [arrow] nealrichardson commented on pull request #9615: ARROW-3316: [R] Multi-threaded conversion from R data.frame to Arrow table / record batch

2021-05-06 Thread GitBox
nealrichardson commented on pull request #9615: URL: https://github.com/apache/arrow/pull/9615#issuecomment-833924620 I'm a little skeptical, with the exception of the big change on the data.frames of factor columns, that this isn't just noise. I don't think there's been any other changes