[GitHub] [arrow] nevi-me commented on pull request #8590: ARROW-10042: [Rust] BufferData's equality should depend on its capacity; ArrayData's equality should not depend on its BufferDatas' capacities

2020-11-10 Thread GitBox
nevi-me commented on pull request #8590: URL: https://github.com/apache/arrow/pull/8590#issuecomment-724977488 Hi @carols10cents, with the IPC integration and logical equality PRs merged, this should be ready (the Parquet changes). We can merge it in after you rebase :) ---

[GitHub] [arrow] nevi-me commented on pull request #8590: ARROW-10042: [Rust] BufferData's equality should depend on its capacity; ArrayData's equality should not depend on its BufferDatas' capacities

2020-11-07 Thread GitBox
nevi-me commented on pull request #8590: URL: https://github.com/apache/arrow/pull/8590#issuecomment-723429467 > One idea: > > 1. Make the array comparison on the parquet tests be done using the `PartialEq`, like this PR is doing > 2. Make `PartialEq` use the function `equal` bein