[GitHub] [arrow] pitrou commented on pull request #7593: ARROW-9160: [C++] Implement contains for exact matches

2020-07-02 Thread GitBox
pitrou commented on pull request #7593: URL: https://github.com/apache/arrow/pull/7593#issuecomment-653053165 Right, I was just mentioned that "binary" isn't exclusive of "utf8" in this particular instance. However, I'm not sure why we need prefixes. "contains" seems sufficient to me :-

[GitHub] [arrow] pitrou commented on pull request #7593: ARROW-9160: [C++] Implement contains for exact matches

2020-07-02 Thread GitBox
pitrou commented on pull request #7593: URL: https://github.com/apache/arrow/pull/7593#issuecomment-653036927 "binary_contains_exact" still works for utf8 data, though. This is an automated message from the Apache Git Service

[GitHub] [arrow] pitrou commented on pull request #7593: ARROW-9160: [C++] Implement contains for exact matches

2020-07-01 Thread GitBox
pitrou commented on pull request #7593: URL: https://github.com/apache/arrow/pull/7593#issuecomment-652244689 `match_regex` then? :-) This is an automated message from the Apache Git Service. To respond to the message, please