pitrou commented on pull request #8023:
URL: https://github.com/apache/arrow/pull/8023#issuecomment-801144014
I'll merge then. Thank you @thamht4190 and @ggershinsky for contributing
this!
This is an automated message from
pitrou commented on pull request #8023:
URL: https://github.com/apache/arrow/pull/8023#issuecomment-800231451
@emkornfield The JSON changes are expected, the encryption layer needs to
parse and generate some JSON.
This is
pitrou commented on pull request #8023:
URL: https://github.com/apache/arrow/pull/8023#issuecomment-799528319
@emkornfield Feel free to take a last look.
This is an automated message from the Apache Git Service.
To respond
pitrou commented on pull request #8023:
URL: https://github.com/apache/arrow/pull/8023#issuecomment-796770371
As for testing, I'd still welcome unit tests with actual pieces of JSON as
per the spec, but I won't insist on it here :-)
Last question: do we want to mark those APIs for
pitrou commented on pull request #8023:
URL: https://github.com/apache/arrow/pull/8023#issuecomment-795824822
Ok, I've pushed some updates to try and conform with coding conventions a
bit more.
Some high-level comments:
* In general, I'm not particularly happy with the API (for
pitrou commented on pull request #8023:
URL: https://github.com/apache/arrow/pull/8023#issuecomment-686599596
Just a drive-by comment for now, but given the number of files added I think
we should create a `src/parquet/encryption` subdirectory.
