[GitHub] [arrow] sagnikc-dremio commented on pull request #9450: ARROW-11565: [C++][Gandiva] Modify upper()/lower() logic to make them work for utf8 strings

2021-02-25 Thread GitBox
sagnikc-dremio commented on pull request #9450: URL: https://github.com/apache/arrow/pull/9450#issuecomment-785798201 @kou This patch seems to resolve the dependency issue. Thanks again. This is an automated message from the

[GitHub] [arrow] sagnikc-dremio commented on pull request #9450: ARROW-11565: [C++][Gandiva] Modify upper()/lower() logic to make them work for utf8 strings

2021-02-24 Thread GitBox
sagnikc-dremio commented on pull request #9450: URL: https://github.com/apache/arrow/pull/9450#issuecomment-784925792 > Could you try the following patch? > > ```diff > diff --git a/cpp/cmake_modules/DefineOptions.cmake b/cpp/cmake_modules/DefineOptions.cmake > index e4df40d61.

[GitHub] [arrow] sagnikc-dremio commented on pull request #9450: ARROW-11565: [C++][Gandiva] Modify upper()/lower() logic to make them work for utf8 strings

2021-02-23 Thread GitBox
sagnikc-dremio commented on pull request #9450: URL: https://github.com/apache/arrow/pull/9450#issuecomment-784875144 @maartenbreddels @kou Hi Maarten/Sutou, I am facing some difficulties with respect to adding the utf8proc dependency for the case conversion of utf8 strings. Can you