[GitHub] [arrow] seddonm1 commented on a change in pull request #9233: ARROW-11289: [Rust][DataFusion] Implement GROUP BY support for Dictionary Encoded columns

2021-02-12 Thread GitBox
seddonm1 commented on a change in pull request #9233: URL: https://github.com/apache/arrow/pull/9233#discussion_r575535635 ## File path: rust/datafusion/src/physical_plan/hash_aggregate.rs ## @@ -398,97 +405,165 @@ fn group_aggregate_batch( Ok(accumulators) } -/// Creat

[GitHub] [arrow] seddonm1 commented on a change in pull request #9233: ARROW-11289: [Rust][DataFusion] Implement GROUP BY support for Dictionary Encoded columns

2021-02-12 Thread GitBox
seddonm1 commented on a change in pull request #9233: URL: https://github.com/apache/arrow/pull/9233#discussion_r575535374 ## File path: rust/datafusion/src/physical_plan/hash_aggregate.rs ## @@ -398,97 +405,165 @@ fn group_aggregate_batch( Ok(accumulators) } -/// Creat

[GitHub] [arrow] seddonm1 commented on a change in pull request #9233: ARROW-11289: [Rust][DataFusion] Implement GROUP BY support for Dictionary Encoded columns

2021-02-12 Thread GitBox
seddonm1 commented on a change in pull request #9233: URL: https://github.com/apache/arrow/pull/9233#discussion_r575535244 ## File path: rust/datafusion/src/physical_plan/hash_aggregate.rs ## @@ -398,97 +405,165 @@ fn group_aggregate_batch( Ok(accumulators) } -/// Creat