[GitHub] [arrow] seddonm1 commented on pull request #9376: ARROW-11446: [DataFusion] Added support for scalarValue in Builtin functions.

2021-02-13 Thread GitBox
seddonm1 commented on pull request #9376: URL: https://github.com/apache/arrow/pull/9376#issuecomment-778716899 > I wonder if it is possible to get the best of both worlds, by extending the `Array` trait slightly and having a subclass of `Array` which denotes scalars, like `ScalarArray` wh

[GitHub] [arrow] seddonm1 commented on pull request #9376: ARROW-11446: [DataFusion] Added support for scalarValue in Builtin functions.

2021-02-12 Thread GitBox
seddonm1 commented on pull request #9376: URL: https://github.com/apache/arrow/pull/9376#issuecomment-778133305 Unfortunately (for me) this logically does go first as being able to identify ScalarValue would give a huge performance advantage. I am happy to rework the other one after

[GitHub] [arrow] seddonm1 commented on pull request #9376: ARROW-11446: [DataFusion] Added support for scalarValue in Builtin functions.

2021-02-01 Thread GitBox
seddonm1 commented on pull request #9376: URL: https://github.com/apache/arrow/pull/9376#issuecomment-771190985 @alamb here is a proof-of-concept for the regexp_replace Postgres function which has been built to support the possibility of passing in different function parameters for each ro

[GitHub] [arrow] seddonm1 commented on pull request #9376: ARROW-11446: [DataFusion] Added support for scalarValue in Builtin functions.

2021-01-31 Thread GitBox
seddonm1 commented on pull request #9376: URL: https://github.com/apache/arrow/pull/9376#issuecomment-770464465 > @jorgecarleitao -- I agree with @Dandandan -- think `date_trunc(scalar, array)` and `date_trun(scalar, scalar) are the really important cases. I have no use case for `date_trun