[GitHub] [arrow] sunchao commented on a change in pull request #7586: ARROW-9280: [Rust] [Parquet] Calculate page and column statistics

2020-07-02 Thread GitBox
sunchao commented on a change in pull request #7586: URL: https://github.com/apache/arrow/pull/7586#discussion_r448842308 ## File path: rust/parquet/src/column/writer.rs ## @@ -216,26 +278,26 @@ impl ColumnWriterImpl { def_levels_sink: vec![], rep_leve

[GitHub] [arrow] sunchao commented on a change in pull request #7586: ARROW-9280: [Rust] [Parquet] Calculate page and column statistics

2020-07-01 Thread GitBox
sunchao commented on a change in pull request #7586: URL: https://github.com/apache/arrow/pull/7586#discussion_r448755889 ## File path: rust/parquet/src/column/writer.rs ## @@ -216,26 +278,26 @@ impl ColumnWriterImpl { def_levels_sink: vec![], rep_leve

[GitHub] [arrow] sunchao commented on a change in pull request #7586: ARROW-9280: [Rust] [Parquet] Calculate page and column statistics

2020-06-30 Thread GitBox
sunchao commented on a change in pull request #7586: URL: https://github.com/apache/arrow/pull/7586#discussion_r448014374 ## File path: rust/parquet/src/column/writer.rs ## @@ -387,15 +538,28 @@ impl ColumnWriterImpl { )); } -// TODO: update page