thamht4190 commented on pull request #8023:
URL: https://github.com/apache/arrow/pull/8023#issuecomment-787455523
I fixed all the comments in this pull, can you please take a look?
@emkornfield @pitrou @bkietz
This is an au
thamht4190 commented on pull request #8023:
URL: https://github.com/apache/arrow/pull/8023#issuecomment-716594944
@pitrou @bkietz I've created a small pull request from this pull:
https://github.com/apache/arrow/pull/8375. Can you take a look on it? If you
see this pull is good to start, I
thamht4190 commented on pull request #8023:
URL: https://github.com/apache/arrow/pull/8023#issuecomment-702625493
@bkietz I have the same thought with @ggershinsky. Moreover, I wrote the
code based on Java version, so I may not have enough deep understanding to
write out the mind & design
thamht4190 commented on pull request #8023:
URL: https://github.com/apache/arrow/pull/8023#issuecomment-701817028
> In general, this PR is difficult to review due to its size. Would it be
possible to break it into a two or more smaller PRs?
In theory, I think yes, we can create each PR f
thamht4190 commented on pull request #8023:
URL: https://github.com/apache/arrow/pull/8023#issuecomment-699915124
I've fixed all comments in the first review round. @pitrou @emkornfield
@ggershinsky Can you please take a look? I guess round 2 will take time to
review as well since the code
