[GitHub] [arrow] tianchen92 commented on a change in pull request #7887: ARROW-9304: [C++] Add "AppendEmpty" builder APIs for use inside StructBuilder::AppendNull

2020-09-12 Thread GitBox
tianchen92 commented on a change in pull request #7887: URL: https://github.com/apache/arrow/pull/7887#discussion_r486768419 ## File path: cpp/src/arrow/array/builder_base.h ## @@ -98,6 +98,9 @@ class ARROW_EXPORT ArrayBuilder { virtual Status AppendNull() = 0; virtual St

[GitHub] [arrow] tianchen92 commented on a change in pull request #7887: ARROW-9304: [C++] Add "AppendEmpty" builder APIs for use inside StructBuilder::AppendNull

2020-09-12 Thread GitBox
tianchen92 commented on a change in pull request #7887: URL: https://github.com/apache/arrow/pull/7887#discussion_r486737805 ## File path: cpp/src/arrow/array/builder_base.h ## @@ -98,6 +98,9 @@ class ARROW_EXPORT ArrayBuilder { virtual Status AppendNull() = 0; virtual St

[GitHub] [arrow] tianchen92 commented on a change in pull request #7887: ARROW-9304: [C++] Add "AppendEmpty" builder APIs for use inside StructBuilder::AppendNull

2020-09-12 Thread GitBox
tianchen92 commented on a change in pull request #7887: URL: https://github.com/apache/arrow/pull/7887#discussion_r486737805 ## File path: cpp/src/arrow/array/builder_base.h ## @@ -98,6 +98,9 @@ class ARROW_EXPORT ArrayBuilder { virtual Status AppendNull() = 0; virtual St

[GitHub] [arrow] tianchen92 commented on a change in pull request #7887: ARROW-9304: [C++] Add "AppendEmpty" builder APIs for use inside StructBuilder::AppendNull

2020-09-10 Thread GitBox
tianchen92 commented on a change in pull request #7887: URL: https://github.com/apache/arrow/pull/7887#discussion_r486768419 ## File path: cpp/src/arrow/array/builder_base.h ## @@ -98,6 +98,9 @@ class ARROW_EXPORT ArrayBuilder { virtual Status AppendNull() = 0; virtual St

[GitHub] [arrow] tianchen92 commented on a change in pull request #7887: ARROW-9304: [C++] Add "AppendEmpty" builder APIs for use inside StructBuilder::AppendNull

2020-09-10 Thread GitBox
tianchen92 commented on a change in pull request #7887: URL: https://github.com/apache/arrow/pull/7887#discussion_r486737805 ## File path: cpp/src/arrow/array/builder_base.h ## @@ -98,6 +98,9 @@ class ARROW_EXPORT ArrayBuilder { virtual Status AppendNull() = 0; virtual St

[GitHub] [arrow] tianchen92 commented on a change in pull request #7887: ARROW-9304: [C++] Add "AppendEmpty" builder APIs for use inside StructBuilder::AppendNull

2020-09-07 Thread GitBox
tianchen92 commented on a change in pull request #7887: URL: https://github.com/apache/arrow/pull/7887#discussion_r484622055 ## File path: cpp/src/arrow/buffer_builder.h ## @@ -292,6 +292,11 @@ class TypedBufferBuilder { return Status::OK(); } + void Forward(int64_t

[GitHub] [arrow] tianchen92 commented on a change in pull request #7887: ARROW-9304: [C++] Add "AppendEmpty" builder APIs for use inside StructBuilder::AppendNull

2020-09-07 Thread GitBox
tianchen92 commented on a change in pull request #7887: URL: https://github.com/apache/arrow/pull/7887#discussion_r484621904 ## File path: cpp/src/arrow/pretty_print.cc ## @@ -339,6 +339,17 @@ class ArrayPrinter : public PrettyPrinter { children.reserve(array.num_fields())

[GitHub] [arrow] tianchen92 commented on a change in pull request #7887: ARROW-9304: [C++] Add "AppendEmpty" builder APIs for use inside StructBuilder::AppendNull

2020-09-07 Thread GitBox
tianchen92 commented on a change in pull request #7887: URL: https://github.com/apache/arrow/pull/7887#discussion_r484621822 ## File path: cpp/src/arrow/pretty_print.cc ## @@ -339,6 +339,17 @@ class ArrayPrinter : public PrettyPrinter { children.reserve(array.num_fields())

[GitHub] [arrow] tianchen92 commented on a change in pull request #7887: ARROW-9304: [C++] Add "AppendEmpty" builder APIs for use inside StructBuilder::AppendNull

2020-09-06 Thread GitBox
tianchen92 commented on a change in pull request #7887: URL: https://github.com/apache/arrow/pull/7887#discussion_r484178152 ## File path: cpp/src/arrow/buffer_builder.h ## @@ -292,6 +292,11 @@ class TypedBufferBuilder { return Status::OK(); } + void Forward(int64_t

[GitHub] [arrow] tianchen92 commented on a change in pull request #7887: ARROW-9304: [C++] Add "AppendEmpty" builder APIs for use inside StructBuilder::AppendNull

2020-09-06 Thread GitBox
tianchen92 commented on a change in pull request #7887: URL: https://github.com/apache/arrow/pull/7887#discussion_r484178023 ## File path: cpp/src/arrow/array/builder_nested.h ## @@ -109,6 +109,25 @@ class BaseListBuilder : public ArrayBuilder { return Status::OK(); }

[GitHub] [arrow] tianchen92 commented on a change in pull request #7887: ARROW-9304: [C++] Add "AppendEmpty" builder APIs for use inside StructBuilder::AppendNull

2020-09-06 Thread GitBox
tianchen92 commented on a change in pull request #7887: URL: https://github.com/apache/arrow/pull/7887#discussion_r484177957 ## File path: cpp/src/arrow/pretty_print.cc ## @@ -339,6 +339,17 @@ class ArrayPrinter : public PrettyPrinter { children.reserve(array.num_fields())

[GitHub] [arrow] tianchen92 commented on a change in pull request #7887: ARROW-9304: [C++] Add "AppendEmpty" builder APIs for use inside StructBuilder::AppendNull

2020-08-16 Thread GitBox
tianchen92 commented on a change in pull request #7887: URL: https://github.com/apache/arrow/pull/7887#discussion_r471248061 ## File path: cpp/src/arrow/buffer_builder.h ## @@ -292,6 +292,11 @@ class TypedBufferBuilder { return Status::OK(); } + void AppendEmpty(int6

[GitHub] [arrow] tianchen92 commented on a change in pull request #7887: ARROW-9304: [C++] Add "AppendEmpty" builder APIs for use inside StructBuilder::AppendNull

2020-08-16 Thread GitBox
tianchen92 commented on a change in pull request #7887: URL: https://github.com/apache/arrow/pull/7887#discussion_r471247138 ## File path: cpp/src/arrow/array/builder_base.h ## @@ -98,6 +98,9 @@ class ARROW_EXPORT ArrayBuilder { virtual Status AppendNull() = 0; virtual St