[GitHub] [arrow] tianchen92 commented on pull request #7231: ARROW-6839: [Java] Add APIs to read and write "custom_metadata" field of IPC file footer

2020-06-16 Thread GitBox
tianchen92 commented on pull request #7231: URL: https://github.com/apache/arrow/pull/7231#issuecomment-644741925 > The commit looks OK but @tianchen92 please use the merge tool not the GitHub UI to merge patches. I see, sorry for the incorrect merge operation :) --

[GitHub] [arrow] tianchen92 commented on pull request #7231: ARROW-6839: [Java] Add APIs to read and write "custom_metadata" field of IPC file footer

2020-06-15 Thread GitBox
tianchen92 commented on pull request #7231: URL: https://github.com/apache/arrow/pull/7231#issuecomment-644557502 > @tianchen92 did you use the merge tool to merge this (if you haven't please read https://cwiki.apache.org/confluence/display/ARROW/Guide+for+Committers+and+Project+Maintainer

[GitHub] [arrow] tianchen92 commented on pull request #7231: ARROW-6839: [Java] Add APIs to read and write "custom_metadata" field of IPC file footer

2020-06-14 Thread GitBox
tianchen92 commented on pull request #7231: URL: https://github.com/apache/arrow/pull/7231#issuecomment-643892709 Thanks @rymurr for the review. @emkornfield Do you have other comments? otherwise I'll merge this in several days later. --

[GitHub] [arrow] tianchen92 commented on pull request #7231: ARROW-6839: [Java] Add APIs to read and write "custom_metadata" field of IPC file footer

2020-05-20 Thread GitBox
tianchen92 commented on pull request #7231: URL: https://github.com/apache/arrow/pull/7231#issuecomment-631361815 @wesm @jacques-n @emkornfield Please help take a look when you have time, thanks! This is an automated message