[GitHub] [arrow] vertexclique edited a comment on pull request #8598: ARROW-10500: [Rust] Refactor bit slice, bit view iterator for array buffers

2020-11-13 Thread GitBox
vertexclique edited a comment on pull request #8598: URL: https://github.com/apache/arrow/pull/8598#issuecomment-726767196 Yes, it won't until that method rewritten using the bit-slice iterator :) written here: https://github.com/apache/arrow/pull/8645#issuecomment-725957761 p.s: totally

[GitHub] [arrow] vertexclique edited a comment on pull request #8598: ARROW-10500: [Rust] Refactor bit slice, bit view iterator for array buffers

2020-11-13 Thread GitBox
vertexclique edited a comment on pull request #8598: URL: https://github.com/apache/arrow/pull/8598#issuecomment-726767196 Yes it won't until that method rewritten using the bit slice iterator :) p.s: totally unrelated topic, how do you run Valgrind on mac? -

[GitHub] [arrow] vertexclique edited a comment on pull request #8598: ARROW-10500: [Rust] Refactor bit slice, bit view iterator for array buffers

2020-11-07 Thread GitBox
vertexclique edited a comment on pull request #8598: URL: https://github.com/apache/arrow/pull/8598#issuecomment-723470048 I don't think that's needed at all. Optimizations were extremely premature. We should have thought about the future beforehand. I think we are prolonging the discussio

[GitHub] [arrow] vertexclique edited a comment on pull request #8598: ARROW-10500: [Rust] Refactor bit slice, bit view iterator for array buffers

2020-11-07 Thread GitBox
vertexclique edited a comment on pull request #8598: URL: https://github.com/apache/arrow/pull/8598#issuecomment-723470048 I don't think that's needed at all. Optimizations were extremely premature. We should have thought about the future beforehand. I think we are prolonging the discussio

[GitHub] [arrow] vertexclique edited a comment on pull request #8598: ARROW-10500: [Rust] Refactor bit slice, bit view iterator for array buffers

2020-11-06 Thread GitBox
vertexclique edited a comment on pull request #8598: URL: https://github.com/apache/arrow/pull/8598#issuecomment-723261667 > So my feedback here is that it is not clear to me what this PR is trying to accomplish (aka answer the question of why make the changes in this pr) and thus it is no

[GitHub] [arrow] vertexclique edited a comment on pull request #8598: ARROW-10500: [Rust] Refactor bit slice, bit view iterator for array buffers

2020-11-06 Thread GitBox
vertexclique edited a comment on pull request #8598: URL: https://github.com/apache/arrow/pull/8598#issuecomment-723261667 > So my feedback here is that it is not clear to me what this PR is trying to accomplish (aka answer the question of why make the changes in this pr) and thus it is no