[GitHub] [arrow-rs] Dandandan commented on a change in pull request #384: Implement faster arrow array reader

2021-05-31 Thread GitBox
Dandandan commented on a change in pull request #384: URL: https://github.com/apache/arrow-rs/pull/384#discussion_r642802751 ## File path: parquet/src/util/memory.rs ## @@ -292,19 +292,28 @@ impl BufferPtr { } /// Returns slice of data in this buffer. +#[inline]

[GitHub] [arrow-rs] Dandandan commented on a change in pull request #384: Implement faster arrow array reader

2021-05-31 Thread GitBox
Dandandan commented on a change in pull request #384: URL: https://github.com/apache/arrow-rs/pull/384#discussion_r642361176 ## File path: arrow/src/compute/kernels/filter.rs ## @@ -59,19 +59,14 @@ pub(crate) struct SlicesIterator<'a> { } impl<'a> SlicesIterator<'a> { -

[GitHub] [arrow-rs] Dandandan commented on a change in pull request #384: Implement faster arrow array reader

2021-05-30 Thread GitBox
Dandandan commented on a change in pull request #384: URL: https://github.com/apache/arrow-rs/pull/384#discussion_r642129881 ## File path: parquet/src/util/memory.rs ## @@ -292,19 +292,28 @@ impl BufferPtr { } /// Returns slice of data in this buffer. +#[inline]